[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

This revision was automatically updated to reflect the committed changes. Closed by commit rG13978643b678: [lldb] implement up and down shortcuts in lldb gui (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68541/new/

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

clayborg accepted this revision. clayborg added a comment. Thanks again for working on this. I will review any subsequent patches as they come in if you have any more contributions. Sorry for the long delay again, I had 3 months that I was out due to the head injury, hopefully this won't happen

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

llunak updated this revision to Diff 281705. llunak added a comment. Updated for current git, and clang-format-ed. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68541/new/ https://reviews.llvm.org/D68541 Files:

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

llunak added a comment. My usual experience with Clang submissions is that I have to be really persistent to get a reaction, let alone an approval, so I assumed it was the same here and I didn't feel like pushing this that much. I'll update the patches to match current git and have a look at

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

clayborg added a comment. Yikes, sorry for not responding for so long. In the fall I was out on medical leave due to a head injury. Please feel free to ping more often if I do this again. I commented in the other patches (one accepted, and questions in the other). Let me know your thoughts.

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

MaskRay added a comment. What is the state of the patch? Does lldb support cgdb-style u/d/f/b etc now? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68541/new/ https://reviews.llvm.org/D68541 ___ lldb-commits

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

llunak added a comment. In D68541#1710489 , @llunak wrote: > Can you please ACK also the other patches linked above that this one depends > on? Or can I take the discussion here as being enough? Ping? Repository: rLLDB LLDB CHANGES SINCE LAST

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/TestGuiBasicDebug.py:31 +# which is not necessarily the order on the screen.) +self.child.timeout = 2 +self.child.send("s") # step

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

llunak added a comment. In D68541#1710031 , @clayborg wrote: > Looks good! Can you please ACK also the other patches linked above that this one depends on? Or can I take the discussion here as being enough? > With a little work, "gui" mode can really

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! With a little work, "gui" mode can really become great. I hope to see more patches? Happy to discuss next stops on the mailing list if you are interested! Repository:

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

llunak updated this revision to Diff 225102. llunak added a comment. Adjusted the testcase. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68541/new/ https://reviews.llvm.org/D68541 Files: lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/Makefile

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/TestGuiBasicDebug.py:32 +self.child.send("s") # step +

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

llunak updated this revision to Diff 225064. llunak added a comment. Removed the explicit test timeout. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68541/new/ https://reviews.llvm.org/D68541 Files:

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

llunak marked an inline comment as done. llunak added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/TestGuiBasicDebug.py:31 +# which is not necessarily the order on the screen.) +self.child.timeout = 2 +

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/TestGuiBasicDebug.py:31 +# which is not necessarily the order on the screen.) +self.child.timeout = 2 +self.child.send("s") # step

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

llunak updated this revision to Diff 224737. llunak edited the summary of this revision. llunak added a comment. Added a unittest. Also, the other discussed changes are at https://reviews.llvm.org/D68908 and https://reviews.llvm.org/D68909 . CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

clayborg added a comment. In D68541#1700398 , @llunak wrote: > In D68541#1700359 , @clayborg wrote: > > > It would be fine to remove the 'd' shortcut for detach and resume if we > > need to by moving this

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

llunak added a comment. In D68541#1700359 , @clayborg wrote: > It would be fine to remove the 'd' shortcut for detach and resume if we need > to by moving this functionality up into the menu bar. Right now the Process > menu has "Detach" only, so it

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

clayborg added a comment. It would be fine to remove the 'd' shortcut for detach and resume if we need to by moving this functionality up into the menu bar. Right now the Process menu has "Detach" only, so it might be good to first change the "Process" menu to have "Detach" or "Detach

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

llunak added a comment. In D68541#1698127 , @JDevlieghere wrote: > Would it be possible to add a test for this? Maybe you can extend > `TestGuiBasic.py`. I can, although to me it looks like a new test would be better. But first of all I wanted some

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

JDevlieghere added a comment. Would it be possible to add a test for this? Maybe you can extend `TestGuiBasic.py`. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68541/new/ https://reviews.llvm.org/D68541 ___

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

llunak created this revision. llunak added a reviewer: clayborg. llunak added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, abidh. The attached patch implements 'u' and 'd' keyboard shortcuts in lldb gui, similar to gdb tui's shortcuts. One obvious problem is that 'd'