[Lldb-commits] [PATCH] D75810: [lldb] Add .clang-tidy with customization to readability-identifier-naming.{Function, Member, Parameter, Variable}Case

2020-03-09 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D75810#1912248 , @labath wrote: > Yeah, naming conventions in lldb have always been a controversial topic. Most > of the code uses the lldb convention, but some of the new code (particularly > if it interfaces with llvm

[Lldb-commits] [PATCH] D75810: [lldb] Add .clang-tidy with customization to readability-identifier-naming.{Function, Member, Parameter, Variable}Case

2020-03-09 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Yeah, naming conventions in lldb have always been a controversial topic. Most of the code uses the lldb convention, but some of the new code (particularly if it interfaces with llvm a lot) uses more llvm-like conventions. I think we used to have a description of the

[Lldb-commits] [PATCH] D75810: [lldb] Add .clang-tidy with customization to readability-identifier-naming.{Function, Member, Parameter, Variable}Case

2020-03-07 Thread Fangrui Song via Phabricator via lldb-commits
MaskRay created this revision. MaskRay added reviewers: JDevlieghere, jingham, labath. Herald added subscribers: lldb-commits, aheejin. Herald added a project: LLDB. MaskRay added a comment. https://github.com/google/llvm-premerge-checks/issues/142 This should suppress the annoying `clang-tidy

[Lldb-commits] [PATCH] D75810: [lldb] Add .clang-tidy with customization to readability-identifier-naming.{Function, Member, Parameter, Variable}Case

2020-03-07 Thread Fangrui Song via Phabricator via lldb-commits
MaskRay added a comment. https://github.com/google/llvm-premerge-checks/issues/142 This should suppress the annoying `clang-tidy linux` diagnostics in `Diff Detail - Build Status`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75810/new/