[Lldb-commits] [PATCH] D85169: [test] Exit with an error if no tests are run.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadb5c23f8c0d: [test] Exit with an error if no tests are run. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D85169: [test] Exit with an error if no tests are run.

rupprecht added a comment. Thanks for the quick review! I have a few more boring changes coming up, but hopefully some interesting ones after that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85169/new/ https://reviews.llvm.org/D85169

[Lldb-commits] [PATCH] D85169: [test] Exit with an error if no tests are run.

JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85169/new/ https://reviews.llvm.org/D85169 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D85169: [test] Exit with an error if no tests are run.

rupprecht updated this revision to Diff 282759. rupprecht added a comment. - Use logging.error - Remove trailing stop - Edit message to indicate that matching tests weren't found (user error) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85169/new/

[Lldb-commits] [PATCH] D85169: [test] Exit with an error if no tests are run.

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:1043 +if configuration.suite.countTestCases() == 0: +print("error: did not discover any tests.") +exitTestSuite(1) MaskRay wrote: > JDevlieghere

[Lldb-commits] [PATCH] D85169: [test] Exit with an error if no tests are run.

MaskRay added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:1043 +if configuration.suite.countTestCases() == 0: +print("error: did not discover any tests.") +exitTestSuite(1) JDevlieghere wrote: > Maybe `did not

[Lldb-commits] [PATCH] D85169: [test] Exit with an error if no tests are run.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:1043 +if configuration.suite.countTestCases() == 0: +print("error: did not discover

[Lldb-commits] [PATCH] D85169: [test] Exit with an error if no tests are run.

rupprecht created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. Herald added a subscriber: JDevlieghere. If the test suite is misconfigured when it's run (a bad regexp, wrong test directory, etc.), the test