This revision was automatically updated to reflect the committed changes.
Closed by commit rG243903f3262d: Factor out common code from the
iPhone/AppleTV/WatchOS simulator platform… (authored by aprantl).
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
JDevlieghere accepted this revision.
JDevlieghere added a comment.
Ship it
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85243/new/
https://reviews.llvm.org/D85243
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Looks good to me.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85243/new/
https://reviews.llvm.org/D85243
___
lldb-commits mailing list
aprantl updated this revision to Diff 283730.
aprantl marked 2 inline comments as done.
aprantl added a comment.
clang-format
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85243/new/
https://reviews.llvm.org/D85243
Files:
lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt
aprantl updated this revision to Diff 283729.
aprantl added a comment.
Address feedback from @JDevlieghere
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85243/new/
https://reviews.llvm.org/D85243
Files:
lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt
aprantl added inline comments.
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h:96
protected:
+ const char *m_class_name;
+ const char *m_description;
JDevlieghere wrote:
> aprantl wrote:
> > JDevlieghere wrote:
> > > "While you are
aprantl added inline comments.
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp:558
+ "arm64e-apple-ios-simulator", "arm64-apple-ios-simulator",
+ "x86_64-apple-ios-simulator", "x86_64h-apple-ios-simulator",
+#else
vsk added a comment.
I gave this another look-over, and while I didn't spot anything troubling, I'm
not terribly familiar with this code. I'll give this a third pass later today
if review is still needed.
Comment at:
JDevlieghere added inline comments.
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h:96
protected:
+ const char *m_class_name;
+ const char *m_description;
aprantl wrote:
> JDevlieghere wrote:
> > "While you are here" could we make
aprantl added inline comments.
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp:85
+ if (!m_sdk.empty())
+strm.Printf(" SDK Path: \"%s\"\n", m_sdk.str().c_str());
+ else
JDevlieghere wrote:
> If you use `<<` you could drop the
JDevlieghere added inline comments.
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp:85
+ if (!m_sdk.empty())
+strm.Printf(" SDK Path: \"%s\"\n", m_sdk.str().c_str());
+ else
If you use `<<` you could drop the `.str().c_str()`.
aprantl updated this revision to Diff 283413.
aprantl retitled this revision from "[WIP] Factor out common code from the
iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)" to "Factor out common
code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)".
aprantl added a
aprantl updated this revision to Diff 283415.
aprantl added a comment.
Actually update the right patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85243/new/
https://reviews.llvm.org/D85243
Files:
lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt
13 matches
Mail list logo
