[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2afaf072f5c1: Implement vAttachOrWait (authored by augusto2112, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

augusto2112 added a comment. @labath sorry for the repeated messages. I believe this is ready to be merged, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94672/new/ https://reviews.llvm.org/D94672

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

augusto2112 added a comment. @labath, @clayborg since both of you approved of it, I think this patch is ready to be merged, right? Could one of you do it? I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94672/new/

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. LGTM. Pavel? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94672/new/ https://reviews.llvm.org/D94672

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

augusto2112 marked 4 inline comments as done. augusto2112 added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:371 + StreamString name_with_slash_stream; + name_with_slash_stream.Format("/{0}", process_name); + auto

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

augusto2112 updated this revision to Diff 316782. augusto2112 added a comment. Addresses comments, includes tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94672/new/ https://reviews.llvm.org/D94672 Files:

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

clayborg added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:359-366 + if (!include_existing) { +// Create the excluded process list before polling begins. +Host::FindProcesses(match_info, exclusion_list); +

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

augusto2112 added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:377 + // by the desired name. + auto should_exclude_process = [_list, _name, + _with_slash]( labath

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:372 + name_with_slash_stream.Format("/{0}", process_name); + auto name_with_slash = name_with_slash_stream.GetString(); + augusto2112 wrote:

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

augusto2112 added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:372 + name_with_slash_stream.Format("/{0}", process_name); + auto name_with_slash =

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

augusto2112 created this revision. augusto2112 added reviewers: labath, clayborg, jingham, aprantl. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Implements the required functions on gdb-remote so the '--include-existing'