[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

MaskRay added a comment. In D94890#2510627 , @JDevlieghere wrote: > In D94890#2510446 , @MaskRay wrote: > >> Is this good? :) > > I think you forgot to update the patch? Ah, looks like you want to do inline

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

MaskRay updated this revision to Diff 317983. MaskRay added a comment. Inline archive rule Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94890/new/ https://reviews.llvm.org/D94890 Files: lldb/packages/Python/lldbsuite/test/make/Makefile.rules

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

JDevlieghere added a comment. In D94890#2510446 , @MaskRay wrote: > Is this good? :) I think you forgot to update the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94890/new/

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

MaskRay added a comment. Is this good? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94890/new/ https://reviews.llvm.org/D94890 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

JDevlieghere added a comment. In D94890#2507875 , @MaskRay wrote: > " (+ one additional test in the Swift fork)" --- Sounds like this can be a > separate patch which should Swift folks a heads-up. I don't know how to test > Swift and probably someone

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

MaskRay added a comment. In D94890#2507856 , @JDevlieghere wrote: > In D94890#2507241 , @MaskRay wrote: > >> In D94890#2505988 , @labath wrote: >> >>> Looks like a nice

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

JDevlieghere added a comment. In D94890#2507241 , @MaskRay wrote: > In D94890#2505988 , @labath wrote: > >> Looks like a nice cleanup. The only part I am not sure of is the part about >> removing `$(RM)

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

MaskRay added a comment. In D94890#2505988 , @labath wrote: > Looks like a nice cleanup. The only part I am not sure of is the part about > removing `$(RM) $(ARCHIVE_OBJECTS)`. Is that necessary? > I'm not sure why is that line there, but if I had to

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

labath added a comment. Looks like a nice cleanup. The only part I am not sure of is the part about removing `$(RM) $(ARCHIVE_OBJECTS)`. Is that necessary? I'm not sure why is that line there, but if I had to guess, I would say it's to ensure that lldb (on macos) reads debug info from the

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

MaskRay updated this revision to Diff 317382. MaskRay edited the summary of this revision. MaskRay added a comment. Don't use double-colon. https://lists.gnu.org/archive/html/help-make/2021-01/msg00016.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

MaskRay created this revision. MaskRay added reviewers: friss, JDevlieghere, labath, rupprecht. MaskRay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Take an example when `CXX_SOURCES` is main.cpp. main.d is a included file. make will