[Lldb-commits] [PATCH] D13727: Add task pool to LLDB

tberghammer created this revision. tberghammer added reviewers: labath, clayborg, vharron, zturner. tberghammer added a subscriber: lldb-commits. Herald added a subscriber: iancottrell. Add a new task pool class to LLDB to make it easy to execute tasks in parallel Basic design goals: * Have a

[Lldb-commits] [lldb] r250299 - cmake: provide flag that enables 'log enable --stack' to provide useful file/function info on POSIX systems

Author: tfiala Date: Wed Oct 14 09:52:15 2015 New Revision: 250299 URL: http://llvm.org/viewvc/llvm-project?rev=250299=rev Log: cmake: provide flag that enables 'log enable --stack' to provide useful file/function info on POSIX systems Adding the following flag to a cmake line:

Re: [Lldb-commits] [PATCH] D13667: cmake: provide flag that enables 'log enable --stack' to provide useful file/line info on POSIX systems

tfiala closed this revision. tfiala added a comment. Closed by the following commit: svn commit Sendingcmake/modules/AddLLDB.cmake Sendingcmake/modules/LLDBConfig.cmake Sendingsource/API/CMakeLists.txt Transmitting file data ... Committed revision 250299.

Re: [Lldb-commits] [PATCH] D10624: [ValueObjectPrinter::GetValueSummaryError] Get summary of non-synthetic values.

tweakoz added a subscriber: tweakoz. tweakoz added a comment. I am hitting this also. Happens when I want a summary and a synthetic on the same type... http://reviews.llvm.org/D10624 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13727: Add task pool to LLDB

zturner added a comment. I thought about this some more and I'm fine with going with a single implementation and not using std async. It would be nice to take advantage of any deep optimizations std::async provides over a hand-rolled solution, but at the same time there's a cost to adding

Re: [Lldb-commits] [PATCH] D13657: [lldb] char summary provider

granata.enrico added inline comments. Comment at: source/API/SBTypeSummary.cpp:155 @@ +154,3 @@ + new CXXFunctionSummaryFormat(options, + [cb] (ValueObject& valobj, Stream& stm, const TypeSummaryOptions& opt) -> bool { +

Re: [Lldb-commits] [PATCH] D13662: Make dwarf parsing multi-threaded

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Just saw that patch, so this looks good then pending the other patch. http://reviews.llvm.org/D13662 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D13662: Make dwarf parsing multi-threaded

clayborg added a comment. BTW: if we can modify clang to produce the Apple accelerator tables, we won't need to do any of this indexing which will really speed up debugging! We only produce the Apple accelerator tables on Darwin, but we could on other systems. There is also a new version of

[Lldb-commits] [PATCH] D13730: Resubmit: RenderScript command for printing allocation contents

EwanCrawford created this revision. EwanCrawford added reviewers: granata.enrico, clayborg, jingham. EwanCrawford added subscribers: lldb-commits, domipheus, labath. EwanCrawford set the repository for this revision to rL LLVM. Previous patch http://reviews.llvm.org/D13699 broke

Re: [Lldb-commits] [PATCH] D13727: Add task pool to LLDB

zturner added a comment. Can this be done in such a way that everything boils down to a single call to std::async on platforms that support thread limiting? Alternatively, why not just put a semaphore inside of the lambda that you run with std::async to limit the number of threads? This seems

Re: [Lldb-commits] [PATCH] D13662: Make dwarf parsing multi-threaded

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Missing the TaskPool.h and TaskPool.cpp files? http://reviews.llvm.org/D13662 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D13727: Add task pool to LLDB

tberghammer added a comment. We can change this class to use std::async on Windows and an std::thread based implementation on Linux with the same interface (other OS-es should be decided) but I would prefer to use just 1 logic as it is easier to maintain. Limiting the number of threads with

Re: [Lldb-commits] [PATCH] D13699: RenderScript command for printing allocation contents.

This revision was automatically updated to reflect the committed changes. Closed by commit rL250281: RenderScript command for printing allocation contents (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D13699?vs=37251=37324#toc Repository: rL LLVM

[Lldb-commits] [lldb] r250281 - RenderScript command for printing allocation contents

Author: ewancrawford Date: Wed Oct 14 04:02:20 2015 New Revision: 250281 URL: http://llvm.org/viewvc/llvm-project?rev=250281=rev Log: RenderScript command for printing allocation contents This patch adds the command 'language renderscript allocation dump ' for printing the contents of a RS

Re: [Lldb-commits] [PATCH] D13657: [lldb] char summary provider

evgeny777 added a comment. One question: CreateWithCallback and CreateWithSummaryString do not require Python support and can be used with LLDB_DISABLE_PYTHON. May be it makes sense to remove conditional compilation, like it is done here: http://reviews.llvm.org/D13577

Re: [Lldb-commits] [PATCH] D13727: Add task pool to LLDB

clayborg added a comment. Zach: If these are implementation details, lets get this in first and then worry about optimizations later. http://reviews.llvm.org/D13727 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [lldb] r250306 - Fix Python initialization for Python 3.

Thanks for the heads up. I have some more patches coming in soon, since this is just a warning and not a blocker I'll fix it in one of these followup patches. On Wed, Oct 14, 2015 at 11:38 AM Ed Maste wrote: > On 14 October 2015 at 13:51, Zachary Turner via lldb-commits >

Re: [Lldb-commits] [PATCH] D13657: [lldb] char summary provider

granata.enrico added inline comments. Comment at: source/API/SBTypeSummary.cpp:155 @@ +154,3 @@ + new CXXFunctionSummaryFormat(options, + [cb] (ValueObject& valobj, Stream& stm, const TypeSummaryOptions& opt) -> bool { +

Re: [Lldb-commits] [PATCH] D13727: Add task pool to LLDB

zturner added a comment. Well, it's not just an optimization. Threading code is hard to reason about, and the more complicated an implementation the more likely it is to have race conditions or other problems. So any opportunity to reduce the amount of manual thread management is a win in

Re: [Lldb-commits] [PATCH] D13657: [lldb] char summary provider

evgeny777 added inline comments. Comment at: source/API/SBTypeSummary.cpp:157 @@ +156,3 @@ +SBStream stream; +if (!cb(valobj.GetSP(), , stream)) +return false; granata.enrico

[Lldb-commits] [PATCH] D13754: Split Socket class into Tcp/Udp/DomainSocket subclasses.

ovyalov created this revision. ovyalov added reviewers: clayborg, zturner, labath. ovyalov added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. There are a few reasons for this change: - Support generic logic flow for different socket types - a preparation

Re: [Lldb-commits] [PATCH] D13742: Fix codesign command with cmake.

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D13742 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D13742: Fix codesign command with cmake.

sas created this revision. sas added reviewers: clayborg, dawn, brucem, tfiala. sas added a subscriber: lldb-commits. Looks like having a space in the Xcode path triggers this bug. We need to use cmake -E env FOO=bar [COMMAND] to set the environment instead. I am using cmake 3.3.1 and ninja

[Lldb-commits] [lldb] r250341 - Add a data formatter for __NSArray0, the type of empty arrays

Author: enrico Date: Wed Oct 14 17:45:04 2015 New Revision: 250341 URL: http://llvm.org/viewvc/llvm-project?rev=250341=rev Log: Add a data formatter for __NSArray0, the type of empty arrays Modified: lldb/trunk/source/Plugins/Language/ObjC/NSArray.cpp

[Lldb-commits] [lldb] r250331 - Make uses of /dev/null portable across OSes.

Author: zturner Date: Wed Oct 14 16:37:36 2015 New Revision: 250331 URL: http://llvm.org/viewvc/llvm-project?rev=250331=rev Log: Make uses of /dev/null portable across OSes. Most platforms have "/dev/null". Windows has "nul". Instead of hardcoding the string /dev/null at various places, make a

[Lldb-commits] [lldb] r250327 - Get Python unit tests working with Python 3.

Author: zturner Date: Wed Oct 14 16:06:13 2015 New Revision: 250327 URL: http://llvm.org/viewvc/llvm-project?rev=250327=rev Log: Get Python unit tests working with Python 3. There were a couple of issues related to string handling that needed to be fixed. In particular, we cannot get away with

[Lldb-commits] [lldb] r250339 - Fix a problem where LLDB could sometimes try to get the size of an Objective-C type without passing an appropriate ExecutionContext

Author: enrico Date: Wed Oct 14 17:44:30 2015 New Revision: 250339 URL: http://llvm.org/viewvc/llvm-project?rev=250339=rev Log: Fix a problem where LLDB could sometimes try to get the size of an Objective-C type without passing an appropriate ExecutionContext Modified:

[Lldb-commits] [lldb] r250340 - Fix a couple issues where trying to print a type would cause LLDB to crash

Author: enrico Date: Wed Oct 14 17:44:50 2015 New Revision: 250340 URL: http://llvm.org/viewvc/llvm-project?rev=250340=rev Log: Fix a couple issues where trying to print a type would cause LLDB to crash Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified:

Re: [Lldb-commits] [PATCH] D12994: Improve support of the ncurses dependency on NetBSD

krytarowski added a comment. There is already preliminary NetBSD support merged with trunk, I need this commit (or altered version of it) to build lldb against ncurses on this platform. Thank you for your time. Repository: rL LLVM http://reviews.llvm.org/D12994

[Lldb-commits] [lldb] r250287 - Fix warning in CommandObjectMemory

Author: tberghammer Date: Wed Oct 14 05:29:36 2015 New Revision: 250287 URL: http://llvm.org/viewvc/llvm-project?rev=250287=rev Log: Fix warning in CommandObjectMemory Modified: lldb/trunk/source/Commands/CommandObjectMemory.cpp Modified: lldb/trunk/source/Commands/CommandObjectMemory.cpp

Re: [Lldb-commits] [PATCH] D13754: Split Socket class into Tcp/Udp/DomainSocket subclasses.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Can we change "TcpSocket" to be "TCPSocket" and "UdpSocket" to be "UDPSocket" in all code and in the file names? Other than that it looks good. Comment at:

Re: [Lldb-commits] [PATCH] D13695: lldb-server: add support for binary memory reads

labath updated this revision to Diff 37340. labath added a comment. The new functionality gets picked up by the client and automatically used everywhere, so I'm not really worried about testing it. A more important issue would be making sure that the legacy read packet does not rot as it is now

[Lldb-commits] [lldb] r250290 - Revert "RenderScript command for printing allocation contents"

Author: labath Date: Wed Oct 14 06:50:37 2015 New Revision: 250290 URL: http://llvm.org/viewvc/llvm-project?rev=250290=rev Log: Revert "RenderScript command for printing allocation contents" This commit breaks TestDataFormatterSmartArray on all buildbots. Modified:

Re: [Lldb-commits] [PATCH] D13699: RenderScript command for printing allocation contents.

labath added a comment. Hi, I have reverted this as all the bots were getting red. In the test, variable was getting printed as `[{},{},{},{},{},{},{}]` instead of `{78.5},{77.25},{78},{76.125},{76.75},{76.875},{77}`. Please resubmit once the issue is resolved. Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D13657: [lldb] char summary provider

evgeny777 updated this revision to Diff 37339. evgeny777 added a comment. Looks like can be done much easier http://reviews.llvm.org/D13657 Files: include/lldb/API/SBTypeSummary.h source/API/SBTypeSummary.cpp Index: source/API/SBTypeSummary.cpp

Re: [Lldb-commits] [PATCH] D13695: lldb-server: add support for binary memory reads

labath updated this revision to Diff 37341. labath added a comment. Remove files which slipped in... http://reviews.llvm.org/D13695 Files: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h

[Lldb-commits] [lldb] r250286 - Make use of lldv::Triple::isAndroid

Author: tberghammer Date: Wed Oct 14 05:29:17 2015 New Revision: 250286 URL: http://llvm.org/viewvc/llvm-project?rev=250286=rev Log: Make use of lldv::Triple::isAndroid It is a new function added to the llvm::Triple class to simplify the checking if we are targeting android to clean up the

[Lldb-commits] [lldb] r250289 - Change ConstString to support massive multi-threaded access

Author: tberghammer Date: Wed Oct 14 05:38:22 2015 New Revision: 250289 URL: http://llvm.org/viewvc/llvm-project?rev=250289=rev Log: Change ConstString to support massive multi-threaded access Previously ConstString had a single mutex guarding the global string pool for each access what become a

Re: [Lldb-commits] [PATCH] D13727: Add task pool to LLDB

zturner added a comment. Ok, it seems reasonable to just use std::async on platforms that this is ok on, and not use it on platforms which it's not ok on. I think it should be enabled on Windows, but I'll leave it up to you to decide whether it's a whitelist or a blacklist.

Re: [Lldb-commits] [PATCH] D13695: lldb-server: add support for binary memory reads

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good http://reviews.llvm.org/D13695 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r250295 - lldb-server: add support for binary memory reads

Author: labath Date: Wed Oct 14 07:59:37 2015 New Revision: 250295 URL: http://llvm.org/viewvc/llvm-project?rev=250295=rev Log: lldb-server: add support for binary memory reads Summary: This commit adds support for binary memory reads ($x) to lldb-server. It also removes the "0x" prefix from