[Lldb-commits] [lldb] r281913 - Xcode: support gtests that use the Inputs dir

2016-09-19 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Mon Sep 19 11:42:41 2016 New Revision: 281913 URL: http://llvm.org/viewvc/llvm-project?rev=281913&view=rev Log: Xcode: support gtests that use the Inputs dir This change adds support for the gtests that require input data in the Inputs files. This is done through a new Xcode

Re: [Lldb-commits] [PATCH] D24711: [lldb-mi] Fix implementation for a few mi commands

2016-09-19 Thread Aetf via lldb-commits
aetf added a comment. Okay, tests should go to `packages/Python/lldbsuite/test/tools/lldb-mi`, right? I need to get familiar with them first. Repository: rL LLVM https://reviews.llvm.org/D24711 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D24711: [lldb-mi] Fix implementation for a few mi commands

2016-09-19 Thread Aetf via lldb-commits
aetf created this revision. aetf added a reviewer: ki.stfu. aetf added a subscriber: lldb-commits. Herald added a subscriber: ki.stfu. Some of the mi commands implemented in lldb-mi are incomplete/not confirming to the spec. - `gdb-show` and `gdb-set` doesn't support getting/setting `disassembly-

Re: [Lldb-commits] [PATCH] D23977: Support of lldb on Kfreebsd

2016-09-19 Thread Todd Fiala via lldb-commits
tfiala added a comment. @sylvestre.ledru, I think this will be ready to go if you can convert that check to a CMake built-in check. Maybe you can pass that along to Pino Toscano? https://reviews.llvm.org/D23977 ___ lldb-commits mailing list lldb-c

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

2016-09-19 Thread Todd Fiala via lldb-commits
tfiala added a comment. Coming back to this today. https://reviews.llvm.org/D20835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r281919 - Fix more functions in Args to use StringRef.

2016-09-19 Thread Zachary Turner via lldb-commits
Author: zturner Date: Mon Sep 19 12:54:06 2016 New Revision: 281919 URL: http://llvm.org/viewvc/llvm-project?rev=281919&view=rev Log: Fix more functions in Args to use StringRef. This patch also marks the const char* versions as =delete to prevent their use. This has the potential to cause build

[Lldb-commits] [lldb] r281922 - Try to fix freebsd and android builds.

2016-09-19 Thread Zachary Turner via lldb-commits
Author: zturner Date: Mon Sep 19 13:03:54 2016 New Revision: 281922 URL: http://llvm.org/viewvc/llvm-project?rev=281922&view=rev Log: Try to fix freebsd and android builds. Modified: lldb/trunk/source/Host/freebsd/Host.cpp lldb/trunk/source/Host/linux/ProcessLauncherLinux.cpp Modified: l

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

2016-09-19 Thread walter erquinigo via lldb-commits
wallace updated this revision to Diff 71853. wallace added a comment. s/NULL/nullptr/ https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

2016-09-19 Thread walter erquinigo via lldb-commits
wallace updated this revision to Diff 71855. wallace added a comment. rebase https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h =

[Lldb-commits] [lldb] r281926 - Fix compilation of unit tests.

2016-09-19 Thread Zachary Turner via lldb-commits
Author: zturner Date: Mon Sep 19 13:32:23 2016 New Revision: 281926 URL: http://llvm.org/viewvc/llvm-project?rev=281926&view=rev Log: Fix compilation of unit tests. Modified: lldb/trunk/unittests/Interpreter/TestArgs.cpp Modified: lldb/trunk/unittests/Interpreter/TestArgs.cpp URL: http://ll

Re: [Lldb-commits] [PATCH] D23977: Support of lldb on Kfreebsd

2016-09-19 Thread Ed Maste via lldb-commits
emaste requested changes to this revision. emaste added a reviewer: emaste. emaste added a comment. This revision now requires changes to proceed. Two requested changes called out in comments above https://reviews.llvm.org/D23977 ___ lldb-commits ma

Re: [Lldb-commits] [PATCH] D24610: LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible

2016-09-19 Thread Muhammad Omair Javaid via lldb-commits
omjavaid added a comment. Answers to comments. I will upload a updated patch after corrections and updates. Comment at: packages/Python/lldbsuite/test/functionalities/watchpoint/multi_watchpoint_slots/main.c:23 @@ +22,3 @@ +{ +printf("About to write byteArray[%d] .

Re: [Lldb-commits] [PATCH] D22831: [LLDB] Documentation for SBAddress class

2016-09-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please rebase from trunk and run Clang-format. Repository: rL LLVM https://reviews.llvm.org/D22831 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:/

[Lldb-commits] [lldb] r281942 - Convert 3 more functions to use a StringRef.

2016-09-19 Thread Zachary Turner via lldb-commits
Author: zturner Date: Mon Sep 19 16:56:59 2016 New Revision: 281942 URL: http://llvm.org/viewvc/llvm-project?rev=281942&view=rev Log: Convert 3 more functions to use a StringRef. This converts Args::Unshift, Args::AddOrReplaceEnvironmentVariable, and Args::ContainsEnvironmentVariable to use Strin

[Lldb-commits] [lldb] r281943 - Fixed the build by changing a couple of const char *s to StringRefs.

2016-09-19 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Mon Sep 19 17:06:12 2016 New Revision: 281943 URL: http://llvm.org/viewvc/llvm-project?rev=281943&view=rev Log: Fixed the build by changing a couple of const char *s to StringRefs. Modified: lldb/trunk/source/Host/macosx/Host.mm lldb/trunk/source/Host/macosx/HostInfoM

Re: [Lldb-commits] [PATCH] D23948: Remove unused variable

2016-09-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r280283. https://reviews.llvm.org/D23948 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D23950: Remove unused local variable

2016-09-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r280283. https://reviews.llvm.org/D23950 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D23951: Remove unused any_found local variable

2016-09-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r280283. https://reviews.llvm.org/D23951 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D23952: Remove unused frame_zero_id local variable

2016-09-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r280283. https://reviews.llvm.org/D23952 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

2016-09-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r266392. https://reviews.llvm.org/D18848 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

[Lldb-commits] [PATCH] D24749: [CMake] Initial support for LLDB.framework

2016-09-19 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: zturner, tfiala. beanz added a subscriber: lldb-commits. Herald added subscribers: mgorny, beanz. This patch adds a CMake option LLDB_BUILD_FRAMEWORK, which builds libLLDB as a macOS framework instead of as a *nix shared library. With this patc

Re: [Lldb-commits] [PATCH] D17521: Update website for building and testing on Windows

2016-09-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r261795. https://reviews.llvm.org/D17521 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D16477: Make all x86 target builds on MSVC use the amd64_x86 toolchain

2016-09-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r258738. https://reviews.llvm.org/D16477 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D16149: Delete char const** swig typemaps

2016-09-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r257670. https://reviews.llvm.org/D16149 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D15723: Allow test decorators to use lists (and not_in(list)) for arches

2016-09-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Committed in r256283. Please specify Differential revision in commit message. https://reviews.llvm.org/D15723 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

Re: [Lldb-commits] [PATCH] D15582: Improve error handling for `f s #`

2016-09-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r256251. Please specify Differential revision in commit message. https://reviews.llvm.org/D15582 ___ lldb-commits ma

Re: [Lldb-commits] [PATCH] D24749: [CMake] Initial support for LLDB.framework

2016-09-19 Thread Zachary Turner via lldb-commits
zturner added inline comments. Comment at: scripts/Python/finishSwigPythonLLDB.py:397 @@ -396,3 +396,3 @@ strBuildDir = os.path.join("..", "..", "..", "..") -strSrc = os.path.normcase(os.path.join(strBuildDir, vstrSrcFile)) +strSrc = os.path.normcase(os.pa

Re: [Lldb-commits] [PATCH] D17152: Improve ReadRegister for RegisterContextWindowsx86

2016-09-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r260559. https://reviews.llvm.org/D17152 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D15723: Allow test decorators to use lists (and not_in(list)) for arches

2016-09-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r256283. https://reviews.llvm.org/D15723 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13679: Fix TestTargetAPI.py test for users who use Swig 3.0.5 or greater.

2016-09-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r250188. https://reviews.llvm.org/D13679 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D10103: Fix inferior's i/o connections to its console window on Windows 7

2016-09-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r238629. https://reviews.llvm.org/D10103 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D9535: Don't attempt dsym tests on Windows

2016-09-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r236620. https://reviews.llvm.org/D9535 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

Re: [Lldb-commits] [PATCH] D9753: Enable debugging of multithreaded programs on Windows.

2016-09-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r237392. https://reviews.llvm.org/D9753 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

Re: [Lldb-commits] [PATCH] D8937: Add logging plugin for Winodows

2016-09-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r234607. https://reviews.llvm.org/D8937 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

Re: [Lldb-commits] [PATCH] D8494: Fix lld command on Windows for many tests

2016-09-19 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r233416. https://reviews.llvm.org/D8494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.

[Lldb-commits] Buildbot numbers for the week of 9/04/2016 - 9/10/201

2016-09-19 Thread Galina Kistanova via lldb-commits
Hello everyone, Below are some buildbot numbers for the week of 9/04/2016 - 9/10/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[Lldb-commits] Buildbot numbers for the week of 9/11/2016 - 9/17/2016

2016-09-19 Thread Galina Kistanova via lldb-commits
Hello everyone, Below are some buildbot numbers for the last week of 9/11/2016 - 9/17/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Re: [Lldb-commits] [PATCH] D24749: [CMake] Initial support for LLDB.framework

2016-09-19 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a subscriber: labath. tfiala added a comment. This revision is now accepted and ready to land. LGTM. Chris - you might want to add @labath to this as well. Comment at: source/API/CMakeLists.txt:9 @@ -8,1 +8,3 @@ +option(LLDB_BUILD_F

Re: [Lldb-commits] [PATCH] D24749: [CMake] Initial support for LLDB.framework

2016-09-19 Thread Zachary Turner via lldb-commits
Unless someone has a strong desire to keep it and it adds necessary functionality I would vote for removing it. It can always be maintained downstream. That being said, let's wait and see if anyone chimes in. I also want to test this tomorrow to make sure nothing breaks. Just to be clear, if i we

Re: [Lldb-commits] [PATCH] D24749: [CMake] Initial support for LLDB.framework

2016-09-19 Thread Todd Fiala via lldb-commits
On Mon, Sep 19, 2016 at 7:39 PM, Zachary Turner wrote: > Unless someone has a strong desire to keep it and it adds necessary > functionality I would vote for removing it. I think it's fine to remove the other support if nobody else has a good reason to want to keep it, but we're not to that poi