[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

labath added a comment. Does that mean we can remove the `.noindex` thingy from the build folder name? (In any case, the change seems fine to me). https://reviews.llvm.org/D44342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D44139: Update selected thread after loading mach core

labath added a comment. I'll leave the cpp change for others to approve (though it certainly looks simpler than the previous one). I just have a couple of drive-by comments on the test. Comment at:

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

labath accepted this revision. labath added a comment. I like this a lot. That's the kind of change I wanted to do as a follow-up one day. Thank you. https://reviews.llvm.org/D42145 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

labath created this revision. labath added reviewers: krytarowski, zturner. Herald added a subscriber: mgorny. This patch consists of two relatively independent changes: - first, I teach the standalone build to detect the case when llvm was built in the shared mode and set the appropriate cmake

[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

clayborg added a comment. I would rather see this done in a more generic fashion. Any platform should be able to enable/disable external symbol lookups. Maybe make this setting: (lldb) settings set symbols.enable-external-lookups false On Darwin this would mean dSYM. Any other platform can

[Lldb-commits] [PATCH] D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

mgorny added a comment. I can't test this right now but please make sure not to break linking to split shared libraries without dylib. https://reviews.llvm.org/D44379 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

labath added a comment. Ah, yes, another build mode :/. Are you doing a standalone build or not? I am pretty sure this will be fine for an integrated build, but I have no idea what will it do in the standalone mode... https://reviews.llvm.org/D44379

[Lldb-commits] [PATCH] D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

mgorny added a comment. Yes, full standalone. https://reviews.llvm.org/D44379 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44139: Update selected thread after loading mach core

JDevlieghere updated this revision to Diff 137993. JDevlieghere added a comment. Thanks for the review @labath! https://reviews.llvm.org/D44139 Files: packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py

[Lldb-commits] [PATCH] D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

krytarowski added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:354 + + check_library_exists(dl dlopen "" HAVE_LIBDL) + if (HAVE_LIBDL) A more portable form of this: ``` foreach(lib ${CMAKE_DL_LIBS}) list(APPEND system_libs -l${lib})

[Lldb-commits] [lldb] r327318 - Improve prologue handling to support functions with multiple entry points.

Author: jingham Date: Mon Mar 12 12:21:59 2018 New Revision: 327318 URL: http://llvm.org/viewvc/llvm-project?rev=327318=rev Log: Improve prologue handling to support functions with multiple entry points. https://reviews.llvm.org/D42582 Patch from Leandro Lupori. Modified:

[Lldb-commits] [PATCH] D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

mgorny added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:354 + + check_library_exists(dl dlopen "" HAVE_LIBDL) + if (HAVE_LIBDL) krytarowski wrote: > A more portable form of this: > > ``` > foreach(lib ${CMAKE_DL_LIBS}) > list(APPEND

[Lldb-commits] [PATCH] D40466: DWZ 01/11: DWARFUnit split out of DWARFCompileUnit

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. This is fine. Lets start with this and then worry about each next patch. 02/11 next. https://reviews.llvm.org/D40466 ___ lldb-commits

[Lldb-commits] [PATCH] D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

krytarowski added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:354 + + check_library_exists(dl dlopen "" HAVE_LIBDL) + if (HAVE_LIBDL) krytarowski wrote: > labath wrote: > > krytarowski wrote: > > > mgorny wrote: > > > > krytarowski wrote: > > >

[Lldb-commits] [PATCH] D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

krytarowski added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:354 + + check_library_exists(dl dlopen "" HAVE_LIBDL) + if (HAVE_LIBDL) mgorny wrote: > krytarowski wrote: > > A more portable form of this: > > > > ``` > > foreach(lib

[Lldb-commits] [PATCH] D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

labath planned changes to this revision. labath added a comment. Right, so this will not work for the BUILD_SHARED_LIBS case, and there doesn't seem to be an easy way to make it work from this end. I'm going to try fixing this from the llvm side and come back to this if we still need the

[Lldb-commits] [PATCH] D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

krytarowski added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:354 + + check_library_exists(dl dlopen "" HAVE_LIBDL) + if (HAVE_LIBDL) labath wrote: > krytarowski wrote: > > mgorny wrote: > > > krytarowski wrote: > > > > A more portable form of

[Lldb-commits] [PATCH] D40466: DWZ 01/11: DWARFUnit split out of DWARFCompileUnit

davide accepted this revision. davide added a comment. This is No functional change, right (just code churn)? If so, LGTM. https://reviews.llvm.org/D40466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D40474: DWZ 09/11: Main functionality

clayborg added a comment. Too many changes to give the whole thing the OK to checkin. I will worry about each one as an individual patch. 02/11 next. https://reviews.llvm.org/D40474 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D42892: DWZ 02/11: Move the codebase to use: DWARFCompileUnit -> DWARFUnit

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D42892 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

labath added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:354 + + check_library_exists(dl dlopen "" HAVE_LIBDL) + if (HAVE_LIBDL) krytarowski wrote: > krytarowski wrote: > > labath wrote: > > > krytarowski wrote: > > > > mgorny wrote: > > > > >

[Lldb-commits] [PATCH] D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

krytarowski accepted this revision. krytarowski added a comment. This revision is now accepted and ready to land. I cannot test it shortly on NetBSD, but if there are any issues left (probably none) - I will fix it in future. Comment at: cmake/modules/LLDBConfig.cmake:349

[Lldb-commits] [PATCH] D42892: DWZ 02/11: Move the codebase to use: DWARFCompileUnit -> DWARFUnit

clayborg accepted this revision. clayborg added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.h:34 class DWARFUnit { + friend class DWARFCompileUnit; + DWARFCompileUnit inherits from this class. This isn't needed right?

[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

aprantl added a comment. Thanks for the suggestion, Greg! I renamed to option to use a more generic name and removed the `#if APPLE` guards. https://reviews.llvm.org/D44342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [lldb] r327318 - Improve prologue handling to support functions with multiple entry points.

Hi Jim, I think this breaks the Xcode bot: http://green.lab.llvm.org/green/job/lldb-xcode/5430/ . The CMake build looks broken too. Mind taking a look or reverting? CompileC

[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

aprantl added a comment. In https://reviews.llvm.org/D44342#1034514, @labath wrote: > Does that mean we can remove the `.noindex` thingy from the build folder > name? (In any case, the change seems fine to me). Yes, but we could still keep it for performance reasons. Perhaps only on Darwin.

[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

aprantl updated this revision to Diff 138082. aprantl added a comment. Renamed option to something more general. https://reviews.llvm.org/D44342 Files: include/lldb/Core/ModuleList.h lit/lit-lldb-init lit/lit.cfg packages/Python/lldbsuite/test/lldbtest.py source/Core/ModuleList.cpp

[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

clayborg added inline comments. Comment at: source/Core/ModuleList.cpp:70 PropertyDefinition g_properties[] = { +// This option only makes sense when the host is macOS. +{"enable-external-lookup", OptionValue::eTypeBoolean, true, true, nullptr, Remove

[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

aprantl updated this revision to Diff 138086. aprantl added a comment. More review feedback. https://reviews.llvm.org/D44342 Files: include/lldb/Core/ModuleList.h lit/lit-lldb-init lit/lit.cfg packages/Python/lldbsuite/test/lldbtest.py source/Core/ModuleList.cpp

[Lldb-commits] [PATCH] D40474: DWZ 09/11: Main functionality

labath added a reviewer: davide. labath added a comment. I think the most controversial issue here is the testing... davide may have some thoughts on that. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:4529 +SymbolFileDWARF::DWZCommonFile::DWZCommonFile( +

[Lldb-commits] [PATCH] D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

krytarowski added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:349 -if (HAVE_LIBPTHREAD) - list(APPEND system_libs pthread) -endif(HAVE_LIBPTHREAD) - -if (HAVE_LIBDL) - list(APPEND system_libs ${CMAKE_DL_LIBS}) +if(UNIX) + set(CMAKE_THREAD_PREFER_PTHREAD

[Lldb-commits] [PATCH] D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

labath added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:349 -if (HAVE_LIBPTHREAD) - list(APPEND system_libs pthread) -endif(HAVE_LIBPTHREAD) - -if (HAVE_LIBDL) - list(APPEND system_libs ${CMAKE_DL_LIBS}) +if(UNIX) + set(CMAKE_THREAD_PREFER_PTHREAD TRUE)

[Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

Author: davide Date: Mon Mar 12 18:40:00 2018 New Revision: 327356 URL: http://llvm.org/viewvc/llvm-project?rev=327356=rev Log: [ExpressionParser] Fix crash when evaluating invalid expresssions. Typical example, illformed comparisons (operator== where LHS and RHS are not compatible). If a symbol

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

On Mon, Mar 12, 2018 at 7:27 PM, Jason Molenda via lldb-commits wrote: > FWIW, we'll definitely get pushback about > >> Now you can't do in lldb anymore >> (lldb) call _Zsomethingsomething(1,2,3) > > > There are clever users of lldb, often working at assembly language

[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

jingham added a comment. This is great. I think I'm supposed to complain that there isn't a positive test that this flag works. This is in the testsuite, but that will just give a negative signal - that we aren't getting random failures that are maybe due to leaving built test products

[Lldb-commits] [lldb] r327350 - [lit] `llvm-mc` is now a dependency to run tests.

Author: davide Date: Mon Mar 12 16:42:37 2018 New Revision: 327350 URL: http://llvm.org/viewvc/llvm-project?rev=327350=rev Log: [lit] `llvm-mc` is now a dependency to run tests. Modified: lldb/trunk/lit/CMakeLists.txt Modified: lldb/trunk/lit/CMakeLists.txt URL:

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

FWIW, we'll definitely get pushback about > Now you can't do in lldb anymore > (lldb) call _Zsomethingsomething(1,2,3) There are clever users of lldb, often working at assembly language level without any symbolic information, who are able to correctly call a C++ mangled function by hand.

Re: [Lldb-commits] [lldb] r327318 - Improve prologue handling to support functions with multiple entry points.

I needed to revert this in r327327 to get the bots going again. vedant > On Mar 12, 2018, at 1:26 PM, Vedant Kumar via lldb-commits > wrote: > > Hi Jim, > > I think this breaks the Xcode bot: > http://green.lab.llvm.org/green/job/lldb-xcode/5430/ >

[Lldb-commits] [lldb] r327327 - Revert "Improve prologue handling to support functions with multiple entry points."

Author: vedantk Date: Mon Mar 12 13:35:33 2018 New Revision: 327327 URL: http://llvm.org/viewvc/llvm-project?rev=327327=rev Log: Revert "Improve prologue handling to support functions with multiple entry points." This reverts commit r327318. It breaks the Xcode and CMake Darwin builders:

[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks @aprantl! https://reviews.llvm.org/D44342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r327330 - Introduce a setting to disable Spotlight while running the test suite

Author: adrian Date: Mon Mar 12 13:52:36 2018 New Revision: 327330 URL: http://llvm.org/viewvc/llvm-project?rev=327330=rev Log: Introduce a setting to disable Spotlight while running the test suite This is a more principled approach to disabling Spotlight .dSYM lookups while running the

[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

This revision was automatically updated to reflect the committed changes. Closed by commit rL327330: Introduce a setting to disable Spotlight while running the test suite (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r327331 - Re-add change for https://reviews.llvm.org/D42582 with added directories.

Author: jingham Date: Mon Mar 12 14:17:04 2018 New Revision: 327331 URL: http://llvm.org/viewvc/llvm-project?rev=327331=rev Log: Re-add change for https://reviews.llvm.org/D42582 with added directories. Added: lldb/trunk/lit/Breakpoint/Inputs/ppc64-localentry.s

[Lldb-commits] [PATCH] D40466: DWZ 01/11: DWARFUnit split out of DWARFCompileUnit

jankratochvil added a comment. In https://reviews.llvm.org/D40466#1034875, @davide wrote: > This is No functional change, right (just code churn)? Right. https://reviews.llvm.org/D40466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org