Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

If you check the expression log, you will see the printf() function declaration and any others we add: (lldb) log enable lldb expr (lldb) 2+3 ... #ifndef NULL #define NULL (__null) #endif #ifndef Nil #define Nil (__null) #endif #ifndef nil #define nil (__null) #endif #ifndef YES #define YES

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

On Tue, Mar 13, 2018 at 11:17 AM, Greg Clayton wrote: > If you check the expression log, you will see the printf() function > declaration and any others we add: > > (lldb) log enable lldb expr > (lldb) 2+3 > > ... > #ifndef NULL > #define NULL (__null) > #endif > #ifndef Nil

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

On Tue, Mar 13, 2018 at 10:56 AM, Greg Clayton wrote: > > > On Mar 13, 2018, at 10:25 AM, Davide Italiano via lldb-commits > wrote: > > On Tue, Mar 13, 2018 at 9:59 AM, Frédéric Riss via lldb-commits > wrote: > > > >

[Lldb-commits] [lldb] r327445 - [DataFormatter] Remove dead code for the NSDictionary formatter.

Author: davide Date: Tue Mar 13 13:26:38 2018 New Revision: 327445 URL: http://llvm.org/viewvc/llvm-project?rev=327445=rev Log: [DataFormatter] Remove dead code for the NSDictionary formatter. I'm going to make changes in this area soon, so I figured I could clean things a bit while I was

[Lldb-commits] [lldb] r327379 - Fix linux s390x build (pr36694)

Author: labath Date: Tue Mar 13 02:46:00 2018 New Revision: 327379 URL: http://llvm.org/viewvc/llvm-project?rev=327379=rev Log: Fix linux s390x build (pr36694) Modified: lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.cpp Modified:

[Lldb-commits] [lldb] r327380 - Fix clang-3.8 build

Author: labath Date: Tue Mar 13 02:46:10 2018 New Revision: 327380 URL: http://llvm.org/viewvc/llvm-project?rev=327380=rev Log: Fix clang-3.8 build clang-3.8 complains that constructor for '...' must explicitly initialize the const member. Newer clangs and gcc seem to be fine with this, but

[Lldb-commits] [PATCH] D44306: Move Args::StringToAddress to Target::EvaluateAddressExpression

labath planned changes to this revision. labath added a comment. Yes, that thought occurred to me almost immediately after I submitted this. I'll try to implement something like that instead. Since this will be just a bunch of static functions with no state, I think we don't even have to put

[Lldb-commits] [lldb] r327413 - include locale.h in IOHandler.cpp

Author: labath Date: Tue Mar 13 08:55:00 2018 New Revision: 327413 URL: http://llvm.org/viewvc/llvm-project?rev=327413=rev Log: include locale.h in IOHandler.cpp This is needed for the setlocale() call, and it seems that it is not transitively pulled in for some build configurations. Modified:

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

> On Mar 12, 2018, at 7:52 PM, Davide Italiano via lldb-commits > wrote: > > On Mon, Mar 12, 2018 at 7:27 PM, Jason Molenda via lldb-commits > wrote: >> FWIW, we'll definitely get pushback about >> >>> Now you can't do in lldb

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

> On Mar 12, 2018, at 6:40 PM, Davide Italiano via lldb-commits > wrote: > > Author: davide > Date: Mon Mar 12 18:40:00 2018 > New Revision: 327356 > > URL: http://llvm.org/viewvc/llvm-project?rev=327356=rev > Log: > [ExpressionParser] Fix crash when evaluating

[Lldb-commits] [lldb] r327463 - [test] Replace some references to Apple-internal bugs

Author: vedantk Date: Tue Mar 13 16:37:11 2018 New Revision: 327463 URL: http://llvm.org/viewvc/llvm-project?rev=327463=rev Log: [test] Replace some references to Apple-internal bugs This removes around 10 references to Apple-internal radars. I've filed fresh bugs on bugs.llvm.org as appropriate

[Lldb-commits] [PATCH] D44139: Update selected thread after loading mach core

jasonmolenda added a comment. (or rather, not "conflict with the OperatingSystemPlugIn stop reason" -- but would make it confusing to users. I think it might be best to remove ThreadMachCore::CalculateStopInfo.) https://reviews.llvm.org/D44139

[Lldb-commits] [lldb] r327448 - Add a missing return in SBPlatform::IsConnected and test

Author: jingham Date: Tue Mar 13 14:06:05 2018 New Revision: 327448 URL: http://llvm.org/viewvc/llvm-project?rev=327448=rev Log: Add a missing return in SBPlatform::IsConnected and test for the behavior - using the fact that the Host platform is always present & connected. Modified:

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

> On Mar 13, 2018, at 11:51 AM, Davide Italiano via lldb-commits > wrote: > > We had the report of a crash where lldb was setting a conditional > breakpoint on an invalid condition (CGRect == pointer, which is, > ill-formed). > The symbol-based resolution of lldb

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

An alternative proposed by Fred which is an OK middle ground IMHO is that of not inserting a decl for the unmangled name, but treat this symbol always as-it-is. i.e. if we have a symbol _Znwm in some object, we don't insert a decl for `operator new(unsigned long)` but for _Znwm itself. Greg,

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

> On Mar 13, 2018, at 10:37 AM, Davide Italiano via lldb-commits > wrote: > > An alternative proposed by Fred which is an OK middle ground IMHO is > that of not inserting a decl for the unmangled name, but treat this > symbol always as-it-is. > i.e. if we have a

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

On Tue, Mar 13, 2018 at 10:57 AM, Greg Clayton wrote: > > >> On Mar 13, 2018, at 10:37 AM, Davide Italiano via lldb-commits >> wrote: >> >> An alternative proposed by Fred which is an OK middle ground IMHO is >> that of not inserting a decl for

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

I agree with Jason, we shouldn't be looking at magic naming and making assumptions. What is the name is a C function that starts with _Z. Both of Jason's examples below should work. Sometimes we only have symbol tables and if people are able to only get to the C++ function via a mangled name,

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

On Tue, Mar 13, 2018 at 9:59 AM, Frédéric Riss via lldb-commits wrote: > > >> On Mar 12, 2018, at 6:40 PM, Davide Italiano via lldb-commits >> wrote: >> >> Author: davide >> Date: Mon Mar 12 18:40:00 2018 >> New Revision: 327356 >> >>

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

> On Mar 13, 2018, at 10:25 AM, Davide Italiano via lldb-commits > wrote: > > On Tue, Mar 13, 2018 at 9:59 AM, Frédéric Riss via lldb-commits > > wrote: >> >> >>> On Mar 12, 2018, at 6:40 PM,

[Lldb-commits] [PATCH] D44456: [SymbolFilePDB] Simplify getting the source file path

asmith created this revision. asmith added reviewers: zturner, rnk, lldb-commits. Herald added a subscriber: llvm-commits. Replace SymbolFilePDB::GetSourceFileNameForPDBCompiland() with PDBSymbolCompiland::getSourceFileFullPath(). Repository: rL LLVM https://reviews.llvm.org/D44456 Files:

[Lldb-commits] [PATCH] D44455: [SymbolFilePDB] Remove a few null pointer checks by passing ref

asmith created this revision. asmith added reviewers: zturner, rnk, lldb-commits. Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44455 Files: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp

[Lldb-commits] [PATCH] D44456: [SymbolFilePDB] Simplify getting the source file path

asmith added a comment. Has a dependence on https://reviews.llvm.org/D44458 Repository: rL LLVM https://reviews.llvm.org/D44456 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

On Tue, Mar 13, 2018 at 2:43 PM, Jason Molenda wrote: > > >> On Mar 13, 2018, at 11:51 AM, Davide Italiano via lldb-commits >> wrote: >> >> We had the report of a crash where lldb was setting a conditional >> breakpoint on an invalid condition

[Lldb-commits] [PATCH] D44321: Support demangling for D symbols via dlopen

timotheecour added a comment. > Actually, this is not the correct interface is it? The returned pointer > should point to newly allocated memory using malloc, right? > Good to document that somewhere. not 100% sure what you mean in that comment but I just pushed a commit that clarifies that

[Lldb-commits] [PATCH] D44321: Support demangling for D symbols via dlopen

timotheecour updated this revision to Diff 138291. timotheecour added a comment. - document C interface https://reviews.llvm.org/D44321 Files: include/lldb/Core/Mangled.h include/lldb/Core/PluginManager.h source/API/SystemInitializerFull.cpp source/Core/CMakeLists.txt