[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

yurydelendik added a comment. Herald added a subscriber: jdoerfert. @jingham is this patch good to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57689/new/ https://reviews.llvm.org/D57689 ___

[Lldb-commits] [PATCH] D58167: Refactor user/group name resolving code

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355323: Refactor user/group name resolving code (authored by labath, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D58167?vs=188448=189169#toc

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

aprantl added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/conflicts/TestStdModuleWithConflicts.py:35 + +self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET) + what's that for? CHANGES SINCE LAST

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/conflicts/TestStdModuleWithConflicts.py:35 + +self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET) +

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

teemperor updated this revision to Diff 189160. teemperor added a comment. Herald added a subscriber: ormris. - Refactored build flags. - Fixed doxygen comment. Yeah, the implicit module map flag wasn't actually necessary for the tests, thanks! For the Makefile, I had to create a utility

[Lldb-commits] [PATCH] D58912: [debugserver] Fix IsUserReady thread filtering

friss created this revision. friss added reviewers: jasonmolenda, clayborg, jingham. Herald added a subscriber: jdoerfert. In 2010 (r118866), filtering code was added to debugserver to avoid reporting threads that were "not ready to be displayed to the user". This code inspects the thread's

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Yes, looks fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57689/new/ https://reviews.llvm.org/D57689

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

labath added a comment. Thank you for writing the test. I think it's really great that we're able to test something like this without depending on the actual c++ library existing and supporting modules. (I think we should have more tests like that). Comment at:

[Lldb-commits] [lldb] r355323 - Refactor user/group name resolving code

Author: labath Date: Mon Mar 4 10:48:00 2019 New Revision: 355323 URL: http://llvm.org/viewvc/llvm-project?rev=355323=rev Log: Refactor user/group name resolving code Summary: This creates an abstract base class called "UserIDResolver", which can be implemented to provide user/group ID

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

aprantl added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:283 + /// + /// @param[in] lang + /// The language for which the include directories should be queried. `\param` Comment at:

[Lldb-commits] [lldb] r355353 - [Host] Fix the build (and the modules build).

Author: davide Date: Mon Mar 4 16:37:40 2019 New Revision: 355353 URL: http://llvm.org/viewvc/llvm-project?rev=355353=rev Log: [Host] Fix the build (and the modules build). -> Add a missing include to find the base class. -> Add a missing out-of-line declaration for a member function.

[Lldb-commits] [PATCH] D58912: [debugserver] Fix IsUserReady thread filtering

jasonmolenda added a comment. Will this hide a thread that jumps through a null function pointer? That's the only user process case where a pc of 0 needs to be reported to the developer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58912/new/ https://reviews.llvm.org/D58912

[Lldb-commits] [lldb] r355351 - [DataFormatters] Fix regression in libc++ std::atomic formatter caused by https://reviews.llvm.org/D56913

Author: shafik Date: Mon Mar 4 16:17:18 2019 New Revision: 355351 URL: http://llvm.org/viewvc/llvm-project?rev=355351=rev Log: [DataFormatters] Fix regression in libc++ std::atomic formatter caused by https://reviews.llvm.org/D56913 rdar://problem/48568543 Modified:

[Lldb-commits] [lldb] r355364 - Revert "[testsuite] Port crashlog and dependencies to Python 3."

Author: davide Date: Mon Mar 4 17:34:47 2019 New Revision: 355364 URL: http://llvm.org/viewvc/llvm-project?rev=355364=rev Log: Revert "[testsuite] Port crashlog and dependencies to Python 3." This revert the commit because it broke the bots. I need to find a way that works with both versions.

[Lldb-commits] [PATCH] D58912: [debugserver] Fix IsUserReady thread filtering

friss added a comment. In D58912#1417570 , @jasonmolenda wrote: > Will this hide a thread that jumps through a null function pointer? That's > the only user process case where a pc of 0 needs to be reported to the > developer. Nope, I tested this

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/Support/Triple.cpp:537 return StringSwitch(EnvironmentName) +// FIXME: We have to put XCOFF before COFF; +// perhaps an order-independent pattern matching is desired? If the conclusion

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu created this revision. jasonliu added reviewers: hubert.reinterpretcast, sfertile, chandlerc, apaprocki. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, dexonsmith, aheejin, hiraditya, javed.absar. Herald added projects: clang, LLDB, LLVM. This patch adds an XCOFF

[Lldb-commits] [PATCH] D58838: Remove tautological #ifdefs

aprantl added a comment. Ping. As far as I can tell, now this patch should be entirely NFC. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58838/new/ https://reviews.llvm.org/D58838 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r355358 - Fix the Xcode project for UserIDResolver.

Author: jingham Date: Mon Mar 4 16:52:12 2019 New Revision: 355358 URL: http://llvm.org/viewvc/llvm-project?rev=355358=rev Log: Fix the Xcode project for UserIDResolver. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r355375 - [Expression] Remove unused parameter from Evaluate

Author: xiaobai Date: Mon Mar 4 19:33:34 2019 New Revision: 355375 URL: http://llvm.org/viewvc/llvm-project?rev=355375=rev Log: [Expression] Remove unused parameter from Evaluate Modified: lldb/trunk/include/lldb/Expression/UserExpression.h lldb/trunk/source/Expression/REPL.cpp

[Lldb-commits] [PATCH] D58838: Remove tautological #ifdefs

davide accepted this revision. davide added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58838/new/ https://reviews.llvm.org/D58838 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r355359 - [testsuite] Port crashlog and dependencies to Python 3.

Author: davide Date: Mon Mar 4 16:53:38 2019 New Revision: 355359 URL: http://llvm.org/viewvc/llvm-project?rev=355359=rev Log: [testsuite] Port crashlog and dependencies to Python 3. Fixes three tests in the testsuite. Modified: lldb/trunk/examples/darwin/heap_find/heap.py

Re: [Lldb-commits] [PATCH] D58727: https://reviews.llvm.org/D58394 done right

The event we are stopping for is the stop to single step over a breakpoint. We should have decided not to broadcast that to the public event queue, since it's an implementation stop of the "continue". It almost looks like the stop hook is getting triggered by a not-broadcast event, though

[Lldb-commits] [lldb] r355356 - [lldbtest] Check against the correct name for libcxxabi (macOS).

Author: davide Date: Mon Mar 4 16:47:15 2019 New Revision: 355356 URL: http://llvm.org/viewvc/llvm-project?rev=355356=rev Log: [lldbtest] Check against the correct name for libcxxabi (macOS). Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified:

[Lldb-commits] [PATCH] D57689: Adds property to force enabling of GDB JIT loader for MacOS

yurydelendik updated this revision to Diff 189244. yurydelendik added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57689/new/ https://reviews.llvm.org/D57689 Files:

[Lldb-commits] [PATCH] D58912: [debugserver] Fix IsUserReady thread filtering

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good, that was my only concern. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58912/new/ https://reviews.llvm.org/D58912

[Lldb-commits] [lldb] r355352 - Revert "[DataFormatters] Fix regression in libc++ std::atomic formatter caused by https://reviews.llvm.org/D56913"

Author: shafik Date: Mon Mar 4 16:29:58 2019 New Revision: 355352 URL: http://llvm.org/viewvc/llvm-project?rev=355352=rev Log: Revert "[DataFormatters] Fix regression in libc++ std::atomic formatter caused by https://reviews.llvm.org/D56913; This reverts commit r355351. Modified:

[Lldb-commits] [PATCH] D58946: [SBAPI] Don't check IsValid in constructor

JDevlieghere created this revision. JDevlieghere added reviewers: labath, davide, jingham. JDevlieghere added a project: LLDB. Herald added a subscriber: abidh. When running the test suite with the instrumentation macros, I noticed two lldb-mi tests regressed. The issue was the copy constructor

[Lldb-commits] [lldb] r355329 - Fix Windows build after UserIDResolver patch.

Author: zturner Date: Mon Mar 4 11:57:04 2019 New Revision: 355329 URL: http://llvm.org/viewvc/llvm-project?rev=355329=rev Log: Fix Windows build after UserIDResolver patch. That patch added a function to HostInfo that returns an instance of UserIDResolver, but this function was unimplemented

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/conflicts/TestStdModuleWithConflicts.py:35 + +self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET) +

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

aprantl added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/conflicts/TestStdModuleWithConflicts.py:35 + +self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET) + teemperor wrote: > aprantl wrote: > >

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:257 -CFLAGS += -I$(SRCDIR) -include $(THIS_FILE_DIR)test_common.h -I$(THIS_FILE_DIR) +ifndef NO_INC_DIRS + CFLAGS += -I$(SRCDIR)

[Lldb-commits] [PATCH] D58833: Fix embedded Python initialization according to changes in version 3.7

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. I spent several hours reading through this code and I do believe this patch (and your reasoning) is correct. The comment is fine to me, FWIW. Repository: rLLDB LLDB CHANGES SINCE LAST

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:257 -CFLAGS += -I$(SRCDIR) -include $(THIS_FILE_DIR)test_common.h -I$(THIS_FILE_DIR) +ifndef NO_INC_DIRS + CFLAGS += -I$(SRCDIR) -include $(THIS_FILE_DIR)test_common.h

[Lldb-commits] [PATCH] D58860: [build.py] Allow clang-cl to build files starting with '/U'

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355341: [build.py] Allow clang-cl to build files starting with /U (authored by xiaobai, committed by ). Herald added subscribers: teemperor, abidh. Herald added a project: LLDB. Changed prior to

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

aprantl added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/conflicts/TestStdModuleWithConflicts.py:35 + +self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET) + teemperor wrote: > aprantl wrote: > >

[Lldb-commits] [lldb] r355340 - [build] Rename clang-headers to clang-resource-headers

Author: smeenai Date: Mon Mar 4 13:19:53 2019 New Revision: 355340 URL: http://llvm.org/viewvc/llvm-project?rev=355340=rev Log: [build] Rename clang-headers to clang-resource-headers Summary: The current install-clang-headers target installs clang's resource directory headers. This is different

[Lldb-commits] [lldb] r355341 - [build.py] Allow clang-cl to build files starting with '/U'

Author: xiaobai Date: Mon Mar 4 13:36:49 2019 New Revision: 355341 URL: http://llvm.org/viewvc/llvm-project?rev=355341=rev Log: [build.py] Allow clang-cl to build files starting with '/U' Summary: clang-cl tries to match cl's interface, and treats /U as "Removes a predefined macro" as cl does.

[Lldb-commits] [lldb] r355342 - Move ProcessInfo from Host to Utility.

Author: zturner Date: Mon Mar 4 13:51:03 2019 New Revision: 355342 URL: http://llvm.org/viewvc/llvm-project?rev=355342=rev Log: Move ProcessInfo from Host to Utility. There are set of classes in Target that describe the parameters of a process - e.g. it's PID, name, user id, and similar.

[Lldb-commits] [PATCH] D58842: Move ProcessInstanceInfo and similar to Utility

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL355342: Move ProcessInfo from Host to Utility. (authored by zturner, committed by ). Herald added a project: LLVM. Herald