[Lldb-commits] [PATCH] D69106: MemoryRegion: Print "don't know" permission values as such

labath marked an inline comment as done. labath added a comment. In D69106#1712949 , @clayborg wrote: > Looks good. Do we maybe want to use "unknown" instead of "don't know" when > printing out the long for of a MemoryRegionInfo::OptionalBool? Or maybe

[Lldb-commits] [PATCH] D69166: [LLDB] Do not take address of std::iscntrl in std::remove_if

KyrBoh updated this revision to Diff 225607. KyrBoh added a comment. Correct patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69166/new/ https://reviews.llvm.org/D69166 Files: lldb/source/Initialization/SystemInitializerCommon.cpp Index:

[Lldb-commits] [PATCH] D69166: [LLDB] Do not take address of std::iscntrl in std::remove_if

KyrBoh abandoned this revision. KyrBoh added a comment. Per labath's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69166/new/ https://reviews.llvm.org/D69166 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D69102: COFF: Set section permissions

labath marked an inline comment as done. labath added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:800 /*flags*/ 0); +header_sp->SetPermissions(ePermissionsReadable); m_sections_up->AddSection(header_sp);

[Lldb-commits] [PATCH] D69102: COFF: Set section permissions

mstorsjo accepted this revision. mstorsjo added inline comments. This revision is now accepted and ready to land. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:800 /*flags*/ 0); +header_sp->SetPermissions(ePermissionsReadable);

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

mstorsjo added a comment. In D69031#1713900 , @aprantl wrote: > Check out `lldb/test/Shell/helper/toolchain.py`, you probably need to filter > out some options for clang_cl specifically. Yeah, I later found that. The issue is that it's passed to

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:235-245 PythonObject =(const PythonObject ) { Reset(PyRefType::Borrowed, other.get()); return *this; } - void Reset(PythonObject &) { + PythonObject

[Lldb-commits] [PATCH] D69133: eliminate nontrivial Reset(...) from TypedPythonObject

labath added a comment. I think the conversion of different string types should be handled differently. Please see inline comment for details. Otherwise, this looks fine. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:326-338 llvm::Expected

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

labath added a comment. Thank you for doing the investigation, and the detailed summary. I'm going to respond inline. In D68968#1713788 , @wallace wrote: > Thanks for your feedback and to @clayborg for an offline discussion we had. > > I'm going to add

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

labath added a comment. In D69031#1714107 , @mstorsjo wrote: > In D69031#1713900 , @aprantl wrote: > > > Check out `lldb/test/Shell/helper/toolchain.py`, you probably need to > > filter out some options for

[Lldb-commits] [PATCH] D67793: new api class: SBFile

labath added a comment. In D67793#1713981 , @lawrence_danna wrote: > In D67793#1692544 , @labath wrote: > > > BTW, I've had to add (or rather, extend) a fairly ugly hack in r373573 in > > order to get the new

[Lldb-commits] [PATCH] D69100: COFF: Create a separate "section" for the file header

labath updated this revision to Diff 225600. labath marked 2 inline comments as done. labath added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69100/new/ https://reviews.llvm.org/D69100 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp

[Lldb-commits] [PATCH] D69100: COFF: Create a separate "section" for the file header

labath marked 4 inline comments as done. labath added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:794 +SectionSP header_sp = std::make_shared( +module_sp, this, ~user_id_t(0), ConstString("header"), +eSectionTypeOther,

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

mstorsjo added a comment. In D69031#1714143 , @labath wrote: > In D69031#1714107 , @mstorsjo wrote: > > > In D69031#1713900 , @aprantl wrote: > > > > > Check out

[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

labath added a comment. In D68961#1713566 , @shafik wrote: > We also have the lldb-cmake-matrix > bot which > runs the test suite using older versions of clang which is there for exactly

Re: [Lldb-commits] [lldb] r375146 - [Reproducer] Surface error if setting the cwd fails

On 17/10/2019 19:58, Jonas Devlieghere via lldb-commits wrote: + cwd->erase(std::remove_if(cwd->begin(), cwd->end(), std::iscntrl), + cwd->end()); What is this hacking around? I can imagine a .rtrim() would be needed to remove a trailing cr/lf (though it would still be

[Lldb-commits] [PATCH] D69166: [LLDB] Do not take address of std::iscntrl in std::remove_if

labath added a comment. I already submitted the very same patch in r375221. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69166/new/ https://reviews.llvm.org/D69166 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D69100: COFF: Create a separate "section" for the file header

mstorsjo added a comment. Looks and sounds good to me, although I'm not familiar with this code and its context yet - so I'm not sure if I'm qualified to formally approve it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69100/new/ https://reviews.llvm.org/D69100

[Lldb-commits] [lldb] r375234 - Add REQUIRES: x86 to more tests which need the x86 llvm target built

Author: labath Date: Fri Oct 18 06:49:40 2019 New Revision: 375234 URL: http://llvm.org/viewvc/llvm-project?rev=375234=rev Log: Add REQUIRES: x86 to more tests which need the x86 llvm target built Modified:

[Lldb-commits] [PATCH] D69166: [LLDB] Do not take address of std::iscntrl in std::remove_if

KyrBoh created this revision. KyrBoh added a reviewer: MyDeveloperDay. Herald added a reviewer: bollu. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Due to the fact, that getting an address of function in the standard library, LLDB fails to compile in my environment with

[Lldb-commits] [PATCH] D69105: minidump: Create memory regions from the sections of loaded modules

labath marked an inline comment as done. labath added inline comments. Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:348-349 + bool is_complete; + std::tie(*m_memory_regions, is_complete) = + m_minidump_parser->BuildMemoryRegions(); +

[Lldb-commits] [lldb] r375221 - SystemInitializerCommon fix compilation on linux

Author: labath Date: Fri Oct 18 04:47:23 2019 New Revision: 375221 URL: http://llvm.org/viewvc/llvm-project?rev=375221=rev Log: SystemInitializerCommon fix compilation on linux C++ defines two overloads of std::iscntrl. One in and one in . On linux we seem to include both which makes the

[Lldb-commits] [lldb] r375242 - Update MinidumpYAML to use minidump::Exception for exception stream

Author: josepht Date: Fri Oct 18 07:56:19 2019 New Revision: 375242 URL: http://llvm.org/viewvc/llvm-project?rev=375242=rev Log: Update MinidumpYAML to use minidump::Exception for exception stream Reviewers: labath, jhenderson, clayborg, MaskRay, grimar Reviewed By: grimar Subscribers:

[Lldb-commits] [lldb] r375244 - ProcessMinidump: Suppress reporting stop for signal '0'

Author: josepht Date: Fri Oct 18 08:02:16 2019 New Revision: 375244 URL: http://llvm.org/viewvc/llvm-project?rev=375244=rev Log: ProcessMinidump: Suppress reporting stop for signal '0' Summary: The minidump exception stream can report an exception record with signal 0. If we try to create a

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

vsk marked an inline comment as done. vsk added inline comments. Comment at: llvm/lib/Support/Unix/Signals.inc:372 if (Sig == SIGPIPE) -exit(EX_IOERR); +if (SignalHandlerFunctionType CurrentPipeFunction = PipeSignalFunction) +

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks for fixing this, Vedant! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69148/new/ https://reviews.llvm.org/D69148 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

jordan_rose added inline comments. Comment at: llvm/lib/Support/Unix/Signals.inc:372 if (Sig == SIGPIPE) -exit(EX_IOERR); +if (SignalHandlerFunctionType CurrentPipeFunction = PipeSignalFunction) + CurrentPipeFunction(); vsk wrote:

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

clayborg added a comment. sounds like we have a plan! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68968/new/ https://reviews.llvm.org/D68968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D69106: MemoryRegion: Print "don't know" permission values as such

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Sounds good, thanks for doing this CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69106/new/ https://reviews.llvm.org/D69106 ___

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

stella.stamenova added a comment. In D68130#1713620 , @teemperor wrote: > Yeah, seems like constructing objects in expressions isn't implemented on > Windows. I'm not sure if there is a reliable way to test that constructors > aren't shadowed by these

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

vsk planned changes to this revision. vsk added a comment. The death tests are flaky. I've noticed two issues: 1. When run under lit, the DisableExitOnSIGPIPE doesn't actually exit when it receives SIGPIPE. Dtrace suggests that the unit test process inherits an "ignore" sigaction from its

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

vsk updated this revision to Diff 225661. vsk added a comment. This revision is now accepted and ready to land. Replace the death tests with a non-death test. I plan to commit this later in the day if there aren't any objections. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69148/new/

[Lldb-commits] [lldb] r375243 - LLDB: Use LLVM's type for minidump ExceptionStream [NFC]

Author: josepht Date: Fri Oct 18 07:59:10 2019 New Revision: 375243 URL: http://llvm.org/viewvc/llvm-project?rev=375243=rev Log: LLDB: Use LLVM's type for minidump ExceptionStream [NFC] Summary: The types defined for it in LLDB are now redundant with core types. Reviewers: labath, clayborg

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

This revision was automatically updated to reflect the committed changes. Closed by commit rGa50272f8261f: Update MinidumpYAML to use minidump::Exception for exception stream (authored by JosephTremoulet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68658: LLDB: Use LLVM's type for minidump ExceptionStream [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rGd094d97d0223: LLDB: Use LLVMs type for minidump ExceptionStream [NFC] (authored by JosephTremoulet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68096: ProcessMinidump: Suppress reporting stop for signal '0'

This revision was automatically updated to reflect the committed changes. Closed by commit rG77460d3888c5: ProcessMinidump: Suppress reporting stop for signal 0 (authored by JosephTremoulet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68096/new/

Re: [Lldb-commits] [lldb] r375146 - [Reproducer] Surface error if setting the cwd fails

You're right. I've replaced it with rtrim in r375259. On Fri, Oct 18, 2019 at 4:12 AM Pavel Labath wrote: > > On 17/10/2019 19:58, Jonas Devlieghere via lldb-commits wrote: > > + cwd->erase(std::remove_if(cwd->begin(), cwd->end(), std::iscntrl), > > + cwd->end()); > > What

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

wallace added a comment. man, thanks for your feedback! Indeed, i was trying to solve some problems that don't exist yet. Later when I add apk debugging support, I'll figure out what's the best way to retrieve apk specific information, but for now display_name is more than enough Repository:

[Lldb-commits] [lldb] 5c28d49 - [lldb][NFC] Remove wrong tests in TestCallOverriddenMethod

Author: Raphael Isemann Date: 2019-10-18T19:18:41Z New Revision: 5c28d49314c7bb84f08c9db3acd5ff64e1c4bc2d URL: https://github.com/llvm/llvm-project/commit/5c28d49314c7bb84f08c9db3acd5ff64e1c4bc2d DIFF:

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

labath added a comment. It doesn't seem to be failing here http://lab.llvm.org:8014/builders/lldb-x86_64-debian. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68130/new/ https://reviews.llvm.org/D68130

[Lldb-commits] [PATCH] D69102: COFF: Set section permissions

mstorsjo added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:800 /*flags*/ 0); +header_sp->SetPermissions(ePermissionsReadable); m_sections_up->AddSection(header_sp); mstorsjo wrote: > labath wrote: > >

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rG32ce14e55e5a: Disable exit-on-SIGPIPE in lldb (authored by vsk). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69148/new/

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

stella.stamenova added a comment. Oh, and TestCallOverridenMethod still has some failures on Windows: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9996/steps/test/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

teemperor added a comment. Sorry, seems like I forgot to delete these tests when I extracted them into their own test function. About the ubuntu failure: I think I have a similar failure on my Arch Linux machine when constructing an object in another test, so I fear that the whole object

[Lldb-commits] [PATCH] D69014: [LLDB] bugfix: command script add -f doesn't work for some callables

lawrence_danna added a comment. @jingham , @labathwhat do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69014/new/ https://reviews.llvm.org/D69014 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D69133: eliminate nontrivial Reset(...) from TypedPythonObject

lawrence_danna updated this revision to Diff 225687. lawrence_danna added a comment. spelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69133/new/ https://reviews.llvm.org/D69133 Files:

[Lldb-commits] [PATCH] D69133: eliminate nontrivial Reset(...) from TypedPythonObject

lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:401 - void Reset(PyRefType type, PyObject *py_obj) { -Reset(); + void Reset() { PythonObject::Reset(); } + labath wrote: > Is this needed,

[Lldb-commits] [PATCH] D69133: eliminate nontrivial Reset(...) from TypedPythonObject

lawrence_danna updated this revision to Diff 225686. lawrence_danna marked 6 inline comments as done. lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69133/new/ https://reviews.llvm.org/D69133 Files:

[Lldb-commits] [lldb] 32ce14e - Disable exit-on-SIGPIPE in lldb

Author: Vedant Kumar Date: 2019-10-18T21:05:30Z New Revision: 32ce14e55e5a99dd99c3b4fd4bd0ccaaf2948c30 URL: https://github.com/llvm/llvm-project/commit/32ce14e55e5a99dd99c3b4fd4bd0ccaaf2948c30 DIFF: https://github.com/llvm/llvm-project/commit/32ce14e55e5a99dd99c3b4fd4bd0ccaaf2948c30.diff

[Lldb-commits] [lldb] 64b7d95 - [Reproducer] Improve reproducer help (NFC)

Author: Jonas Devlieghere Date: 2019-10-18T21:47:31Z New Revision: 64b7d95568607eac5336428a22e02f27b8663a79 URL: https://github.com/llvm/llvm-project/commit/64b7d95568607eac5336428a22e02f27b8663a79 DIFF:

[Lldb-commits] [lldb] 06a2bea - [Reproducer] XFAIL TestWorkingDir on Windows

Author: Jonas Devlieghere Date: 2019-10-18T22:16:15Z New Revision: 06a2beae92f5d2adcd0143a6798918418c2ea325 URL: https://github.com/llvm/llvm-project/commit/06a2beae92f5d2adcd0143a6798918418c2ea325 DIFF:

[Lldb-commits] [PATCH] D69209: [lldb] Add test for running static initializers in expressions.

teemperor created this revision. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. teemperor added a comment. Just dumping this here because I don't want to anger the build bots before going into the weekend. While reading ClangExpressionParser source code I

[Lldb-commits] [PATCH] D69209: [lldb] Add test for running static initializers in expressions.

teemperor added a comment. Just dumping this here because I don't want to anger the build bots before going into the weekend. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69209/new/ https://reviews.llvm.org/D69209

[Lldb-commits] [PATCH] D69210: [Disassembler] Simplify MCInst predicates

vsk created this revision. vsk added reviewers: jasonmolenda, ab. DisassemblerLLVMC exposes a few MCInst predicates (e.g. `HasDelaySlot`). Group the logic for evaluating the existing predicates together, to prep for adding new ones. This is NFC-ish: with this change, the existing predicates will

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

teemperor added a comment. Well, I'm fine with x-failing it on Linux, even though I guess at some point someone (i.e., probably me) has to figure out why this stuff is broken in the expression parser. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 90c64a3 - Move endian constant from Host.h to SwapByteOrder.h, prune include

Author: Reid Kleckner Date: 2019-10-19T00:48:11Z New Revision: 90c64a3456b972432a21ef043b205c18a91e011b URL: https://github.com/llvm/llvm-project/commit/90c64a3456b972432a21ef043b205c18a91e011b DIFF: https://github.com/llvm/llvm-project/commit/90c64a3456b972432a21ef043b205c18a91e011b.diff

[Lldb-commits] [lldb] 0904f92 - Skip (more) PExpect tests under ASAN, I can't get them to work reliably.

Author: Adrian Prantl Date: 2019-10-19T00:30:30Z New Revision: 0904f924012db8002eec3a0533e310c1e714cca4 URL: https://github.com/llvm/llvm-project/commit/0904f924012db8002eec3a0533e310c1e714cca4 DIFF: https://github.com/llvm/llvm-project/commit/0904f924012db8002eec3a0533e310c1e714cca4.diff

[Lldb-commits] [PATCH] D69133: eliminate nontrivial Reset(...) from TypedPythonObject

lawrence_danna updated this revision to Diff 225738. lawrence_danna added a comment. use enable_if on CStringArg so the other constructors take precedence Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69133/new/ https://reviews.llvm.org/D69133

[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, clayborg, labath, jingham. Herald added a subscriber: mgorny. Herald added a project: LLDB. With this patch, only the no-argument form of `Reset()` remains in PythonDataObjects. It also deletes