[Lldb-commits] [PATCH] D70050: [lldb] [test] Add a test for watchpoint set error handling on NetBSD

mgorny created this revision. mgorny added reviewers: labath, krytarowski. Herald added a subscriber: jfb. mgorny added a parent revision: D70025: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events. Add a test that verifies that when the user does not have permissions to set

Re: [Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

On 11/09/19 12:41 PM, Jan Kratochvil wrote: > > On Sat, 09 Nov 2019 03:25:51 +0100, Jason Molenda via lldb-commits wrote: > > I'm switching the default for at least the weekend via > > 60ab30ebce833c87bd4776f67cd9a82fe162ef9c / > > https://reviews.llvm.org/rG60ab30ebce83 so the bots aren't

[Lldb-commits] [PATCH] D70060: [lldb] [Process/NetBSD] Use PT_STOP to stop the process

mgorny created this revision. mgorny added reviewers: labath, krytarowski. https://reviews.llvm.org/D70060 Files: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h Index:

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil added a comment. I am going to investigate it this week. Feel free to revert it but some such patch is definitely needed for all recent Fedoras, RHEL-8 and CentOS-8 (due to annobin on all

[Lldb-commits] [PATCH] D70022: [lldb] [Process/NetBSD] Improve threading support

labath added a comment. The code seems reasonable, but I think it would be good include the set of tests which this patch is supposed to fix into the patch itself. (And same for other patches too.) There's also some functionality here that's probably not tested by any of our existing tests, so

Re: [Lldb-commits] [lldb] 0877dd1 - [Driver] Force llvm to install its handlers before lldb's

On 09/11/2019 03:05, v...@apple.com wrote: On Nov 8, 2019, at 1:17 AM, Pavel Labath wrote: On 08/11/2019 01:33, via lldb-commits wrote: Hey JF, Pavel, We're still seeing crashes due to SIGPIPE on some lldb bots. This workaround in the lldb driver is insufficient, because liblldb.dylib may

[Lldb-commits] [lldb] a14eb8f - lldb: Fix some -Wdeprecated-copy warnings

Author: Pavel Labath Date: 2019-11-11T17:55:49+01:00 New Revision: a14eb8f47d43c701651ad59f49167a614a8c9773 URL: https://github.com/llvm/llvm-project/commit/a14eb8f47d43c701651ad59f49167a614a8c9773 DIFF: https://github.com/llvm/llvm-project/commit/a14eb8f47d43c701651ad59f49167a614a8c9773.diff

[Lldb-commits] [PATCH] D70060: [lldb] [Process/NetBSD] Use PT_STOP to stop the process

labath added a comment. Does this have any functional difference that would be useful to test? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70060/new/ https://reviews.llvm.org/D70060 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D70050: [lldb] [test] Add a test for watchpoint set error handling on NetBSD

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/test/Shell/Watchpoint/Inputs/thread-dbreg.c:1-23 +#include + +int g_watchme = 0; + +void *thread_func(void *arg) { + /* watchpoint trigger from subthread */ + g_watchme = 2;

[Lldb-commits] [PATCH] D70050: [lldb] [test] Add a test for watchpoint set error handling on NetBSD

labath added inline comments. Comment at: lldb/test/Shell/Watchpoint/Inputs/thread-dbreg.c:1-23 +#include + +int g_watchme = 0; + +void *thread_func(void *arg) { + /* watchpoint trigger from subthread */ + g_watchme = 2; mgorny wrote: > labath wrote: > >

[Lldb-commits] [PATCH] D70022: [lldb] [Process/NetBSD] Improve threading support

mgorny marked 2 inline comments as done. mgorny added a comment. Well, are there any LLDB commands that can actually cause such an event to happen? I haven't been able to find one to send a signal to thread in the first place. Comment at:

[Lldb-commits] [PATCH] D70022: [lldb] [Process/NetBSD] Improve threading support

labath added a comment. In D70022#1740388 , @mgorny wrote: > Well, are there any LLDB commands that can actually cause such an event to > happen? I haven't been able to find one to send a signal to thread in the > first place. You can make a

[Lldb-commits] [PATCH] D70050: [lldb] [test] Add a test for watchpoint set error handling on NetBSD

labath added inline comments. Comment at: lldb/test/Shell/Watchpoint/Inputs/thread-dbreg.c:1-23 +#include + +int g_watchme = 0; + +void *thread_func(void *arg) { + /* watchpoint trigger from subthread */ + g_watchme = 2; labath wrote: > mgorny wrote: > >

[Lldb-commits] [PATCH] D70070: [lldb][NFC] Move LLVM RTTI implementation from enum to static ID variable

teemperor created this revision. teemperor added reviewers: labath, davide. teemperor added a project: Upstreaming LLDB's downstream patches. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. swift-lldb currently has to patch the ExpressionKind enum to add

[Lldb-commits] [PATCH] D70070: [lldb][NFC] Move LLVM RTTI implementation from enum to static ID variable

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Swift aside, I think it's also good that the generic Expression class does not need to know about the various kinds of expressions that the Clang Expression parser plugin wants to invent.

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

smeenai added a comment. Commit message needs to be updated. Comment at: lldb/cmake/modules/LLDBFramework.cmake:124 + +# Add an rpath pointing to the directory where LLDB.framework is installed. +set_property(TARGET liblldb APPEND PROPERTY INSTALL_RPATH You

Re: [Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

On Mon, 11 Nov 2019 17:34:45 +0100, Pavel Labath wrote: > On 09/11/2019 21:41, Jan Kratochvil via lldb-commits wrote: > > Linux Fedora 30 x86_64: > > d162e02cee74a3dbbfb1317fa9749f5e18610282 > > > >File > >

[Lldb-commits] [PATCH] D70074: [lldb][NFC] Remove unused CompilerType::IsPossibleCPlusPlusDynamicType

teemperor added a comment. (Just leaving this here to have it in my patch queue until the automerger bot is back from the dead). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70074/new/ https://reviews.llvm.org/D70074

[Lldb-commits] [PATCH] D70074: [lldb][NFC] Remove unused CompilerType::IsPossibleCPlusPlusDynamicType

teemperor created this revision. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D70074 Files: lldb/include/lldb/Symbol/CompilerType.h Index: lldb/include/lldb/Symbol/CompilerType.h

Re: [Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

Thanks!  lldb is trying to resume execution for some reason. I wonder if the T11 as the stop reason is causing problems, I just did it at random. I'll try changing the test to use a T02 stop reason. Baffled as to the difference in behavior, but we'll see if this matters. On 11/10/19 10:32 PM,

[Lldb-commits] [PATCH] D69931: Add rpath to liblldb so vendors can ship their own python framework (or others)

smeenai added inline comments. Comment at: lldb/cmake/modules/LLDBFramework.cmake:124 + +# Add an rpath pointing to the directory where LLDB.framework is installed. +set_property(TARGET liblldb APPEND PROPERTY INSTALL_RPATH smeenai wrote: > You may wanna add the

[Lldb-commits] [lldb] da83e96 - Fix a regression in macOS-style path remapping.

Author: Adrian Prantl Date: 2019-11-11T12:21:38-08:00 New Revision: da83e96273527a137f2ebd77cedb920180eab621 URL: https://github.com/llvm/llvm-project/commit/da83e96273527a137f2ebd77cedb920180eab621 DIFF: https://github.com/llvm/llvm-project/commit/da83e96273527a137f2ebd77cedb920180eab621.diff

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

aadsm added a comment. > The proposed path in this patch, -rpath "@loader_path/../../../", uses the > @loader_path expansion which is the directory containing the binary that the > load command is in (in this case liblldb's directory). Popping 3 directories > up from that is likely not sane in

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

aadsm updated this revision to Diff 228634. aadsm added a comment. Updating to only add an rpath that points to the directory where LLDB.frameworks gets installed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69931/new/

[Lldb-commits] [lldb] 135a493 - Fix TestNoGPacketSupported on linux

Author: Pavel Labath Date: 2019-11-11T17:29:48+01:00 New Revision: 135a493f34561219d67251b58a482cd3fc6416b9 URL: https://github.com/llvm/llvm-project/commit/135a493f34561219d67251b58a482cd3fc6416b9 DIFF: https://github.com/llvm/llvm-project/commit/135a493f34561219d67251b58a482cd3fc6416b9.diff

Re: [Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

On 09/11/2019 21:41, Jan Kratochvil via lldb-commits wrote: On Sat, 09 Nov 2019 03:25:51 +0100, Jason Molenda via lldb-commits wrote: I'm switching the default for at least the weekend via 60ab30ebce833c87bd4776f67cd9a82fe162ef9c / https://reviews.llvm.org/rG60ab30ebce83 so the bots aren't

[Lldb-commits] [lldb] d24bce5 - Add a testcase for .dSYM path remapping dictionaries.

Author: Adrian Prantl Date: 2019-11-11T12:21:38-08:00 New Revision: d24bce57c3ca2414ff5e53d8f7f3f007d6a946fe URL: https://github.com/llvm/llvm-project/commit/d24bce57c3ca2414ff5e53d8f7f3f007d6a946fe DIFF: https://github.com/llvm/llvm-project/commit/d24bce57c3ca2414ff5e53d8f7f3f007d6a946fe.diff

Re: [Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

Hi Jason, On Mon, 11 Nov 2019 02:04:55 +0100, Jason Molenda wrote: > ./lldb-dotest -t -v -p TestNoGPacketSupported.py Linux Fedora 30 x86_64 6ef63638cb8bac243e0e59cec66a19c57b79e351 Thanks, Jan /usr/bin/python /home/jkratoch/redhat/llvm-monorepo/lldb/test/API/dotest.py --arch=x86_64 -s

[Lldb-commits] [PATCH] D70050: [lldb] [test] Add a test for watchpoint set error handling on NetBSD

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/test/Shell/Watchpoint/Inputs/thread-dbreg.c:1-23 +#include + +int g_watchme = 0; + +void *thread_func(void *arg) { + /* watchpoint trigger from subthread */ + g_watchme = 2;

[Lldb-commits] [PATCH] D70050: [lldb] [test] Add a test for watchpoint set error handling on NetBSD

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/Shell/Watchpoint/Inputs/thread-dbreg.c:1-23 +#include + +int g_watchme = 0; + +void *thread_func(void *arg) { + /* watchpoint trigger from

[Lldb-commits] [PATCH] D70060: [lldb] [Process/NetBSD] Use PT_STOP to stop the process

mgorny added a comment. Not that I know of. The main difference is how it behaves on a stopped process but I don't think we're ever issuing it on one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70060/new/ https://reviews.llvm.org/D70060

[Lldb-commits] [PATCH] D70060: [lldb] [Process/NetBSD] Use PT_STOP to stop the process

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70060/new/ https://reviews.llvm.org/D70060 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This seems reasonable to me. > path @loader_path/../../../../../../../../Library/Frameworks/ LOL :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70070: [lldb][NFC] Move LLVM RTTI implementation from enum to static ID variable

davide added a comment. LGTM. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70070/new/ https://reviews.llvm.org/D70070 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D70074: [lldb][NFC] Remove unused CompilerType::IsPossibleCPlusPlusDynamicType

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Nice! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70074/new/ https://reviews.llvm.org/D70074 ___

[Lldb-commits] [PATCH] D69931: Add rpath to liblldb so vendors can ship their own python framework (or others)

aadsm updated this revision to Diff 228765. aadsm edited the summary of this revision. aadsm added a comment. Clarify the point of the install_path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69931/new/ https://reviews.llvm.org/D69931 Files:

[Lldb-commits] [PATCH] D70037: Fix a regression in macOS-style path remapping.

This revision was automatically updated to reflect the committed changes. Closed by commit rGda83e9627352: Fix a regression in macOS-style path remapping. (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70100: [DWARF] Handle call sites with indirect call targets

vsk created this revision. vsk added reviewers: aprantl, friss, jingham. Split CallEdge into DirectCallEdge and IndirectCallEdge. Teach DWARFExpression how to evaluate entry values in cases where the current activation was created by an indirect call. Writing tests for this is challenging, at

[Lldb-commits] [PATCH] D70002: [lldb] Make Target* a Target& in CommandObjectExpression::DoExecute REPL logic

jingham added a comment. I don't think either version is right. We really shouldn't be using "GetSelectedTarget" (with or without the Dummy) for getting the Target context for a command. That's how it was originally done, but you aren't guaranteed that the selected target is the right target

[Lldb-commits] [lldb] 0b8dfb5 - [lldb] Re-enable VSCode tests

Author: Jonas Devlieghere Date: 2019-11-11T15:59:54-08:00 New Revision: 0b8dfb5762fdc350c5071c9eeffd4f7e4d495e98 URL: https://github.com/llvm/llvm-project/commit/0b8dfb5762fdc350c5071c9eeffd4f7e4d495e98 DIFF:

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/CompileUnit.h:169 + /// \param[in] matching_lambda + /// A predicate used to evaluate each function name. + /// This doesn't explain what the bool return does. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69873: [lldb-vscode] support the completion request

clayborg added a comment. Maybe limit the matches if posssible if that works. If you type "target variable " you can complete a list of all global variables everywhere which might be quite a few. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70100: [DWARF] Handle call sites with indirect call targets

aprantl added a comment. Mechanically, this seems reasonable. Comment at: lldb/include/lldb/Symbol/Function.h:334 - DISALLOW_COPY_AND_ASSIGN(CallEdge); +/// An indirect call site. +class IndirectCallEdge : public CallEdge { You might want to briefly explain

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

labath added a comment. So, if I understand correctly, this patch doesn't just add an "ABI" plugin (for which we have in the past agreed that we don't know of a better way to test than just running "TestReturnValue" on the given architecture), but it actually adds all the bits and pieces

[Lldb-commits] [lldb] 0cf86da - [Reproducer] Quit the debugger after generating a reproducer

Author: Jonas Devlieghere Date: 2019-11-11T14:29:53-08:00 New Revision: 0cf86da1741fb1a4278dc31dfc8f1538c9186892 URL: https://github.com/llvm/llvm-project/commit/0cf86da1741fb1a4278dc31dfc8f1538c9186892 DIFF:

[Lldb-commits] [PATCH] D69931: Add rpath to liblldb so vendors can ship their own python framework (or others)

smeenai accepted this revision. smeenai added a comment. LGTM Comment at: lldb/cmake/modules/LLDBFramework.cmake:125 +# Add an rpath pointing to the directory where LLDB.framework is installed. +# This allows frameworks (relying on @rpath) to be installed in the same folder

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

shafik updated this revision to Diff 228774. shafik added a comment. - Adjust comment - matching_lambda argument is now `FunctionSP` to match `ForeachFunction` signature. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69913/new/ https://reviews.llvm.org/D69913 Files:

[Lldb-commits] [PATCH] D69913: Re-enable std::function formatter with fixes to improve non-cached lookup performance

shafik marked an inline comment as done. shafik added a comment. In D69913#1739579 , @jingham wrote: > Why not have the FindFunctions lambda take a FunctionSP? It would be easy to > get the Function name out of the function in the lambda, and that would

[Lldb-commits] [PATCH] D69704: [lldb] Add IsTypeSystemCompatible method to SBModule to allow checking compatibility between language versions

jingham added a comment. In D69704#1732484 , @labath wrote: > The part that bothers me here is that this assumes that the entirety of a > module (or an least the portion of it written in the same language) uses the > same version of the language. Is

[Lldb-commits] [PATCH] D69931: Add rpath to liblldb so vendors can ship their own python framework (or others)

This revision was automatically updated to reflect the committed changes. Closed by commit rG31ea714e9a94: Add rpath to liblldb so vendors can ship their own python framework (or others) (authored by António Afonso aa...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70106: Performance: Add a set of visited SymbolFiles to other the FindFiles variant.

aprantl created this revision. aprantl added reviewers: JDevlieghere, jasonmolenda. Herald added a reviewer: shafik. This is basically the same bug as in r260434 again. SymbolFileDWARF::FindTypes has exponential worst-case when digging through dependency DAG of .pcms because each object file