[Lldb-commits] [PATCH] D70335: [lldb] [test] Enable lldb-server tests on NetBSD, and set XFAILs

mgorny marked an inline comment as done. mgorny added a comment. In D70335#1748773 , @labath wrote: > What's up with the new test (TestGdbRemoteTwoThreadsInvCont.py)? Is that > ready for checkin or a mistake? Should it be in a separate patch? Sorry,

[Lldb-commits] [PATCH] D70335: [lldb] [test] Enable lldb-server tests on NetBSD, and set XFAILs

mgorny updated this revision to Diff 229703. mgorny added a comment. Remove accidentally added wip test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70335/new/ https://reviews.llvm.org/D70335 Files: lldb/packages/Python/lldbsuite/test/dotest.py

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

merge_guards_bot added a comment. Build result: pass - 60084 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[Lldb-commits] [PATCH] D70277: [Signal] Allow llvm clients to opt into one-shot SIGPIPE handling

vsk updated this revision to Diff 229601. vsk edited the summary of this revision. vsk added a comment. - Preserve the current behavior w.r.t SIGPIPE for all llvm-derived tools except lldb. - Document the trickiness re: registering a SIGPIPE handler before llvm sets up its signal handlers.

[Lldb-commits] [PATCH] D69704: [lldb] Add IsDebugInfoCompatible method to SBModule to allow checking compatibility between language versions

teemperor abandoned this revision. teemperor added a comment. Turns out this is actually not even used by anyone but was just (somehow?) added to the SBAPI in lldb-swift... Anyway, deleting this downstream... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69704/new/

[Lldb-commits] [PATCH] D70277: [Signal] Allow llvm clients to opt into one-shot SIGPIPE handling

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM if Pavel's happy :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70277/new/ https://reviews.llvm.org/D70277 ___

[Lldb-commits] [PATCH] D70272: [-gmodules] Let LLDB log a warning if the Clang module hash mismatches.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1cbe0038944a: [-gmodules] Let LLDB log a warning if the Clang module hash mismatches. (authored by aprantl). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 1cbe003 - [-gmodules] Let LLDB log a warning if the Clang module hash mismatches.

Author: Adrian Prantl Date: 2019-11-15T11:52:13-08:00 New Revision: 1cbe0038944a39ba79078997f9c65ba8abf6fbdd URL: https://github.com/llvm/llvm-project/commit/1cbe0038944a39ba79078997f9c65ba8abf6fbdd DIFF: https://github.com/llvm/llvm-project/commit/1cbe0038944a39ba79078997f9c65ba8abf6fbdd.diff

[Lldb-commits] [PATCH] D70322: Add RTTI support to SymbolFile

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d71dd928d1d: Add RTTI support to the SymbolFile class hierarchy (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 7d71dd9 - Add RTTI support to the SymbolFile class hierarchy

Author: Adrian Prantl Date: 2019-11-15T11:52:13-08:00 New Revision: 7d71dd928d1dcc838dc4dbe5cf294f557609f271 URL: https://github.com/llvm/llvm-project/commit/7d71dd928d1dcc838dc4dbe5cf294f557609f271 DIFF: https://github.com/llvm/llvm-project/commit/7d71dd928d1dcc838dc4dbe5cf294f557609f271.diff

[Lldb-commits] [lldb] 2f95b64 - Rename posix/FileSystem.cpp to FileSystemPosix.cpp

Author: Adrian Prantl Date: 2019-11-15T11:48:46-08:00 New Revision: 2f95b6488bfa7197cae69f511066d84e926573ab URL: https://github.com/llvm/llvm-project/commit/2f95b6488bfa7197cae69f511066d84e926573ab DIFF: https://github.com/llvm/llvm-project/commit/2f95b6488bfa7197cae69f511066d84e926573ab.diff

[Lldb-commits] [PATCH] D70335: [lldb] [test] Enable lldb-server tests on NetBSD, and set XFAILs

mgorny created this revision. mgorny added reviewers: krytarowski, labath. Herald added a reviewer: jfb. Herald added a subscriber: jfb. https://reviews.llvm.org/D70335 Files: lldb/packages/Python/lldbsuite/test/dotest.py

[Lldb-commits] [PATCH] D70335: [lldb] [test] Enable lldb-server tests on NetBSD, and set XFAILs

mgorny updated this revision to Diff 229629. mgorny added a comment. Herald added a subscriber: dexonsmith. Missed a few tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70335/new/ https://reviews.llvm.org/D70335 Files: lldb/packages/Python/lldbsuite/test/dotest.py

[Lldb-commits] [lldb] a578adc - dotest: Add a way for the run_to_* helpers to register dylibs

Author: Fred Riss Date: 2019-11-15T15:17:27-08:00 New Revision: a578adc1bc8e17b147ed5ef4794cd6f3f82b584b URL: https://github.com/llvm/llvm-project/commit/a578adc1bc8e17b147ed5ef4794cd6f3f82b584b DIFF: https://github.com/llvm/llvm-project/commit/a578adc1bc8e17b147ed5ef4794cd6f3f82b584b.diff

[Lldb-commits] [PATCH] D70252: [Docs] Add Python caveats under the development section

aprantl added inline comments. Comment at: lldb/docs/resources/caveats.rst:34 +with Xcode links against the Python that's part of Xcode. You should always use +the system's Python interpreter to import the lldb module or install packages. That 's confusingly

[Lldb-commits] [PATCH] D70134: dotest: Add a way for the run_to_* helpers to register dylibs

This revision was automatically updated to reflect the committed changes. Closed by commit rGa578adc1bc8e: dotest: Add a way for the run_to_* helpers to register dylibs (authored by friss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70134/new/

[Lldb-commits] [PATCH] D70252: [Docs] Add Python caveats under the development section

JDevlieghere updated this revision to Diff 229668. JDevlieghere added a comment. Address feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70252/new/ https://reviews.llvm.org/D70252 Files: lldb/docs/index.rst lldb/docs/resources/build.rst lldb/docs/resources/caveats.rst

[Lldb-commits] [lldb] 4d23764 - Fix -Wunused-result warnings in LLDB

Author: Reid Kleckner Date: 2019-11-15T16:38:00-08:00 New Revision: 4d23764dddc23e74ad165086d7f471a3e0e52bf8 URL: https://github.com/llvm/llvm-project/commit/4d23764dddc23e74ad165086d7f471a3e0e52bf8 DIFF: https://github.com/llvm/llvm-project/commit/4d23764dddc23e74ad165086d7f471a3e0e52bf8.diff

[Lldb-commits] [lldb] 0304360 - Add a testcase for Clang modules being updated within one LLDB session.

Author: Adrian Prantl Date: 2019-11-15T16:27:14-08:00 New Revision: 0304360a40b45ffcbb040596d2a01733c0103455 URL: https://github.com/llvm/llvm-project/commit/0304360a40b45ffcbb040596d2a01733c0103455 DIFF: https://github.com/llvm/llvm-project/commit/0304360a40b45ffcbb040596d2a01733c0103455.diff

[Lldb-commits] [PATCH] D70281: Fix -Wunused-result warnings in LLDB

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d23764dddc2: Fix -Wunused-result warnings in LLDB (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D70281?vs=229421=229667#toc Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 2c7c528 - [lldb-vscode] support the completion request

Author: Walter Erquinigo Date: 2019-11-15T17:37:55-08:00 New Revision: 2c7c528d7ac17230f1f239b629a02d407a74e1bf URL: https://github.com/llvm/llvm-project/commit/2c7c528d7ac17230f1f239b629a02d407a74e1bf DIFF:

[Lldb-commits] [PATCH] D69873: [lldb-vscode] support the completion request

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c7c528d7ac1: [lldb-vscode] support the completion request (authored by Walter Erquinigo walterme...@oculus.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70335: [lldb] [test] Enable lldb-server tests on NetBSD, and set XFAILs

labath added a comment. What's up with the new test (TestGdbRemoteTwoThreadsInvCont.py)? Is that ready for checkin or a mistake? Should it be in a separate patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70335/new/ https://reviews.llvm.org/D70335

[Lldb-commits] [lldb] 9b40a7f - Remove +x permission on some files

Author: Sylvestre Ledru Date: 2019-11-16T14:47:20+01:00 New Revision: 9b40a7f3bf7198dd64403cbd83478087e72f994b URL: https://github.com/llvm/llvm-project/commit/9b40a7f3bf7198dd64403cbd83478087e72f994b DIFF:

[Lldb-commits] [PATCH] D70335: [lldb] [test] Enable lldb-server tests on NetBSD, and set XFAILs

krytarowski added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/thread-name/TestGdbRemoteThreadName.py:33 @skipIfWindows # the test is not updated for Windows. +@skipIfNetBSD # build failure due to pthread_setname_np prototype

[Lldb-commits] [PATCH] D70303: Fix TestFormatters.py stepping too far

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f0c3bad2f03: Fix TestFormatters.py stepping too far (authored by rovka). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68179: [lldb] Fix JSON parser to allow empty arrays

labath accepted this revision. labath added a comment. I'm not sure whose approval are you waiting for, but this LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68179/new/ https://reviews.llvm.org/D68179 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D70303: Fix TestFormatters.py stepping too far

rovka updated this revision to Diff 229505. rovka added a comment. Addressed @labath's comment (test run in progress). Thanks for having a look! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70303/new/ https://reviews.llvm.org/D70303 Files:

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil added a comment. @omjavaid In the end I built a native `armv7l-unknown-linux-gnueabihf` lldb using: cmake ../llvm-monorepo/llvm/ -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS="lldb;clang;lld" -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_BUILD_LLVM_DYLIB Built it from trunk:

[Lldb-commits] [PATCH] D70272: [-gmodules] Let LLDB log a warning if the Clang module hash mismatches.

aprantl marked 3 inline comments as done. aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/SymbolFile.h:283-285 + /// Return a hash for this symbol file, such as a dwo_id. + virtual llvm::Optional GetSymbolHash() { return {}; } + labath

[Lldb-commits] [lldb] 3bc7119 - Comment the fact that DWARFDebugInfoEntry isn't copyable.

Author: Adrian Prantl Date: 2019-11-15T09:14:48-08:00 New Revision: 3bc71193bd4f29ebb5e5baa11581909972265b4f URL: https://github.com/llvm/llvm-project/commit/3bc71193bd4f29ebb5e5baa11581909972265b4f DIFF: https://github.com/llvm/llvm-project/commit/3bc71193bd4f29ebb5e5baa11581909972265b4f.diff

[Lldb-commits] [lldb] 81104ea - [CMake] Configure the Info.plist so it contains a real version number.

Author: Jonas Devlieghere Date: 2019-11-15T09:50:42-08:00 New Revision: 81104ea9ab618219b608aec8bbcba54a3c470004 URL: https://github.com/llvm/llvm-project/commit/81104ea9ab618219b608aec8bbcba54a3c470004 DIFF:

[Lldb-commits] [PATCH] D70277: [Signal] Allow llvm clients to opt into one-shot SIGPIPE handling

labath added a comment. As I said in the other discussion, though this is a (small) step in what I consider to be the right direction for this, it still seems like a workaround to me. But if everyone else is fine with that, then I won't stand in your way. One thing I am not sure of is why

[Lldb-commits] [PATCH] D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation.

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/terminal/TestEditline.py:37-38 + +# Run help for different commands for escape variants to make sure each +# one matches uniquely (the buffer isn't cleared in between matches). +

[Lldb-commits] [lldb] 5f0c3ba - Fix TestFormatters.py stepping too far

Author: Diana Picus Date: 2019-11-15T14:20:25+01:00 New Revision: 5f0c3bad2f03b9bba7f899d7b0ce667ca355f69d URL: https://github.com/llvm/llvm-project/commit/5f0c3bad2f03b9bba7f899d7b0ce667ca355f69d DIFF: https://github.com/llvm/llvm-project/commit/5f0c3bad2f03b9bba7f899d7b0ce667ca355f69d.diff

[Lldb-commits] [PATCH] D70303: Fix TestFormatters.py stepping too far

labath added a comment. Looks reasonable, but I'd suggest using something more unique for the breakpoint placement. Feel free to add some comment to the .cpp file and then search for that in python (that's what most of our other tests tend to do). CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70314: [lldb] Add better test commands for expression evaluation

teemperor created this revision. teemperor added reviewers: JDevlieghere, shafik, labath. Herald added subscribers: lldb-commits, abidh, christof. Herald added a project: LLDB. This patch adds two new commands to lldbtest: `expect_expr` and `expect_simple_expr`. These commands are supposed to

[Lldb-commits] [PATCH] D70314: [lldb] Add better test commands for expression evaluation

labath added a comment. Semi-random idea: Instead of running the expression through the command line and then unpacking the result, should we just use the appropriate SBFrame api here (EvaluateExpression/GetValueForVariablePath)? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70272: [-gmodules] Let LLDB log a warning if the Clang module hash mismatches.

labath added inline comments. Comment at: lldb/include/lldb/Symbol/SymbolFile.h:283-285 + /// Return a hash for this symbol file, such as a dwo_id. + virtual llvm::Optional GetSymbolHash() { return {}; } + aprantl wrote: > labath wrote: > > Can we remove

[Lldb-commits] [PATCH] D70314: [lldb] Add better test commands for expression evaluation

teemperor added a comment. In D70314#1747711 , @labath wrote: > Semi-random idea: Instead of running the expression through the command line > and then unpacking the result, should we just use the appropriate SBFrame api > here

[Lldb-commits] [PATCH] D70272: [-gmodules] Let LLDB log a warning if the Clang module hash mismatches.

aprantl marked 2 inline comments as done. aprantl added inline comments. Comment at: lldb/source/Host/common/Host.cpp:300 va_end(args); + + // Log to log channel. This allows testcases to grep for log output. jingham wrote: > On macOS, SystemLog vsprintf's

Re: [Lldb-commits] [PATCH] D70272: [-gmodules] Let LLDB log a warning if the Clang module hash mismatches.

I'm not sure that's right. LLDB_LOG_OPTION_VERBOSE is independent of the log channel, it's a basic feature of Log.h/cpp. You test it with Log::GetVerbose. I know it works with the lldb channel because I hide a bunch of extra logging in the step & expr logs behind GetVerbose() == true. Jim

[Lldb-commits] [PATCH] D70322: Add RTTI support to SymbolFile

aprantl created this revision. aprantl added reviewers: labath, teemperor, jingham. Thanks to Pavel for suggesting this and Raphael for helping me understand how this works. https://reviews.llvm.org/D70322 Files: lldb/include/lldb/Expression/UserExpression.h

[Lldb-commits] [PATCH] D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation.

rupprecht marked 3 inline comments as done. rupprecht added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/terminal/TestEditline.py:37-38 + +# Run help for different commands for escape variants to make sure each +# one matches uniquely (the

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

rupprecht created this revision. rupprecht added a reviewer: labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. expect() forwards its command to sendline(). This can be problematic if the command already contains a newline: sendline() unconditionally adds a newline