[Lldb-commits] [PATCH] D70580: Register Objective-C property accessors with their property decls.

2019-11-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Symbol/ClangASTContext.cpp:8462 +ClangASTContext::SetMetadata(clang_ast, getter, *metadata); +

[Lldb-commits] [PATCH] D70415: Complete complete types early when importing types from Clang module DWARF.

2019-11-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70415/new/ https://reviews.llvm.org/D70415

[Lldb-commits] [lldb] c0eeea5 - Register Objective-C property accessors with their property decls.

2019-11-22 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2019-11-22T09:55:25-08:00 New Revision: c0eeea5d74d979139378660513712e8f33278285 URL: https://github.com/llvm/llvm-project/commit/c0eeea5d74d979139378660513712e8f33278285 DIFF: https://github.com/llvm/llvm-project/commit/c0eeea5d74d979139378660513712e8f33278285.diff

[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

2019-11-22 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd updated this revision to Diff 230658. compnerd added a comment. Use @labath's suggestion of bumping minimum required version for Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69535/new/ https://reviews.llvm.org/D69535 Files:

[Lldb-commits] [PATCH] D70022: [lldb] [Process/NetBSD] Improve threading support

2019-11-22 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemote_vContThreads.py:68-72 +"read packet: $vCont;C{0:x}:{1:x};C{0:x}:{2:x}#00".format( +lldbutil.get_signal_number('SIGUSR1'), +

[Lldb-commits] [lldb] 4fdbc07 - [DWARF] Handle call sites with indirect call targets

2019-11-22 Thread Vedant Kumar via lldb-commits
Author: Vedant Kumar Date: 2019-11-22T11:50:22-08:00 New Revision: 4fdbc0728d4b8acb1921fc48301622e971fc3961 URL: https://github.com/llvm/llvm-project/commit/4fdbc0728d4b8acb1921fc48301622e971fc3961 DIFF: https://github.com/llvm/llvm-project/commit/4fdbc0728d4b8acb1921fc48301622e971fc3961.diff

[Lldb-commits] [PATCH] D70415: Complete complete types early when importing types from Clang module DWARF.

2019-11-22 Thread Adrian Prantl via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG539117616d7a: Complete complete types early when importing types from Clang module DWARF. (authored by aprantl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70100: [DWARF] Handle call sites with indirect call targets

2019-11-22 Thread Vedant Kumar via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4fdbc0728d4b: [DWARF] Handle call sites with indirect call targets (authored by vsk). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D70100?vs=228921=230704#toc

[Lldb-commits] [PATCH] D70580: Register Objective-C property accessors with their property decls.

2019-11-22 Thread Adrian Prantl via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc0eeea5d74d9: Register Objective-C property accessors with their property decls. (authored by aprantl). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 8b40bdb - Reformat code for readability.

2019-11-22 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2019-11-22T10:03:25-08:00 New Revision: 8b40bdbd7edc4cbd6c906911be0329b0900e0486 URL: https://github.com/llvm/llvm-project/commit/8b40bdbd7edc4cbd6c906911be0329b0900e0486 DIFF: https://github.com/llvm/llvm-project/commit/8b40bdbd7edc4cbd6c906911be0329b0900e0486.diff

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

2019-11-22 Thread Jordan Rupprecht via Phabricator via lldb-commits
rupprecht added a comment. In D70324#1755712 , @davide wrote: > In D70324#1755704 , @labath wrote: > > > [This is probably not the right patch, as the last run on that bot still > > doesn't have this commit.] >

[Lldb-commits] [PATCH] D70517: [lldb][DataFormatters] Support pretty printing std::string when built with -funsigned-char.

2019-11-22 Thread Jordan Rupprecht via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG506144da04b9: [lldb][DataFormatters] Support pretty printing std::string when built with… (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 5391176 - Complete complete types early when importing types from Clang module DWARF.

2019-11-22 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2019-11-22T09:58:16-08:00 New Revision: 539117616d7a4c5690f1b9284faf0d282cd79621 URL: https://github.com/llvm/llvm-project/commit/539117616d7a4c5690f1b9284faf0d282cd79621 DIFF: https://github.com/llvm/llvm-project/commit/539117616d7a4c5690f1b9284faf0d282cd79621.diff

[Lldb-commits] [PATCH] D70442: [LLDB] Force message formatting to English

2019-11-22 Thread Reid Kleckner via Phabricator via lldb-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70442/new/ https://reviews.llvm.org/D70442 ___

[Lldb-commits] [lldb] 45098b6 - Remove extraneous log enabling.

2019-11-22 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2019-11-22T14:13:35-08:00 New Revision: 45098b6809ebd5640a1b9578f58ade495986b9ee URL: https://github.com/llvm/llvm-project/commit/45098b6809ebd5640a1b9578f58ade495986b9ee DIFF: https://github.com/llvm/llvm-project/commit/45098b6809ebd5640a1b9578f58ade495986b9ee.diff

[Lldb-commits] [PATCH] D70622: [cmake][lit] Follow symlinks when looking for lit tests & reconfigure lldb's tests.

2019-11-22 Thread Jordan Rupprecht via Phabricator via lldb-commits
rupprecht created this revision. rupprecht added reviewers: JDevlieghere, labath. Herald added subscribers: llvm-commits, lldb-commits, mgorny. Herald added projects: LLDB, LLVM. The lldb tree contains a symlink directory, `lldb/test/API/testcases`, which points to the tests in

[Lldb-commits] [lldb] b6ae524 - [Examples] Move structured-data unpacking out of the loop. (NFC)

2019-11-22 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2019-11-22T15:43:39-08:00 New Revision: b6ae524cd2d5139748e207d4b60b4a900775d6a7 URL: https://github.com/llvm/llvm-project/commit/b6ae524cd2d5139748e207d4b60b4a900775d6a7 DIFF:

[Lldb-commits] [lldb] 1b099c1 - [Examples] Add in_call_stack breakpoint function.

2019-11-22 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2019-11-22T15:36:42-08:00 New Revision: 1b099c1df00e3c8a0ba20af199c89a154bdb7a45 URL: https://github.com/llvm/llvm-project/commit/1b099c1df00e3c8a0ba20af199c89a154bdb7a45 DIFF:

[Lldb-commits] [PATCH] D70622: [cmake][lit] Follow symlinks when looking for lit tests & reconfigure lldb's tests.

2019-11-22 Thread pre-merge checks [bot] via Phabricator via lldb-commits
merge_guards_bot added a comment. Build result: pass - 60250 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

2019-11-22 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. In D70324#1757070 , @rupprecht wrote: > In D70324#1755712 , @davide wrote: > > > In D70324#1755704 , @labath wrote: > > > > > [This is probably

[Lldb-commits] [PATCH] D70022: [lldb] [Process/NetBSD] Improve threading support

2019-11-22 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Thanks for doing those tests. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemote_vContThreads.py:68-72 +"read packet:

[Lldb-commits] [PATCH] D70023: [lldb] [Process/NetBSD] Copy watchpoints to newly-created threads

2019-11-22 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.h:74-76 + Status + CopyHardwareWatchpointsFrom(NativeRegisterContextNetBSD ) +

[Lldb-commits] [PATCH] D70022: [lldb] [Process/NetBSD] Improve threading support

2019-11-22 Thread Michał Górny via Phabricator via lldb-commits
mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemote_vContThreads.py:68-72 +"read packet: $vCont;C{0:x}:{1:x};C{0:x}:{2:x}#00".format( +

[Lldb-commits] [PATCH] D69880: [lldb] Fix exception breakpoint not being resolved when set on dummy target

2019-11-22 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. I can land this right now, thanks for the patch! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69880/new/ https://reviews.llvm.org/D69880 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D70023: [lldb] [Process/NetBSD] Copy watchpoints to newly-created threads

2019-11-22 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 230604. mgorny marked 2 inline comments as done. mgorny added a comment. Switched to `%clang_host`. Fun fact: things work better if you remove the file before 'readding' it via patch (i.e. ending up appending new contents to old). CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69880: [lldb] Fix exception breakpoint not being resolved when set on dummy target

2019-11-22 Thread Martin Svensson via Phabricator via lldb-commits
poya added a comment. Thanks, currently no commit access, so would like to ask you for that favor as well Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69880/new/ https://reviews.llvm.org/D69880 ___ lldb-commits

[Lldb-commits] [lldb] 0b0dca9 - [lldb] Fix exception breakpoint not being resolved when set on dummy target

2019-11-22 Thread Raphael Isemann via lldb-commits
Author: Martin Svensson Date: 2019-11-22T11:20:09+01:00 New Revision: 0b0dca9f6fe34333abdb437bd1d3d92c8362a2e6 URL: https://github.com/llvm/llvm-project/commit/0b0dca9f6fe34333abdb437bd1d3d92c8362a2e6 DIFF:

[Lldb-commits] [PATCH] D70023: [lldb] [Process/NetBSD] Copy watchpoints to newly-created threads

2019-11-22 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 230609. mgorny marked 3 inline comments as done. mgorny added a comment. Switched to `RegisterContextNetBSD &` return type as suggested, and fixed formatting. Had to do some include shifting too. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69880: [lldb] Fix exception breakpoint not being resolved when set on dummy target

2019-11-22 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0b0dca9f6fe3: [lldb] Fix exception breakpoint not being resolved when set on dummy target (authored by poya, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION