[Lldb-commits] [PATCH] D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message

labath added a comment. I don't actually use vscode, so I don't really know whether this is a good idea, but if you say it is then I can go with that. However, I think the implementation needs a lot of work: - it is very windows-hostile: `dup`, `pipe`, `select`, etc. don't exist or don't work

[Lldb-commits] [PATCH] D78421: Fix out of sync source code/executable when debugging

n1tram1 added a comment. In D78421#2060327 , @labath wrote: > So, I'm not actually convinced that this is an improvement... This is exactly what is was worried about, I'm not sure either. The only thing I thought was a bug is the fact the lldb shows

[Lldb-commits] [PATCH] D79929: [lldb] Tab completion for process plugin name

jingham added a comment. In D79929#2058939 , @MrHate wrote: > That does make sense. I will split it into `eArgTypeProcessPlugin` and > `eArgTypeDisassemblePlugin` along with the corresponding completion function > names at the time I implement the

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk marked an inline comment as done. kwk added a comment. @labath please see my inline comment. Comment at: lldb/source/Breakpoint/BreakpointResolverName.cpp:315 + if (filter_by_cu && filter_by_function) { +// Keep this symbol context if it is a function call to

[Lldb-commits] [PATCH] D80543: [lldb] Manual remove of DISALLOW_COPY_AND_ASSIGN def and one expansion

labath added a comment. In D80543#2055448 , @teemperor wrote: > In D80543#2054405 , @labath wrote: > > > I am all for this, because makes lldb code more consistent with llvm (llvm > > used to have a

[Lldb-commits] [PATCH] D78421: Fix out of sync source code/executable when debugging

labath added a comment. In D78421#2054544 , @n1tram1 wrote: > Passing a simple `Module &` sounds like an easy but I would also have to make > `SourceManager::GetFile` take a `Module &`. > > There is one corner case, let's say file.c is being used by

[Lldb-commits] [PATCH] D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message

aadsm added a comment. thanks for the feedback, I'll read it more carefully later. As for the tests it should be easy to set up, didn't want to spend time on that before we agreed on doing it this way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D80680: save_crashlog should not be using the load_addr property of an SBAddress

This revision was automatically updated to reflect the committed changes. Closed by commit rG723a1caa377b: Fix the crashlog.py scripts use of the load_address property. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80680/new/

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

labath added inline comments. Comment at: lldb/source/Breakpoint/BreakpointResolverName.cpp:315 + if (filter_by_cu && filter_by_function) { +// Keep this symbol context if it is a function call to a function +// whose declaration is located in a file that

[Lldb-commits] [lldb] 723a1ca - Fix the crashlog.py script's use of the load_address property.

Author: Jim Ingham Date: 2020-05-28T09:55:40-07:00 New Revision: 723a1caa377b898ff3dc0897156f544feab99ac8 URL: https://github.com/llvm/llvm-project/commit/723a1caa377b898ff3dc0897156f544feab99ac8 DIFF: https://github.com/llvm/llvm-project/commit/723a1caa377b898ff3dc0897156f544feab99ac8.diff

[Lldb-commits] [lldb] ac1dc13 - [Docs] Correct description of lldbinit behavior

Author: Jonas Devlieghere Date: 2020-05-28T13:10:33-07:00 New Revision: ac1dc1336ad76d719445d706654ca0ec4ff5557c URL: https://github.com/llvm/llvm-project/commit/ac1dc1336ad76d719445d706654ca0ec4ff5557c DIFF:

[Lldb-commits] [lldb] b950c26 - [lldb/Reproducers] Add top-level-target check-lldb-reproducers

Author: Jonas Devlieghere Date: 2020-05-28T10:48:16-07:00 New Revision: b950c261d9c107d2c9366dd7e583f9f1c4f282f3 URL: https://github.com/llvm/llvm-project/commit/b950c261d9c107d2c9366dd7e583f9f1c4f282f3 DIFF:

[Lldb-commits] [lldb] 81b7901 - [lldb-vscode] Make it possible to run vsce package

Author: Greg Clayton Date: 2020-05-28T13:33:48-07:00 New Revision: 81b79011a77f97798236af6d716e5d352790d54b URL: https://github.com/llvm/llvm-project/commit/81b79011a77f97798236af6d716e5d352790d54b DIFF: https://github.com/llvm/llvm-project/commit/81b79011a77f97798236af6d716e5d352790d54b.diff

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in SBTarget::AddModule

jarin created this revision. jarin added a reviewer: labath. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. SBTarget::AddModule currently handles the UUID parameter in a very weird way: UUIDs with more than 16 bytes are trimmed to 16 bytes. On the other hand,

[Lldb-commits] [PATCH] D79811: WIP: Reenable creation of artificial methods in AddMethodToCXXRecordType(...)

dblaikie added a comment. FWIW I agree that based on the current DWARF LLVM and GCC produce there's no way to allow users to default construct structs in C++11 (where non-static data member initializers were added) or above in the absence of a user-provided constructor - I don't think it'd be

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

jingham added inline comments. Comment at: lldb/source/Breakpoint/BreakpointResolverName.cpp:315 + if (filter_by_cu && filter_by_function) { +// Keep this symbol context if it is a function call to a function +// whose declaration is located in a file that

[Lldb-commits] [lldb] 8ae21fb - [lldb/CMake] Set both the BUILD and INSTALL RPATH on macOS

Author: Jonas Devlieghere Date: 2020-05-28T16:04:35-07:00 New Revision: 8ae21fb8d2a2a5c55070b82dd57b345dd4716f56 URL: https://github.com/llvm/llvm-project/commit/8ae21fb8d2a2a5c55070b82dd57b345dd4716f56 DIFF: