[Lldb-commits] [PATCH] D82396: [lldb/ScriptInterpreter] Extract IO redirection logic and move it out of ScriptInterpreterPython (NFC)

labath added a comment. Sounds like a good idea, just the error handling needs to be done carefully. Comment at: lldb/source/Interpreter/ScriptInterpreter.cpp:171 + if (!nullin) { +error = nullin.takeError(); +return; I'm pretty sure this will trigger

[Lldb-commits] [lldb] 16e17ca - [lldb] Refactor Scalar::TruncOrExtendTo

Author: Pavel Labath Date: 2020-06-24T15:58:33+02:00 New Revision: 16e17ca16a89daa099fd2726d92f08a49870e5a9 URL: https://github.com/llvm/llvm-project/commit/16e17ca16a89daa099fd2726d92f08a49870e5a9 DIFF: https://github.com/llvm/llvm-project/commit/16e17ca16a89daa099fd2726d92f08a49870e5a9.diff

[Lldb-commits] [PATCH] D81978: Redo of Add terminateCommands to lldb-vscode protocol

fhahn added a comment. I noticed that it appears that ` lldb-api :: tools/lldb-vscode/attach/TestVSCode_attach.py` is flaky and I noticed it failing spuriously relatively frequently For example http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/5519 failed with FAIL: lldb-api ::

[Lldb-commits] [lldb] 4bfa438 - [lldb] fix typo in docs: withing -> within

Author: Konrad Kleine Date: 2020-06-24T05:19:47-04:00 New Revision: 4bfa43809fe6780159a4980cf601c504cbec6f32 URL: https://github.com/llvm/llvm-project/commit/4bfa43809fe6780159a4980cf601c504cbec6f32 DIFF: https://github.com/llvm/llvm-project/commit/4bfa43809fe6780159a4980cf601c504cbec6f32.diff

[Lldb-commits] [lldb] 6507bc5 - [lldb/Test] Temporarily disable TestSimulatorPlatform.py

Author: Jonas Devlieghere Date: 2020-06-23T22:41:01-07:00 New Revision: 6507bc56216ba4441790bc581a5b76d9c2ad9774 URL: https://github.com/llvm/llvm-project/commit/6507bc56216ba4441790bc581a5b76d9c2ad9774 DIFF:

Re: [Lldb-commits] [PATCH] D81978: Redo of Add terminateCommands to lldb-vscode protocol

I'll revert this patch. This seems to be the reason Il Mer 24 Giu 2020, 6:27 AM Florian Hahn via Phabricator < revi...@reviews.llvm.org> ha scritto: > fhahn added a comment. > > I noticed that it appears that ` lldb-api :: > tools/lldb-vscode/attach/TestVSCode_attach.py` is flaky and I noticed

[Lldb-commits] [lldb] 8e08422 - Disable flaky lldb-vscode tests on aarch64

Author: Walter Erquinigo Date: 2020-06-24T08:57:20-07:00 New Revision: 8e08422385d93fd99354286abd495484f4513f88 URL: https://github.com/llvm/llvm-project/commit/8e08422385d93fd99354286abd495484f4513f88 DIFF:

Re: [Lldb-commits] [PATCH] D82155: [WIP][lldb/interpreter] Add ability to save lldb session to a file

> On Jun 22, 2020, at 5:52 AM, Pavel Labath via Phabricator via lldb-commits > wrote: > > labath added a comment. > > This seems like it could be useful in some circumstances, though for the use > cases I am imagining (bug reporting) it would be easier to just copy-paste > the terminal

[Lldb-commits] [PATCH] D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented

labath updated this revision to Diff 273043. labath added a comment. - remove trailing whitespace - simplify test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82378/new/ https://reviews.llvm.org/D82378 Files:

[Lldb-commits] [PATCH] D82155: [WIP][lldb/interpreter] Add ability to save lldb session to a file

mib updated this revision to Diff 273087. mib marked 8 inline comments as done. mib added a comment. Addressed Pavel's and Jonas' comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82155/new/ https://reviews.llvm.org/D82155 Files:

[Lldb-commits] [PATCH] D82155: [WIP][lldb/interpreter] Add ability to save lldb session to a file

mib updated this revision to Diff 273090. mib added a comment. Ran clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82155/new/ https://reviews.llvm.org/D82155 Files: lldb/include/lldb/Interpreter/CommandInterpreter.h

[Lldb-commits] [PATCH] D82382: [lldb][NFC] Replace most uses of StringConvert in LLDB with LLVM's to_integer

JDevlieghere added inline comments. Comment at: lldb/source/Host/common/Socket.cpp:286 host_str = host_str.substr(1, host_str.size() - 2); -bool ok = false; -port = StringConvert::ToUInt32(port_str.c_str(), UINT32_MAX, 10, ); +bool ok =

[Lldb-commits] [PATCH] D82396: [lldb/ScriptInterpreter] Extract IO redirection logic and move it out of ScriptInterpreterPython (NFC)

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/ScriptInterpreter.cpp:171 + if (!nullin) { +error = nullin.takeError(); +return; labath wrote: > I'm pretty sure this will trigger an

[Lldb-commits] [PATCH] D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. In D82378#2111675 , @labath wrote: > It's not related, at least not directly. My goal was to prove

[Lldb-commits] [PATCH] D82396: [lldb/ScriptInterpreter] Extract IO redirection logic and move it out of ScriptInterpreterPython (NFC)

JDevlieghere updated this revision to Diff 273068. JDevlieghere added a comment. This now has a small function change w.r.t. the error message. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82396/new/ https://reviews.llvm.org/D82396 Files:

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen created this revision. aelitashen added reviewers: wallace, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Make lldb-vscode receive and process module events so that modules can be rendered in the IDE. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D82412: [lldb/Lua] Redirect Lua stdout/stderr to the CommandReturnObject

JDevlieghere updated this revision to Diff 273073. JDevlieghere added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82412/new/ https://reviews.llvm.org/D82412 Files: lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp

[Lldb-commits] [PATCH] D82378: [lldb/Unwind] Use eh_frame plan directly when it doesn't need to be augmented

labath added a comment. In D82378#2109467 , @jankratochvil wrote: > In D82378#2109330 , @labath wrote: > > > Now this situation is not actually handled by lldb's "augmenter", so the > > example somewhat shaky,

[Lldb-commits] [lldb] b4fdddf - [Apple Silicon] Debugging of process under Rosetta is supported.

Author: Davide Italiano Date: 2020-06-24T12:25:01-07:00 New Revision: b4fdddf971b191aa9a6643ab637b87bc1d686254 URL: https://github.com/llvm/llvm-project/commit/b4fdddf971b191aa9a6643ab637b87bc1d686254 DIFF:

[Lldb-commits] [PATCH] D82493: [Apple Silicon] Debugging of process under Rosetta is supported

davide accepted this revision. davide added a comment. commit b4fdddf971b191aa9a6643ab637b87bc1d686254 (HEAD -> master, origin/master, origin/HEAD) Author: Davide Italiano Date: Wed Jun 24 12:25:01 2020 -0700 [Apple Silicon] Debugging of process under Rosetta is supported.

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

echristo added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:20 #include +#include #include echristo wrote: > echristo wrote: > > This is problematic in that sys/sysctl is deprecated on linux (causing > >

[Lldb-commits] [lldb] cad79f7 - [lldb][NFC] Use expect_expr in TestStructTypes.py

Author: Raphael Isemann Date: 2020-06-24T22:12:17+02:00 New Revision: cad79f73b6b67c9306ad147381e8a8be5db6d5cf URL: https://github.com/llvm/llvm-project/commit/cad79f73b6b67c9306ad147381e8a8be5db6d5cf DIFF:

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

davide created this revision. davide added reviewers: jasonmolenda, aprantl, friss. jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. davide closed this revision. LGTM. With p_flag, we only need to evaluate

[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk

[Lldb-commits] [PATCH] D82493: [Apple Silicon] Debugging of process under Rosetta is supported

davide created this revision. davide added reviewers: jasonmolenda, friss, aprantl. Remove this early exit. It's vestigial from the ppc -> Intel transition, but it doesn't apply anymore: https://reviews.llvm.org/D82493 Files: lldb/source/Host/macosx/objcxx/Host.mm Index:

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. With p_flag, we only need to evaluate (processInfo.kp_proc.p_flag & P_TRANSLATED) as a boolean, but that's a style pref as much as anything. CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] d4ef569 - Disable a flaky lldb-vscode test on aarch64

Author: Walter Erquinigo Date: 2020-06-24T11:09:21-07:00 New Revision: d4ef569577625d50dfe01ab54c7b9995db3e013f URL: https://github.com/llvm/llvm-project/commit/d4ef569577625d50dfe01ab54c7b9995db3e013f DIFF:

[Lldb-commits] [PATCH] D82493: [Apple Silicon] Debugging of process under Rosetta is supported

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Yep. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82493/new/ https://reviews.llvm.org/D82493 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

davide closed this revision. davide added a comment. commit fd19ddb8f2a2b082f492fc59f7f360adf3495701 (HEAD -> master, origin/master, origin/HEAD) Author: Davide Italiano Date: Wed Jun 24 12:18:29 2020 -0700 [Apple Silicon] Initial support for Rosetta Translated

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So great first patch Yifan! A few things to fix up, see inlined comments. We need to add a test for lldb::SBTarget::eBroadcastBitSymbolsLoaded if possible. This can be done by

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

davide added a comment. In D82491#2112269 , @jasonmolenda wrote: > LGTM. With p_flag, we only need to evaluate (processInfo.kp_proc.p_flag & > P_TRANSLATED) as a boolean, but that's a style pref as much as anything. Fair, let me change that.

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

echristo added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:20 #include +#include #include echristo wrote: > This is problematic in that sys/sysctl is deprecated on linux (causing > warnings/Werror failures). I'm

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

echristo added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:20 #include +#include #include This is problematic in that sys/sysctl is deprecated on linux (causing warnings/Werror failures). CHANGES SINCE LAST

[Lldb-commits] [lldb] 58de2a3 - [ProcessGDBRemote] Placate the Windows buildbot.

Author: Davide Italiano Date: 2020-06-24T13:23:49-07:00 New Revision: 58de2a3851391dd9fa675ea6bcd26072a0638829 URL: https://github.com/llvm/llvm-project/commit/58de2a3851391dd9fa675ea6bcd26072a0638829 DIFF:

[Lldb-commits] [lldb] fd19ddb - [Apple Silicon] Initial support for Rosetta

Author: Davide Italiano Date: 2020-06-24T12:19:21-07:00 New Revision: fd19ddb8f2a2b082f492fc59f7f360adf3495701 URL: https://github.com/llvm/llvm-project/commit/fd19ddb8f2a2b082f492fc59f7f360adf3495701 DIFF:

[Lldb-commits] [lldb] 0cd9e59 - [ProcessGDBRemote] Fix a typo in an ifdef from 58de2a3851391d

Author: Martin Storsjö Date: 2020-06-24T23:49:33+03:00 New Revision: 0cd9e598291df8c633aaa0c0e1d8eeab95de9680 URL: https://github.com/llvm/llvm-project/commit/0cd9e598291df8c633aaa0c0e1d8eeab95de9680 DIFF:

[Lldb-commits] [lldb] 2010444 - [Apple Silicon] Handle macOS in PlatformDarwin

Author: Davide Italiano Date: 2020-06-24T16:35:36-07:00 New Revision: 2010444e5e5f2a310334e98d7a65667ed78d23ab URL: https://github.com/llvm/llvm-project/commit/2010444e5e5f2a310334e98d7a65667ed78d23ab DIFF:

[Lldb-commits] [PATCH] D82507: [lldb/Docs] Add more details to the issues with custom Python installs on macOS

JDevlieghere created this revision. JDevlieghere added a reviewer: friss. Repository: rLLDB LLDB https://reviews.llvm.org/D82507 Files: lldb/docs/resources/caveats.rst Index: lldb/docs/resources/caveats.rst === ---

[Lldb-commits] [lldb] 06412da - [lldb] Use std::make_unique<> (NFC)

Author: Jonas Devlieghere Date: 2020-06-24T17:48:40-07:00 New Revision: 06412dae82376c12bc64b944e6d21141313b5cf1 URL: https://github.com/llvm/llvm-project/commit/06412dae82376c12bc64b944e6d21141313b5cf1 DIFF:

[Lldb-commits] [lldb] 1c0bbe4 - [lldb/API] Use std::make_unique<> (NFC)

Author: Jonas Devlieghere Date: 2020-06-24T16:29:30-07:00 New Revision: 1c0bbe4341ac0ffbaf2e1f482239b45166607f2d URL: https://github.com/llvm/llvm-project/commit/1c0bbe4341ac0ffbaf2e1f482239b45166607f2d DIFF:

[Lldb-commits] [PATCH] D82505: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 273189. aelitashen added a comment. Formatting the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82505/new/ https://reviews.llvm.org/D82505 Files: clang/tools/clang-format/git-clang-format

[Lldb-commits] [PATCH] D82505: [lldb-vscode] Add Support for Module Event

clayborg added a comment. This seems like a continuation of https://reviews.llvm.org/D82477. I would close this one down by selecting abandon revision, and then click the "update diff" button in D82477 and upload your new patch. I am guessing you did this

[Lldb-commits] [lldb] 47ac453 - [HostInfoMacOS] Parse correctly the triple for Apple Silicon.

Author: Davide Italiano Date: 2020-06-24T16:37:21-07:00 New Revision: 47ac45332e25c89d0ced5108c667fe92cf0f509a URL: https://github.com/llvm/llvm-project/commit/47ac45332e25c89d0ced5108c667fe92cf0f509a DIFF:

[Lldb-commits] [PATCH] D82505: [lldb-vscode] Add Support for Module Event

aelitashen created this revision. aelitashen added reviewers: wallace, clayborg. aelitashen added a project: LLDB. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make lldb-vscode receive and process module events so that modules can be rendered in the IDE. Repository:

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3444 +size_t bufsize = sizeof(processInfo); +if (sysctl(mib, (unsigned)(sizeof(mib)/sizeof(int)), , + , NULL, 0) == 0 && bufsize > 0) {

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

jankratochvil added a comment. Just some notes of mine to find out which functions get used in which breakpoint case: -o 'breakpoint set -f main.c -l 1' -o q -o 'b main.c:1' lldb/source/Commands/CommandObjectBreakpoint.cpp:578 = eSetTypeFileAndLine lldb/source/Target/Target.cpp:330