[Lldb-commits] [PATCH] D84402: [lldb/DWARF] Add more line table validation

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1044 for (const llvm::DWARFDebugLine::Sequence : line_table->Sequences) { +if (!list.ContainsFileAddressRange(seq.LowPC, seq.HighPC

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

tatyana-krasnukha added a comment. I went further than just moving m_hardware_index from StoppointLocation. Please, take a look at D84527 and let me know what you think about that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D84401: [lldb] Add SectionList::ContainsFileAddressRange

labath planned changes to this revision. labath added a comment. Waiting for the resolution of the discussion in the follow-up patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84401/new/ https://reviews.llvm.org/D84401

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 added a comment. Yes, I'm testing it on Mac. By the way, I checked its output on the error message. When the test failed, the characters, `buffer (last 100 chars) : ~~~`, are displayed as an error message. I thought it was pexpect's output, possibly it is not that output? CHANGES

[Lldb-commits] [PATCH] D84501: NativeThreadLinux invalidate register cache on stop

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yep, looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84501/new/ https://reviews.llvm.org/D84501 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

labath added a comment. In D81001#2170570 , @gedatsu217 wrote: > I checked what's the sequence that actually gets output, and it was like > below. > > h\x1b[2melp frame\x1b[0m\x1b[1Ghe\x1b[2mlp frame\x1b[0m\x1b[1Gel\x1b[2mp > frame\x1b[0m\x1b[1Gl > >

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

labath added a comment. In D81001#2171999 , @gedatsu217 wrote: > > That said, are you sure this is the right sequence? \x1b[1Gl seems like it > > should print the l at column one, which does not sound right... > > I thought it did not add up too, but

[Lldb-commits] [PATCH] D84501: NativeThreadLinux invalidate register cache on stop

omjavaid updated this revision to Diff 280374. omjavaid added a comment. Corrected a typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84501/new/ https://reviews.llvm.org/D84501 Files: lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp Index:

[Lldb-commits] [PATCH] D84528: [lldb][NFC] Use a StringRef for AddRegexCommand::AddRegexCommand parameters

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added a subscriber: JDevlieghere. This way we can get rid of this 1024 char buffer workaround. Repository: rLLDB LLDB https://reviews.llvm.org/D84528 Files: lldb/include/lldb/Interpreter/CommandObjectRegexCommand.h

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

tatyana-krasnukha updated this revision to Diff 280448. tatyana-krasnukha added a comment. @omjavaid, thank you for verifying this! Added the checks that IsHardware is consistent with m_hardware_index. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D84501: NativeThreadLinux invalidate register cache on stop

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a reviewer: rengolin. In our discussion D79699 SVE ptrace register access support we decide to invalidate register context cached data on every stop instead of doing at before

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 added a comment. > That said, are you sure this is the right sequence? \x1b[1Gl seems like it > should print the l at column one, which does not sound right... I thought it did not add up too, but pexpect probably actually outputs these characters. > The sequence I got in this test

[Lldb-commits] [PATCH] D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation

tatyana-krasnukha created this revision. Herald added subscribers: lldb-commits, yaxunl, mgorny. Herald added a project: LLDB. Working on the patch D84257 I noticed that both BreakpointLocation and BreakpointSite were inherited from StoppointLocation. Also, I

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 280373. omjavaid added a comment. In this update I have moved ConfigureRegisterContext insider InvalidateAllRegisters in light of D84501 where we move InvalidateAllRegisters on every stop rather than doing so before

[Lldb-commits] [PATCH] D84475: [lldb] Inform every language runtime of the modified modules

teemperor added a comment. (Mea culpa, I thought the Swift recognizers would be as trivial to fix as the upstream ones) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84475/new/ https://reviews.llvm.org/D84475 ___

[Lldb-commits] [PATCH] D84530: [lldb] Modernize away some snprintf calls

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added a subscriber: JDevlieghere. Repository: rLLDB LLDB https://reviews.llvm.org/D84530 Files: lldb/source/Commands/CommandObjectProcess.cpp lldb/source/Core/Communication.cpp lldb/source/Core/Debugger.cpp

[Lldb-commits] [PATCH] D84537: [lldb/AppleSimulator] Always provide a -simulator environment

aprantl added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp:270 +static const ArchSpec platform_arch( +HostInfo::GetArchitecture(HostInfo::eArchKind64)); +arch = platform_arch; I guess I should really

[Lldb-commits] [PATCH] D84537: [lldb/AppleSimulator] Always provide a -simulator environment

aprantl added inline comments. Comment at: lldb/unittests/Platform/PlatformAppleSimulatorTest.cpp:72 + } +} + Does this explicitly test that platform[0] == HostInfo::GetArchitecture()? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D84475: [lldb] Inform every language runtime of the modified modules

clayborg accepted this revision. clayborg added a comment. LGTM with a few nits that can be fixed if needed Comment at: lldb/source/Target/Process.cpp:5762-5764 if (sys_runtime) { sys_runtime->ModulesDidLoad(module_list); } remove braces?

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d09ecf36175: [CMake] Simplify CMake handling for zlib (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 added a comment. I do not intend for this feature to work with colors disabled. I found that pexpect output the below sequence, and this passed the test. self.child.expect_exact("\x1b[" + str(len("(lldb) he") + 1) + "G" + "l" + "\x1b[2m" + "p frame" + "\x1b[0m\x1b[1G" + "l" +

[Lldb-commits] [lldb] 58d84eb - debugserver: Support ios simulator load command disambiguation in qProcessInfo

Author: Adrian Prantl Date: 2020-07-24T09:49:16-07:00 New Revision: 58d84eb534252747115b358c890a1b79c65d4ad4 URL: https://github.com/llvm/llvm-project/commit/58d84eb534252747115b358c890a1b79c65d4ad4 DIFF: https://github.com/llvm/llvm-project/commit/58d84eb534252747115b358c890a1b79c65d4ad4.diff

[Lldb-commits] [PATCH] D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation

JDevlieghere added a comment. Some nits but overall this looks good. Comment at: lldb/include/lldb/Breakpoint/Breakpoint.h:657 bool m_resolve_indirect_symbols; - uint32_t m_hit_count; // Number of times this breakpoint/watchpoint has been -// hit.

[Lldb-commits] [PATCH] D84537: [lldb/AppleSimulator] Always provide a -simulator environment

friss created this revision. friss added a reviewer: aprantl. Herald added a subscriber: mgorny. Herald added a project: LLDB. This commit is somewhat NFC-ish today as the environment of triples is not considered when comparing s if one of them is not set (I plan to change that). We have made

[Lldb-commits] [PATCH] D84402: [lldb/DWARF] Add more line table validation

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1044 for (const llvm::DWARFDebugLine::Sequence : line_table->Sequences) { +if (!list.ContainsFileAddressRange(seq.LowPC, seq.HighPC - seq.LowPC)) + continue;

[Lldb-commits] [lldb] 22c1636 - [lldb/ObjectFileMachO] Correctly account for resolver symbols

Author: Fred Riss Date: 2020-07-24T09:19:17-07:00 New Revision: 22c16360dd00230987fee5f6f3c57f8071144cc1 URL: https://github.com/llvm/llvm-project/commit/22c16360dd00230987fee5f6f3c57f8071144cc1 DIFF: https://github.com/llvm/llvm-project/commit/22c16360dd00230987fee5f6f3c57f8071144cc1.diff

[Lldb-commits] [PATCH] D84475: [lldb] Inform every language runtime of the modified modules

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84475/new/ https://reviews.llvm.org/D84475 ___

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

labath added a comment. In D81001#2172035 , @labath wrote: > In D81001#2171999 , @gedatsu217 > wrote: > > > > That said, are you sure this is the right sequence? \x1b[1Gl seems like > > > it should print the l at

[Lldb-commits] [PATCH] D84480: debugserver: Support ios simulator load command disambiguation in qProcessInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG58d84eb53425: debugserver: Support ios simulator load command disambiguation in qProcessInfo (authored by aprantl). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D84530: [lldb] Modernize away some snprintf calls

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84530/new/ https://reviews.llvm.org/D84530 ___

Re: [Lldb-commits] [lldb] 0d5fc82 - [lldb] Eliminate unneeded value parameters in Utility (NFC)

Honestly, a sentence in the class Doxygen comment that this is supposed to be passed by value works just as well :-) -- adrian > On Jul 24, 2020, at 12:31 AM, Raphael “Teemperor” Isemann > wrote: > > We could make a custom attribute for types that should be always passed by > value and then

[Lldb-commits] [PATCH] D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation

jingham added a comment. This overall change makes sense to me. It seems a little awkward that Target has to know that Watchpoints have a m_hit_counter. It's also a little weird that we're clearing watchpoint hit counts when a process dies, but not breakpoint hit counts. If we do one we

[Lldb-commits] [lldb] 0db2934 - [ASTImporter] Modify ImportDefiniton for ObjCInterfaceDecl so that we always the ImportDeclContext one we start the definition

Author: shafik Date: 2020-07-24T13:15:08-07:00 New Revision: 0db2934b0fa9e00ac98e2cb168adba96f6bcd0da URL: https://github.com/llvm/llvm-project/commit/0db2934b0fa9e00ac98e2cb168adba96f6bcd0da DIFF: https://github.com/llvm/llvm-project/commit/0db2934b0fa9e00ac98e2cb168adba96f6bcd0da.diff LOG:

[Lldb-commits] [PATCH] D83972: Modify ImportDefiniton for ObjCInterfaceDecl so that we always the ImportDeclContext one we start the definition

This revision was automatically updated to reflect the committed changes. Closed by commit rG0db2934b0fa9: [ASTImporter] Modify ImportDefiniton for ObjCInterfaceDecl so that we always… (authored by shafik). Herald added projects: clang, LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 313b607 - Revert "Add Debug Info Size to Symbol Status"

Author: Walter Erquinigo Date: 2020-07-24T13:28:29-07:00 New Revision: 313b60742af1f567ef7d8e26eb5b1015a7b5c78f URL: https://github.com/llvm/llvm-project/commit/313b60742af1f567ef7d8e26eb5b1015a7b5c78f DIFF:

[Lldb-commits] [lldb] c86f56e - [CMake] Find zlib when building lldb as standalone

Author: Petr Hosek Date: 2020-07-24T13:36:13-07:00 New Revision: c86f56e32e724c6018e579bb2bc11e667c96fc96 URL: https://github.com/llvm/llvm-project/commit/c86f56e32e724c6018e579bb2bc11e667c96fc96 DIFF: https://github.com/llvm/llvm-project/commit/c86f56e32e724c6018e579bb2bc11e667c96fc96.diff

[Lldb-commits] [PATCH] D84272: Add checks for ValueObjectSP in Cocoa summary providers

teemperor accepted this revision. teemperor added a comment. I'm still not sure how this can happen or how this could be tested, but this patch seems reasonable. Also it seems we usually do nullptr checks on GetSyntheticChildAtOffset results, so at least it would be consistent if we do it here

[Lldb-commits] [PATCH] D84555: [lldb-vscode ]Add Syntax Highlighting to Disassembly View

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. can you include a screenshot of how the view looked before (without the colors)? Also explain that this is done via a mime-type identification and a built-in support in the IDE

[Lldb-commits] [PATCH] D84475: [lldb] Inform every language runtime of the modified modules

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b339c069266: [lldb] Inform every language runtime of the modified modules (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 986e3af - Add Debug Info Size to Symbol Status

Author: Yifan Shen Date: 2020-07-24T13:26:06-07:00 New Revision: 986e3af53bfe591e88a1ae4f82ea1cc0a15819a3 URL: https://github.com/llvm/llvm-project/commit/986e3af53bfe591e88a1ae4f82ea1cc0a15819a3 DIFF: https://github.com/llvm/llvm-project/commit/986e3af53bfe591e88a1ae4f82ea1cc0a15819a3.diff

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

This revision was automatically updated to reflect the committed changes. Closed by commit rG986e3af53bfe: Add Debug Info Size to Symbol Status (authored by aelitashen, committed by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D84555: [lldb-vscode ]Add Syntax Highlighting to Disassembly View

aelitashen updated this revision to Diff 280596. aelitashen added a comment. Use unique id for disassembly.json Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84555/new/ https://reviews.llvm.org/D84555 Files:

[Lldb-commits] [PATCH] D84555: [lldb-vscode ]Add Syntax Highlighting to Disassembly View

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Very good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84555/new/ https://reviews.llvm.org/D84555

[Lldb-commits] [PATCH] D84537: [lldb/AppleSimulator] Always provide a -simulator environment

friss updated this revision to Diff 280604. friss added a comment. Simplify the logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84537/new/ https://reviews.llvm.org/D84537 Files:

[Lldb-commits] [lldb] 34d4c8a - [lldb] Have LanguageRuntime and SystemRuntime share a base class (NFC)

Author: Jonas Devlieghere Date: 2020-07-24T16:28:34-07:00 New Revision: 34d4c8a53e569b1b83a0672015a19f8ca9bb3c35 URL: https://github.com/llvm/llvm-project/commit/34d4c8a53e569b1b83a0672015a19f8ca9bb3c35 DIFF:

[Lldb-commits] [lldb] 9999621 - [lldb] Don't wrap and release raw pointer in unique_ptr (NFC)

Author: Jonas Devlieghere Date: 2020-07-24T16:28:34-07:00 New Revision: 6213ebd9655bb0488387f906d5438bcd37f8 URL: https://github.com/llvm/llvm-project/commit/6213ebd9655bb0488387f906d5438bcd37f8 DIFF:

[Lldb-commits] [lldb] 0b339c0 - [lldb] Inform every language runtime of the modified modules

Author: Jonas Devlieghere Date: 2020-07-24T12:10:45-07:00 New Revision: 0b339c069266b7a4f3c82f80067d74620cbe19c4 URL: https://github.com/llvm/llvm-project/commit/0b339c069266b7a4f3c82f80067d74620cbe19c4 DIFF:

[Lldb-commits] [lldb] 2c1bea8 - Add Debug Info Size to Symbol Status

Author: Yifan Shen Date: 2020-07-24T13:30:04-07:00 New Revision: 2c1bea88a5f8334015455aae8b842fdd87f7e34a URL: https://github.com/llvm/llvm-project/commit/2c1bea88a5f8334015455aae8b842fdd87f7e34a DIFF: https://github.com/llvm/llvm-project/commit/2c1bea88a5f8334015455aae8b842fdd87f7e34a.diff

[Lldb-commits] [PATCH] D84537: [lldb/AppleSimulator] Always provide a -simulator environment

friss marked 4 inline comments as done. friss added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp:270 +static const ArchSpec platform_arch( +HostInfo::GetArchitecture(HostInfo::eArchKind64)); +arch = platform_arch;

[Lldb-commits] [PATCH] D84555: Add Syntax Highlighting to Disassembly View

aelitashen created this revision. aelitashen added reviewers: wallace, clayborg. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. When lldb cannot find source file thus IDE renders a disassembly view, add syntax highlighting for constants, registers and

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

MaskRay added a comment. What is the state of the patch? Does lldb support cgdb-style u/d/f/b etc now? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68541/new/ https://reviews.llvm.org/D68541 ___ lldb-commits

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

vsk added a comment. @phosek I suspect this is causing a cmake error on the lldb standalone bot, would you mind taking a look? http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake-standalone/1858/ CMake Error at

Re: [Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

Thanks, that addressed the issue. > On Jul 24, 2020, at 1:41 PM, Petr Hosek wrote: > > Thanks for the heads up, this should be addressed by > c86f56e32e724c6018e579bb2bc11e667c96fc96, let me know if there are other > issues. > > On Fri, Jul 24, 2020 at 12:33 PM Vedant Kumar via Phabricator

Re: [Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

Thanks for the heads up, this should be addressed by c86f56e32e724c6018e579bb2bc11e667c96fc96, let me know if there are other issues. On Fri, Jul 24, 2020 at 12:33 PM Vedant Kumar via Phabricator < revi...@reviews.llvm.org> wrote: > vsk added a comment. > > @phosek I suspect this is causing a

[Lldb-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

logan-5 added a comment. In D84126#2171469 , @labath wrote: > Instead of adding -Wno-suggest-override to every user it might be cleaner to > add the flag to the INTERFACE_COMPILE_OPTIONS property of the relevant > targets (gtest, gmock, and gbenchmark

[Lldb-commits] [lldb] e937840 - Upstream macCatalyst support in ArchSpec and associated unit tests.

Author: Adrian Prantl Date: 2020-07-24T18:01:41-07:00 New Revision: e937840dbdce20f2ab7ca4dcd9f04c3fd89e56e3 URL: https://github.com/llvm/llvm-project/commit/e937840dbdce20f2ab7ca4dcd9f04c3fd89e56e3 DIFF: https://github.com/llvm/llvm-project/commit/e937840dbdce20f2ab7ca4dcd9f04c3fd89e56e3.diff

[Lldb-commits] [PATCH] D84401: [lldb] Add SectionList::ContainsFileAddressRange

MaskRay added inline comments. Comment at: lldb/source/Core/Section.cpp:570 + while (file_addr < end) { +SectionSP sect_sp = FindSectionContainingFileAddress(file_addr); +if (!sect_sp) I am a bit concerned about the potential large time complexity

[Lldb-commits] [PATCH] D84537: [lldb/AppleSimulator] Always provide a -simulator environment

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This looks much cleaner! Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.cpp:155 + "x86_64-apple-tvos-simulator", +

[Lldb-commits] [PATCH] D84576: Fix debugserver's qProcessInfo reporting of maccatalyst binaries

aprantl created this revision. aprantl added reviewers: friss, jasonmolenda. This patch is similar in spirit to https://reviews.llvm.org/D84480, but does the maccatalyst/macosx disambiguation. I also took the opportunity to factor out the gdb-remote packet log scanning used by several testcases

[Lldb-commits] [PATCH] D84402: [lldb/DWARF] Add more line table validation

MaskRay added a comment. For ELF, there are non-pic cases (i.e. -no-pie) and pic cases (-pie or -shared). I think it is sufficient just testing -pie (image base is zero). If filtering for -pie works, filter for -no-pie or -shared should work as well. Comment at:

[Lldb-commits] [PATCH] D84506: [tools] Add paranthesese for print in Python

galou created this revision. Herald added a reviewer: bollu. Herald added subscribers: llvm-commits, openmp-commits, lldb-commits, Sanitizers, cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added projects: clang, Sanitizers, LLDB, OpenMP, LLVM. Add paranthesese for print in Python

[Lldb-commits] [PATCH] D84506: [tools] Add paranthesese for print in Python

galou added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Add parentheses for print in Python (all Python files where the print statement was used). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84506/new/

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

This revision was automatically updated to reflect the committed changes. Closed by commit rG10b1b4a231a4: [CMake] Simplify CMake handling for zlib (authored by phosek). Herald added subscribers: msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, lucyrfox,

[Lldb-commits] [PATCH] D84506: [tools] Add paranthesese for print in Python

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Seems NFC and towards the right syntax, thx :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84506/new/

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 280305. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/CMakeLists.txt clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in

[Lldb-commits] [PATCH] D84083: [lldb/ObjectFileMachO] Correctly account for resolver symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rG22c16360dd00: [lldb/ObjectFileMachO] Correctly account for resolver symbols (authored by friss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84083/new/

[Lldb-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

labath added a comment. Instead of adding -Wno-suggest-override to every user it might be cleaner to add the flag to the INTERFACE_COMPILE_OPTIONS property of the relevant targets (gtest, gmock, and gbenchmark ?). That way, anything which links against these will inherit it automatically.

[Lldb-commits] [lldb] 10b1b4a - [CMake] Simplify CMake handling for zlib

Author: Petr Hosek Date: 2020-07-23T23:05:36-07:00 New Revision: 10b1b4a231a485f1711d576e6131f6755e008abe URL: https://github.com/llvm/llvm-project/commit/10b1b4a231a485f1711d576e6131f6755e008abe DIFF: https://github.com/llvm/llvm-project/commit/10b1b4a231a485f1711d576e6131f6755e008abe.diff

Re: [Lldb-commits] [lldb] 0d5fc82 - [lldb] Eliminate unneeded value parameters in Utility (NFC)

We could make a custom attribute for types that should be always passed by value and then maybe have Clang handle that. The problem seems generic enough that maybe other people could find this useful. - Raphael > On 24 Jul 2020, at 09:27, Pavel Labath via lldb-commits > wrote: > > On

Re: [Lldb-commits] [lldb] 0d5fc82 - [lldb] Eliminate unneeded value parameters in Utility (NFC)

On 23/07/2020 18:24, Adrian Prantl wrote: > Is there some clever C++ way to prohibit taking an object's address (similar > to how you can delete a copy constructor)? > > -- adrian You could =delete the address-of operator, but redefining unary & is generally frowned upon and I am not sure it

[Lldb-commits] [PATCH] D83972: Modify ImportDefiniton for ObjCInterfaceDecl so that we always the ImportDeclContext one we start the definition

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. > Unlike RecordDecl case which uses DefinitionCompleter to force > completeDefinition we don't seem to have a similar mechanism for > ObjCInterfaceDecl. It is unfortunate that the AST does