[Lldb-commits] [PATCH] D91801: [lldb] Fix incorrect error handling in GDBRemoteCommunicationClient::SendGetSupportedTraceType

This revision was automatically updated to reflect the committed changes. Closed by commit rG47b7138b484b: [lldb] Fix incorrect error handling in GDBRemoteCommunicationClient… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [lldb] 47b7138 - [lldb] Fix incorrect error handling in GDBRemoteCommunicationClient::SendGetSupportedTraceType

Author: Raphael Isemann Date: 2020-11-19T19:14:04+01:00 New Revision: 47b7138b484b8fc94633ac4750a11acad797473e URL: https://github.com/llvm/llvm-project/commit/47b7138b484b8fc94633ac4750a11acad797473e DIFF:

[Lldb-commits] [PATCH] D87173: Ignores functions that have a range starting outside of a code section

aadsm added a comment. When I landed this I got test errors on the windows machine (the same tests pass on the other machine). I tried to repro this on 2 different machines I was able to get access but to no avail. These are the failing tests: http://lab.llvm.org:8011/#/builders/83/builds/644

[Lldb-commits] [PATCH] D91810: [lldb] [Process/FreeBSD] Fix 'process connect' plugin choice

emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. Looks ok to me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91810/new/ https://reviews.llvm.org/D91810 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D91801: [lldb] Fix incorrect error handling in GDBRemoteCommunicationClient::SendGetSupportedTraceType

teemperor added a comment. From what understand this is Linux exclusive feature at the moment, and the command test itself is testing the command but missing the edge case of testing this against a running process. Not sure if it's worth starting a process just to test that the command still

[Lldb-commits] [lldb] c77aefb - [lldb] Fix another Python2/3 string<->bytes type error in patch-crashlog.py

Author: Raphael Isemann Date: 2020-11-19T19:24:40+01:00 New Revision: c77aefb0ff36277c97f52e22cec3ffcc5db43064 URL: https://github.com/llvm/llvm-project/commit/c77aefb0ff36277c97f52e22cec3ffcc5db43064 DIFF:

[Lldb-commits] [PATCH] D90857: [lldb] add a missing dependency on intrinsics_gen

rmaz added a comment. > I'd still like to hear an explanation on how is this patch relevant (in this > repository). Apologies, missed the last notification. > Judging by the error message, this dependency is not correct even in the > swift fork. lldbSymbol does not have a direct dependency on

[Lldb-commits] [PATCH] D91810: [lldb] [Process/FreeBSD] Fix 'process connect' plugin choice

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. Herald added a subscriber: arichardson. mgorny requested review of this revision. Fix ProcessFreeBSD::CanDebug() to indicate whether the legacy plugin is actually being used. This is necessary to prevent LLDB from

[Lldb-commits] [lldb] 0fd0433 - [LLDB] Fixing lldb/test/Shell/Register/x86-fp-write.test

Author: shafik Date: 2020-11-19T16:29:28-08:00 New Revision: 0fd04337a17138174adf9e6d408cf9c885dea086 URL: https://github.com/llvm/llvm-project/commit/0fd04337a17138174adf9e6d408cf9c885dea086 DIFF: https://github.com/llvm/llvm-project/commit/0fd04337a17138174adf9e6d408cf9c885dea086.diff LOG:

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

rupprecht added a comment. I ran manual tests for this, but I did so by introducing an intentional crash in a place that obviously can't be checked in. Does LLDB have any kind of intentional-crash-for-test mechanism that could be used for a test? Also, I picked `SBDebugger` for this as it

[Lldb-commits] [PATCH] D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64

shafik added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/test/Shell/Register/x86-fp-write.test:2 # XFAIL: system-windows -# REQUIRES: native && target-x86 +# REQUIRES: native && (target-x86 || target-x86_64) # RUN: %clangxx_host

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

rupprecht created this revision. rupprecht added reviewers: teemperor, JDevlieghere, labath, vsk. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. As noticed in D87637 , when LLDB crashes, we only

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

labath added a comment. Well... I think that will make the test fail on mac, as debugserver hasn't been updated. This test comes from D12592 , and is actually serves a very similar purpose to the test you just wrote. Normally, I would say we don't need both of

[Lldb-commits] [PATCH] D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64

labath accepted this revision. labath added a subscriber: omjavaid. labath added a comment. This revision is now accepted and ready to land. Looks good to me. @omjavaid, could you take a quick look at the invalidate/contained register lists? Comment at:

[Lldb-commits] [PATCH] D91728: [lldb] [Process/Utility] Declare register overlaps between ST and MM [WIP]

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfos_x86_64.h:93 { \ #reg #i, nullptr, sizeof(uint64_t), \

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

labath added a comment. Looks good. Some minor questions inline. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:523 + case DBRegSet: { +uint8_t *data = GetOffsetRegSetData(set, reg_info->byte_offset); +FXSAVE *fpr =

[Lldb-commits] [PATCH] D91728: [lldb] [Process/Utility] Declare register overlaps between ST and MM [WIP]

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I don't know omitting this had any practical effects (my experiments with rax were... inconclusive) , but it definitely sounds like the right to do. Comment at:

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

labath added a comment. Continuing the discussion from the inline comment: > Lua can be compiled to use try/catch instead of longjmp, but that is an > exception (no pun intended). Since we rely on the host's library, we need to > assume that it's using longjmp. Right. In fact even if it had

[Lldb-commits] [PATCH] D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64

omjavaid added a comment. In D91497#2404813 , @labath wrote: > Looks good to me. @omjavaid, could you take a quick look at the > invalidate/contained register lists? These list look good. Also I like the approach of using single invalidate list for

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

mgorny updated this revision to Diff 306356. mgorny marked an inline comment as done. mgorny added a comment. Simplified FreeBSD & Linux code as @labath suggested. Also added the scope thingy to tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91504/new/

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

mgorny updated this revision to Diff 306360. mgorny added a comment. Declare `MMSRegComp` type explicitly to avoid warnings: In file included from /home/mgorny/llvm-project/llvm/tools/lldb/source/Plugins/Process/Utility/RegisterContextLinux_x86_64.cpp:11: In file included from

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. ship it CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91504/new/ https://reviews.llvm.org/D91504 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

omjavaid added a comment. In D91241#2402491 , @labath wrote: > Yes, this is pretty much what I hoped for. Thanks. > > Besides relaxing existing tests, it would be nice to have a positive test > that checks for the behavior that we want. Maybe a

[Lldb-commits] [PATCH] D91728: [lldb] [Process/Utility] Declare register overlaps between ST and MM [WIP]

mgorny updated this revision to Diff 306363. mgorny added a comment. Updated to cover i386, reformatted the macro. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91728/new/ https://reviews.llvm.org/D91728 Files: lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_x86.cpp

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

mgorny marked 4 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:537 +uint16_t sw = m_xstate->fxsave.fstat; +llvm::ArrayRef st_regs{m_xstate->fxsave.stmm, 8}; +

[Lldb-commits] [PATCH] D87442: [lldb][AArch64/Linux] Show memory tagged memory regions

labath added a comment. Hopefully last round of cosmetic fixes, and then this should be good. Comment at: lldb/include/lldb/Target/MemoryRegionInfo.h:15 #include "lldb/Utility/RangeMap.h" +#include "llvm/ADT/StringRef.h" #include "llvm/Support/FormatProviders.h"

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

This revision was automatically updated to reflect the committed changes. Closed by commit rGc43abf043692: [lldb] Use translated full ftag values (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8ff269f6776: [lldb] Add explicit 64-bit fip/fdp registers on x86_64 (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D91497?vs=306160=306369#toc

[Lldb-commits] [lldb] d8ff269 - [lldb] Add explicit 64-bit fip/fdp registers on x86_64

Author: Michał Górny Date: 2020-11-19T13:23:12+01:00 New Revision: d8ff269f677621a773d75c79d50bb3f59a6b052e URL: https://github.com/llvm/llvm-project/commit/d8ff269f677621a773d75c79d50bb3f59a6b052e DIFF: https://github.com/llvm/llvm-project/commit/d8ff269f677621a773d75c79d50bb3f59a6b052e.diff

[Lldb-commits] [lldb] c43abf0 - [lldb] Use translated full ftag values

Author: Michał Górny Date: 2020-11-19T13:23:12+01:00 New Revision: c43abf043692babf9ad4f8bded2fdf6ab9c354b0 URL: https://github.com/llvm/llvm-project/commit/c43abf043692babf9ad4f8bded2fdf6ab9c354b0 DIFF: https://github.com/llvm/llvm-project/commit/c43abf043692babf9ad4f8bded2fdf6ab9c354b0.diff

[Lldb-commits] [PATCH] D90857: [lldb] add a missing dependency on intrinsics_gen

labath added a comment. Ping! I'd still like to hear an explanation on how is this patch relevant (in this repository). Per our code review policy , the responsibility for a patch does not end the moment the patch is committed : Post-commit review is

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

goncharov added a comment. Herald added a subscriber: JDevlieghere. Hi @mgorny! http://lab.llvm.org:8011/#/builders/68/builds/2298 build failed. Could you please fix the test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91504/new/

[Lldb-commits] [lldb] 193a9b3 - Revert "[lldb] Use translated full ftag values"

Author: Mikhail Goncharov Date: 2020-11-19T15:24:59+01:00 New Revision: 193a9b374e24d31b30095f2789f1994bc0c7b663 URL: https://github.com/llvm/llvm-project/commit/193a9b374e24d31b30095f2789f1994bc0c7b663 DIFF:

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

mgorny added a comment. In D91504#2405504 , @goncharov wrote: > Hi @mgorny! http://lab.llvm.org:8011/#/builders/68/builds/2298 build failed. > Could you please fix the test? I'm sorry about that. I'll look into it. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

mgorny reopened this revision. mgorny added a comment. This revision is now accepted and ready to land. Does this change to TestRegister.py look good? It makes the test pass for me (and seems logically correct). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91504/new/

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

mgorny updated this revision to Diff 306403. mgorny added a comment. Update TestRegisters.py. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91504/new/ https://reviews.llvm.org/D91504 Files: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp

[Lldb-commits] [PATCH] D87442: [lldb][AArch64/Linux] Show memory tagged memory regions

DavidSpickett updated this revision to Diff 306406. DavidSpickett added a comment. - Use assertIn - Cleanup Status/Error handling - Refactor test so it runs once and we skip based on whether it returns a value or hits a breakpoint. - Seperated exit codes for non MTE toolchain and non MTE target,

[Lldb-commits] [lldb] a703998 - [lldb] Remove legacy casts from TestStackFromStdModule

Author: Raphael Isemann Date: 2020-11-19T17:07:12+01:00 New Revision: a703998e66f7500442e8f55bfcddf4a5820ca023 URL: https://github.com/llvm/llvm-project/commit/a703998e66f7500442e8f55bfcddf4a5820ca023 DIFF:

[Lldb-commits] [lldb] b7a09de - [lldb][NFC] Add a FIXME for ClangASTSource::FindExternalLexicalDecls's unused 'decls' parameter

Author: Raphael Isemann Date: 2020-11-19T17:15:14+01:00 New Revision: b7a09de10ffc59dec78a7d4b39bc78d07d3110eb URL: https://github.com/llvm/llvm-project/commit/b7a09de10ffc59dec78a7d4b39bc78d07d3110eb DIFF: