[Lldb-commits] [lldb] 626681b - [lldb] Fix two documentation typos

Author: Raphael Isemann Date: 2021-01-19T15:25:15+01:00 New Revision: 626681b09a3e87cfeda54a3cd00f7b0ed9df3bcc URL: https://github.com/llvm/llvm-project/commit/626681b09a3e87cfeda54a3cd00f7b0ed9df3bcc DIFF:

[Lldb-commits] [lldb] 480643a - [CMake] Remove dead code setting policies to NEW

Author: Raul Tambre Date: 2021-01-19T17:19:36+02:00 New Revision: 480643a95cd157e654f4f97e8231b18850e7d79a URL: https://github.com/llvm/llvm-project/commit/480643a95cd157e654f4f97e8231b18850e7d79a DIFF: https://github.com/llvm/llvm-project/commit/480643a95cd157e654f4f97e8231b18850e7d79a.diff

[Lldb-commits] [PATCH] D94917: [lldb] Fix crash in "help memory read"

teemperor added a comment. From what I understand this means D91378 is no longer necessary. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94917/new/ https://reviews.llvm.org/D94917

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

MaskRay updated this revision to Diff 317599. MaskRay added a comment. Delete `if os.path.isdir("/usr/include/c++/v1"):` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94888/new/ https://reviews.llvm.org/D94888 Files:

[Lldb-commits] [PATCH] D94937: [lldb] change SBStructuredData GetStringValue signature

tammela added a comment. In D94937#2505676 , @JDevlieghere wrote: > We guarantee that the SB API is ABI stable so you cannot change the signature > of existing functions. Would an overload do the trick? If overloaded with `const char

[Lldb-commits] [lldb] 3cae8b3 - [lldb][docs] Add a doc page for enums and constants

Author: Raphael Isemann Date: 2021-01-19T18:54:05+01:00 New Revision: 3cae8b33297b14449514a87dcaa8996ba40db412 URL: https://github.com/llvm/llvm-project/commit/3cae8b33297b14449514a87dcaa8996ba40db412 DIFF:

[Lldb-commits] [PATCH] D94959: [lldb][docs] Add a doc page for enums and constants

This revision was automatically updated to reflect the committed changes. Closed by commit rG3cae8b33297b: [lldb][docs] Add a doc page for enums and constants (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D94900: [lldb][docs] Update .htaccess to redirect from old SB API documentation to new one

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f8099509030: [lldb][docs] Update .htaccess to redirect from old SB API documentation to new… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [lldb] 2f80995 - [lldb][docs] Update .htaccess to redirect from old SB API documentation to new one

Author: Raphael Isemann Date: 2021-01-19T18:58:43+01:00 New Revision: 2f8099509030d3352ac211b1fbae4c6c32b0bfa7 URL: https://github.com/llvm/llvm-project/commit/2f8099509030d3352ac211b1fbae4c6c32b0bfa7 DIFF:

Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

> On Jan 17, 2021, at 10:47 AM, David Blaikie wrote: > > On Fri, Jan 15, 2021 at 6:22 PM Jim Ingham wrote: >> >> If you set a breakpoint on source lines with no line table entries, lldb >> slides the actual match forward to the nearest line table entry to the given >> line number. That's

Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

On Tue, Jan 19, 2021 at 10:17 AM Jim Ingham wrote: > > > > > On Jan 17, 2021, at 10:47 AM, David Blaikie wrote: > > > > On Fri, Jan 15, 2021 at 6:22 PM Jim Ingham wrote: > >> > >> If you set a breakpoint on source lines with no line table entries, lldb > >> slides the actual match forward to

Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

On Tue, Jan 19, 2021 at 2:55 PM Jim Ingham wrote: > > > > > On Jan 19, 2021, at 11:40 AM, David Blaikie wrote: > > > > On Tue, Jan 19, 2021 at 10:17 AM Jim Ingham wrote: > >> > >> > >> > >>> On Jan 17, 2021, at 10:47 AM, David Blaikie wrote: > >>> > >>> On Fri, Jan 15, 2021 at 6:22 PM Jim

[Lldb-commits] [lldb] 3471455 - [lldb/test] Skip TestProcessAttach: test_attach_to_process_from_different_dir_by_id on Windows

Author: Stella Stamenova Date: 2021-01-19T14:09:09-08:00 New Revision: 347145538443347e705aaf1fb1473a5dcc5698e6 URL: https://github.com/llvm/llvm-project/commit/347145538443347e705aaf1fb1473a5dcc5698e6 DIFF:

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

JDevlieghere added a comment. In D94890#2507241 , @MaskRay wrote: > In D94890#2505988 , @labath wrote: > >> Looks like a nice cleanup. The only part I am not sure of is the part about >> removing `$(RM)

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

clayborg added a comment. Another solution would be to not auto create a target if the "program" argument is missing from the launch config and document this in the "attachCommands" or "launchCommands"? Or is "program" a required launch config argument? Repository: rG LLVM Github Monorepo

Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

> On Jan 19, 2021, at 3:34 PM, David Blaikie wrote: > > On Tue, Jan 19, 2021 at 2:55 PM Jim Ingham wrote: >> >> >> >>> On Jan 19, 2021, at 11:40 AM, David Blaikie wrote: >>> >>> On Tue, Jan 19, 2021 at 10:17 AM Jim Ingham wrote: > On Jan 17, 2021, at 10:47 AM,

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

serhiy.redko created this revision. serhiy.redko requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. launch.json's fields have ambiguity with how final target is created:  1. There are dedicated fields to specify target like "program", "pid",

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

MaskRay added a comment. In D94890#2507856 , @JDevlieghere wrote: > In D94890#2507241 , @MaskRay wrote: > >> In D94890#2505988 , @labath wrote: >> >>> Looks like a nice

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

JDevlieghere added a comment. In D94890#2507875 , @MaskRay wrote: > " (+ one additional test in the Swift fork)" --- Sounds like this can be a > separate patch which should Swift folks a heads-up. I don't know how to test > Swift and probably someone

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We have iterated on this patch and talked about the ramifications prior to posting this public patch. I will start with a little history: I added "launchCommands" a long time

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

On Tue, Jan 19, 2021 at 1:12 AM Pavel Labath wrote: > > (sorry for inactivity -- I mostly tuned out of this discussion as I > couldn't keep up with its pace) No worries - sorry for the noise/thanks for taking the time! > On 08/01/2021 01:55, Jim Ingham via lldb-commits wrote: > > 3) However,

Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

> On Jan 19, 2021, at 11:40 AM, David Blaikie wrote: > > On Tue, Jan 19, 2021 at 10:17 AM Jim Ingham wrote: >> >> >> >>> On Jan 17, 2021, at 10:47 AM, David Blaikie wrote: >>> >>> On Fri, Jan 15, 2021 at 6:22 PM Jim Ingham wrote: If you set a breakpoint on source lines with

[Lldb-commits] [PATCH] D95008: Revert "Revert "Ignores functions that have a range starting outside of a code section""

aadsm created this revision. aadsm added a reviewer: stella.stamenova. Herald added a reviewer: shafik. aadsm requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. This reverts commit

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation and make restart

MaskRay added a comment. In D94890#2505988 , @labath wrote: > Looks like a nice cleanup. The only part I am not sure of is the part about > removing `$(RM) $(ARCHIVE_OBJECTS)`. Is that necessary? > I'm not sure why is that line there, but if I had to

Re: [Lldb-commits] [lldb] 079e664 - [lldb] Re-enable TestPlatformProcessConnect on macos

+Jordan Rupprecht Interesting, we were using this internally to point to an lldb-server to test. I've disabled some tests at the moment, but I'm not sure it isn't entirely useful functionality :) -eric On Tue, Jan 19, 2021 at 5:01 AM Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org>

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

(sorry for inactivity -- I mostly tuned out of this discussion as I couldn't keep up with its pace) On 08/01/2021 01:55, Jim Ingham via lldb-commits wrote: > 3) However, we try to push as many tests as possible all the way > through the compiler, since the lldb test suite is also one of the >

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

labath added a comment. In D94888#2506000 , @MaskRay wrote: > In D94888#2505992 , @labath wrote: > >> It looks like this is removing the ability to build libc++ tests with gcc >> (as it does not have the `-stdlib`

[Lldb-commits] [PATCH] D94917: [lldb] Fix crash in "help memory read"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9a7672ac4980: [lldb] Fix crash in help memory read (authored by DavidSpickett). Changed prior to commit:

[Lldb-commits] [lldb] 9a7672a - [lldb] Fix crash in "help memory read"

Author: David Spickett Date: 2021-01-19T09:54:17Z New Revision: 9a7672ac4980bca8829814e1e49e1c201a5bf9b6 URL: https://github.com/llvm/llvm-project/commit/9a7672ac4980bca8829814e1e49e1c201a5bf9b6 DIFF: https://github.com/llvm/llvm-project/commit/9a7672ac4980bca8829814e1e49e1c201a5bf9b6.diff

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

labath added a comment. It looks like this is removing the ability to build libc++ tests with gcc (as it does not have the `-stdlib` option). While having that ability would be nice, I don't believe there's anyone currently using that configuration, so it shouldn't stand in the way of other

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

labath added a comment. In D94888#2505698 , @dblaikie wrote: > Out of curiousity did you find a way to get lldb-test to print out the > stdout/stderr of the underlying lldb process to see what error messages it > was producing that demonstrated this

[Lldb-commits] [PATCH] D94888: [lldb] Add -Wl, -rpath to make tests run with fresh built libc++

MaskRay added a comment. In D94888#2505992 , @labath wrote: > It looks like this is removing the ability to build libc++ tests with gcc (as > it does not have the `-stdlib` option). While having that ability would be > nice, I don't believe there's

[Lldb-commits] [lldb] e448ad7 - [LLDB] Add support to resize SVE registers at run-time

Author: Muhammad Omair Javaid Date: 2021-01-19T15:01:32+05:00 New Revision: e448ad787e16119f8db8cc6999896e678a0356ac URL: https://github.com/llvm/llvm-project/commit/e448ad787e16119f8db8cc6999896e678a0356ac DIFF:

[Lldb-commits] [lldb] 4d30813 - [LLDB] Test SVE dynamic resize with multiple threads

Author: Muhammad Omair Javaid Date: 2021-01-19T15:01:32+05:00 New Revision: 4d3081331ad854e0bff5032c818ec6414fb974c0 URL: https://github.com/llvm/llvm-project/commit/4d3081331ad854e0bff5032c818ec6414fb974c0 DIFF:

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

This revision was automatically updated to reflect the committed changes. Closed by commit rGe448ad787e16: [LLDB] Add support to resize SVE registers at run-time (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D82866: [LLDB] Test SVE dynamic resize with multiple threads

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d3081331ad8: [LLDB] Test SVE dynamic resize with multiple threads (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 079e664 - [lldb] Re-enable TestPlatformProcessConnect on macos

Author: Pavel Labath Date: 2021-01-19T11:01:07+01:00 New Revision: 079e664661770a78e30c0d27a12d50047f1b1ea8 URL: https://github.com/llvm/llvm-project/commit/079e664661770a78e30c0d27a12d50047f1b1ea8 DIFF: https://github.com/llvm/llvm-project/commit/079e664661770a78e30c0d27a12d50047f1b1ea8.diff