Author: Fred Grim
Date: 2024-04-25T15:05:45-07:00
New Revision: a5c4f969f4f2f15a4150229eebff769521759554
URL:
https://github.com/llvm/llvm-project/commit/a5c4f969f4f2f15a4150229eebff769521759554
DIFF:
https://github.com/llvm/llvm-project/commit/a5c4f969f4f2f15a4150229eebff769521759554.diff
https://github.com/feg208 closed https://github.com/llvm/llvm-project/pull/89637
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
Jonas upstreamed recognition of DW_TAG_LLVM_ptrauth_type
https://reviews.llvm.org/D130215 but it isn't recognized as a type qualifier
tag in DWARFASTParserClang::ParseTypeFromDWARF.
---
Full diff:
@@ -568,10 +569,22 @@ class Debugger : public
std::enable_shared_from_this,
static void ReportSymbolChange(const ModuleSpec _spec);
- void
+ /// DEPRECATED. Use AddDestroyCallback and RemoveDestroyCallback instead.
+ /// Clear all previously added callbacks and only
@@ -1686,13 +1686,33 @@ void
SBDebugger::SetLoggingCallback(lldb::LogOutputCallback log_callback,
}
}
-void SBDebugger::SetDestroyCallback(
-lldb::SBDebuggerDestroyCallback destroy_callback, void *baton) {
+lldb::SBDebuggerDestroyCallbackToken
jimingham wrote:
> Hi @jimingham ,
>
> I have updated the code. Now we have `Add` and `Remove` (with tokens as you
> suggested). `Set` clears everything then add the given one (also returns a
> token).
>
> Thread-safety is done through a `std::lock_guard`. This
> is consistent with some of
https://github.com/JDevlieghere approved this pull request.
LGTM with the formatting and braces fixed.
https://github.com/llvm/llvm-project/pull/90144
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -909,6 +909,26 @@ uint64_t SBValue::GetValueAsUnsigned(uint64_t fail_value) {
return fail_value;
}
+lldb::addr_t SBValue::GetValueAsAddress() {
+ addr_t fail_value = LLDB_INVALID_ADDRESS;
+ ValueLocker locker;
+ lldb::ValueObjectSP value_sp(GetSP(locker));
+ if
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/90144
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ldrumm wrote:
Perhaps things have got lost during the discussion, but my this part of my
original commit message is perhaps worth re-reading:
> In simple terms this means "unless otherwise specified, convert all files
> considered "text" files to LF in the project history, but checkout them
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/90140
Jonas upstreamed recognition of DW_TAG_LLVM_ptrauth_type
https://reviews.llvm.org/D130215 but it isn't recognized as a type qualifier
tag in DWARFASTParserClang::ParseTypeFromDWARF.
>From
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/90144
I previously added this API via https://reviews.llvm.org/D142792 in 2023, along
with changes to the ValueObject class to treat pointer types as addresses, and
to annotate those ValueObjects with the
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
I previously added this API via https://reviews.llvm.org/D142792 in 2023, along
with changes to the ValueObject class to treat pointer types as addresses, and
to annotate those ValueObjects with the
https://github.com/marcauberer updated
https://github.com/llvm/llvm-project/pull/89680
>From efa805079552cf8f247a499d9b26cfc0ff03db72 Mon Sep 17 00:00:00 2001
From: Marc Auberer
Date: Tue, 23 Apr 2024 00:05:53 +0200
Subject: [PATCH 1/2] [lldb] Fix typo in CumulativeSystemTimeIsValid check
---
@@ -121,6 +121,7 @@ typedef struct type256 { uint64_t x[4]; } type256;
using ValueObjectProviderTy =
std::function;
+typedef int DebuggerDestroyCallbackToken;
jimingham wrote:
There's no need to make separate lldb_private & SB versions of the
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/90140
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ilovepi wrote:
Hi, I think we're seeing some breakage in our CI after this patch.
We see the lldb-api :: tools/lldb-dap/console/TestDAP_console.py test failing.
https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-arm64/b8749666263730294449/overview
```
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
5ac744d72ad2a8d04e0ae869c4e30558dd8058e3...3b66943d9c49fd5e71c2eb136b5bb3311e932bbc
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/90144
>From 3b66943d9c49fd5e71c2eb136b5bb3311e932bbc Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 25 Apr 2024 15:51:44 -0700
Subject: [PATCH 1/2] [lldb] Add SBValue::GetValueAsAddress API
I previously
Author: Jason Molenda
Date: 2024-04-25T16:42:33-07:00
New Revision: eb7dc991841489e2f8f18467705944c9136b06d2
URL:
https://github.com/llvm/llvm-project/commit/eb7dc991841489e2f8f18467705944c9136b06d2
DIFF:
https://github.com/llvm/llvm-project/commit/eb7dc991841489e2f8f18467705944c9136b06d2.diff
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/90144
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-04-25T16:42:47-07:00
New Revision: bb2b04c73332f017955115fedb94790dac3608b9
URL:
https://github.com/llvm/llvm-project/commit/bb2b04c73332f017955115fedb94790dac3608b9
DIFF:
https://github.com/llvm/llvm-project/commit/bb2b04c73332f017955115fedb94790dac3608b9.diff
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/90140
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Fangrui Song
Date: 2024-04-25T17:50:59-07:00
New Revision: 5a12f2867a167bbe11099150f3cb6b6cb77d767c
URL:
https://github.com/llvm/llvm-project/commit/5a12f2867a167bbe11099150f3cb6b6cb77d767c
DIFF:
https://github.com/llvm/llvm-project/commit/5a12f2867a167bbe11099150f3cb6b6cb77d767c.diff
@@ -743,10 +743,11 @@ DebuggerSP
Debugger::CreateInstance(lldb::LogOutputCallback log_callback,
}
void Debugger::HandleDestroyCallback() {
- if (m_destroy_callback) {
-m_destroy_callback(GetID(), m_destroy_callback_baton);
-m_destroy_callback = nullptr;
+ const
@@ -321,8 +321,15 @@ class LLDB_API SBDebugger {
void SetLoggingCallback(lldb::LogOutputCallback log_callback, void *baton);
- void SetDestroyCallback(lldb::SBDebuggerDestroyCallback destroy_callback,
- void *baton);
+
Author: Pavel Labath
Date: 2024-04-25T09:06:48+02:00
New Revision: 565bdb55453f0bdd59d9325b8a748cb42e6df95b
URL:
https://github.com/llvm/llvm-project/commit/565bdb55453f0bdd59d9325b8a748cb42e6df95b
DIFF:
https://github.com/llvm/llvm-project/commit/565bdb55453f0bdd59d9325b8a748cb42e6df95b.diff
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/89730
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/89913
>From d9b8ee42dfb753012f2f7032d7fb2dfde3e440f0 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 24 Apr 2024 10:21:08 +0100
Subject: [PATCH 1/3] [lldb][Docs] Make formatting in platform packet doc
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
So we aren't describing the same packets twice. Basically turning the platform
doc into a list of cross links.
qLaunchSuccess was missing a description so I added one.
The links will have text
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/90029
So we aren't describing the same packets twice. Basically turning the platform
doc into a list of cross links.
qLaunchSuccess was missing a description so I added one.
The links will have text generated
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/90029
>From 034efa46305f001092bbaacd563d9d2635ed49ed Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 24 Apr 2024 11:21:15 +0100
Subject: [PATCH 1/2] [lldb][Docs] Link from platform doc to extensions doc
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/90029
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I'll remove the "Brief" subtitles after this.
https://github.com/llvm/llvm-project/pull/90029
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I forgot I didn't land this, so I will instead push a Markdown version of the
same content once the other PRs have landed.
https://github.com/llvm/llvm-project/pull/89357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: David Spickett
Date: 2024-04-25T08:49:57+01:00
New Revision: 51f6570eba69b7030f2845e30b7973bd9ac6c522
URL:
https://github.com/llvm/llvm-project/commit/51f6570eba69b7030f2845e30b7973bd9ac6c522
DIFF:
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/89913
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1,484 +1,49 @@
# LLDB Platform Packets
-Here is a brief overview of the packets that an lldb platform server
+This is a list of the packets that an lldb platform server
needs to implement for the lldb testsuite to be run on a remote
target device/system.
These are
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/89981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1203,26 +1203,23 @@ bool StackFrame::IsArtificial() const {
return m_stack_frame_kind == StackFrame::Kind::Artificial;
}
-lldb::LanguageType StackFrame::GetLanguage() {
+SourceLanguage StackFrame::GetLanguage() {
CompileUnit *cu =
https://github.com/Michael137 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/89981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
When an enum is used to represent certain data it can be useful to know its
name and the value of it. For instance, register fields are often set in source
code as numbers, but in the debugger you'd
DavidSpickett wrote:
This is the first change for
https://discourse.llvm.org/t/rfc-adding-register-field-enums-to-lldb/77275,
though there has been a change of plans and now I'm implementing existing GDB
features to get the same result.
It is a subset of
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
This represents the enum type that can be assigned to a field using the
`enum` element in the target XML.
https://sourceware.org/gdb/current/onlinedocs/gdb.html/Enum-Target-Types.html
Each
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/90063
This represents the enum type that can be assigned to a field using the
`` element in the target XML.
https://sourceware.org/gdb/current/onlinedocs/gdb.html/Enum-Target-Types.html
Each enumerator has:
*
Endilll wrote:
I'm excited so see changes in this area!
> It is a subset of https://github.com/llvm/llvm-project/pull/69815, only for
> use by register printing (ping @Endilll).
Yeah, that effort is stalled because I don't see a clear path forward there,
and I'm lacking energy to find and
DavidSpickett wrote:
> It's also not clear how this new "presentation mode" is going to be
> controlled. While it's not in the scope of this PR, it would be nice if you
> can share a bigger picture.
For me the picture is limited to register printing. I'll be setting this new
option on the
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/90059
When an enum is used to represent certain data it can be useful to know its
name and the value of it. For instance, register fields are often set in source
code as numbers, but in the debugger you'd like
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/89405
>From edefccebc44296d9be29ddde2c48174feb5d2911 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 19 Apr 2024 08:08:02 -0700
Subject: [PATCH] Report exit status message in lldb-dap, same as lldb cli
Summary:
DavidSpickett wrote:
I understand, so the value is made from `a | b | c` for example. I didn't think
of whether register fields could hit this path, but it's equivalent to a C enum
they'll be using, so I think it could happen.
I'll test this, thanks for bringing it up.
jimingham wrote:
For legacy reasons, I think we have to keep SetDestroyCallbacks doing what it
did, but we should comment that it is deprecated and to use the Add and Remove
to only affect your own callbacks.
Jim
> On Apr 24, 2024, at 6:19 PM, royitaqi ***@***.***> wrote:
>
>
> @royitaqi
ldrumm wrote:
@compnerd I just realised I didn't respond to your concern. Apologies.
> I think that the concern that I have is that do we have sufficient testing
> for supporting line-ending dependent behaviour in the compiler?
For the first part: I don't know that it matters, since this
https://github.com/ita-sc created
https://github.com/llvm/llvm-project/pull/90075
Hi
This patch adds an interface GetLastInstrSize to get information about the size
of last tried to be decoded instruction and uses it to set software breakpoint
if the memory can be decoded as instruction.
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (ita-sc)
Changes
Hi
This patch adds an interface GetLastInstrSize to get information about the size
of last tried to be decoded instruction and uses it to set software breakpoint
if the memory can be decoded as instruction.
RISC-V
Author: Miro Bucko
Date: 2024-04-25T09:20:43-07:00
New Revision: ef2ca97f48f1aee1483f0c29de5ba52979bec454
URL:
https://github.com/llvm/llvm-project/commit/ef2ca97f48f1aee1483f0c29de5ba52979bec454
DIFF:
https://github.com/llvm/llvm-project/commit/ef2ca97f48f1aee1483f0c29de5ba52979bec454.diff
https://github.com/jeffreytan81 closed
https://github.com/llvm/llvm-project/pull/89405
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
@mbucko Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a build,
@@ -1203,26 +1203,23 @@ bool StackFrame::IsArtificial() const {
return m_stack_frame_kind == StackFrame::Kind::Artificial;
}
-lldb::LanguageType StackFrame::GetLanguage() {
+SourceLanguage StackFrame::GetLanguage() {
CompileUnit *cu =
ldrumm wrote:
> I'll add a comment to the testing infrastructure page to be mindful of how
> line endings are storedand link to the .gitattributes documentation. Does
> that sound enough?
Added
Endilll wrote:
> For me the picture is limited to register printing. I'll be setting this new
> option on the register type when printing
>
compnerd wrote:
> @compnerd I just realised I didn't respond to your concern. Apologies.
>
> > I think that the concern that I have is that do we have sufficient testing
> > for supporting line-ending dependent behaviour in the compiler?
>
> For the first part: I don't know that it matters,
https://github.com/ayushsahay1837 closed
https://github.com/llvm/llvm-project/pull/88301
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
cor3ntin wrote:
changes to `clang/test/CXX/lex/lex.literal/lex.string/p4.cpp` should be
reverted (it's a CRLF related test)
https://github.com/llvm/llvm-project/pull/86318
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: Ayush Sahay
Date: 2024-04-25T22:30:02+05:30
New Revision: 2db782047b295730cd018b2641a16461f87ce55e
URL:
https://github.com/llvm/llvm-project/commit/2db782047b295730cd018b2641a16461f87ce55e
DIFF:
https://github.com/llvm/llvm-project/commit/2db782047b295730cd018b2641a16461f87ce55e.diff
compnerd wrote:
> changes to `clang/test/CXX/lex/lex.literal/lex.string/p4.cpp` should be
> reverted (it's a CRLF related test)
This is the type of problems that I am concerned about. We certainly have some
tests which are line-ending sensitive, and each test should be audited before
we make
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/90099
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
Can we add a test for this with obj2yaml?
https://github.com/llvm/llvm-project/pull/90099
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -1854,6 +1854,49 @@ class VMAddressProvider {
};
}
+namespace {
+ // We have to do this because ELF doesn't have section IDs, and also
+ // doesn't require section names to be unique. (We use the section index
+ // for section IDs, but that isn't guaranteed to be the
@@ -1854,6 +1854,49 @@ class VMAddressProvider {
};
}
+namespace {
+ // We have to do this because ELF doesn't have section IDs, and also
+ // doesn't require section names to be unique. (We use the section index
+ // for section IDs, but that isn't guaranteed to be the
@@ -1854,6 +1854,49 @@ class VMAddressProvider {
};
}
+namespace {
JDevlieghere wrote:
Nit: LLVM and LLDB prefer static functions over anonymous namespaces.
https://github.com/llvm/llvm-project/pull/90099
___
@@ -2067,10 +2110,8 @@ unsigned ObjectFileELF::ParseSymbols(Symtab *symtab,
user_id_t start_id,
SectionList *module_section_list =
module_sp ? module_sp->GetSectionList() : nullptr;
- // Local cache to avoid doing a FindSectionByName for each symbol. The "const
-
@@ -67,6 +67,10 @@ class LLDB_API SBExpressionOptions {
void SetTrapExceptions(bool trap_exceptions = true);
void SetLanguage(lldb::LanguageType language);
+ /// Set the language using a pair of language code and version as
+ /// defined by the DWARF 6 specification.
+
https://github.com/al45tair created
https://github.com/llvm/llvm-project/pull/90099
Section unification cannot just use names, because it's valid for ELF binaries
to have multiple sections with the same name. We should check other section
properties too.
Fixes #88001.
rdar://124467787
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alastair Houghton (al45tair)
Changes
Section unification cannot just use names, because it's valid for ELF binaries
to have multiple sections with the same name. We should check other section
properties too.
Fixes #88001.
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff f5953f46aa0a664461584b78c14cb141a3be2b9d
ce54a7fb339a00029da266c9f518e344aac5d19e --
https://github.com/AaronBallman commented:
I don't want this to be considered a comment which blocks the changes if others
feel strongly in favor of them, but I'm not really convinced we should do this.
The number of problems this patch will solve is approximately zero but the
number of
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/90029
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
compnerd wrote:
> Also, it's a bit funny to have .bat files without CRLF endings given that
> they run on Windows.
I'm not sure about the funny bit - but certainly dangerous. I've had cmd
misinterpret batch files with LF vs CRLF.
https://github.com/llvm/llvm-project/pull/86318
Author: erichkeane
Date: 2024-04-25T10:36:31-07:00
New Revision: f5953f46aa0a664461584b78c14cb141a3be2b9d
URL:
https://github.com/llvm/llvm-project/commit/f5953f46aa0a664461584b78c14cb141a3be2b9d
DIFF:
https://github.com/llvm/llvm-project/commit/f5953f46aa0a664461584b78c14cb141a3be2b9d.diff
https://github.com/kusmour approved this pull request.
Most comments are addressed. Stamping to unblock. We can iterate with another
PR :D
https://github.com/llvm/llvm-project/pull/86623
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: jeffreytan81
Date: 2024-04-25T11:49:10-07:00
New Revision: 2f2e31c3c980407b2660b4f5d10e7cdb3fa79138
URL:
https://github.com/llvm/llvm-project/commit/2f2e31c3c980407b2660b4f5d10e7cdb3fa79138
DIFF:
https://github.com/llvm/llvm-project/commit/2f2e31c3c980407b2660b4f5d10e7cdb3fa79138.diff
https://github.com/jeffreytan81 closed
https://github.com/llvm/llvm-project/pull/86623
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/89868
>From 079a550481d4cdcb69ad01c376b5e1f0632a07d6 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Tue, 23 Apr 2024 18:10:21 -0700
Subject: [PATCH 1/7] Allow multiple destroy callbacks in
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/89868
>From 079a550481d4cdcb69ad01c376b5e1f0632a07d6 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Tue, 23 Apr 2024 18:10:21 -0700
Subject: [PATCH 1/8] Allow multiple destroy callbacks in
@@ -1425,10 +1426,19 @@ void
Debugger::SetLoggingCallback(lldb::LogOutputCallback log_callback,
std::make_shared(log_callback, baton);
}
+void Debugger::AddDestroyCallback(
+lldb_private::DebuggerDestroyCallback destroy_callback, void *baton) {
+
@@ -321,9 +321,14 @@ class LLDB_API SBDebugger {
void SetLoggingCallback(lldb::LogOutputCallback log_callback, void *baton);
+ void AddDestroyCallback(lldb::SBDebuggerDestroyCallback destroy_callback,
+ void *baton);
+
void
@@ -1425,10 +1426,19 @@ void
Debugger::SetLoggingCallback(lldb::LogOutputCallback log_callback,
std::make_shared(log_callback, baton);
}
+void Debugger::AddDestroyCallback(
+lldb_private::DebuggerDestroyCallback destroy_callback, void *baton) {
+
@@ -743,10 +743,11 @@ DebuggerSP
Debugger::CreateInstance(lldb::LogOutputCallback log_callback,
}
void Debugger::HandleDestroyCallback() {
- if (m_destroy_callback) {
-m_destroy_callback(GetID(), m_destroy_callback_baton);
-m_destroy_callback = nullptr;
+ const
royitaqi wrote:
Hi @jimingham ,
I have updated the code. Now we have `Add` and `Remove` (with tokens as you
suggested). `Set` clears everything then add the given one (also returns a
token).
Thread-safety is done through a `std::lock_guard`. This
is consistent with some of the other
https://github.com/medismailben approved this pull request.
Pretty cool! LGTM!
https://github.com/llvm/llvm-project/pull/90063
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ldrumm wrote:
> Also, it's a bit funny to have .bat files without CRLF endings given that
> they run on Windows
They do have CRLF line endings:
ldrumm wrote:
> Note, the changes to clang-format-vs should likely all be reverted. .sln is a
> Microsoft Visual Studio solution file, as are many of the others
Right. .sln is a text file:
92 matches
Mail list logo
