[Lldb-commits] [PATCH] D27305: Replace __ANDROID_NDK__ with simply ANDROID

2016-12-01 Thread Dan Albert via Phabricator via lldb-commits
danalbert added inline comments. Comment at: cmake/platforms/Android.cmake:36 # flags and definitions remove_definitions( -DANDROID -D__ANDROID__ ) +add_definitions( -DANDROID -DLLDB_DISABLE_LIBEDIT ) You're removing it a line before just to add it back?

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

2019-10-17 Thread Dan Albert via Phabricator via lldb-commits
danalbert added a subscriber: enh. danalbert added a comment. In D68968#1710520 , @labath wrote: > Independently, I am wondering if there's a better way to link the process id > to a bundle. Using argv[0] might be ok if we're using it just for display >