[Lldb-commits] [PATCH] D14634: [LLDB][MIPS] Fix TestDisassembleBreakpoint.py for MIPS

nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovyalov, jaydeep. nitesh.jain added subscribers: bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. The "break" is opcode for breakpoint instruction. Repository: rL

[Lldb-commits] [PATCH] D14635: [LLDB][MIPS] Fix lldbplatformutil.py Failure

nitesh.jain created this revision. nitesh.jain added reviewers: jaydeep, clayborg, ovyalov. nitesh.jain added subscribers: bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. This patch check whether first register is readable. Repository:

[Lldb-commits] [PATCH] D14493: [MIPS][LLDB]Fix TestBreakpointCondition.py for MIPS

nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovyalov. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. The self.getArchitecture() returns the architecture based on the

Re: [Lldb-commits] [PATCH] D12671: [LLDB][MIPS] Added support for the debugging of N32/O32 applications on MIPS64 target.

nitesh.jain updated the summary for this revision. nitesh.jain updated this revision to Diff 34146. nitesh.jain added a comment. Added include/lldb/Core/ArchSpec.h diff Repository: rL LLVM http://reviews.llvm.org/D12671 Files: include/lldb/Core/ArchSpec.h source/Core/ArchSpec.cpp

[Lldb-commits] [PATCH] D12671: [LLDB][MIPS] Added support for the debugging of N32/O32 applications on MIPS64 target.

nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovyalov. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. Repository: rL LLVM http://reviews.llvm.org/D12671 Files:

[Lldb-commits] [PATCH] D15915: [LLDB][MIPS] Fix TestDisassembleRawData.py

nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovehakola, emaste. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. This patch adds check for the correctness of

[Lldb-commits] [PATCH] D16132: [LLDB][MIPS] Fix TestExprsChar.py

nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovyalov. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. When incorrect type used for 'char' then (at least) one of the

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

nitesh.jain added a comment. I will check it and let you know asap. Thanks http://reviews.llvm.org/D20368 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

nitesh.jain added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:438 @@ +437,3 @@ +// The auxiliary vector consists of a sequence of key-value pairs, where key and value are of +// the pointer size for the architecture

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

nitesh.jain added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:438 @@ +437,3 @@ +// The auxiliary vector consists of a sequence of key-value pairs, where key and value are of +// the pointer size for the architecture

Re: [Lldb-commits] [PATCH] D21064: [LLDB][MIPS] Fix Emulation of Compact branch and ADDIU instructions

nitesh.jain added a comment. In http://reviews.llvm.org/D21064#465410, @sdardis wrote: > You also need to emulate dsubu and subu as the MIPS LLVM backend will > generate them in certain cases. Thanks will emulate them too. Repository: rL LLVM http://reviews.llvm.org/D21064

Re: [Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

nitesh.jain updated the summary for this revision. nitesh.jain updated this revision to Diff 46913. nitesh.jain added a comment. Updated as per the suggestion. Repository: rL LLVM http://reviews.llvm.org/D16840 Files:

Re: [Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

nitesh.jain marked an inline comment as done. Comment at: packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py:24 @@ -23,3 +23,3 @@ @expectedFailureAndroid("llvm.org/pr24497", archs=['arm', 'aarch64']) -

Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

nitesh.jain updated this revision to Diff 47776. nitesh.jain added a comment. Update the diff as per suggestion. Repository: rL LLVM http://reviews.llvm.org/D17131 Files: packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py Index:

Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

nitesh.jain updated this revision to Diff 47767. nitesh.jain added a comment. Updated as per suggestion. Repository: rL LLVM http://reviews.llvm.org/D17131 Files: packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py Index:

Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

nitesh.jain marked an inline comment as done. nitesh.jain added a comment. Thanks zturner. Will update the diff as per suggestion. Repository: rL LLVM http://reviews.llvm.org/D17131 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

nitesh.jain updated this revision to Diff 46919. nitesh.jain added a comment. updates diff with triple =re.compile('^mips') to check if architecture string starts with mips. Repository: rL LLVM http://reviews.llvm.org/D16840 Files:

Re: [Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

nitesh.jain updated this revision to Diff 46750. nitesh.jain added a comment. Update the diff with suggested changes Repository: rL LLVM http://reviews.llvm.org/D16840 Files: packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py

Re: [Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

nitesh.jain added a comment. Thanks zturner. The triple is match using re.match(triple, lldb.DBG.GetSelectedPlatform().GetTriple()). I will update diff with the suggested changes. Repository: rL LLVM http://reviews.llvm.org/D16840 ___

[Lldb-commits] [PATCH] D17597: [LLDB][MIPS] Fix TestDisassembleBreakpoint

nitesh.jain created this revision. nitesh.jain added a reviewer: clayborg. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. The MIPS/MICROMIPS architecture will generate different jump instruction.

[Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovyalov. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. The debug version of libc.so is require for backtracing which may

[Lldb-commits] [PATCH] D18082: [LLDB]{MIPS] Fix TestPlatformProcessConnect.py

nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, tberghammer, labath. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. The patch http://reviews.llvm.org/D14952 which modifies

Re: [Lldb-commits] [PATCH] D18082: [LLDB]{MIPS] Fix TestPlatformProcessConnect.py

nitesh.jain added a comment. Hi Tamas Berghammer, Is it ok to commit? Repository: rL LLVM http://reviews.llvm.org/D18082 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D18638: [LLDB][MIPS] Provide ABI string to compiler for appropriate code generation for MIPS

nitesh.jain set the repository for this revision to rL LLVM. nitesh.jain updated this revision to Diff 52177. nitesh.jain added a comment. Corrected formatting issue Repository: rL LLVM http://reviews.llvm.org/D18638 Files: include/lldb/Core/ArchSpec.h source/Core/ArchSpec.cpp

[Lldb-commits] [PATCH] D18638: [LLDB][MIPS] Provide ABI string to compiler for appropriate code generation for MIPS

nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovyalov. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. These patch will set clang::TargetOptions::ABI and accordingly code will be generated For MIPS target.

[Lldb-commits] [PATCH] D18858: [LLDB][MIPS] Setting appropriate ArchSpec::m_flags based on ABI

nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovyalov. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. The ArchSpec::m_flags will be set based on ELF flag ABI.

Re: [Lldb-commits] [PATCH] D18638: [LLDB][MIPS] Provide ABI string to compiler for appropriate code generation for MIPS

nitesh.jain updated this revision to Diff 52886. nitesh.jain added a comment. The diff is updated as per suggestion Repository: rL LLVM http://reviews.llvm.org/D18638 Files: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp

Re: [Lldb-commits] [PATCH] D18638: [LLDB][MIPS] Provide ABI string to compiler for appropriate code generation for MIPS

nitesh.jain added a comment. Yes this function is clang specific(even GetClangTargetCPU) .Will update the diff as per suggestion. Thanks Repository: rL LLVM http://reviews.llvm.org/D18638 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D18858: [LLDB][MIPS] Setting appropriate ArchSpec::m_flags based on ABI

nitesh.jain added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1625-1626 @@ -1624,4 +1624,4 @@ if (arch_spec.GetMachine() == llvm::Triple::mips || arch_spec.GetMachine() == llvm::Triple::mipsel ||

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

nitesh.jain added a comment. In case of MIPS, ptrace always return 64 bit data irrespetive of Arch. http://reviews.llvm.org/D20368 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

nitesh.jain added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:53 @@ -22,2 +52,3 @@ + NativeRegisterContextLinux::NativeRegisterContextLinux(NativeThreadProtocol _thread,

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

nitesh.jain added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:39 @@ +38,3 @@ +int regset = NT_PRSTATUS; +Error error = NativeProcessLinux::PtraceWrapper(PTRACE_GETREGSET, tid, , , sizeof_native_regs_struct); +

Re: [Lldb-commits] [PATCH] D20416: [LLDB][MIPS] Fix floating point handling in case of thread step-out

nitesh.jain added a comment. committed in revision 270207 Repository: rL LLVM http://reviews.llvm.org/D20416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D18858: [LLDB][MIPS] Setting appropriate ArchSpec::m_flags based on ABI

nitesh.jain updated this revision to Diff 56891. nitesh.jain added a comment. Added IsMIPS() method. Repository: rL LLVM http://reviews.llvm.org/D18858 Files: include/lldb/Core/ArchSpec.h source/Core/ArchSpec.cpp source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp Index:

Re: [Lldb-commits] [PATCH] D18638: [LLDB][MIPS] Provide ABI string to compiler for appropriate code generation for MIPS

nitesh.jain closed this revision. nitesh.jain added a comment. Committed in revision 269407 Repository: rL LLVM http://reviews.llvm.org/D18638 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

nitesh.jain added a comment. Hi Greg, Please could you find some time to review this ? Thanks http://reviews.llvm.org/D20357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D22322: [LLDB] Fixes for standalone build

nitesh.jain accepted this revision. nitesh.jain added a comment. LGTM. Thanks Repository: rL LLVM http://reviews.llvm.org/D22322 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

nitesh.jain marked 9 inline comments as done. nitesh.jain added a comment. https://reviews.llvm.org/D20357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D22851: [LLDB][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation for (D)ADDIU, SD/SW and LW/LD instructions

nitesh.jain created this revision. nitesh.jain added reviewers: jaydeep, bhushan, clayborg. nitesh.jain added subscribers: slthakur, mohit.bhakkad, lldb-commits, sdardis. Herald added a subscriber: dsanders. To handle the immediate size greater than 2^16 - 1 , the clang compiler generate LUI,

[Lldb-commits] [lldb] r275785 - [LLVM][MIPS] Revert support for FRE.

Author: nitesh.jain Date: Mon Jul 18 07:37:44 2016 New Revision: 275785 URL: http://llvm.org/viewvc/llvm-project?rev=275785=rev Log: [LLVM][MIPS] Revert support for FRE. Reviewers: jaydeep Subscribers: bhushan, mohit.bhakkad, slthakur, llvm-commits Modified:

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

nitesh.jain marked 8 inline comments as done. nitesh.jain added a comment. https://reviews.llvm.org/D20357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

nitesh.jain updated this revision to Diff 64693. nitesh.jain added a comment. Removed dynamic_size_dwarf_len field from RegisterInfo struct. https://reviews.llvm.org/D20357 Files: include/lldb/Host/common/NativeRegisterContext.h include/lldb/Host/common/NativeRegisterContextRegisterInfo.h

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

nitesh.jain updated this revision to Diff 61940. nitesh.jain added a comment. Thanks Labath. Updated diff as per suggestion. Repository: rL LLVM http://reviews.llvm.org/D20464 Files: cmake/LLDBDependencies.cmake Index: cmake/LLDBDependencies.cmake

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

nitesh.jain added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:98 @@ +97,3 @@ +const ArchSpec = m_thread.GetProcess()->GetTarget().GetArchitecture(); +RegisterInfo* reg_info = const_cast(m_reg_info.GetRegisterInfoAtIndex

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

nitesh.jain marked 6 inline comments as done. nitesh.jain added a comment. Repository: rL LLVM http://reviews.llvm.org/D20357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

nitesh.jain marked an inline comment as done. nitesh.jain added a comment. Repository: rL LLVM http://reviews.llvm.org/D20357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

nitesh.jain retitled this revision from "[LLDB][MIPS] Fix FPU Size Based on Dynamic FR/FRE bit" to "[LLDB][MIPS] Fix FPU Size Based on Dynamic FR". nitesh.jain updated the summary for this revision. nitesh.jain updated this revision to Diff 63201. nitesh.jain added a comment. Update diff as per

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

nitesh.jain marked an inline comment as done. nitesh.jain added a comment. http://reviews.llvm.org/D20357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

nitesh.jain removed rL LLVM as the repository for this revision. nitesh.jain updated this revision to Diff 63224. nitesh.jain added a comment. Added lldb_private::RegisterInfo * DynamicRegisterInfo::GetRegisterInfoAtIndex (uint32_t i) http://reviews.llvm.org/D20357 Files:

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

nitesh.jain added a comment. In http://reviews.llvm.org/D20464#473884, @Eugene.Zelenko wrote: > As fas as I could judge from log, you built LLDB with LLVM/Clang. But problem > happens when it's necessary to build LLDB separately from LLVM/Clang > (standalone build). Then we need to introduce

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

nitesh.jain added a comment. In http://reviews.llvm.org/D20464#472733, @Eugene.Zelenko wrote: > I run CMake with --trace and is mentioned only in condition added there. I have attach log of CMake with --trace. F2135359: log Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR (Merge Request)

Thanks Hans. -Original Message- From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans Wennborg Sent: 09 August 2016 01:58 To: Greg Clayton Cc: Nitesh Jain; Jaydeep Patil; Bhushan Attarde; lldb-commits@lists.llvm.org Subject: Re: [PATCH] D20357: [LLDB][MIPS] Fix FPU

Re: [Lldb-commits] [Diffusion] rL277426: [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation…

Thanks Hans -Original Message- From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans Wennborg Sent: 09 August 2016 01:59 To: Greg Clayton Cc: Nitesh Jain; Jaydeep Patil; Bhushan Attarde; lldb-commits@lists.llvm.org Subject: Re: [Diffusion] rL277426: [LLVM][MIPS] Add

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

nitesh.jain added a comment. Thanks Greg for all your help. Repository: rL LLVM https://reviews.llvm.org/D20357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r277426 - [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation for (D)ADDIU, SD/SW and LW/LD instructions

Author: nitesh.jain Date: Tue Aug 2 02:18:07 2016 New Revision: 277426 URL: http://llvm.org/viewvc/llvm-project?rev=277426=rev Log: [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation for (D)ADDIU, SD/SW and LW/LD instructions Reviewers: clayborg, jaydeep, bhushan

Re: [Lldb-commits] [PATCH] D22851: [LLDB][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation for (D)ADDIU, SD/SW and LW/LD instructions

nitesh.jain closed this revision. nitesh.jain added a comment. committed in revision https://reviews.llvm.org/rL277426, https://reviews.llvm.org/D22851 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR/FRE bit

nitesh.jain added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:497-505 @@ +496,11 @@ + { +bool fre; +bool fr1; +IsFR1_FRE (fr1, fre); + +// fr1 fre fpu_reg_size +

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

nitesh.jain added a comment. In http://reviews.llvm.org/D20464#471803, @Eugene.Zelenko wrote: > I see HAVE_CXX_ATOMICS64_WITHOUT_LIB messages during LLVM Cmake run, but I > don't see such message during LLDB CMake run. > > Is this value is supposed to be read form LLVM CMake cache? Yes.

[Lldb-commits] [lldb] r294415 - [LLDB][MIPS] Fix TestMiniDumpNew

Author: nitesh.jain Date: Wed Feb 8 01:29:24 2017 New Revision: 294415 URL: http://llvm.org/viewvc/llvm-project?rev=294415=rev Log: [LLDB][MIPS] Fix TestMiniDumpNew Reviewers: labath, clayborg Subscribers: jaydeep, bhushan, lldb-commits, slthakur Differential Revision:

[Lldb-commits] [lldb] r294418 - [LLDB][MIPS] Fix TestMiExec and TestMiData failures

Author: nitesh.jain Date: Wed Feb 8 01:42:56 2017 New Revision: 294418 URL: http://llvm.org/viewvc/llvm-project?rev=294418=rev Log: [LLDB][MIPS] Fix TestMiExec and TestMiData failures Subscribers: jaydeep, bhushan, lldb-commits, slthakur Modified:

[Lldb-commits] [PATCH] D24122: [LLDB][MIPS] Fix TestEhFrameUnwind.py for MIPS

nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, labath. nitesh.jain added subscribers: jaydeep, bhushan, slthakur, lldb-commits. This patch will fix TestEhFrameUnwind.py failure for MIPS https://reviews.llvm.org/D24122 Files:

[Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for big endian

nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, labath. nitesh.jain added subscribers: jaydeep, bhushan, slthakur, lldb-commits. Herald added a subscriber: sdardis. The RegisterValue.SetBytes for 4 byte data followed by GetAsUInt64 for 32 bit big endian system will

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for big endian

nitesh.jain added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1844 @@ +1843,3 @@ + +uint64_t value; +value = reg_size == 4 ? *(uint32_t *)reg_bytes : *(uint64_t *)reg_bytes; labath wrote: > This

Re: [Lldb-commits] [PATCH] D23802: gdb-remote: Make the sequence mutex non-recursive

nitesh.jain added a comment. Forgot to mention that this case has been observed for MIPS architecture. Since for MIPS, the floating point register size is calculated at runtime. -NJ Repository: rL LLVM https://reviews.llvm.org/D23802 ___

Re: [Lldb-commits] [PATCH] D23802: gdb-remote: Make the sequence mutex non-recursive

nitesh.jain added inline comments. Comment at: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:131 @@ +130,3 @@ + +GDBRemoteClientBase::Lock lock(gdb_comm, false); +if (!lock) Hi labath, This patch cause deadlock when we try to

[Lldb-commits] [PATCH] D24549: [LLDB][MIPS] Skip some test case which were causing LLDB to go into infinite loop

nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, labath. nitesh.jain added subscribers: jaydeep, bhushan, slthakur, lldb-commits. These test cases tries to insert breakpoint in atomic sequence and cause atomic sequence to restart when breakpoint is hit .

Re: [Lldb-commits] [PATCH] D24498: [LLDB][MIPS] Fix TestReturnValue failure for MIPS

nitesh.jain added inline comments. Comment at: source/Plugins/ABI/SysV-mips64/ABISysV_mips64.cpp:972 @@ -968,4 +971,3 @@ f0_value.GetData(f0_data); The issued was while setting f0_data and f2_data successively via RegisterValue.GetData. Since

[Lldb-commits] [PATCH] D24498: [LLDB][MIPS] Fix TestReturnValue failure for MIPS

nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, labath, bhushan. nitesh.jain added subscribers: jaydeep, slthakur, lldb-commits. Herald added a subscriber: sdardis. https://reviews.llvm.org/D24498 Files: source/Plugins/ABI/SysV-mips64/ABISysV_mips64.cpp Index:

Re: [Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

nitesh.jain marked an inline comment as done. nitesh.jain added a comment. https://reviews.llvm.org/D24603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

nitesh.jain updated this revision to Diff 71505. nitesh.jain added a comment. Updated diff as per suggestion. https://reviews.llvm.org/D24603 Files: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.h Index:

Re: [Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

nitesh.jain added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:1183 @@ +1182,3 @@ + case dwarf_config5_mips64: +return reg_info->byte_offset; + case dwarf_cause_mips: labath wrote: > Why do we need to do

[Lldb-commits] [lldb] r281031 - [LLDB][MIPS] Fix TestEhFrameUnwind.py for MIPS

Author: nitesh.jain Date: Fri Sep 9 05:20:08 2016 New Revision: 281031 URL: http://llvm.org/viewvc/llvm-project?rev=281031=rev Log: [LLDB][MIPS] Fix TestEhFrameUnwind.py for MIPS Reviewers: clayborg, labath Subscribers: jaydeep, bhushan, slthakur, lldb-commits Differential Revision:

Re: [Lldb-commits] [PATCH] D24122: [LLDB][MIPS] Fix TestEhFrameUnwind.py for MIPS

This revision was automatically updated to reflect the committed changes. Closed by commit rL281031: [LLDB][MIPS] Fix TestEhFrameUnwind.py for MIPS (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D24122?vs=69974=70807#toc Repository: rL LLVM

[Lldb-commits] [lldb] r281032 - [LLDB][MIPS] Fix Emulation for JALR64 Instruction

Author: nitesh.jain Date: Fri Sep 9 05:46:25 2016 New Revision: 281032 URL: http://llvm.org/viewvc/llvm-project?rev=281032=rev Log: [LLDB][MIPS] Fix Emulation for JALR64 Instruction Subscribers: jaydeep, bhushan, slthakur, sdardis, lldb-commits Modified:

[Lldb-commits] [lldb] r281026 - [LLDB][MIPS] Fix TestLldbGdbServer.py failure

Author: nitesh.jain Date: Fri Sep 9 04:50:33 2016 New Revision: 281026 URL: http://llvm.org/viewvc/llvm-project?rev=281026=rev Log: [LLDB][MIPS] Fix TestLldbGdbServer.py failure Subscribers: jaydeep, bhushan, slthakur, lldb-commits Modified:

[Lldb-commits] [PATCH] [Updated, 58 lines] D25021: [LLDB][MIPS] Fix qProcessInfo to return correct pointer size based on ELF ABI

nitesh.jain removed rL LLVM as the repository for this revision. nitesh.jain updated this revision to Diff 73029. nitesh.jain added a comment. We just require ABI information so that auxv vector is parse when lldb try to attach a process via "attach -p pid" https://reviews.llvm.org/D25021

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

nitesh.jain updated the summary for this revision. nitesh.jain updated this revision to Diff 72024. https://reviews.llvm.org/D24124 Files: source/Core/RegisterValue.cpp source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp Index:

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

nitesh.jain added a comment. In https://reviews.llvm.org/D24124#543823, @clayborg wrote: > A few things about a the RegisterContext class in case it would change and > thing that you are submitting here. The entire register context defines a > buffer of bytes that can contain all register

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

nitesh.jain retitled this revision from "[LLDB][MIPS] Fix register read/write for big endian" to "[LLDB][MIPS] Fix register read/write for 32 bit big endian system". nitesh.jain updated the summary for this revision. nitesh.jain updated this revision to Diff 71360.

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

nitesh.jain added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1940 @@ +1939,3 @@ + uint64_t dst_value; + RegisterValue reg_value; + lldb::ByteOrder byte_order = lldb::eByteOrderInvalid; The GetAsUint64

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

nitesh.jain marked 2 inline comments as done. nitesh.jain added a comment. https://reviews.llvm.org/D24124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, labath, jaydeep. nitesh.jain added subscribers: bhushan, slthakur, lldb-commits. Herald added a subscriber: sdardis. This patch add fix for reading and writing floating point register based on SR.FR bit.

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

nitesh.jain added a comment. Will submit separate patch for Floating point register read/write and ptrace changes. https://reviews.llvm.org/D24124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D25021: [LLDB][MIPS] Fix qProcessInfo to return correct pointer size based on ELF ABI

nitesh.jain added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:1218 @@ +1217,3 @@ +response.Printf("eflags:%" PRIx32 ";", proc_arch.GetFlags()); +if (proc_triple.isArch64Bit()) { + if (proc_arch.IsMIPS()) {

Re: [Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

nitesh.jain added a comment. In https://reviews.llvm.org/D24603#548902, @clayborg wrote: > So it seems like this can be fixed by doing a few things: > 1 - just set the RegisterInfo.offset to the actual offset in the buffer and > don't use the offset as the ptrace key used to grab the register

Re: [Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

nitesh.jain updated this revision to Diff 72618. nitesh.jain added a comment. Herald added a subscriber: ki.stfu. Updated patch as per suggestion. https://reviews.llvm.org/D24603 Files: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp

[Lldb-commits] [PATCH] D25021: [LLDB][MIPS] Fix qProcessInfo to return correct pointer size based on ELF ABI

nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, labath. nitesh.jain added subscribers: jaydeep, bhushan, slthakur, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. In case of MIPS64, the pointer size depends on ELF abi. The MIPS64 currently

[Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

nitesh.jain updated this revision to Diff 73278. nitesh.jain added a comment. These diff remove manually bit twiddling due to the size of the floating point register that can change. We use register offset to get floating point register data based on endianess and it's size. We have not remove

[Lldb-commits] [PATCH] D26542: [LLDB][MIPS] Fix some test case failures due to "elf_abi" field of qprocessInfo packet

nitesh.jain added a comment. The elf_abi field was introduced in qprocessInfo packet (commit https://reviews.llvm.org/rL284001) so that LLDB can set pointer size and parse aux vector accordingly. This patch fix some test cases failures by introducing this field in _KNOWN_PROCESS_INFO_KEYS.

[Lldb-commits] [PATCH] D26542: [LLDB][MIPS] Fix some test case failures due to "elf_abi" field of qprocessInfo packet

nitesh.jain created this revision. nitesh.jain added reviewers: jaydeep, bhushan, clayborg. nitesh.jain added subscribers: lldb-commits, slthakur. https://reviews.llvm.org/D26542 Files: packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py Index:

[Lldb-commits] [PATCH] D27085: [LLDB][MIPS] Fix TestMultipleHits for MIPS

nitesh.jain created this revision. nitesh.jain added reviewers: labath, clayborg, zturner. nitesh.jain added subscribers: jaydeep, bhushan, slthakur, lldb-commits. https://reviews.llvm.org/D27085 Files: packages/Python/lldbsuite/test/functionalities/watchpoint/multiple_hits/main.cpp Index:

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, labath, zturner. nitesh.jain added subscribers: jaydeep, bhushan, slthakur, lldb-commits. In case of MIPS, the floating point register size is based on FR bit of status register(SR) (https://reviews.llvm.org/rL277343). In

[Lldb-commits] [PATCH] D24549: [LLDB][MIPS] Skip some test case which were causing LLDB to go into infinite loop

This revision was automatically updated to reflect the committed changes. Closed by commit rL283732: [LLDB][MIPS] Skip some test case which were causing LLDB to go into infinite… (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D24549?vs=71314=74204#toc Repository:

[Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

This revision was automatically updated to reflect the committed changes. Closed by commit rL283728: [LLDB][MIPS] Fix register read/write for 32 bit big endian system (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D24124?vs=72024=74202#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D24498: [LLDB][MIPS] Fix TestReturnValue failure for MIPS

This revision was automatically updated to reflect the committed changes. Closed by commit rL283729: [LLDB][MIPS] Fix TestReturnValue failure for MIPS (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D24498?vs=71131=74203#toc Repository: rL LLVM

[Lldb-commits] [lldb] r284001 - [LLDB][MIPS] Fix qProcessInfo to return correct pointer size based on ELF ABI

Author: nitesh.jain Date: Wed Oct 12 05:21:09 2016 New Revision: 284001 URL: http://llvm.org/viewvc/llvm-project?rev=284001=rev Log: [LLDB][MIPS] Fix qProcessInfo to return correct pointer size based on ELF ABI Reviewers: clayborg, labath Subscribers: jaydeep, bhushan, slthakur, lldb-commits

[Lldb-commits] [PATCH] D25021: [LLDB][MIPS] Fix qProcessInfo to return correct pointer size based on ELF ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rL284001: [LLDB][MIPS] Fix qProcessInfo to return correct pointer size based on ELF ABI (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D25021?vs=73029=74356#toc Repository:

[Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

This revision was automatically updated to reflect the committed changes. Closed by commit rL284003: [LLDB][MIPS] fix Floating point register read/write for big endian (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D24603?vs=73278=74357#toc Repository: rL LLVM

[Lldb-commits] [lldb] r284003 - [LLDB][MIPS] fix Floating point register read/write for big endian

Author: nitesh.jain Date: Wed Oct 12 05:53:57 2016 New Revision: 284003 URL: http://llvm.org/viewvc/llvm-project?rev=284003=rev Log: [LLDB][MIPS] fix Floating point register read/write for big endian Reviewers: clayborg, labath, jaydeep Subscribers: bhushan, slthakur, lldb-commits Differential

[Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

nitesh.jain added a comment. In https://reviews.llvm.org/D24603#566575, @clayborg wrote: > Commit anytime. Thanks https://reviews.llvm.org/D24603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

  1   2   >