[Lldb-commits] [lldb] r343023 - [lldbinline] Set directory attribute on test-specific classes

Author: vedantk Date: Tue Sep 25 13:20:13 2018 New Revision: 343023 URL: http://llvm.org/viewvc/llvm-project?rev=343023&view=rev Log: [lldbinline] Set directory attribute on test-specific classes Set the "mydir" attribute of an inline test on the test-specific class, instead of on the base Inline

[Lldb-commits] [lldb] r343899 - Relax a data formatter test

Author: vedantk Date: Fri Oct 5 16:14:13 2018 New Revision: 343899 URL: http://llvm.org/viewvc/llvm-project?rev=343899&view=rev Log: Relax a data formatter test Before inspecting the contents of a list, make sure that we've stepped past the push_back() that inserts the element we're interested i

[Lldb-commits] [lldb] r343900 - Add support for artificial tail call frames

Author: vedantk Date: Fri Oct 5 16:23:15 2018 New Revision: 343900 URL: http://llvm.org/viewvc/llvm-project?rev=343900&view=rev Log: Add support for artificial tail call frames This patch teaches lldb to detect when there are missing frames in a backtrace due to a sequence of tail calls, and to

Re: [Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

It's probably not, it's just that the --filecheck arg is missing. I wrote things this way because I was advised that dotest.py shouldn't assume where FileCheck is on the filesystem. vedant > On Oct 11, 2018, at 3:22 PM, Zachary Turner wrote: > > Why is FileCheck missing in the first place? >

Re: [Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

> On Oct 11, 2018, at 3:30 PM, Stella Stamenova via Phabricator > wrote: > > stella.stamenova added a comment. > > I spent a bit more time on this and I think I have a better idea of what's > happening. > > Vedant added functionality so that we can use FileCheck-style checks inside > non-l

Re: [Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

Does this look reasonable to you? I'm not sure how to test this. diff --git a/zorg/buildbot/builders/LLDBBuilder.py b/zorg/buildbot/builders/LLDBBuilder.py index 5a1b2e87..62152924 100644 --- a/zorg/buildbot/builders/LLDBBuilder.py +++ b/zorg/buildbot/builders/LLDBBuilder.py @@ -270,6 +270,7 @@ d

Re: [Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

Can we get the Xcode build to generate lldb-dotest, just like the cmake build does? That way there's no need to duplicate build system logic into dotest.py. It would just live in one place, and we'd all invoke lldb-dotest the same way. vedant > On Oct 11, 2018, at 3:53 PM, Jason Molenda via Pha

Re: [Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

All right, Committed r344396, I’ll keep an eye out for failures. vedant > On Oct 12, 2018, at 9:58 AM, Stella Stamenova wrote: > > Those changes look reasonable, but I don't know how to test it either. I > would be in favor of checking it in because the buildbots are currently > broken and th

[Lldb-commits] [lldb] r344401 - [dotest] Make a missing FileCheck binary a warning, not an error

Author: vedantk Date: Fri Oct 12 12:29:59 2018 New Revision: 344401 URL: http://llvm.org/viewvc/llvm-project?rev=344401&view=rev Log: [dotest] Make a missing FileCheck binary a warning, not an error This allows bots which haven't updated to pass in --filecheck to dotest.py to run more tests. File

Re: [Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

Ah gotcha. For the public Darwin bots, we needed to specifically trigger a Jenkins job to distribute Zorg updates to all our builders. This can be a bit of a manual process, because you need to kill the jobs on the builders’ queues to make sure they run the Zorg_Distribute job asap. I’m not sur

Re: [Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

> On Oct 12, 2018, at 12:52 PM, Stella Stamenova via Phabricator > wrote: > > stella.stamenova added a comment. > > The bots are now failing because lexists doesn't handle NoneType correctly: > >File > "/lldb-buildbot/lldbSlave/buildWorkingDir/llvm/tools/lldb/packages/Python/lldbsuite/t

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

> On Oct 15, 2018, at 3:47 PM, Stella Stamenova via Phabricator > wrote: > > stella.stamenova added a comment. > > In https://reviews.llvm.org/D50478#1262717, @vsk wrote: > >> In https://reviews.llvm.org/D50478#1262710, @stella.stamenova wrote: >> >>> Unfortunately, the bots are broken beca

[Lldb-commits] [lldb] r344581 - Use assertEqual to improve test failure logging

Author: vedantk Date: Mon Oct 15 20:31:33 2018 New Revision: 344581 URL: http://llvm.org/viewvc/llvm-project?rev=344581&view=rev Log: Use assertEqual to improve test failure logging Some tests in test/functionalities/tail_call_frames are failing on non-Darwin platforms. Use assertEqual to improve

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

> On Oct 15, 2018, at 4:46 PM, Frédéric Riss wrote: > > > >> On Oct 15, 2018, at 4:40 PM, Vedant Kumar > > wrote: >> >> >> >>> On Oct 15, 2018, at 3:47 PM, Stella Stamenova via Phabricator >>> mailto:revi...@reviews.llvm.org>> wrote: >>> >>> stella.stamenova added

[Lldb-commits] [lldb] r344634 - Use a relaxed substring check for function names in a test

Author: vedantk Date: Tue Oct 16 11:13:42 2018 New Revision: 344634 URL: http://llvm.org/viewvc/llvm-project?rev=344634&view=rev Log: Use a relaxed substring check for function names in a test The TestTailCallFrameSBAPI.py test checks that function names in a backtrace are equal to an expected va

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

> On Oct 16, 2018, at 10:59 AM, Stella Stamenova wrote: > > The windows error is because the names are different, as you expected: > > AssertionError: 'void sink(void)' != 'sink()' > > You can probably update the test to look for a different name on Windows > (though if I recall correctly,

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

Hi Stella, The logs are really helpful, thanks. This part is unexpected: python Finding frames between main and sink(), retn-pc=0x4005b8 python GetCallEdges: Attempting to parse call site info for main python CollectCallEdges: Found call site info in main python

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

> On Oct 19, 2018, at 5:37 PM, Vedant Kumar wrote: > > Hi Stella, > > The logs are really helpful, thanks. This part is unexpected: > > python Finding frames between main and sink(), retn-pc=0x4005b8 > python GetCallEdges: Attempting to parse call site info for main > pyth

[Lldb-commits] [lldb] r344960 - [DWARF] Use a function-local offset for AT_call_return_pc

Author: vedantk Date: Mon Oct 22 14:44:21 2018 New Revision: 344960 URL: http://llvm.org/viewvc/llvm-project?rev=344960&view=rev Log: [DWARF] Use a function-local offset for AT_call_return_pc Logs provided by @stella.stamenova indicate that on Linux, lldb adds a spurious slide offset to the retur

[Lldb-commits] [lldb] r333583 - [lldb-test] Add a testing harness for the JIT's IRMemoryMap

Author: vedantk Date: Wed May 30 12:39:10 2018 New Revision: 333583 URL: http://llvm.org/viewvc/llvm-project?rev=333583&view=rev Log: [lldb-test] Add a testing harness for the JIT's IRMemoryMap This teaches lldb-test how to launch a process, set up an IRMemoryMap, and issue memory allocations in

[Lldb-commits] [lldb] r333585 - [lldb-test] ir-memory-map: Avoid accessing a bad iterator

Author: vedantk Date: Wed May 30 12:46:47 2018 New Revision: 333585 URL: http://llvm.org/viewvc/llvm-project?rev=333585&view=rev Log: [lldb-test] ir-memory-map: Avoid accessing a bad iterator Do not access Probe.start() when Probe is at the end of the interval map. Modified: lldb/trunk/tools

[Lldb-commits] [lldb] r333701 - [lit] Remove the *.test suffix from two test inputs

Author: vedantk Date: Thu May 31 15:09:01 2018 New Revision: 333701 URL: http://llvm.org/viewvc/llvm-project?rev=333701&view=rev Log: [lit] Remove the *.test suffix from two test inputs This prevents the test inputs from being marked as unsupported tests, due to their lack of RUN lines. Added:

[Lldb-commits] [lldb] r333700 - [IRMemoryMap] Test interleaved Mallocs and Frees

Author: vedantk Date: Thu May 31 15:09:01 2018 New Revision: 333700 URL: http://llvm.org/viewvc/llvm-project?rev=333700&view=rev Log: [IRMemoryMap] Test interleaved Mallocs and Frees This adds a new command to the ir-memory-map tester: free The argument to free is an index which identifies w

[Lldb-commits] [lldb] r333698 - [IRMemoryMap] Test host-side allocations

Author: vedantk Date: Thu May 31 15:09:00 2018 New Revision: 333698 URL: http://llvm.org/viewvc/llvm-project?rev=333698&view=rev Log: [IRMemoryMap] Test host-side allocations r333583 introduced testing for IRMemoryMap's process-side allocations (eAllocationPolicyProcessOnly). This adds support fo

[Lldb-commits] [lldb] r333699 - [lldb-test] Make logging available to all subcommands

Author: vedantk Date: Thu May 31 15:09:00 2018 New Revision: 333699 URL: http://llvm.org/viewvc/llvm-project?rev=333699&view=rev Log: [lldb-test] Make logging available to all subcommands Modified: lldb/trunk/tools/lldb-test/lldb-test.cpp Modified: lldb/trunk/tools/lldb-test/lldb-test.cpp UR

[Lldb-commits] [lldb] r333697 - [IRMemoryMap] Fix the alignment adjustment in Malloc

Author: vedantk Date: Thu May 31 15:08:59 2018 New Revision: 333697 URL: http://llvm.org/viewvc/llvm-project?rev=333697&view=rev Log: [IRMemoryMap] Fix the alignment adjustment in Malloc This prevents Malloc from allocating the same chunk of memory twice, as a byproduct of an alignment adjustment

Re: [Lldb-commits] [lldb] r333700 - [IRMemoryMap] Test interleaved Mallocs and Frees

> On Jun 1, 2018, at 1:39 AM, Pavel Labath wrote: > > On Thu, 31 May 2018 at 23:13, Vedant Kumar via lldb-commits > wrote: >> >> Author: vedantk >> Date: Thu May 31 15:09:01 2018 >> New Revision: 333700 >> >> URL: http://llvm.or

Re: [Lldb-commits] [lldb] r333700 - [IRMemoryMap] Test interleaved Mallocs and Frees

Patch up for review: https://reviews.llvm.org/D47646 <https://reviews.llvm.org/D47646> thanks, vedant > On Jun 1, 2018, at 11:31 AM, Vedant Kumar wrote: > > > >> On Jun 1, 2018, at 1:39 AM, Pavel Labath wrote: >> >> On Thu, 31 May 2018 at 23:13, Ved

[Lldb-commits] [lldb] r333785 - Disable TestIRMemoryMap.test on Windows

Author: vedantk Date: Fri Jun 1 13:02:57 2018 New Revision: 333785 URL: http://llvm.org/viewvc/llvm-project?rev=333785&view=rev Log: Disable TestIRMemoryMap.test on Windows It's been pointed out in https://reviews.llvm.org/D47646 that lldb-test fails to create a usable process on Windows when ru

[Lldb-commits] [lldb] r333787 - XFAIL TestIRMemoryMap.test on Windows

Author: vedantk Date: Fri Jun 1 13:32:32 2018 New Revision: 333787 URL: http://llvm.org/viewvc/llvm-project?rev=333787&view=rev Log: XFAIL TestIRMemoryMap.test on Windows I've xfailed this test instead of skipping it by request (https://reviews.llvm.org/D47646). Bug: https://bugs.llvm.org/show_

[Lldb-commits] [lldb] r333930 - [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

Author: vedantk Date: Mon Jun 4 10:11:15 2018 New Revision: 333930 URL: http://llvm.org/viewvc/llvm-project?rev=333930&view=rev Log: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands Change the syntax of the malloc and free commands in lldb-test's ir-memory-map subcommand to

[Lldb-commits] [lldb] r338588 - [StackFrame] Factor GetOnlyConcreteFramesUpTo out of GetFramesUpTo (NFC)

Author: vedantk Date: Wed Aug 1 10:07:40 2018 New Revision: 338588 URL: http://llvm.org/viewvc/llvm-project?rev=338588&view=rev Log: [StackFrame] Factor GetOnlyConcreteFramesUpTo out of GetFramesUpTo (NFC) Splitting GetOnlyConcreteFramesUpTo will make it easier to implement support for synthetic

[Lldb-commits] [lldb] r338590 - [StackFrame] Add doxygen comments to the StackFrameList API (NFC)

Author: vedantk Date: Wed Aug 1 10:08:11 2018 New Revision: 338590 URL: http://llvm.org/viewvc/llvm-project?rev=338590&view=rev Log: [StackFrame] Add doxygen comments to the StackFrameList API (NFC) Clarify how StackFrameList works by documenting its methods. Also, delete some dead code and inse

[Lldb-commits] [lldb] r338589 - [StackFrame] Use early returns in ResetCurrentInlinedDepth (NFC)

Author: vedantk Date: Wed Aug 1 10:07:56 2018 New Revision: 338589 URL: http://llvm.org/viewvc/llvm-project?rev=338589&view=rev Log: [StackFrame] Use early returns in ResetCurrentInlinedDepth (NFC) Using early returns in this function substantially reduces the nesting level, making the logic eas

[Lldb-commits] [lldb] r339051 - [IRMemoryMap] Avoid redundant zero-init in the Allocation constructor (NFC)

Author: vedantk Date: Mon Aug 6 13:13:52 2018 New Revision: 339051 URL: http://llvm.org/viewvc/llvm-project?rev=339051&view=rev Log: [IRMemoryMap] Avoid redundant zero-init in the Allocation constructor (NFC) In the lldb-bench/arithmetic benchmark, 1.7% of the total running time is spent zero-in

[Lldb-commits] [lldb] r339206 - Delete a dead Function constructor (NFC)

Author: vedantk Date: Tue Aug 7 16:48:40 2018 New Revision: 339206 URL: http://llvm.org/viewvc/llvm-project?rev=339206&view=rev Log: Delete a dead Function constructor (NFC) Modified: lldb/trunk/include/lldb/Symbol/Function.h lldb/trunk/source/Symbol/Function.cpp Modified: lldb/trunk/in

[Lldb-commits] [lldb] r339205 - [StackFrame] Add more clarifying comments to StackFrameList (NFC)

Author: vedantk Date: Tue Aug 7 16:48:25 2018 New Revision: 339205 URL: http://llvm.org/viewvc/llvm-project?rev=339205&view=rev Log: [StackFrame] Add more clarifying comments to StackFrameList (NFC) Modified: lldb/trunk/source/Target/StackFrameList.cpp Modified: lldb/trunk/source/Target/Sta

[Lldb-commits] [lldb] r339290 - [IRMemoryMap] Shrink Allocation and make it move-only (NFC)

Author: vedantk Date: Wed Aug 8 14:26:49 2018 New Revision: 339290 URL: http://llvm.org/viewvc/llvm-project?rev=339290&view=rev Log: [IRMemoryMap] Shrink Allocation and make it move-only (NFC) Profiling data show that Allocation::operator= is hot (see the data attached to the Phab review). Reor

Re: [Lldb-commits] [lldb] r339716 - Remove asseration from ConstString::GetConstCStringAndSetMangledCounterPart() to fix more tests first

Apologies for double-posting, but I'm not sure that my Phab comment made it to you. --- /lldb/trunk/source/Utility/ConstString.cpp:130 Great catch! I wonder, what does it mean for the entry value to be non-null but empty? vedant > On Aug 14, 2018, at 12:38 PM, Stefan Granitz via lldb-commits

[Lldb-commits] [lldb] r339914 - Disable two flaky pexpect-backed tests on Darwin

Author: vedantk Date: Thu Aug 16 11:18:16 2018 New Revision: 339914 URL: http://llvm.org/viewvc/llvm-project?rev=339914&view=rev Log: Disable two flaky pexpect-backed tests on Darwin These tests are sporadically timing out on our bots, e.g here: https://ci.swift.org/job/swift-PR-Linux/6841 Mo

[Lldb-commits] [lldb] r339929 - [dotest] Make --test-subdir work with --no-multiprocess

Author: vedantk Date: Thu Aug 16 12:56:38 2018 New Revision: 339929 URL: http://llvm.org/viewvc/llvm-project?rev=339929&view=rev Log: [dotest] Make --test-subdir work with --no-multiprocess The single-process test runner is invoked in a number of different scenarios, including when multiple test

[Lldb-commits] [lldb] r342008 - [MIPS] Fix signed overflow in DADDIU emulation

Author: vedantk Date: Tue Sep 11 16:04:05 2018 New Revision: 342008 URL: http://llvm.org/viewvc/llvm-project?rev=342008&view=rev Log: [MIPS] Fix signed overflow in DADDIU emulation This fixes a signed integer overflow diagnostic reported by ubsan. rdar://44353380 Modified: lldb/trunk/source

[Lldb-commits] [lldb] r342508 - Allow use of self.filecheck in LLDB tests (c.f self.expect)

Author: vedantk Date: Tue Sep 18 12:31:47 2018 New Revision: 342508 URL: http://llvm.org/viewvc/llvm-project?rev=342508&view=rev Log: Allow use of self.filecheck in LLDB tests (c.f self.expect) Add a "filecheck" method to the LLDB test base. This allows test authors to pattern match command outpu

[Lldb-commits] [lldb] r342699 - [lldbtest] Fix self.filecheck check file lookup

Author: vedantk Date: Thu Sep 20 16:56:39 2018 New Revision: 342699 URL: http://llvm.org/viewvc/llvm-project?rev=342699&view=rev Log: [lldbtest] Fix self.filecheck check file lookup The 'test_filename' property in TestBase changes over time, so attempting to find a check file relative to the dire

[Lldb-commits] [lldb] r319595 - Fix warnings in DNBDataRef.cpp, NFC

Author: vedantk Date: Fri Dec 1 15:24:12 2017 New Revision: 319595 URL: http://llvm.org/viewvc/llvm-project?rev=319595&view=rev Log: Fix warnings in DNBDataRef.cpp, NFC Modified: lldb/trunk/tools/debugserver/source/DNBDataRef.cpp Modified: lldb/trunk/tools/debugserver/source/DNBDataRef.cpp

[Lldb-commits] [lldb] r319596 - Fix warnings in JSON.cpp, NFC

Author: vedantk Date: Fri Dec 1 15:29:04 2017 New Revision: 319596 URL: http://llvm.org/viewvc/llvm-project?rev=319596&view=rev Log: Fix warnings in JSON.cpp, NFC These asserts are no-ops, and are supplanted by -Wcovered-switch. Modified: lldb/trunk/tools/debugserver/source/JSON.cpp Modifi

[Lldb-commits] [lldb] r319597 - Fix warning in DynamicLoaderDarwinKernel.cpp, NFC

Author: vedantk Date: Fri Dec 1 15:53:01 2017 New Revision: 319597 URL: http://llvm.org/viewvc/llvm-project?rev=319597&view=rev Log: Fix warning in DynamicLoaderDarwinKernel.cpp, NFC Modified: lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp Modified: ll

Re: [Lldb-commits] [PATCH] D40821: Fix const-correctness in RegisterContext methods, NFC

> On Dec 4, 2017, at 6:02 PM, Zachary Turner wrote: > > It almost looks to me like this should be using aggregation instead of > inheritance. That would add a 3rd option (mark it mutable). I don't have my head wrapped around your suggestion. Do you mean that 'const GPR &' and friends should b

[Lldb-commits] [lldb] r319939 - Fix const-correctness in RegisterContext methods, NFC

Author: vedantk Date: Wed Dec 6 11:21:12 2017 New Revision: 319939 URL: http://llvm.org/viewvc/llvm-project?rev=319939&view=rev Log: Fix const-correctness in RegisterContext methods, NFC A few methods in RegisterContext classes accept const objects which are cast to a non-const thread_state_t. D

[Lldb-commits] [lldb] r319937 - Fix misc -Wcast-qual warnings, NFC

Author: vedantk Date: Wed Dec 6 11:21:11 2017 New Revision: 319937 URL: http://llvm.org/viewvc/llvm-project?rev=319937&view=rev Log: Fix misc -Wcast-qual warnings, NFC Modified: lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm lldb/trunk/tools/debugserver/source/MacOSX/MachTask.

[Lldb-commits] [lldb] r319938 - Fix an -Wunused-function warning, NFC

Author: vedantk Date: Wed Dec 6 11:21:11 2017 New Revision: 319938 URL: http://llvm.org/viewvc/llvm-project?rev=319938&view=rev Log: Fix an -Wunused-function warning, NFC Modified: lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm Modified: lldb/trunk/tools/debugserver/source/MacOSX

[Lldb-commits] [lldb] r319936 - Remove no-op function pointer null checks, NFC

Author: vedantk Date: Wed Dec 6 11:21:10 2017 New Revision: 319936 URL: http://llvm.org/viewvc/llvm-project?rev=319936&view=rev Log: Remove no-op function pointer null checks, NFC Null-checking functions which aren't marked weak_import is a no-op (the compiler rewrites the check to 'true'), rega

[Lldb-commits] [lldb] r319934 - [MappedHash] Fix alignment violations

Author: vedantk Date: Wed Dec 6 11:21:08 2017 New Revision: 319934 URL: http://llvm.org/viewvc/llvm-project?rev=319934&view=rev Log: [MappedHash] Fix alignment violations This fixes a few alignment problems pointed out by UBSan, and is otherwise NFC. Modified: lldb/trunk/include/lldb/Core/M

[Lldb-commits] [lldb] r319935 - Use a static_cast instead of a C cast, NFC

Author: vedantk Date: Wed Dec 6 11:21:09 2017 New Revision: 319935 URL: http://llvm.org/viewvc/llvm-project?rev=319935&view=rev Log: Use a static_cast instead of a C cast, NFC Pointed out by Davide Italiano in post-commit review. Modified: lldb/trunk/source/Plugins/DynamicLoader/Darwin-Ker

Re: [Lldb-commits] [lldb] r319597 - Fix warning in DynamicLoaderDarwinKernel.cpp, NFC

> On Dec 2, 2017, at 12:22 PM, Davide Italiano wrote: > > On Fri, Dec 1, 2017 at 3:53 PM, Vedant Kumar via lldb-commits > wrote: >> Author: vedantk >> Date: Fri Dec 1 15:53:01 2017 >> New Revision: 319597 >> >> URL: http://llvm.org/viewvc/llvm-

[Lldb-commits] [lldb] r319943 - Fix the -Wunused-function warning properly (MachProcess.mm)

Author: vedantk Date: Wed Dec 6 11:27:20 2017 New Revision: 319943 URL: http://llvm.org/viewvc/llvm-project?rev=319943&view=rev Log: Fix the -Wunused-function warning properly (MachProcess.mm) r319938 was not NFC, because it got the preprocessor guard wrong. Check WITH_FBS and WITH_BKS before de

[Lldb-commits] [lldb] r320071 - Disable warnings related to anonymous types in the ObjC plugin

Author: vedantk Date: Thu Dec 7 10:57:09 2017 New Revision: 320071 URL: http://llvm.org/viewvc/llvm-project?rev=320071&view=rev Log: Disable warnings related to anonymous types in the ObjC plugin This part of lldb make use of anonymous structs and unions. The usage is idiomatic and doesn't deser

[Lldb-commits] [lldb] r320127 - [MachException] Avoid alignment UB, NFC

Author: vedantk Date: Thu Dec 7 17:09:40 2017 New Revision: 320127 URL: http://llvm.org/viewvc/llvm-project?rev=320127&view=rev Log: [MachException] Avoid alignment UB, NFC Fix alignment UB in some Mach exception-handling logic. This lets us build lldb and debugserver with UBSan in trapping mod

[Lldb-commits] [lldb] r320126 - Remove extant references to g_message_mutex, NFC

Author: vedantk Date: Thu Dec 7 17:09:39 2017 New Revision: 320126 URL: http://llvm.org/viewvc/llvm-project?rev=320126&view=rev Log: Remove extant references to g_message_mutex, NFC Thanks to Jim Ingham for providing the explanation! Modified: lldb/trunk/source/Plugins/Process/Darwin/MachEx

[Lldb-commits] [lldb] r320456 - Avoid module import in a textual header, NFC

Author: vedantk Date: Mon Dec 11 19:27:13 2017 New Revision: 320456 URL: http://llvm.org/viewvc/llvm-project?rev=320456&view=rev Log: Avoid module import in a textual header, NFC This unbreaks the lldb modules build (-DLLVM_ENABLE_MODULES=On). Modified: lldb/trunk/source/Plugins/Process/Util

[Lldb-commits] [lldb] r320522 - Add an #include to appease an older clang, NFC

Author: vedantk Date: Tue Dec 12 12:19:40 2017 New Revision: 320522 URL: http://llvm.org/viewvc/llvm-project?rev=320522&view=rev Log: Add an #include to appease an older clang, NFC Add in a missing #include that AppleClang-900 complains about when building with -DLLVM_ENABLE_MODULES. Modified:

Re: [Lldb-commits] [lldb] r320456 - Avoid module import in a textual header, NFC

ig undertaking, though. > > On Mon, Dec 11, 2017 at 7:27 PM Vedant Kumar via lldb-commits > mailto:lldb-commits@lists.llvm.org>> wrote: > Author: vedantk > Date: Mon Dec 11 19:27:13 2017 > New Revision: 320456 > > URL: http://llvm.org/viewvc/llvm-project?rev=320456&

[Lldb-commits] [lldb] r322340 - Skip TestFunctionTemplateParameterPack.py, which unexpectedly asserts (PR35920)

Author: vedantk Date: Thu Jan 11 17:23:52 2018 New Revision: 322340 URL: http://llvm.org/viewvc/llvm-project?rev=322340&view=rev Log: Skip TestFunctionTemplateParameterPack.py, which unexpectedly asserts (PR35920) This test stresses expression evaluation support for template functions. Currently

[Lldb-commits] [lldb] r322728 - Skip a flaky test (TestRdar12408181.py)

Author: vedantk Date: Wed Jan 17 10:53:42 2018 New Revision: 322728 URL: http://llvm.org/viewvc/llvm-project?rev=322728&view=rev Log: Skip a flaky test (TestRdar12408181.py) This test frequently times out on our bots. While we're investigating the issue, mark the test as skipped so the builds are

[Lldb-commits] [lldb] r322740 - Try again to mark TestRdar12408181.py as skipped

Author: vedantk Date: Wed Jan 17 11:25:12 2018 New Revision: 322740 URL: http://llvm.org/viewvc/llvm-project?rev=322740&view=rev Log: Try again to mark TestRdar12408181.py as skipped rdar://36417163 Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/rdar-12408181/TestRdar12408181

[Lldb-commits] [lldb] r322756 - A third attempt to mark TestRdar12408181.py as skipped

Author: vedantk Date: Wed Jan 17 12:54:39 2018 New Revision: 322756 URL: http://llvm.org/viewvc/llvm-project?rev=322756&view=rev Log: A third attempt to mark TestRdar12408181.py as skipped Due to an unfortunate difference between the open source test harness and our internal harness, applying two

[Lldb-commits] [lldb] r322803 - [CMake] Make check-lldb work with LLDB_CODESIGN_IDENTITY=''

Author: vedantk Date: Wed Jan 17 17:16:30 2018 New Revision: 322803 URL: http://llvm.org/viewvc/llvm-project?rev=322803&view=rev Log: [CMake] Make check-lldb work with LLDB_CODESIGN_IDENTITY='' On Darwin, if a test machine isn't set up for code-signing (see docs/code-signing.txt), running check-l

[Lldb-commits] [lldb] r323450 - Use test-specific module caches to avoid stale header conflicts

Author: vedantk Date: Thu Jan 25 10:01:27 2018 New Revision: 323450 URL: http://llvm.org/viewvc/llvm-project?rev=323450&view=rev Log: Use test-specific module caches to avoid stale header conflicts Stale global module caches cause problems for the bots. The modules become invalid when clang heade

Re: [Lldb-commits] [lldb] r323450 - Use test-specific module caches to avoid stale header conflicts

t. > > http://lab.llvm.org:8080/green/view/LLDB/job/lldb-xcode/4513/ > > > Can you please take a look, Vedant? > > Thanks, > > -- > Davide > > On Thu, Jan 25, 2018 at 10:01 AM, Vedant Kumar via lldb-commits > wrote: >> Author: vedantk >> Date: Th

Re: [Lldb-commits] [lldb] r323450 - Use test-specific module caches to avoid stale header conflicts

st not actually running with > -fmodules in the -gmodules configuration. > > vedant > >> On Jan 25, 2018, at 12:40 PM, Davide Italiano wrote: >> >> The bot started failing recently, and this commit seems the most likely >> culprit. >> >> http://l

Re: [Lldb-commits] [lldb] r323450 - Use test-specific module caches to avoid stale header conflicts

n. >> >> vedant >> >>> On Jan 25, 2018, at 12:40 PM, Davide Italiano >> <mailto:dccitali...@gmail.com>> wrote: >>> >>> The bot started failing recently, and this commit seems the most likely >>> culprit. >>> >>>

[Lldb-commits] [lldb] r323467 - [test] Fix a test that never compiled under -fmodules

Author: vedantk Date: Thu Jan 25 13:20:29 2018 New Revision: 323467 URL: http://llvm.org/viewvc/llvm-project?rev=323467&view=rev Log: [test] Fix a test that never compiled under -fmodules This test #include's stdio.h, which, on at least two bots results in a module import of MacTypes.h (due to we

Re: [Lldb-commits] [lldb] r323450 - Use test-specific module caches to avoid stale header conflicts

gt;> It looks like we're picking up "struct Point" from /usr/include/MacTypes.h! >> >> vedant >> >> On Jan 25, 2018, at 1:02 PM, Vedant Kumar wrote: >> >> Taking a look. It may be another instance of a test not actually running >> with -fmod

Re: [Lldb-commits] [lldb] r323450 - Use test-specific module caches to avoid stale header conflicts

gt;point.x, ptr[i]->point.y); >>> >>> ~ ^ >>> 5 errors generated. >>> make: *** [main.o] Error 1 >>> >>> It looks like we're picking up "struct Point" from /usr/include/MacTypes.h! >>> >>> vedant >

[Lldb-commits] [lldb] r323723 - dotest: Apply --skip-categories to debug info categories

Author: vedantk Date: Mon Jan 29 19:36:00 2018 New Revision: 323723 URL: http://llvm.org/viewvc/llvm-project?rev=323723&view=rev Log: dotest: Apply --skip-categories to debug info categories Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified: lldb/trunk/packages/Python/

[Lldb-commits] [lldb] r323809 - PR25934: Skip EventAPITestCase. It still SEGV's on Darwin.

Author: vedantk Date: Tue Jan 30 11:49:05 2018 New Revision: 323809 URL: http://llvm.org/viewvc/llvm-project?rev=323809&view=rev Log: PR25934: Skip EventAPITestCase. It still SEGV's on Darwin. See: https://ci.swift.org/job/swift-lldb-PR-osx/39 llvm.org/PR25934 Modified: lldb/trunk/packages/

[Lldb-commits] [lldb] r323817 - XUnit Formatter: Handle UTF-8 decode errors on invalid XML

Author: vedantk Date: Tue Jan 30 13:16:42 2018 New Revision: 323817 URL: http://llvm.org/viewvc/llvm-project?rev=323817&view=rev Log: XUnit Formatter: Handle UTF-8 decode errors on invalid XML Strings which contain garbage data can trigger an exception in the XUnit plugin at the UTF-8 decode step

Re: [Lldb-commits] [lldb] r322339 - When parsing the target.xml register file, if no architecture has

Barring serious extenuating circumstances, an untested functional change in llvm is not complete. And as time goes on it becomes less and less likely that we'll revisit this. I think it's a good idea to revert this until there's a test. vedant > On Feb 6, 2018, at 7:42 AM, Davide Italiano via

Re: [Lldb-commits] [lldb] r324743 - [Testsuite] Remove leak tests, it's not useful anymore.

Nice! vedant > On Feb 9, 2018, at 8:06 AM, Davide Italiano via lldb-commits > wrote: > > Author: davide > Date: Fri Feb 9 08:06:39 2018 > New Revision: 324743 > > URL: http://llvm.org/viewvc/llvm-project?rev=324743&view=rev > Log: > [Testsuite] Remove leak tests, it's not useful anymore. >

[Lldb-commits] [lldb] r325068 - [cmake] Darwin: Copy in the system debugserver if needed

Author: vedantk Date: Tue Feb 13 15:05:46 2018 New Revision: 325068 URL: http://llvm.org/viewvc/llvm-project?rev=325068&view=rev Log: [cmake] Darwin: Copy in the system debugserver if needed This makes the built debugger functional on Darwin when compiling without code signing (as documented in d

Re: [Lldb-commits] [lldb] r325068 - [cmake] Darwin: Copy in the system debugserver if needed

@Davide I think you ran into this issue yesterday, let me know if this resolves it for you. vedant > On Feb 13, 2018, at 3:05 PM, Vedant Kumar via lldb-commits > wrote: > > Author: vedantk > Date: Tue Feb 13 15:05:46 2018 > New Revision: 325068 > > URL: http://llvm

Re: [Lldb-commits] [lldb] r325068 - [cmake] Darwin: Copy in the system debugserver if needed

mework, then it falls back to > using the one in the currently selected Xcode. We don't really need to copy > it if we just want to use the active system version? > >> On Feb 13, 2018, at 3:08 PM, Vedant Kumar via lldb-commits >> wrote: >> >> @Davide I think you

[Lldb-commits] [lldb] r325841 - [ObjC] Fix the NSConcreteData formatter and test it

Author: vedantk Date: Thu Feb 22 15:48:21 2018 New Revision: 325841 URL: http://llvm.org/viewvc/llvm-project?rev=325841&view=rev Log: [ObjC] Fix the NSConcreteData formatter and test it The length field of an NSConcreteData lives one word past the start of the object, not two. Modified: lld

[Lldb-commits] [lldb] r325847 - Delete some unused #includes of CleanUp.h, NFC

Author: vedantk Date: Thu Feb 22 16:29:40 2018 New Revision: 325847 URL: http://llvm.org/viewvc/llvm-project?rev=325847&view=rev Log: Delete some unused #includes of CleanUp.h, NFC Modified: lldb/trunk/source/Commands/CommandCompletions.cpp lldb/trunk/source/Host/common/Host.cpp lldb/

[Lldb-commits] [lldb] r325964 - [Utility] Simplify and generalize the CleanUp helper, NFC

Author: vedantk Date: Fri Feb 23 14:08:38 2018 New Revision: 325964 URL: http://llvm.org/viewvc/llvm-project?rev=325964&view=rev Log: [Utility] Simplify and generalize the CleanUp helper, NFC Removing the template arguments and most of the mutating methods from CleanUp makes it easier to understa

[Lldb-commits] [lldb] r325974 - Fix a compiler warning in ModuleCacheTest.cpp, NFC

Author: vedantk Date: Fri Feb 23 15:18:27 2018 New Revision: 325974 URL: http://llvm.org/viewvc/llvm-project?rev=325974&view=rev Log: Fix a compiler warning in ModuleCacheTest.cpp, NFC Modified: lldb/trunk/unittests/Target/ModuleCacheTest.cpp Modified: lldb/trunk/unittests/Target/ModuleCache

[Lldb-commits] [lldb] r326002 - Delete dead code in MachVMMemory.cpp, NFC

Author: vedantk Date: Fri Feb 23 16:17:05 2018 New Revision: 326002 URL: http://llvm.org/viewvc/llvm-project?rev=326002&view=rev Log: Delete dead code in MachVMMemory.cpp, NFC This addresses a compiler warning. Modified: lldb/trunk/tools/debugserver/source/MacOSX/MachVMMemory.cpp Modified:

[Lldb-commits] [lldb] r326001 - [unittests] Disable lldb-server tests if an external debug server is in use

Author: vedantk Date: Fri Feb 23 16:17:04 2018 New Revision: 326001 URL: http://llvm.org/viewvc/llvm-project?rev=326001&view=rev Log: [unittests] Disable lldb-server tests if an external debug server is in use The lldb-server unit tests don't test the right thing when the debug server in use is c

Re: [Lldb-commits] [lldb] r323803 - Compile the LLDB tests out-of-tree.

Hey Adrian, Did you mean to write cls.getBuildArtifact() here? I'm seeing a Python exception locally when I run check-lldb-single: Traceback (most recent call last): File "/Users/vsk/src/llvm.org-lldbsan/llvm/tools/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 584, in tearDownClass

Re: [Lldb-commits] [lldb] r323803 - Compile the LLDB tests out-of-tree.

Will test and commit momentarily, thanks! vedant > On Feb 28, 2018, at 6:47 PM, Adrian Prantl wrote: > > That looks reasonable, since this is a class method, yes. Thanks for spotting > it! Would you mind committing the change? > > -- adrian > >> On Feb 28, 2018, at 6:46 PM, Vedant Kumar >

[Lldb-commits] [lldb] r326414 - [test] Restore cleanup behavior in TestQuoting.py

Author: vedantk Date: Wed Feb 28 19:03:38 2018 New Revision: 326414 URL: http://llvm.org/viewvc/llvm-project?rev=326414&view=rev Log: [test] Restore cleanup behavior in TestQuoting.py Before the change to compile tests out-of-tree, the cleanup classmethod in TestQuoting.py would remove a temp fil

Re: [Lldb-commits] [lldb] r323803 - Compile the LLDB tests out-of-tree.

Done, r326414 > On Feb 28, 2018, at 6:48 PM, Vedant Kumar wrote: > > Will test and commit momentarily, thanks! > > vedant > >> On Feb 28, 2018, at 6:47 PM, Adrian Prantl > > wrote: >> >> That looks reasonable, since this is a class method, yes. Thanks for >> spottin

Re: [Lldb-commits] [lldb] r326552 - [testsuite] Remove workaround for categories and inline tests.

Thanks for taking care of this! vedant > On Mar 2, 2018, at 2:38 AM, Jonas Devlieghere via lldb-commits > wrote: > > Author: jdevlieghere > Date: Fri Mar 2 02:38:11 2018 > New Revision: 326552 > > URL: http://llvm.org/viewvc/llvm-project?rev=326552&view=rev > Log: > [testsuite] Remove workar

[Lldb-commits] [lldb] r326739 - [test] Skip pexpect-based lldb-mi tests on Darwin

Author: vedantk Date: Mon Mar 5 12:16:52 2018 New Revision: 326739 URL: http://llvm.org/viewvc/llvm-project?rev=326739&view=rev Log: [test] Skip pexpect-based lldb-mi tests on Darwin These tests fail with a relatively frequently on Darwin machines with errors such as: File ".../lldb/third_par

[Lldb-commits] [lldb] r327052 - [test] Skip a test when using an out-of-tree debugserver

Author: vedantk Date: Thu Mar 8 11:46:39 2018 New Revision: 327052 URL: http://llvm.org/viewvc/llvm-project?rev=327052&view=rev Log: [test] Skip a test when using an out-of-tree debugserver The test "test_fp_special_purpose_register_read" in TestRegisters.py fails on Darwin machines configured t

[Lldb-commits] [lldb] r327089 - [test] Skip a test which sporadically fails in its dsym variant

Author: vedantk Date: Thu Mar 8 16:34:43 2018 New Revision: 327089 URL: http://llvm.org/viewvc/llvm-project?rev=327089&view=rev Log: [test] Skip a test which sporadically fails in its dsym variant There is a mailing list discussion re: r325927 about why this test fails in the dsym variant. I've

Re: [Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

I've gone ahead and skipped this test for the dsym variant until this is resolved. r327089. vedant > On Mar 8, 2018, at 10:49 AM, Davide Italiano via lldb-commits > wrote: > > On Thu, Mar 8, 2018 at 10:46 AM, Jim Ingham wrote: >> >> >>> On Mar 8, 2018, at 2:49 AM, Pavel Labath wrote: >>>

Re: [Lldb-commits] [lldb] r327318 - Improve prologue handling to support functions with multiple entry points.

Hi Jim, I think this breaks the Xcode bot: http://green.lab.llvm.org/green/job/lldb-xcode/5430/ . The CMake build looks broken too. Mind taking a look or reverting? CompileC build/lldb.build/Release/lldb-core.build/Objects-normal/x86_64/Ar

[Lldb-commits] [lldb] r327327 - Revert "Improve prologue handling to support functions with multiple entry points."

Author: vedantk Date: Mon Mar 12 13:35:33 2018 New Revision: 327327 URL: http://llvm.org/viewvc/llvm-project?rev=327327&view=rev Log: Revert "Improve prologue handling to support functions with multiple entry points." This reverts commit r327318. It breaks the Xcode and CMake Darwin builders: c

Re: [Lldb-commits] [lldb] r327318 - Improve prologue handling to support functions with multiple entry points.

I needed to revert this in r327327 to get the bots going again. vedant > On Mar 12, 2018, at 1:26 PM, Vedant Kumar via lldb-commits > wrote: > > Hi Jim, > > I think this breaks the Xcode bot: > http://green.lab.llvm.org/green/job/lldb-xcode/5430/ > <http://green.

  1   2   3   >