Where clang stores modules by default on the host system seems like a Host
function. It isn't in practice because that gets delegated to clang to do the
host specific calculation, but in theory that seems where the functionality
properly belongs. It's a little odd to have ModuleList depend on
We've been going to a lot of effort recently to separate out dependencies
and properly layer libraries. Even if we deemed this to be an acceptable
location to #include something from clang/Driver, the CMake does not
actually reference clangDriver in its link list. So the only reason this
is worki
Can you help me understand why this dependency poses a problem? It's not clear
to me how to resolve this otherwise. The point of the patch is to ask the clang
driver for the clang module cache path. If the problem is that we otherwise
don't use the driver and now pull it in, would moving the Cla
zturner added subscribers: aprantl, labath, zturner.
zturner added a comment.
This change has introduced a dependency from Core -> clang Driver (due to
#include "clang/Driver/Driver.h" in ModuleList.cpp). Can you please try to
find a way to remove this dependency?
Repository:
rL LLVM
https:/
This change has introduced a dependency from Core -> clang Driver (due to
#include "clang/Driver/Driver.h" in ModuleList.cpp). Can you please try to
find a way to remove this dependency?
On Fri, Mar 2, 2018 at 2:45 PM Phabricator via Phabricator via lldb-commits
wrote:
> This revision was not a
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326628: Make the clang module cache setting available
without a target (authored by adrian, committed by ).
Herald added a
aprantl updated this revision to Diff 136803.
aprantl added a comment.
Added a testcase.
https://reviews.llvm.org/D43984
Files:
include/lldb/Core/ModuleList.h
include/lldb/Target/Target.h
packages/Python/lldbsuite/test/lang/objc/modules-cache/Makefile
packages/Python/lldbsuite/test/lan
aprantl added a comment.
The entire testsuite depends on being able to set this option (see the change
in `packages/Python/lldbsuite/test/lldbtest.py`), but we don't verify that the
directory is being used. I'll see if I can come up with a dedicated test.
https://reviews.llvm.org/D43984
___
jingham added a comment.
This looks fine. Did you have a way to test it?
https://reviews.llvm.org/D43984
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aprantl created this revision.
aprantl added a reviewer: jingham.
It turns out that setting the clang module cache after LLDB has a Target can be
too late. In particular, the Swift language plugin needs to know the setting
without having access to a Target. This patch moves the setting into the
10 matches
Mail list logo