This revision was automatically updated to reflect the committed changes.
Closed by commit rL347716: [Reproducers] Improve reproducer API and add unit
tests. (authored by JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54616/new/
https://reviews.llvm.org/D54616
___
lldb-commits mailing list
labath added a comment.
I haven't been following the reproducer work in detail, but this seems
reasonable to me. Thanks for incorporating my drive-by suggestions.
Comment at: include/lldb/Utility/Reproducer.h:104
+ template T *Create() {
+std::unique_ptr provider(new
JDevlieghere added a comment.
Does anybody want to have another look or can I land this?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54616/new/
https://reviews.llvm.org/D54616
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
JDevlieghere updated this revision to Diff 175293.
JDevlieghere marked 6 inline comments as done.
JDevlieghere added a comment.
Thanks Pavel, really useful feedback, I learned a few new things :-)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54616/new/
https://reviews.llvm.org/D54616
labath added inline comments.
Comment at: include/lldb/Utility/Reproducer.h:59-64
+ void InitializeFileInfo(llvm::StringRef name,
+ llvm::ArrayRef files) {
+m_info.name = name;
+for (auto file : files)
+ m_info.files.push_back(file);
+ }
JDevlieghere updated this revision to Diff 174416.
https://reviews.llvm.org/D54616
Files:
include/lldb/API/SBDebugger.h
include/lldb/Core/Debugger.h
include/lldb/Utility/Reproducer.h
scripts/interface/SBDebugger.i
source/API/SBDebugger.cpp
source/Commands/CommandObjectReproducer.cpp
JDevlieghere updated this revision to Diff 174407.
JDevlieghere added a comment.
Simplify code a little, as per Stefan's (offline) suggestion.
https://reviews.llvm.org/D54616
Files:
include/lldb/API/SBDebugger.h
include/lldb/Utility/Reproducer.h
scripts/interface/SBDebugger.i
JDevlieghere updated this revision to Diff 174399.
JDevlieghere marked an inline comment as done.
JDevlieghere added a comment.
Missed a comment; fixed now.
https://reviews.llvm.org/D54616
Files:
include/lldb/API/SBDebugger.h
include/lldb/Utility/Reproducer.h
JDevlieghere updated this revision to Diff 174398.
JDevlieghere marked 4 inline comments as done.
JDevlieghere added a comment.
Address Stefan's review feedback.
https://reviews.llvm.org/D54616
Files:
include/lldb/API/SBDebugger.h
include/lldb/Utility/Reproducer.h
sgraenitz added a comment.
Looks pretty good to me, but added my 2¢ on minor things.
Comment at: include/lldb/Utility/Reproducer.h:169
+ llvm::Error SetCapture(bool value, FileSpec root = {});
+ llvm::Error SetReplay(bool value, FileSpec root = {});
Are
JDevlieghere created this revision.
JDevlieghere added reviewers: davide, shafik, friss, jingham.
JDevlieghere added a project: LLDB.
Herald added subscribers: abidh, mgorny.
When I landed the initial reproducer framework I knew there were some things
that needed improvement. Rather than
12 matches
Mail list logo
