[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

This revision was automatically updated to reflect the committed changes. Closed by commit rG8aea95f3cb4e: [lldb] Reland Use translated full ftag values (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D91504?vs=306647=306849#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

mgorny updated this revision to Diff 306647. mgorny added a comment. Skipped python test on non-Darwin, xfailed shell test on Darwin, added respective comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91504/new/ https://reviews.llvm.org/D91504 Files:

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

mgorny added a comment. In D91504#2407397 , @labath wrote: > Well... I think that will make the test fail on mac, as debugserver hasn't > been updated. > > This test comes from D12592 , and is > actually serves a very

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

labath added a comment. Well... I think that will make the test fail on mac, as debugserver hasn't been updated. This test comes from D12592 , and is actually serves a very similar purpose to the test you just wrote. Normally, I would say we don't need both of

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

mgorny reopened this revision. mgorny added a comment. This revision is now accepted and ready to land. Does this change to TestRegister.py look good? It makes the test pass for me (and seems logically correct). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91504/new/

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

mgorny updated this revision to Diff 306403. mgorny added a comment. Update TestRegisters.py. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91504/new/ https://reviews.llvm.org/D91504 Files: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

mgorny added a comment. In D91504#2405504 , @goncharov wrote: > Hi @mgorny! http://lab.llvm.org:8011/#/builders/68/builds/2298 build failed. > Could you please fix the test? I'm sorry about that. I'll look into it. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

goncharov added a comment. Herald added a subscriber: JDevlieghere. Hi @mgorny! http://lab.llvm.org:8011/#/builders/68/builds/2298 build failed. Could you please fix the test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91504/new/

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

This revision was automatically updated to reflect the committed changes. Closed by commit rGc43abf043692: [lldb] Use translated full ftag values (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. ship it CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91504/new/ https://reviews.llvm.org/D91504 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

mgorny updated this revision to Diff 306360. mgorny added a comment. Declare `MMSRegComp` type explicitly to avoid warnings: In file included from /home/mgorny/llvm-project/llvm/tools/lldb/source/Plugins/Process/Utility/RegisterContextLinux_x86_64.cpp:11: In file included from

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

mgorny updated this revision to Diff 306356. mgorny marked an inline comment as done. mgorny added a comment. Simplified FreeBSD & Linux code as @labath suggested. Also added the scope thingy to tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91504/new/

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

mgorny marked 4 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:537 +uint16_t sw = m_xstate->fxsave.fstat; +llvm::ArrayRef st_regs{m_xstate->fxsave.stmm, 8}; +

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

labath added a comment. Looks good. Some minor questions inline. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:523 + case DBRegSet: { +uint8_t *data = GetOffsetRegSetData(set, reg_info->byte_offset); +FXSAVE *fpr =

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

mgorny updated this revision to Diff 306159. mgorny retitled this revision from "[lldb] Use translated full ftag values [WIP]" to "[lldb] Use translated full ftag values". mgorny added a comment. Updated Linux to use pointer comparison and FreeBSD. It's ready for review now, though I'd use a

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values [WIP]

labath added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:534 + // TODO + if (reg_info->kinds[lldb::eRegisterKindLLDB] == lldb_ftag_x86_64) { +uint8_t abridged_tw = *(uint8_t *)src; mgorny wrote: >

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values [WIP]

mgorny updated this revision to Diff 305545. mgorny added a comment. Port NetBSD plugin. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91504/new/ https://reviews.llvm.org/D91504 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values [WIP]

mgorny updated this revision to Diff 305536. mgorny added a comment. Move the functions into a new file, add comment, use `llvm::ArrayRef`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91504/new/ https://reviews.llvm.org/D91504 Files:

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values [WIP]

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:534 + // TODO + if (reg_info->kinds[lldb::eRegisterKindLLDB] == lldb_ftag_x86_64) { +uint8_t abridged_tw = *(uint8_t *)src; labath wrote: >

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values [WIP]

labath added a comment. Looks reasonable to me. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:534 + // TODO + if (reg_info->kinds[lldb::eRegisterKindLLDB] == lldb_ftag_x86_64) { +uint8_t abridged_tw = *(uint8_t *)src;

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values [WIP]

mgorny added a comment. I'll port to other platforms once we agree on the approach. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:534 + // TODO + if (reg_info->kinds[lldb::eRegisterKindLLDB] == lldb_ftag_x86_64) { +uint8_t

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values [WIP]

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. mgorny requested review of this revision. Translate between abridged and full ftag values in order to expose the latter in the gdb-remote protocol while the former are used by FXSAVE/XSAVE... This matches the gdb