Re: [lldb-dev] RFC: Eliminate LLDB_DISABLE_PYTHON

2019-03-07 Thread Adrian McCarthy via lldb-dev
OK, thanks all for the discussion. I'll try to fix the immediate problems (the build breakage and the Python detection). If I get more ambitious, I'll make another proposal. On Thu, Mar 7, 2019 at 12:55 PM Zachary Turner wrote: > Yes, Pavel pointed out one specific case where it is used, and

Re: [lldb-dev] RFC: Eliminate LLDB_DISABLE_PYTHON

2019-03-07 Thread Zachary Turner via lldb-dev
Yes, Pavel pointed out one specific case where it is used, and that case definitely needs to be supported. We've talked in the past about fixing the layering in such a way that all Python related code is in ScriptInterpreterPython, but there's definitely a non-trivial amount of work needed to

Re: [lldb-dev] RFC: Eliminate LLDB_DISABLE_PYTHON

2019-03-07 Thread Jim Ingham via lldb-dev
> On Mar 7, 2019, at 11:37 AM, Zachary Turner wrote: > > > > On Thu, Mar 7, 2019 at 11:03 AM Jim Ingham via lldb-dev > wrote: > Even though you can just use debugserver/lldb-server and debug remotely, many > people find it handy to be able to run a debugger directly on the device they >

Re: [lldb-dev] RFC: Eliminate LLDB_DISABLE_PYTHON

2019-03-07 Thread Pavel Labath via lldb-dev
On 07/03/2019 20:52, Zachary Turner wrote: Does lldb-server for Android currently use this flag?  I was under the impression it just linked against Python anyway. No, it doesn't link against python. In fact, when targetting android, we default to disabling all external dependencies.

Re: [lldb-dev] RFC: Eliminate LLDB_DISABLE_PYTHON

2019-03-07 Thread Nat! via lldb-dev
I second this opinion and have really not much further to add, except maybe that just yesterday to my delight I actually discovered this option and now promptly use it as the default when building my debugger variant. It removed a lot of python warnings when running my handbuilt lldb on

Re: [lldb-dev] RFC: Eliminate LLDB_DISABLE_PYTHON

2019-03-07 Thread Zachary Turner via lldb-dev
Does lldb-server for Android currently use this flag? I was under the impression it just linked against Python anyway. On Thu, Mar 7, 2019 at 11:50 AM Pavel Labath via lldb-dev < lldb-dev@lists.llvm.org> wrote: > On 07/03/2019 20:29, Davide Italiano via lldb-dev wrote: > > I'm in favor of this.

Re: [lldb-dev] RFC: Eliminate LLDB_DISABLE_PYTHON

2019-03-07 Thread Pavel Labath via lldb-dev
On 07/03/2019 20:29, Davide Italiano via lldb-dev wrote: I'm in favor of this. FWIW, I will be surprised if lldb works at all with that option. I would actually be also surprised if it works. However, the option I think is important to keep is to be able to build lldb-server without python

Re: [lldb-dev] RFC: Eliminate LLDB_DISABLE_PYTHON

2019-03-07 Thread Zachary Turner via lldb-dev
On Thu, Mar 7, 2019 at 11:03 AM Jim Ingham via lldb-dev < lldb-dev@lists.llvm.org> wrote: > Even though you can just use debugserver/lldb-server and debug remotely, > many people find it handy to be able to run a debugger directly on the > device they are using. But requiring that you port

Re: [lldb-dev] RFC: Eliminate LLDB_DISABLE_PYTHON

2019-03-07 Thread Pavel Labath via lldb-dev
On 07/03/2019 19:27, Adrian McCarthy via lldb-dev wrote: We have a build option to build LLDB without Python.  This option is automatically set if Cmake can't find or "validate" your Python distribution. Since LLDB is rarely built with this option, nobody discovers when this configuration

Re: [lldb-dev] RFC: Eliminate LLDB_DISABLE_PYTHON

2019-03-07 Thread Davide Italiano via lldb-dev
I'm in favor of this. FWIW, I will be surprised if lldb works at all with that option. On Thu, Mar 7, 2019 at 10:28 AM Adrian McCarthy via lldb-dev wrote: > > We have a build option to build LLDB without Python. This option is > automatically set if Cmake can't find or "validate" your Python

Re: [lldb-dev] RFC: Eliminate LLDB_DISABLE_PYTHON

2019-03-07 Thread Jim Ingham via lldb-dev
Even though you can just use debugserver/lldb-server and debug remotely, many people find it handy to be able to run a debugger directly on the device they are using. But requiring that you port Python and bundle it with your embedded platform just to get a debugger there is a pretty big ask.

[lldb-dev] RFC: Eliminate LLDB_DISABLE_PYTHON

2019-03-07 Thread Adrian McCarthy via lldb-dev
We have a build option to build LLDB without Python. This option is automatically set if Cmake can't find or "validate" your Python distribution. Since LLDB is rarely built with this option, nobody discovers when this configuration breaks. For example, if you try it today, you'll get a handful