Re: [lldb-dev] Failure connecting to lldb-server running in local virtual machine.

2017-02-21 Thread Howard Hellyer via lldb-dev
Greg Clayton wrote on 16/02/2017 17:17:41: > We seem to have a race condition here. Any help figuring out what > that might be would be great. I think I've now identified the problem. Normally in lldb-server when the child lldb-server process is launched inside

Re: [lldb-dev] About lldbHost

2017-02-21 Thread Greg Clayton via lldb-dev
> On Feb 21, 2017, at 1:47 PM, Zachary Turner wrote: > > > > On Wed, Feb 15, 2017 at 11:02 AM Greg Clayton > wrote: > > The other thing is on Mac we add new flags to mmap that allow us not to crash > if the backing store

Re: [lldb-dev] Too many ModuleSP references

2017-02-21 Thread Greg Clayton via lldb-dev
> On Feb 21, 2017, at 9:10 AM, Zachary Turner via lldb-dev > wrote: > > No comments on this specifically, but +1 to reducing shared_ptr usage in > general. We use way too many, and often it feels like shared_ptr is used as a > way to avoid having to think about

Re: [lldb-dev] Too many ModuleSP references

2017-02-21 Thread Jim Ingham via lldb-dev
> On Feb 21, 2017, at 4:24 PM, Greg Clayton via lldb-dev > wrote: > >> - StepOverBreakpointTestCase: Have the test not store the breakpoints >> in the test case object. Basically, declare that this is not a bug, >> and it's the users responsibility to clean up

Re: [lldb-dev] Too many ModuleSP references

2017-02-21 Thread Greg Clayton via lldb-dev
> On Feb 21, 2017, at 9:36 AM, Jim Ingham via lldb-dev > wrote: > > Thanks for digging into this. > > Maybe a better option would be to have IRExecutionUnit hold a > SymbolContextScope, rather than a SymbolContext. We started out with > SymbolContext's because they

Re: [lldb-dev] Too many ModuleSP references

2017-02-21 Thread Zachary Turner via lldb-dev
On Tue, Feb 21, 2017 at 4:24 PM Greg Clayton via lldb-dev < lldb-dev@lists.llvm.org> wrote: > On Feb 21, 2017, at 9:10 AM, Zachary Turner via lldb-dev < > lldb-dev@lists.llvm.org> wrote: > > No comments on this specifically, but +1 to reducing shared_ptr usage in > general. We use way too many,

Re: [lldb-dev] Too many ModuleSP references

2017-02-21 Thread Jim Ingham via lldb-dev
> On Feb 21, 2017, at 4:49 PM, Jim Ingham via lldb-dev > wrote: > > >> On Feb 21, 2017, at 4:24 PM, Greg Clayton via lldb-dev >> wrote: >> >>> - StepOverBreakpointTestCase: Have the test not store the breakpoints >>> in the test case

Re: [lldb-dev] Debugging ELF relocatable files using LLDB

2017-02-21 Thread Ramana via lldb-dev
On Thu, Feb 16, 2017 at 10:26 PM, Greg Clayton wrote: > > On Feb 16, 2017, at 3:51 AM, Ramana via lldb-dev > wrote: > > It looks like LLDB doesn't like ELF relocatable files for debugging > and asserts with the following message when tried > >

Re: [lldb-dev] Too many ModuleSP references

2017-02-21 Thread Jim Ingham via lldb-dev
> On Feb 21, 2017, at 4:26 PM, Greg Clayton wrote: > >> >> On Feb 21, 2017, at 9:36 AM, Jim Ingham via lldb-dev >> wrote: >> >> Thanks for digging into this. >> >> Maybe a better option would be to have IRExecutionUnit hold a >>

Re: [lldb-dev] About lldbHost

2017-02-21 Thread Zachary Turner via lldb-dev
(Correction: I just double checked and the bug is not present in LLDB) On Tue, Feb 21, 2017 at 2:05 PM Zachary Turner wrote: > I bet that's it. The 4 failing tests are: > > LLVM-Unit.Support/SupportTests.FileOutputBuffer.Test >

Re: [lldb-dev] About lldbHost

2017-02-21 Thread Zachary Turner via lldb-dev
I bet that's it. The 4 failing tests are: LLVM-Unit.Support/SupportTests.FileOutputBuffer.Test LLVM-Unit.Support/SupportTests.FileSystemTest.FileMapping LLVM.DebugInfo/PDB.pdbdump-readwrite.test LLVM.DebugInfo/PDB.pdbdump-write.test All of which appear to be related to writing. It looks

Re: [lldb-dev] Too many ModuleSP references

2017-02-21 Thread Jim Ingham via lldb-dev
Thanks for digging into this. Maybe a better option would be to have IRExecutionUnit hold a SymbolContextScope, rather than a SymbolContext. We started out with SymbolContext's because they were convenient but they hold too many things alive so when we run into SymbolContext's we've been

Re: [lldb-dev] About lldbHost

2017-02-21 Thread Zachary Turner via lldb-dev
On Wed, Feb 15, 2017 at 11:02 AM Greg Clayton wrote: > > The other thing is on Mac we add new flags to mmap that allow us not to > crash if the backing store (network mount) goes away. There is also a flag > that says "if code signature is borked, please still allow me to

Re: [lldb-dev] Too many ModuleSP references

2017-02-21 Thread Zachary Turner via lldb-dev
No comments on this specifically, but +1 to reducing shared_ptr usage in general. We use way too many, and often it feels like shared_ptr is used as a way to avoid having to think about ownership, which leads to more problems than it solves imo On Tue, Feb 21, 2017 at 9:03 AM Pavel Labath via

[lldb-dev] Too many ModuleSP references

2017-02-21 Thread Pavel Labath via lldb-dev
Hello all, I've been debugging the newly added TestStepOverBreakpoint.py, which has been failing on windows, for a very prosaic reason: after the test completes, we are unable to run "make clean" because lldb still holds the file open. After some debugging, I've found that this happens because