[llvm-branch-commits] [clang] release/20.x: [PAC] Do not support some values of branch-protection with ptrauth-returns (#125280) (PR #126589)

https://github.com/kovdan01 approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/126589 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-c

[llvm-branch-commits] [clang] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin or with pauthtest ABI (PR #113152)

@@ -15,50 +16,85 @@ // RUN: -fno-ptrauth-indirect-gotos -fptrauth-indirect-gotos \ // RUN: -fno-ptrauth-init-fini -fptrauth-init-fini \ // RUN: -fno-ptrauth-init-fini-address-discrimination -fptrauth-init-fini-address-discrimination \ +// RUN: -fno-ptrauth-elf-got -fpt

[llvm-branch-commits] [clang] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin or with pauthtest ABI (PR #113152)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113152 >From 0caff13d6748f8c2d14608412db80eb5bba5fe71 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024 12:18:56 +0300 Subject: [PATCH 1/7] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin

[llvm-branch-commits] [clang] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin or with pauthtest ABI (PR #113152)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113152 >From 0caff13d6748f8c2d14608412db80eb5bba5fe71 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024 12:18:56 +0300 Subject: [PATCH 1/6] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin

[llvm-branch-commits] [clang] [PAC][clang] Handle pauthtest environment and ABI in Linux-specific code (PR #113151)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113151 >From 74c5de129cd4a1e90463aa9ad05b1b90bd3ff981 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024 12:00:19 +0300 Subject: [PATCH] [PAC][clang] Handle pauthtest environment and ABI in Linux-sp

[llvm-branch-commits] [clang] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin or with pauthtest ABI (PR #113152)

https://github.com/kovdan01 edited https://github.com/llvm/llvm-project/pull/113152 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed GOT with tiny code model (PR #113816)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113816 >From 67683bb9c119d98ba8e57c2a51a3df113a5fe562 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 21:28:18 +0300 Subject: [PATCH 01/10] [PAC][lld][AArch64][ELF] Support signed GOT with tiny c

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113817 >From bddd8de9f922790a63237cc581df37c6f7fc4464 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 12:32:27 +0300 Subject: [PATCH 01/11] [PAC][lld][AArch64][ELF] Support signed TLSDESC Support

[llvm-branch-commits] [clang] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin or with pauthtest ABI (PR #113152)

kovdan01 wrote: @MaskRay Previous comments should now be addressed, would be glad to see your feedback on the new version of the PR https://github.com/llvm/llvm-project/pull/113152 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.or

[llvm-branch-commits] [clang] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin or with pauthtest ABI (PR #113152)

@@ -1808,34 +1808,6 @@ void Clang::AddAArch64TargetArgs(const ArgList &Args, AddUnalignedAccessWarning(CmdArgs); - Args.addOptInFlag(CmdArgs, options::OPT_fptrauth_intrinsics, kovdan01 wrote: @MaskRay Applied your suggestion in 346d1ef9d0d638ddda2b48a9c62

[llvm-branch-commits] [clang] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin or with pauthtest ABI (PR #113152)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113152 >From 1914833e15a81ee85aea3a6e1bed2b88a338d3e7 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024 12:18:56 +0300 Subject: [PATCH 1/5] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin

[llvm-branch-commits] [clang] [PAC][clang] Handle pauthtest environment and ABI in Linux-specific code (PR #113151)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113151 >From 491c4551aababde147705d1bea649cffded7d325 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024 12:00:19 +0300 Subject: [PATCH] [PAC][clang] Handle pauthtest environment and ABI in Linux-sp

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113817 >From f2dc47f188eb68bb53bb60d85d3d617bcf90d823 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 12:32:27 +0300 Subject: [PATCH 01/10] [PAC][lld][AArch64][ELF] Support signed TLSDESC Support

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed GOT with tiny code model (PR #113816)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113816 >From ec3a34c2cb55f3179739c2c068e1c3d1c1de5b9a Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 21:28:18 +0300 Subject: [PATCH 01/10] [PAC][lld][AArch64][ELF] Support signed GOT with tiny c

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed GOT with tiny code model (PR #113816)

@@ -77,6 +77,60 @@ _start: adrp x1, :got_auth:zed add x1, x1, :got_auth_lo12:zed +#--- ok-tiny.s +# RUN: llvm-mc -filetype=obj -triple=aarch64 ok-tiny.s -o ok-tiny.o + +# RUN: ld.lld ok-tiny.o a.so -pie -o external-tiny +# RUN: llvm-readelf -r -S -x .got external-tiny | F

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113817 >From e903e06eb6cfccfd65964ada48081e2ae1b2befd Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 12:32:27 +0300 Subject: [PATCH 01/10] [PAC][lld][AArch64][ELF] Support signed TLSDESC Support

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed GOT with tiny code model (PR #113816)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113816 >From de7feb154caec76b1ddf705689d1e7e8b4b2c491 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 21:28:18 +0300 Subject: [PATCH 1/9] [PAC][lld][AArch64][ELF] Support signed GOT with tiny cod

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

https://github.com/kovdan01 edited https://github.com/llvm/llvm-project/pull/113817 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

kovdan01 wrote: @MaskRay would be glad to see your feedback on this https://github.com/llvm/llvm-project/pull/113817 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-com

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113817 >From 717771ed63181be2935137304842c27f621acefd Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 12:32:27 +0300 Subject: [PATCH 01/10] [PAC][lld][AArch64][ELF] Support signed TLSDESC Support

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed GOT with tiny code model (PR #113816)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113816 >From e56c23349f6a25e69cc5c61977c24b774c7a4e80 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 21:28:18 +0300 Subject: [PATCH 1/8] [PAC][lld][AArch64][ELF] Support signed GOT with tiny cod

[llvm-branch-commits] [clang] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin or with pauthtest ABI (PR #113152)

@@ -1808,34 +1808,6 @@ void Clang::AddAArch64TargetArgs(const ArgList &Args, AddUnalignedAccessWarning(CmdArgs); - Args.addOptInFlag(CmdArgs, options::OPT_fptrauth_intrinsics, kovdan01 wrote: > You can make these options TargetSpecific and only handle the

[llvm-branch-commits] [clang] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin or with pauthtest ABI (PR #113152)

@@ -543,12 +543,59 @@ static void handlePAuthABI(const Driver &D, const ArgList &DriverArgs, CC1Args.push_back("-faarch64-jump-table-hardening"); } +static void addPointerAuthFlags(const llvm::opt::ArgList &DriverArgs, kovdan01 wrote: Thanks for suggesti

[llvm-branch-commits] [clang] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin or with pauthtest ABI (PR #113152)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113152 >From db5e43b4170da9317be16e7dba18ad54f1b6ae9f Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024 12:18:56 +0300 Subject: [PATCH 1/4] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin

[llvm-branch-commits] [clang] [PAC][clang] Handle pauthtest environment and ABI in Linux-specific code (PR #113151)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113151 >From de4d000713f190c7bebada8cc228edc3770d6401 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024 12:00:19 +0300 Subject: [PATCH] [PAC][clang] Handle pauthtest environment and ABI in Linux-sp

[llvm-branch-commits] [clang] [PAC][clang] Handle pauthtest environment and ABI in Linux-specific code (PR #113151)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113151 >From 4ff3cdb5c1ee4f45f0b7606c36fd5163335868c0 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024 12:00:19 +0300 Subject: [PATCH] [PAC][clang] Handle pauthtest environment and ABI in Linux-sp

[llvm-branch-commits] [clang] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin or with pauthtest ABI (PR #113152)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113152 >From f435790b75909026e22d8422d368202b7b5be4c9 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024 12:18:56 +0300 Subject: [PATCH 1/3] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed GOT with tiny code model (PR #113816)

https://github.com/kovdan01 edited https://github.com/llvm/llvm-project/pull/113816 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed GOT with tiny code model (PR #113816)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113816 >From 8f3005f33d0945f066b4abbc0fb715687fce94b2 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 21:28:18 +0300 Subject: [PATCH 1/7] [PAC][lld][AArch64][ELF] Support signed GOT with tiny cod

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113817 >From 67e828f807bd60535d242e534ae5427fccdb9237 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 12:32:27 +0300 Subject: [PATCH 1/9] [PAC][lld][AArch64][ELF] Support signed TLSDESC Support `

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed GOT with tiny code model (PR #113816)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113816 >From f061ec8df5648bdff25e0278075ad515e681b698 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 21:28:18 +0300 Subject: [PATCH 1/7] [PAC][lld][AArch64][ELF] Support signed GOT with tiny cod

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113817 >From ca216cb4ecf6bc1bac57b228c49d5d7d62d26b38 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 12:32:27 +0300 Subject: [PATCH 1/9] [PAC][lld][AArch64][ELF] Support signed TLSDESC Support `

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113817 >From 8c57e4cf99d7517079df09135f155e16cfe58e21 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 12:32:27 +0300 Subject: [PATCH 1/9] [PAC][lld][AArch64][ELF] Support signed TLSDESC Support `

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed GOT with tiny code model (PR #113816)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113816 >From 6aced2afcc1a97719464024ada75da2c47994ca8 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 21:28:18 +0300 Subject: [PATCH 1/7] [PAC][lld][AArch64][ELF] Support signed GOT with tiny cod

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

@@ -92,6 +92,10 @@ enum RelExpr { R_AARCH64_PAGE_PC, R_AARCH64_RELAX_TLS_GD_TO_IE_PAGE_PC, R_AARCH64_TLSDESC_PAGE, + R_AARCH64_AUTH_TLSDESC_PAGE, + // TODO: maybe it's better to rename this expression + // to avoid name conflict with dynamic reloc + R_AARCH64_AUTH_TLS

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed GOT with tiny code model (PR #113816)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113816 >From 6aced2afcc1a97719464024ada75da2c47994ca8 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 21:28:18 +0300 Subject: [PATCH 1/6] [PAC][lld][AArch64][ELF] Support signed GOT with tiny cod

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113817 >From 8c57e4cf99d7517079df09135f155e16cfe58e21 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 12:32:27 +0300 Subject: [PATCH 1/8] [PAC][lld][AArch64][ELF] Support signed TLSDESC Support `

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

kovdan01 wrote: @MaskRay would be glad to see your feedback on this https://github.com/llvm/llvm-project/pull/113817 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-com

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113817 >From a3cb7c88370a9aea7f276ebd39a548ff64abf6cc Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 12:32:27 +0300 Subject: [PATCH 1/7] [PAC][lld][AArch64][ELF] Support signed TLSDESC Support `

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed GOT with tiny code model (PR #113816)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113816 >From ddbd738fcc401c79ed597ed5ea5086af7c83ae0c Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 21:28:18 +0300 Subject: [PATCH 1/4] [PAC][lld][AArch64][ELF] Support signed GOT with tiny cod

[llvm-branch-commits] [clang] [PAC][clang] Handle pauthtest environment and ABI in Linux-specific code (PR #113151)

kovdan01 wrote: @MaskRay Would be glad to see your feedback on the changes https://github.com/llvm/llvm-project/pull/113151 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bra

[llvm-branch-commits] [clang] [PAC][clang] Add new features to pauthtest ABI (PR #113150)

kovdan01 wrote: @MaskRay Would be glad to see your feedback on the changes https://github.com/llvm/llvm-project/pull/113150 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bra

[llvm-branch-commits] [clang] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin or with pauthtest ABI (PR #113152)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113152 >From 5d32f1c80a0a239f2e2f40a54f4b1bfcd65ff195 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024 12:18:56 +0300 Subject: [PATCH 1/3] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin

[llvm-branch-commits] [clang] [PAC][clang] Handle pauthtest environment and ABI in Linux-specific code (PR #113151)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113151 >From 9d722052269875eb958edd9b4b8d5f42cd418bc1 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024 12:00:19 +0300 Subject: [PATCH] [PAC][clang] Handle pauthtest environment and ABI in Linux-sp

[llvm-branch-commits] [clang] [PAC][clang] Add new features to pauthtest ABI (PR #113150)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113150 >From 3de3592e51d05cfd3ab839b0cb20d0e40a5c157a Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024 10:58:04 +0300 Subject: [PATCH] [PAC][clang] Add new features to pauthtest ABI Enable init/fi

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed GOT with tiny code model (PR #113816)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113816 >From 881722580399908ad2d42d9aea3423783251706b Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 21:28:18 +0300 Subject: [PATCH 1/3] [PAC][lld][AArch64][ELF] Support signed GOT with tiny cod

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

kovdan01 wrote: @MaskRay Would be glad to see your feedback on the changes https://github.com/llvm/llvm-project/pull/113817 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bra

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113817 >From 17efa983ef782960545d33200d4a0e9f6ccf3af5 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 12:32:27 +0300 Subject: [PATCH 1/5] [PAC][lld][AArch64][ELF] Support signed TLSDESC Support `

[llvm-branch-commits] [clang] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin or with pauthtest ABI (PR #113152)

https://github.com/kovdan01 edited https://github.com/llvm/llvm-project/pull/113152 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin (PR #113152)

kovdan01 wrote: > I think we'd need to keep driver flags for `pauthtest` ABI as the intention > is to enable easier bringup of pointer authentication ABI on a new target @asl Thanks for suggestion, addressed in 515574c415b7d9814d7942c7609095dcb3e7916a, and updated the PR description correspon

[llvm-branch-commits] [clang] [PAC][clang] Handle pauthtest environment and ABI in Linux-specific code (PR #113151)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113151 >From c4de0f5cbbc35bee65aae9d0f3a71619b6b45280 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024 12:00:19 +0300 Subject: [PATCH] [PAC][clang] Handle pauthtest environment and ABI in Linux-sp

[llvm-branch-commits] [clang] [PAC][clang] Add new features to pauthtest ABI (PR #113150)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113150 >From 7abf7b7c4dd2420036bf9461d8c356df3282b652 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024 10:58:04 +0300 Subject: [PATCH] [PAC][clang] Add new features to pauthtest ABI Enable init/fi

[llvm-branch-commits] [clang] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin (PR #113152)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113152 >From 388b86934631cfa1ea284f19ac2702b81cb34bc9 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024 12:18:56 +0300 Subject: [PATCH 1/2] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin

[llvm-branch-commits] [clang] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin (PR #113152)

https://github.com/kovdan01 edited https://github.com/llvm/llvm-project/pull/113152 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [PAC][Driver] Support ptrauth flags only on AArch64 Linux and ARM64 Darwin (PR #113152)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113152 >From e610387c4f870518d9a06035cce1ce72a9fee32b Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024 12:18:56 +0300 Subject: [PATCH] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin Most

[llvm-branch-commits] [clang] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin (PR #113152)

https://github.com/kovdan01 edited https://github.com/llvm/llvm-project/pull/113152 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin (PR #113152)

kovdan01 wrote: @MaskRay As discussed in https://github.com/llvm/llvm-project/pull/96160#issuecomment-2468793288, this drops support for ptrauth driver flags, but with an exception for apple targets - to the best of my knowledge, they have use cases for them. Also tagging @ahmedbougacha Not

[llvm-branch-commits] [clang] [PAC][clang] Add new features to pauthtest ABI (PR #113150)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113150 >From c1ad05b926befb687937d89d52fb4212beb9631e Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024 10:58:04 +0300 Subject: [PATCH] [PAC][clang] Add new features to pauthtest ABI Enable init/fi

[llvm-branch-commits] [clang] [PAC][Driver] Support ptrauth flags only on ARM64 Darwin (PR #113152)

https://github.com/kovdan01 edited https://github.com/llvm/llvm-project/pull/113152 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [PAC][clang] Handle pauthtest environment and ABI in Linux-specific code (PR #113151)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113151 >From 5fb854a97bbf65290bb1e16942126b5505e4face Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024 12:00:19 +0300 Subject: [PATCH] [PAC][clang] Handle pauthtest environment and ABI in Linux-sp

[llvm-branch-commits] [clang] [PAC][clang] Add new features to pauthtest ABI (PR #113150)

kovdan01 wrote: Would be glad to see everyone's feedback on the changes. https://github.com/llvm/llvm-project/pull/113150 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branc

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed GOT with tiny code model (PR #113816)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113816 >From ff01757ad3d20b9538a23b12e7c3e2cd7f6dc20d Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 21:28:18 +0300 Subject: [PATCH 1/3] [PAC][lld][AArch64][ELF] Support signed GOT with tiny cod

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113817 >From ece091010f97775f2ea857ea21cbbc117b0d63ad Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 12:32:27 +0300 Subject: [PATCH 1/5] [PAC][lld][AArch64][ELF] Support signed TLSDESC Support `

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed GOT with tiny code model (PR #113816)

@@ -78,6 +78,79 @@ _start: adrp x1, :got_auth:zed add x1, x1, :got_auth_lo12:zed +#--- ok-tiny.s + +# RUN: llvm-mc -filetype=obj -triple=aarch64-none-linux ok-tiny.s -o ok-tiny.o kovdan01 wrote: Thanks for suggestion, changed to `aarch64` in 3c80d75c601

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed GOT with tiny code model (PR #113816)

@@ -78,6 +78,79 @@ _start: adrp x1, :got_auth:zed add x1, x1, :got_auth_lo12:zed +#--- ok-tiny.s + +# RUN: llvm-mc -filetype=obj -triple=aarch64-none-linux ok-tiny.s -o ok-tiny.o + +# RUN: ld.lld ok-tiny.o a.so -pie -o external-tiny +# RUN: llvm-readelf -r -S -x .got exte

[llvm-branch-commits] [lld] [PAC][lld] Use PAC instructions in PLT header with `-z pac-plt` (PR #116334)

kovdan01 wrote: Both changes from the PR description require dynamic loader support, which seems missing for glibc (see discussion in https://discord.com/channels/636084430946959380/1133112394701348895/1298121731428585564). However, I don't think that it should prevent us from supporting this

[llvm-branch-commits] [lld] [PAC][lld][ELF] Use PAC instructions in PLT header with `-z pac-plt` (PR #116334)

https://github.com/kovdan01 edited https://github.com/llvm/llvm-project/pull/116334 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lld] [PAC][lld] Use PAC instructions in PLT header with `-z pac-plt` (PR #116334)

https://github.com/kovdan01 ready_for_review https://github.com/llvm/llvm-project/pull/116334 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lld] [PAC][lld] Use PAC instructions in PLT header with `-z pac-plt` (PR #116334)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/116334 >From f3584a0660270a07cc446e31175a93965ebffd3c Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024 16:46:22 +0300 Subject: [PATCH] [PAC][lld] Use PAC instructions in PLT header with `-z pac-pl

[llvm-branch-commits] [lld] [PAC][lld] Use PAC instructions in PLT header with `-z pac-plt` (PR #116334)

kovdan01 wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/116334?utm_source=stack-comment-downstack-mergeability-warning"

[llvm-branch-commits] [lld] [PAC][lld] Use PAC instructions in PLT header with `-z pac-plt` (PR #116334)

https://github.com/kovdan01 created https://github.com/llvm/llvm-project/pull/116334 1. Sign return address before storing into stack. 2. Treat lazy resolver address as signed. >From 7fbca897414b538d2b528cc8ca54a89d38ba3c6d Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024

[llvm-branch-commits] [llvm] [AArch64][PAC] Eliminate excessive MOVs when computing blend (PR #115185)

@@ -188,6 +188,33 @@ define void @test_tailcall_omit_mov_x16_x16(ptr %objptr) #0 { ret void } +define i32 @test_call_omit_extra_moves(ptr %objptr) #0 { kovdan01 wrote: As far as I see, there are two places where `emitPtrauthDiscriminator` is called with `

[llvm-branch-commits] [llvm] [AArch64][PAC] Eliminate excessive MOVs when computing blend (PR #115185)

@@ -163,8 +163,15 @@ class AArch64AsmPrinter : public AsmPrinter { // Emit the sequence for AUT or AUTPAC. void emitPtrauthAuthResign(const MachineInstr *MI); - // Emit the sequence to compute a discriminator into x17, or reuse AddrDisc. - unsigned emitPtrauthDiscriminat

[llvm-branch-commits] [llvm] [AArch64][PAC] Eliminate excessive MOVs when computing blend (PR #115185)

@@ -163,8 +163,15 @@ class AArch64AsmPrinter : public AsmPrinter { // Emit the sequence for AUT or AUTPAC. void emitPtrauthAuthResign(const MachineInstr *MI); - // Emit the sequence to compute a discriminator into x17, or reuse AddrDisc. - unsigned emitPtrauthDiscriminat

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed GOT with tiny code model (PR #113816)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113816 >From 7eddd301c02588dd56fea43996e089ab181ae0c5 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 21:28:18 +0300 Subject: [PATCH 1/2] [PAC][lld][AArch64][ELF] Support signed GOT with tiny cod

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113817 >From 9476c4028766e076587889100c34bf5002f85c99 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 12:32:27 +0300 Subject: [PATCH 1/5] [PAC][lld][AArch64][ELF] Support signed TLSDESC Support `

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

@@ -0,0 +1,134 @@ +// REQUIRES: aarch64 +// RUN: rm -rf %t && split-file %s %t && cd %t + +//--- a.s + +.section .tbss,"awT",@nobits +.global a +a: +.xword 0 + +//--- ok.s + +// RUN: llvm-mc -filetype=obj -triple=aarch64-pc-linux -mattr=+pauth ok.s -o ok.o +// RUN: ld.lld -shared

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

@@ -1352,6 +1352,36 @@ unsigned RelocationScanner::handleTlsRelocation(RelExpr expr, RelType type, return 1; } + auto fatalBothAuthAndNonAuth = [&sym]() { +fatal("both AUTH and non-AUTH TLSDESC entries for '" + sym.getName() + kovdan01 wrote: > We

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

@@ -0,0 +1,134 @@ +// REQUIRES: aarch64 +// RUN: rm -rf %t && split-file %s %t && cd %t + +//--- a.s + +.section .tbss,"awT",@nobits +.global a +a: +.xword 0 + +//--- ok.s + +// RUN: llvm-mc -filetype=obj -triple=aarch64-pc-linux -mattr=+pauth ok.s -o ok.o +// RUN: ld.lld -shared

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

@@ -92,6 +92,10 @@ enum RelExpr { R_AARCH64_PAGE_PC, R_AARCH64_RELAX_TLS_GD_TO_IE_PAGE_PC, R_AARCH64_TLSDESC_PAGE, + R_AARCH64_AUTH_TLSDESC_PAGE, + // TODO: maybe it's better to rename this expression + // to avoid name conflict with dynamic reloc + R_AARCH64_AUTH_TLS

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113817 >From 0a2b9e4ce6e6d991a0c7de28e8a6bcca63861bae Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 12:32:27 +0300 Subject: [PATCH 1/4] [PAC][lld][AArch64][ELF] Support signed TLSDESC Support `

[llvm-branch-commits] [lld] [PAC][lld] Use braa instr in PAC PLT sequence with valid PAuth core info (PR #113945)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113945 >From d195b1eb6c41d9cda912ed50b79bc05a7d700e5b Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 28 Oct 2024 21:23:54 +0300 Subject: [PATCH 1/2] [PAC][lld] Use braa instr in PAC PLT sequence with valid

[llvm-branch-commits] [lld] [PAC][lld] Use braa instr in PAC PLT sequence with valid PAuth core info (PR #113945)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113945 >From 9751851e290bb7a1af6d327663c4f90ad3205df9 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 28 Oct 2024 21:23:54 +0300 Subject: [PATCH 1/2] [PAC][lld] Use braa instr in PAC PLT sequence with valid

[llvm-branch-commits] [lld] [PAC][lld] Do not emit warnings for `-z pac-plt` with valid PAuth core info (PR #112959)

kovdan01 wrote: ### Merge activity * **Nov 10, 1:05 AM EST**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/112959). https://github.com/llvm/llvm-project/pull/112959 ___

[llvm-branch-commits] [clang] [PAC][Driver] Support ptrauth flags only on AArch64 Linux and ARM64 Darwin (PR #113152)

kovdan01 wrote: Would be glad to see everyone's feedback on the changes. https://github.com/llvm/llvm-project/pull/113152 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branc

[llvm-branch-commits] [clang] [PAC][clang] Handle pauthtest environment and ABI in Linux-specific code (PR #113151)

kovdan01 wrote: Would be glad to see everyone's feedback on the changes. https://github.com/llvm/llvm-project/pull/113151 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branc

[llvm-branch-commits] [clang] [PAC][clang] Add new features to pauthtest ABI (PR #113150)

kovdan01 wrote: Would be glad to see everyone's feedback on the changes. https://github.com/llvm/llvm-project/pull/113150 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branc

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed GOT with tiny code model (PR #113816)

kovdan01 wrote: > I see a number of test failures, ATM. @ilovepi Yes, these are currently expected - as mentioned in the PR description, it depends on #114525 (codegen support for the feature). The dependency isn't included in the Graphite PR stack since this does not cause merge conflicts (d

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed GOT with tiny code model (PR #113816)

https://github.com/kovdan01 edited https://github.com/llvm/llvm-project/pull/113816 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lld] [PAC][lld] Use braa instr in PAC PLT sequence with valid PAuth core info (PR #113945)

@@ -999,7 +999,9 @@ class AArch64BtiPac final : public AArch64 { private: bool btiHeader; // bti instruction needed in PLT Header and Entry - bool pacEntry; // autia1716 instruction needed in PLT Entry + bool pacEntry; // Authenticated branch needed in PLT Entry

[llvm-branch-commits] [lld] [PAC][lld] Use braa instr in PAC PLT sequence with valid PAuth core info (PR #113945)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113945 >From f2daf75b8506e31180f2d41291c6f1a63da5138b Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 28 Oct 2024 21:23:54 +0300 Subject: [PATCH 1/2] [PAC][lld] Use braa instr in PAC PLT sequence with valid

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed GOT with tiny code model (PR #113816)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113816 >From 4b1795d57490dbcef1cf7ce17739a0d6023e5cca Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 21:28:18 +0300 Subject: [PATCH 1/2] [PAC][lld][AArch64][ELF] Support signed GOT with tiny cod

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113817 >From d89a47e22f427f8fe989ca24c9289821c8bda09d Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 25 Oct 2024 12:32:27 +0300 Subject: [PATCH 1/2] [PAC][lld][AArch64][ELF] Support signed TLSDESC Support `

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed GOT with tiny code model (PR #113816)

https://github.com/kovdan01 edited https://github.com/llvm/llvm-project/pull/113816 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed GOT with tiny code model (PR #113816)

@@ -78,6 +78,79 @@ _start: adrp x1, :got_auth:zed add x1, x1, :got_auth_lo12:zed +#--- ok-tiny.s + +# RUN: llvm-mc -filetype=obj -triple=aarch64-none-linux ok-tiny.s -o ok-tiny.o + +# RUN: ld.lld ok-tiny.o a.so -pie -o external-tiny +# RUN: llvm-readelf -r -S -x .got exte

[llvm-branch-commits] [lld] [PAC][lld][AArch64][ELF] Support signed TLSDESC (PR #113817)

@@ -1355,6 +1355,36 @@ unsigned RelocationScanner::handleTlsRelocation(RelExpr expr, RelType type, return 1; } + auto fatalBothAuthAndNonAuth = [&sym]() { +fatal("both AUTH and non-AUTH TLSDESC entries for '" + sym.getName() + + "' requested, but only one

[llvm-branch-commits] [llvm] [PAC][CodeGen][ELF][AArch64] Support signed GOT with tiny code model (PR #113812)

https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113812 >From c2ffa88c7b9f8e7a6b12cef59c83b288382c402b Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Sun, 27 Oct 2024 17:23:17 +0300 Subject: [PATCH] [PAC][CodeGen][ELF][AArch64] Support signed GOT with tiny cod

[llvm-branch-commits] [lld] [PAC][lld] Use braa instr in PAC PLT sequence with valid PAuth core info (PR #113945)

https://github.com/kovdan01 created https://github.com/llvm/llvm-project/pull/113945 Assume PAC instructions being supported with PAuth core info different from (0,0). Given that, `autia1716; br x17` can be replaced with `braa x17, x16; nop`. >From f2daf75b8506e31180f2d41291c6f1a63da5138b Mon S

[llvm-branch-commits] [lld] [PAC][lld] Use braa instr in PAC PLT sequence with valid PAuth core info (PR #113945)

https://github.com/kovdan01 ready_for_review https://github.com/llvm/llvm-project/pull/113945 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lld] [PAC][lld] Use braa instr in PAC PLT sequence with valid PAuth core info (PR #113945)

kovdan01 wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/113945?utm_source=stack-comment-downstack-mergeability-warning"

  1   2   3   >