[llvm-branch-commits] [clang] Backport: [clang] Serialization: support hashing null template arguments (PR #141957)

2025-05-29 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 approved this pull request. https://github.com/llvm/llvm-project/pull/141957 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/20.x: [Clang] Fix the trailing comma regression (#136273) (PR #136283)

2025-05-02 Thread Younan Zhang via llvm-branch-commits
zyn0217 wrote: @cor3ntin https://github.com/llvm/llvm-project/pull/136283 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/20.x: [clang][AST] Handle implicit first argument in CallExpr::getBeginLoc() (PR #135927)

2025-04-16 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 approved this pull request. https://github.com/llvm/llvm-project/pull/135927 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/20.x: [Clang] Fix a lambda pattern comparison mismatch after ecc7e6ce4 (#133863) (PR #134194)

2025-04-15 Thread Younan Zhang via llvm-branch-commits
zyn0217 wrote: It's been 11 days so I think this is mature enough - @erichkeane WDYT? https://github.com/llvm/llvm-project/pull/134194 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[llvm-branch-commits] [clang] [clang-tools-extra] [libcxx] [clang] improved preservation of template keyword (PR #133610)

2025-04-04 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/133610 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang] NFC: introduce UnsignedOrNone as a replacement for std::optional (PR #134142)

2025-04-04 Thread Younan Zhang via llvm-branch-commits
@@ -13343,28 +13344,25 @@ class Sema final : public SemaBase { /// The current index into pack expansion arguments that will be /// used for substitution of parameter packs. /// - /// The pack expansion index will be -1 to indicate that parameter packs + /// The pack ex

[llvm-branch-commits] [clang] [clang] NFC: introduce UnsignedOrNone as a replacement for std::optional (PR #134142)

2025-04-02 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 approved this pull request. One question otherwise LGTM! https://github.com/llvm/llvm-project/pull/134142 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[llvm-branch-commits] [clang] [clang] NFC: introduce UnsignedOrNone as a replacement for std::optional (PR #134142)

2025-04-02 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/134142 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang-tools-extra] [libcxx] [clang] improved preservation of template keyword (PR #133610)

2025-03-31 Thread Younan Zhang via llvm-branch-commits
@@ -544,6 +545,35 @@ class QualifiedTemplateName : public llvm::FoldingSetNode { } }; +struct IdentifierOrOverloadedOperator { + IdentifierOrOverloadedOperator() = default; + IdentifierOrOverloadedOperator(const IdentifierInfo *II); + IdentifierOrOverloadedOperator(Overlo

[llvm-branch-commits] [clang] [clang-tools-extra] [libcxx] [clang] improved preservation of template keyword (PR #133610)

2025-03-31 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 approved this pull request. Thanks for the improvement. https://github.com/llvm/llvm-project/pull/133610 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[llvm-branch-commits] [clang] [clang-tools-extra] [libcxx] [clang] improved preservation of template keyword (PR #133610)

2025-03-31 Thread Younan Zhang via llvm-branch-commits
@@ -587,12 +587,12 @@ bool Parser::ParseOptionalCXXScopeSpecifier( << II.getName() << FixItHint::CreateInsertion(Tok.getLocation(), "template "); } - -SourceLocation TemplateNameLoc = ConsumeToken(); +ConsumeToken();

[llvm-branch-commits] [clang] [clang-tools-extra] [libcxx] [clang] improved preservation of template keyword (PR #133610)

2025-03-31 Thread Younan Zhang via llvm-branch-commits
@@ -124,6 +124,31 @@ void SubstTemplateTemplateParmPackStorage::Profile( ID.AddBoolean(Final); } +IdentifierOrOverloadedOperator::IdentifierOrOverloadedOperator( +const IdentifierInfo *II) +: PtrOrOp(reinterpret_cast(II)) { + static_assert(NUM_OVERLOADED_OPERATORS <

[llvm-branch-commits] [clang] [clang-tools-extra] [clang] support pack expansions for trailing requires clauses (PR #133190)

2025-03-26 Thread Younan Zhang via llvm-branch-commits
zyn0217 wrote: Looks like there are some dependencies on the implicit bool conversion. So feel free to drop the explicit specifier ;) https://github.com/llvm/llvm-project/pull/133190 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.

[llvm-branch-commits] [clang] [clang-tools-extra] [clang][HeuristicResolver] Default argument heuristic for template parameters (PR #131074)

2025-03-25 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 approved this pull request. Sorry for missing this. LGTM assuming @hokein is happy too. https://github.com/llvm/llvm-project/pull/131074 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.ll

[llvm-branch-commits] [clang] release/20.x: [Clang] Fix various bugs in alias CTAD transform (PR #132697)

2025-03-24 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/132697 This patch cherry-picks 032ad590d6, 868c89ff0 and 38d71c9bd onto the 20 release branch. The first patch addresses recently surfaced CTAD problems, which we believe it would be nice to roll out the fix quickly,

[llvm-branch-commits] [clang] release/20.x: [Clang] Fix various bugs in alias CTAD transform (PR #132697)

2025-03-24 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 milestoned https://github.com/llvm/llvm-project/pull/132697 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang-tools-extra] [clang][HeuristicResolver] Apply default argument heuristic in resolveDeclRefExpr as well (PR #132576)

2025-03-22 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 approved this pull request. Thanks for following up on it, this looks great. Please flesh out the PR body before you commit, with the reason you said in https://github.com/llvm/llvm-project/pull/132576#issuecomment-2745944724. (Just a copy-paste is good enough) https

[llvm-branch-commits] [clang] [clang][HeuristicResolver] Default argument heuristic for template parameters (PR #131074)

2025-03-21 Thread Younan Zhang via llvm-branch-commits
zyn0217 wrote: @HighCommander4 did you merge it into a wrong branch? https://github.com/llvm/llvm-project/pull/131074 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-co

[llvm-branch-commits] [clang] [clang][HeuristicResolver] Default argument heuristic for template parameters (PR #131074)

2025-03-21 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 approved this pull request. thanks https://github.com/llvm/llvm-project/pull/131074 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang-tools-extra] [clang][HeuristicResolver] Default argument heuristic for template parameters (PR #131074)

2025-03-19 Thread Younan Zhang via llvm-branch-commits
@@ -125,6 +126,20 @@ TagDecl *HeuristicResolverImpl::resolveTypeToTagDecl(QualType QT) { if (!T) return nullptr; + // If T is the type of a template parameter, we can't get a useful TagDecl + // out of it. However, if the template parameter has a default argument, +

[llvm-branch-commits] [clang] [clang-tools-extra] [clang][HeuristicResolver] Default argument heuristic for template parameters (PR #131074)

2025-03-19 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/131074 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] 1cfbb9f - Backport/20.x: [Clang] Fix an incorrect assumption on getTemplatedDecl()

2025-03-18 Thread Younan Zhang via llvm-branch-commits
Author: Younan Zhang Date: 2025-03-18T12:54:25+08:00 New Revision: 1cfbb9f334360fc836966a79eba6d00c8d3d22c7 URL: https://github.com/llvm/llvm-project/commit/1cfbb9f334360fc836966a79eba6d00c8d3d22c7 DIFF: https://github.com/llvm/llvm-project/commit/1cfbb9f334360fc836966a79eba6d00c8d3d22c7.diff

[llvm-branch-commits] [clang] Backport/20.x: [Clang] Fix an incorrect assumption on getTemplatedDecl() (PR #131729)

2025-03-18 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/131729 This backports d9110858ee because it fixes a regression introduced in 19 and we don't want it to persist in 20 >From 1cfbb9f334360fc836966a79eba6d00c8d3d22c7 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: M

[llvm-branch-commits] [clang] release/20.x: [Clang] Do not emit nodiscard warnings for the base expr of static member access (#131450) (PR #131474)

2025-03-18 Thread Younan Zhang via llvm-branch-commits
@@ -10671,10 +10671,9 @@ class Sema final : public SemaBase { SourceLocation EndLoc); void ActOnForEachDeclStmt(DeclGroupPtrTy Decl); - /// DiagnoseDiscardedExprMarkedNodiscard - Given an expression that is - /// semantically a discarded-value ex

[llvm-branch-commits] [clang] Backport/20.x: [Clang] Fix an incorrect assumption on getTemplatedDecl() (PR #131729)

2025-03-17 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 milestoned https://github.com/llvm/llvm-project/pull/131729 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/20.x: [Clang] Fix an integer overflow issue in computing CTAD's parameter depth (PR #128845)

2025-03-11 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 milestoned https://github.com/llvm/llvm-project/pull/128845 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/20.x: [Clang] Fix an integer overflow issue in computing CTAD's parameter depth (PR #128845)

2025-02-26 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/128845 This fixes a potential integer overflow bug that has been around for many versions and was exposed by my patch recently. So we think it warrants a backport. Backports b8d1f3d62. >From 4adb975ae689d575dcd329cc

[llvm-branch-commits] [clang] [clang][NFC] Remove CXXRecordDecl::lookupDependentName() and its helpers (PR #128392)

2025-02-23 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 approved this pull request. https://github.com/llvm/llvm-project/pull/128392 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang][NFC] Remove CXXRecordDecl::lookupDependentName() and its helpers (PR #128392)

2025-02-23 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/128392 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang][NFC] Remove CXXRecordDecl::lookupDependentName() and its helpers (PR #128392)

2025-02-23 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 commented: LGTM in general, but my concern would be that we're less clear if there's any use of this function out-of-tree, so as an alternative, can we turn the implementation to use HeuristicResolver and explicitly deprecate it for a while before eventually removing

[llvm-branch-commits] [clang] release/20.x: [Clang] Remove the PackExpansion restrictions for rewrite substitution (PR #127174)

2025-02-13 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/127174 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/20.x: [Clang] Remove the PackExpansion restrictions for rewrite substitution (PR #127174)

2025-02-13 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 ready_for_review https://github.com/llvm/llvm-project/pull/127174 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/20.x: [Clang] Remove the PackExpansion restrictions for rewrite substitution (PR #127174)

2025-02-13 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/127174 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/20.x: [Clang] Remove the PackExpansion restrictions for rewrite substitution (PR #127174)

2025-02-13 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/127174 This backports [commit-sha] with a release note towards 20 so that we could resolve some pains in CTAD. >From ec69f0589eb471877ccd488f6d7d4fd43bcf0d02 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 7

[llvm-branch-commits] [clang] release/20.x: [Clang] Remove the PackExpansion restrictions for rewrite substitution (PR #127174)

2025-02-13 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 milestoned https://github.com/llvm/llvm-project/pull/127174 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/20.x: [clang][AST] Handle dependent representation of call to function with explicit object parameter in CallExpr::getBeginLoc() (#126868) (PR #127148)

2025-02-13 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 approved this pull request. https://github.com/llvm/llvm-project/pull/127148 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang] Implement evaluation context for checking template parameters (PR #126088)

2025-02-06 Thread Younan Zhang via llvm-branch-commits
zyn0217 wrote: (Did you mean `Implement *instantiation* context for checking template parameters`?) https://github.com/llvm/llvm-project/pull/126088 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[llvm-branch-commits] [clang] [clang] fix nondeduced mismatch with nullptr template arguments (PR #124498)

2025-01-26 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 approved this pull request. Thanks https://github.com/llvm/llvm-project/pull/124498 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang] fix template argument conversion (PR #124386)

2025-01-24 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/124386 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang] fix template argument conversion (PR #124386)

2025-01-24 Thread Younan Zhang via llvm-branch-commits
@@ -5252,63 +5253,89 @@ bool Sema::CheckTemplateArgument( return true; } -switch (Arg.getArgument().getKind()) { -case TemplateArgument::Null: - llvm_unreachable("Should never see a NULL template argument here"); - -case TemplateArgument::Expressio

[llvm-branch-commits] [clang] [clang] fix template argument conversion (PR #124386)

2025-01-24 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 approved this pull request. Generally looks good, but please give others a chance to take a look. https://github.com/llvm/llvm-project/pull/124386 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https:

[llvm-branch-commits] [clang] [Clang][CWG2369] Implement GCC's heuristic for DR 2369 (PR #124231)

2025-01-24 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/124231 >From f766c8c099cf8f1bc076c0308afc3a2832a5b495 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 24 Jan 2025 13:52:37 +0800 Subject: [PATCH] Implement GCC's CWG 2369 heuristic --- clang/include/clang/Sema

[llvm-branch-commits] [clang] [Clang][CWG2369] Implement GCC's heuristic for DR 2369 (PR #124231)

2025-01-23 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/124231 >From c36dd4fcac367b206072b36ccc9be4106a22ec3b Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 24 Jan 2025 13:52:37 +0800 Subject: [PATCH 1/2] Implement GCC's CWG 2369 heuristic --- clang/include/clang/

[llvm-branch-commits] [clang] [Clang][CWG2369] Implement GCC's heuristic for DR 2369 (PR #124231)

2025-01-23 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/124231 None >From c36dd4fcac367b206072b36ccc9be4106a22ec3b Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 24 Jan 2025 13:52:37 +0800 Subject: [PATCH] Implement GCC's CWG 2369 heuristic --- clang/include/clan

[llvm-branch-commits] [clang] release/19.x: [Clang] Consider outer instantiation scopes for constraint normalization (PR #114951)

2024-11-05 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/114951 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/19.x: [Clang] Consider outer instantiation scopes for constraint normalization (PR #114951)

2024-11-05 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 milestoned https://github.com/llvm/llvm-project/pull/114951 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/19.x: [Clang] Consider outer instantiation scopes for constraint normalization (PR #114951)

2024-11-05 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/114951 Backport 227afac3 >From ee31957b09ee5cb03d36b15fcc59cff5754aa553 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Tue, 5 Nov 2024 16:25:35 +0800 Subject: [PATCH] release/19.x: [Clang] Consider outer instantiat

[llvm-branch-commits] [clang] [Clang] Fix handling of placeholder variables name in init captures (#107055) (PR #107214)

2024-09-04 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 approved this pull request. https://github.com/llvm/llvm-project/pull/107214 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/19.x: [Clang][Sema] Revisit the fix for the lambda within a type alias template decl (#89934) (PR #106166)

2024-08-26 Thread Younan Zhang via llvm-branch-commits
zyn0217 wrote: This is a short-term regression fix that was unfortunately not merged in time. It is anticipated that @mizvekov will put up an ultimate fix of lambda context declaration in Clang 20, so this will be superseded eventually. However, given that it still takes time for Matheus to com

[llvm-branch-commits] [clang] release/19.x: [Clang][Concepts] Fix the constraint equivalence checking involving parameter packs (#102131) (PR #106043)

2024-08-26 Thread Younan Zhang via llvm-branch-commits
zyn0217 wrote: > Is this a major fix or regression fix? It is a follow-up fix for the previous bug fix incorporated in 19. https://github.com/llvm/llvm-project/commit/04d20b17050203e07394b4f9ee61b5affe2d5347 But this isn't a regression since clang wasn't working properly in such cases, nor a

[llvm-branch-commits] [clang] [clang] CTAD alias: fix the transformation for the require-clause expr (PR #90961)

2024-05-03 Thread Younan Zhang via llvm-branch-commits
@@ -2744,31 +2744,155 @@ bool hasDeclaredDeductionGuides(DeclarationName Name, DeclContext *DC) { return false; } +unsigned getTemplateDepth(NamedDecl *TemplateParam) { + if (auto *TTP = dyn_cast(TemplateParam)) +return TTP->getDepth(); + if (auto *TTP = dyn_cast(Temp

[llvm-branch-commits] [clang] [clang] CTAD alias: fix the transformation for the require-clause expr (PR #90961)

2024-05-03 Thread Younan Zhang via llvm-branch-commits
@@ -2744,31 +2744,155 @@ bool hasDeclaredDeductionGuides(DeclarationName Name, DeclContext *DC) { return false; } +unsigned getTemplateDepth(NamedDecl *TemplateParam) { + if (auto *TTP = dyn_cast(TemplateParam)) +return TTP->getDepth(); + if (auto *TTP = dyn_cast(Temp

[llvm-branch-commits] [clang] release/18.x: Backport PR86914 "Fix a CTAD regression after 42239d2e9" (PR #87084)

2024-04-01 Thread Younan Zhang via llvm-branch-commits
zyn0217 wrote: @tstellar thanks! > Fixed a regression in CTAD of clang 18 that a friend declaration that > befriends itself may cause incorrect constraint substitution. is just fine to me. https://github.com/llvm/llvm-project/pull/87084 ___ llvm-bra

[llvm-branch-commits] [clang] release/18.x: Backport PR86914 "Fix a CTAD regression after 42239d2e9" (PR #87084)

2024-03-29 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 milestoned https://github.com/llvm/llvm-project/pull/87084 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/18.x: Backport PR86914 "Fix a CTAD regression after 42239d2e9" (PR #87084)

2024-03-29 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/87084 This fixes a regression that was introduced in 18, which we don't want to carry it over to 19 anyways. >From 997ea41a48a94e92ebe47ac5345428582b32d967 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 29 M

[llvm-branch-commits] [clang-tools-extra] release/18.x: [clangd] [HeuristicResolver] Protect against infinite recursion on DependentNameTypes (#83542) (PR #84117)

2024-03-15 Thread Younan Zhang via llvm-branch-commits
zyn0217 wrote: > There is an umbrella entry in the release notes for "Various stability > improvements, e.g. crash fixes". Ah, although that sounds a bit unclear. :) Alright, I think it is probably fine for clangd to not to detail what crashes we had fixed, as crashes from clangd itself are pr

[llvm-branch-commits] [clang-tools-extra] release/18.x: [clangd] [HeuristicResolver] Protect against infinite recursion on DependentNameTypes (#83542) (PR #84117)

2024-03-15 Thread Younan Zhang via llvm-branch-commits
zyn0217 wrote: Oh, I saw PR https://github.com/llvm/llvm-project/pull/84436 just now. Do you think this needs a release note? (I don't know if you (or we, the members) have access to the backport branch; if not, you probably need a separate PR (close this one and open a new manually and target

[llvm-branch-commits] [clang-tools-extra] release/18.x: [clangd] [HeuristicResolver] Protect against infinite recursion on DependentNameTypes (#83542) (PR #84117)

2024-03-15 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 approved this pull request. I think this merits a backport as we don't actually want this crash on some std libraries delays to 19.0. > (Does the backport need to be reviewed separately? Not sure what is the > process these days.) @HighCommander4 : Yes. And we shall

[llvm-branch-commits] [clang] [libcxx] [llvm] [clang-tools-extra] [compiler-rt] [openmp] [lld] PR for llvm/llvm-project#79568 (PR #80120)

2024-02-05 Thread Younan Zhang via llvm-branch-commits
zyn0217 wrote: @tstellar Would you mind merging this PR? Thank you in advance! https://github.com/llvm/llvm-project/pull/80120 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-

[llvm-branch-commits] [clang] [libcxx] [llvm] [clang-tools-extra] [compiler-rt] [openmp] [lld] PR for llvm/llvm-project#79568 (PR #80120)

2024-02-05 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/80120 >From 16a8c31d342abed9c02493445c14c1bc7fd1519e Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Sat, 27 Jan 2024 15:42:52 +0800 Subject: [PATCH] [Concepts] Traverse the instantiation chain for parameter injecti

[llvm-branch-commits] [clang] PR for llvm/llvm-project#79568 (PR #80120)

2024-01-31 Thread Younan Zhang via llvm-branch-commits
zyn0217 wrote: I think this is a regression from clang 16. https://cpp1.godbolt.org/z/1PnWbvY1r https://github.com/llvm/llvm-project/pull/80120 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[llvm-branch-commits] [clang] PR for llvm/llvm-project#79568 (PR #80120)

2024-01-31 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 milestoned https://github.com/llvm/llvm-project/pull/80120 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] PR for llvm/llvm-project#79568 (PR #80120)

2024-01-31 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/80120 Backporting https://github.com/llvm/llvm-project/pull/79568 to clang 18. >From 16a8c31d342abed9c02493445c14c1bc7fd1519e Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Sat, 27 Jan 2024 15:42:52 +0800 Subject: