https://github.com/zyn0217 approved this pull request.
https://github.com/llvm/llvm-project/pull/141957
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
zyn0217 wrote:
@cor3ntin
https://github.com/llvm/llvm-project/pull/136283
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/zyn0217 approved this pull request.
https://github.com/llvm/llvm-project/pull/135927
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
zyn0217 wrote:
It's been 11 days so I think this is mature enough - @erichkeane WDYT?
https://github.com/llvm/llvm-project/pull/134194
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/133610
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -13343,28 +13344,25 @@ class Sema final : public SemaBase {
/// The current index into pack expansion arguments that will be
/// used for substitution of parameter packs.
///
- /// The pack expansion index will be -1 to indicate that parameter packs
+ /// The pack ex
https://github.com/zyn0217 approved this pull request.
One question otherwise LGTM!
https://github.com/llvm/llvm-project/pull/134142
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/134142
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -544,6 +545,35 @@ class QualifiedTemplateName : public llvm::FoldingSetNode {
}
};
+struct IdentifierOrOverloadedOperator {
+ IdentifierOrOverloadedOperator() = default;
+ IdentifierOrOverloadedOperator(const IdentifierInfo *II);
+ IdentifierOrOverloadedOperator(Overlo
https://github.com/zyn0217 approved this pull request.
Thanks for the improvement.
https://github.com/llvm/llvm-project/pull/133610
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
@@ -587,12 +587,12 @@ bool Parser::ParseOptionalCXXScopeSpecifier(
<< II.getName()
<< FixItHint::CreateInsertion(Tok.getLocation(), "template ");
}
-
-SourceLocation TemplateNameLoc = ConsumeToken();
+ConsumeToken();
@@ -124,6 +124,31 @@ void SubstTemplateTemplateParmPackStorage::Profile(
ID.AddBoolean(Final);
}
+IdentifierOrOverloadedOperator::IdentifierOrOverloadedOperator(
+const IdentifierInfo *II)
+: PtrOrOp(reinterpret_cast(II)) {
+ static_assert(NUM_OVERLOADED_OPERATORS <
zyn0217 wrote:
Looks like there are some dependencies on the implicit bool conversion. So feel
free to drop the explicit specifier ;)
https://github.com/llvm/llvm-project/pull/133190
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.
https://github.com/zyn0217 approved this pull request.
Sorry for missing this. LGTM assuming @hokein is happy too.
https://github.com/llvm/llvm-project/pull/131074
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.ll
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/132697
This patch cherry-picks 032ad590d6, 868c89ff0 and 38d71c9bd onto the 20 release
branch.
The first patch addresses recently surfaced CTAD problems, which we believe it
would be nice to roll out the fix quickly,
https://github.com/zyn0217 milestoned
https://github.com/llvm/llvm-project/pull/132697
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/zyn0217 approved this pull request.
Thanks for following up on it, this looks great.
Please flesh out the PR body before you commit, with the reason you said in
https://github.com/llvm/llvm-project/pull/132576#issuecomment-2745944724.
(Just a copy-paste is good enough)
https
zyn0217 wrote:
@HighCommander4 did you merge it into a wrong branch?
https://github.com/llvm/llvm-project/pull/131074
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-co
https://github.com/zyn0217 approved this pull request.
thanks
https://github.com/llvm/llvm-project/pull/131074
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -125,6 +126,20 @@ TagDecl
*HeuristicResolverImpl::resolveTypeToTagDecl(QualType QT) {
if (!T)
return nullptr;
+ // If T is the type of a template parameter, we can't get a useful TagDecl
+ // out of it. However, if the template parameter has a default argument,
+
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/131074
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
Author: Younan Zhang
Date: 2025-03-18T12:54:25+08:00
New Revision: 1cfbb9f334360fc836966a79eba6d00c8d3d22c7
URL:
https://github.com/llvm/llvm-project/commit/1cfbb9f334360fc836966a79eba6d00c8d3d22c7
DIFF:
https://github.com/llvm/llvm-project/commit/1cfbb9f334360fc836966a79eba6d00c8d3d22c7.diff
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/131729
This backports d9110858ee because it fixes a regression introduced in 19 and we
don't want it to persist in 20
>From 1cfbb9f334360fc836966a79eba6d00c8d3d22c7 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: M
@@ -10671,10 +10671,9 @@ class Sema final : public SemaBase {
SourceLocation EndLoc);
void ActOnForEachDeclStmt(DeclGroupPtrTy Decl);
- /// DiagnoseDiscardedExprMarkedNodiscard - Given an expression that is
- /// semantically a discarded-value ex
https://github.com/zyn0217 milestoned
https://github.com/llvm/llvm-project/pull/131729
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/zyn0217 milestoned
https://github.com/llvm/llvm-project/pull/128845
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/128845
This fixes a potential integer overflow bug that has been around for many
versions and was exposed by my patch recently. So we think it warrants a
backport.
Backports b8d1f3d62.
>From 4adb975ae689d575dcd329cc
https://github.com/zyn0217 approved this pull request.
https://github.com/llvm/llvm-project/pull/128392
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/128392
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/zyn0217 commented:
LGTM in general, but my concern would be that we're less clear if there's any
use of this function out-of-tree, so as an alternative, can we turn the
implementation to use HeuristicResolver and explicitly deprecate it for a while
before eventually removing
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/127174
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/zyn0217 ready_for_review
https://github.com/llvm/llvm-project/pull/127174
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/127174
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/127174
This backports [commit-sha] with a release note towards 20 so that we could
resolve some pains in CTAD.
>From ec69f0589eb471877ccd488f6d7d4fd43bcf0d02 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 7
https://github.com/zyn0217 milestoned
https://github.com/llvm/llvm-project/pull/127174
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/zyn0217 approved this pull request.
https://github.com/llvm/llvm-project/pull/127148
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
zyn0217 wrote:
(Did you mean `Implement *instantiation* context for checking template
parameters`?)
https://github.com/llvm/llvm-project/pull/126088
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/zyn0217 approved this pull request.
Thanks
https://github.com/llvm/llvm-project/pull/124498
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/124386
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -5252,63 +5253,89 @@ bool Sema::CheckTemplateArgument(
return true;
}
-switch (Arg.getArgument().getKind()) {
-case TemplateArgument::Null:
- llvm_unreachable("Should never see a NULL template argument here");
-
-case TemplateArgument::Expressio
https://github.com/zyn0217 approved this pull request.
Generally looks good, but please give others a chance to take a look.
https://github.com/llvm/llvm-project/pull/124386
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https:
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/124231
>From f766c8c099cf8f1bc076c0308afc3a2832a5b495 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 24 Jan 2025 13:52:37 +0800
Subject: [PATCH] Implement GCC's CWG 2369 heuristic
---
clang/include/clang/Sema
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/124231
>From c36dd4fcac367b206072b36ccc9be4106a22ec3b Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 24 Jan 2025 13:52:37 +0800
Subject: [PATCH 1/2] Implement GCC's CWG 2369 heuristic
---
clang/include/clang/
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/124231
None
>From c36dd4fcac367b206072b36ccc9be4106a22ec3b Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 24 Jan 2025 13:52:37 +0800
Subject: [PATCH] Implement GCC's CWG 2369 heuristic
---
clang/include/clan
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/114951
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/zyn0217 milestoned
https://github.com/llvm/llvm-project/pull/114951
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/114951
Backport 227afac3
>From ee31957b09ee5cb03d36b15fcc59cff5754aa553 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Tue, 5 Nov 2024 16:25:35 +0800
Subject: [PATCH] release/19.x: [Clang] Consider outer instantiat
https://github.com/zyn0217 approved this pull request.
https://github.com/llvm/llvm-project/pull/107214
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
zyn0217 wrote:
This is a short-term regression fix that was unfortunately not merged in time.
It is anticipated that @mizvekov will put up an ultimate fix of lambda context
declaration in Clang 20, so this will be superseded eventually. However, given
that it still takes time for Matheus to com
zyn0217 wrote:
> Is this a major fix or regression fix?
It is a follow-up fix for the previous bug fix incorporated in 19.
https://github.com/llvm/llvm-project/commit/04d20b17050203e07394b4f9ee61b5affe2d5347
But this isn't a regression since clang wasn't working properly in such cases,
nor a
@@ -2744,31 +2744,155 @@ bool hasDeclaredDeductionGuides(DeclarationName Name,
DeclContext *DC) {
return false;
}
+unsigned getTemplateDepth(NamedDecl *TemplateParam) {
+ if (auto *TTP = dyn_cast(TemplateParam))
+return TTP->getDepth();
+ if (auto *TTP = dyn_cast(Temp
@@ -2744,31 +2744,155 @@ bool hasDeclaredDeductionGuides(DeclarationName Name,
DeclContext *DC) {
return false;
}
+unsigned getTemplateDepth(NamedDecl *TemplateParam) {
+ if (auto *TTP = dyn_cast(TemplateParam))
+return TTP->getDepth();
+ if (auto *TTP = dyn_cast(Temp
zyn0217 wrote:
@tstellar thanks!
> Fixed a regression in CTAD of clang 18 that a friend declaration that
> befriends itself may cause incorrect constraint substitution.
is just fine to me.
https://github.com/llvm/llvm-project/pull/87084
___
llvm-bra
https://github.com/zyn0217 milestoned
https://github.com/llvm/llvm-project/pull/87084
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/87084
This fixes a regression that was introduced in 18, which we don't want to carry
it over to 19 anyways.
>From 997ea41a48a94e92ebe47ac5345428582b32d967 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 29 M
zyn0217 wrote:
> There is an umbrella entry in the release notes for "Various stability
> improvements, e.g. crash fixes".
Ah, although that sounds a bit unclear. :)
Alright, I think it is probably fine for clangd to not to detail what crashes
we had fixed, as crashes from clangd itself are pr
zyn0217 wrote:
Oh, I saw PR https://github.com/llvm/llvm-project/pull/84436 just now. Do you
think this needs a release note?
(I don't know if you (or we, the members) have access to the backport branch;
if not, you probably need a separate PR (close this one and open a new manually
and target
https://github.com/zyn0217 approved this pull request.
I think this merits a backport as we don't actually want this crash on some std
libraries delays to 19.0.
> (Does the backport need to be reviewed separately? Not sure what is the
> process these days.)
@HighCommander4 : Yes. And we shall
zyn0217 wrote:
@tstellar Would you mind merging this PR? Thank you in advance!
https://github.com/llvm/llvm-project/pull/80120
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/80120
>From 16a8c31d342abed9c02493445c14c1bc7fd1519e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Sat, 27 Jan 2024 15:42:52 +0800
Subject: [PATCH] [Concepts] Traverse the instantiation chain for parameter
injecti
zyn0217 wrote:
I think this is a regression from clang 16. https://cpp1.godbolt.org/z/1PnWbvY1r
https://github.com/llvm/llvm-project/pull/80120
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
https://github.com/zyn0217 milestoned
https://github.com/llvm/llvm-project/pull/80120
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/80120
Backporting https://github.com/llvm/llvm-project/pull/79568 to clang 18.
>From 16a8c31d342abed9c02493445c14c1bc7fd1519e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Sat, 27 Jan 2024 15:42:52 +0800
Subject:
63 matches
Mail list logo