Re: [llvm-commits] RFC: internal label names

2007-10-11 Thread Evan Cheng
On Oct 10, 2007, at 4:46 PM, Chris Lattner wrote: On Oct 10, 2007, at 12:41 PM, Dan Gohman wrote: 1. if the name is short, print it as you propose. 2. if the name is long, print it with a number and optionally with a subset of the name (last 10 chars?) This could be implemented by just

[llvm-commits] RFC: internal label names

2007-10-10 Thread Dan Gohman
The attached patch changes the names of internal labels used by codegen. In place of the function number, which is a number that codegen itself assigns specifically for this purpose, it uses the (mangled) name of the function, which is already sufficiently unique. For example, what currently

Re: [llvm-commits] RFC: internal label names

2007-10-10 Thread Anton Korobeynikov
Dan, I saw this in another compiler and liked it. Does anyone here dislike it? Patch looks pretty neat for me. -- With best regards, Anton Korobeynikov. Faculty of Mathematics Mechanics, Saint Petersburg State University. ___ llvm-commits

Re: [llvm-commits] RFC: internal label names

2007-10-10 Thread Evan Cheng
My only concern is it won't look as pleasant if the function name is long. Evan On Oct 10, 2007, at 7:36 AM, Dan Gohman [EMAIL PROTECTED] wrote: The attached patch changes the names of internal labels used by codegen. In place of the function number, which is a number that codegen itself

Re: [llvm-commits] RFC: internal label names

2007-10-10 Thread Chris Lattner
On Oct 10, 2007, at 9:33 AM, Evan Cheng wrote: My only concern is it won't look as pleasant if the function name is long. Which happens with C++ mangled names all the time :( a potentially solution to this (which may be over complex :) is to have two options: 1. if the name is short,

Re: [llvm-commits] RFC: internal label names

2007-10-10 Thread Dan Gohman
My only concern is it won't look as pleasant if the function name is long. Which happens with C++ mangled names all the time :( a potentially solution to this (which may be over complex :) is to have two options: 1. if the name is short, print it as you propose. 2. if the name is

Re: [llvm-commits] RFC: internal label names

2007-10-10 Thread Chris Lattner
On Oct 10, 2007, at 12:41 PM, Dan Gohman wrote: 1. if the name is short, print it as you propose. 2. if the name is long, print it with a number and optionally with a subset of the name (last 10 chars?) This could be implemented by just adding a new ivar like CurrentFunctionName that holds