On Tue, Nov 25, 2014 at 03:39:20PM +0800, yan.songm...@linaro.org wrote:
I think if we use other environment. We can't even use any API in odp_linux.h
which is used in many file of odp.
This photo blew show the file which used 'odph_linux_pthread_create'. There
are more than ten places to
On Mon, 24 Nov 2014 23:38:49 +0100 Ola Liljedahl ola.liljed...@linaro.org
wrote:
Use GCC __atomic builtins
AFAIK these were introduced in gcc = 4.7
Maybe I'm missing something, but isn't there a portability concern
here?
Regards,
Shmulik
___
On 25 November 2014 at 09:56, Shmulik Ladkani shmulik.ladk...@gmail.com wrote:
On Mon, 24 Nov 2014 23:38:49 +0100 Ola Liljedahl ola.liljed...@linaro.org
wrote:
Use GCC __atomic builtins
AFAIK these were introduced in gcc = 4.7
All usage of non-standard features could cause problems for
-There is nothing wrong in existing odph_linux_pthread_create. All I am
saying that, Don't allocate
-the memory from stack to share the data between different execution context.
pthrd_arg thrdarg its from stack,
-you can allocate it from odp shared memeory to share between different cores.
I
From: Alexandru Badicioiu alexandru.badici...@linaro.org
This fixes https://bugs.linaro.org/show_bug.cgi?id=714.
Signed-off-by: Alexandru Badicioiu alexandru.badici...@linaro.org
---
example/ipsec/odp_ipsec.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
On Tue, Nov 25, 2014 at 06:13:37PM +0800, yan.songm...@linaro.org wrote:
-There is nothing wrong in existing odph_linux_pthread_create. All I am
saying that, Don't allocate
-the memory from stack to share the data between different execution
context. pthrd_arg thrdarg its from stack,
-you
On 11/24/2014 10:11 PM, Mike Holmes wrote:
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
test/validation/odp_crypto.c | 11 +--
test/validation/odp_init.c | 7 ---
test/validation/odp_queue.c | 7 +--
3 files changed, 18 insertions(+), 7 deletions(-)
diff --git
On 11/25/2014 01:18 AM, Mike Holmes wrote:
Does no one else see this ?
Files are in the same directory where you run the test. So please remove
path from the patch
and add others:
CUnit-Memory-Dump.xml
example/packet/core
test/validation/CUnit-Memory-Dump.xml
I guess any Ethernet interface can be configured to work in loopback mode (
at least with SDK provided tools/functions). Loopback interface applied
to HW is confusing - usually loopback is software only; how a HW packet
classifier would be tested with a loopback interface? For this purpose a
real
On 25 November 2014 at 07:15, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 11/25/2014 01:18 AM, Mike Holmes wrote:
Does no one else see this ?
Files are in the same directory where you run the test. So please remove
path from the patch
and add others:
CUnit-Memory-Dump.xml
On 11/25/2014 02:19 PM, Alexandru Badicioiu wrote:
I guess any Ethernet interface can be configured to work in loopback
mode ( at least with SDK provided tools/functions). Loopback interface
applied to HW is confusing - usually loopback is software only; how a HW
packet classifier would be
On 11/25/2014 02:43 PM, Mike Holmes wrote:
On 25 November 2014 at 07:15, Maxim Uvarov maxim.uva...@linaro.org
mailto:maxim.uva...@linaro.org wrote:
On 11/25/2014 01:18 AM, Mike Holmes wrote:
Does no one else see this ?
Files are in the same directory where you run the test.
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
.gitignore | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.gitignore b/.gitignore
index 9d45504..1572ea5 100644
--- a/.gitignore
+++ b/.gitignore
@@ -50,3 +50,6 @@ doxygen-doc
test-driver
test/validation/*.log
test/validation/*.trs
Yes. But for testing the basic pktio APIs which I believe is Maxim's
requirement it can be done using loopback interface (configuring a HW
interface as loop is an implementation detail) so that there is no need for
any HW configuration as such while running the validation suite.
Packet classifier
Please ignore - we can refactor into multiple .gitignore files
On 25 November 2014 at 07:56, Mike Holmes mike.hol...@linaro.org wrote:
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
.gitignore | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.gitignore b/.gitignore
index
On 11/25/2014 12:21 PM, Alexandru Badicioiu wrote:
+
+/*
+ * This test verifies that HW random number generator is able
+ * to produce an IV for TDES_CBC cipher algorithm.
+ * */
+#define RNG_GET_SIZE RNG_GET_SIZE
+static void rng_get_size(void)
+{
On Mon, Nov 24, 2014 at 11:53 AM, Maxim Uvarov maxim.uva...@linaro.org wrote:
Add basic check for mtu and promisc modes.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/Makefile.am | 4 +-
test/validation/odp_pktio.c | 164
On 11/25/2014 03:06 PM, Bala Manoharan wrote:
Yes. But for testing the basic pktio APIs which I believe is Maxim's
requirement it can be done using loopback interface (configuring a HW
interface as loop is an implementation detail) so that there is no need
for any HW configuration as such while
On 25 November 2014 at 08:16, Ciprian Barbu ciprian.ba...@linaro.org
wrote:
On Mon, Nov 24, 2014 at 11:53 AM, Maxim Uvarov maxim.uva...@linaro.org
wrote:
Add basic check for mtu and promisc modes.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/Makefile.am |
On Tue, Nov 25, 2014 at 3:24 PM, Mike Holmes mike.hol...@linaro.org wrote:
On 25 November 2014 at 08:16, Ciprian Barbu ciprian.ba...@linaro.org
wrote:
On Mon, Nov 24, 2014 at 11:53 AM, Maxim Uvarov maxim.uva...@linaro.org
wrote:
Add basic check for mtu and promisc modes.
Signed-off-by:
On 25 November 2014 at 08:17, Taras Kondratiuk taras.kondrat...@linaro.org
wrote:
On 11/25/2014 03:06 PM, Bala Manoharan wrote:
Yes. But for testing the basic pktio APIs which I believe is Maxim's
requirement it can be done using loopback interface (configuring a HW
interface as loop is an
What is a self-contained application? An application which uses only ODP
calls?
Regarding the classification tests and loopbacks, why there's a need for a
special kind of ODP loopback interface?
Why the following scenario is not acceptable for a test - open a pktio
(ethernet), configure it in
On 25 November 2014 at 07:11, Taras Kondratiuk taras.kondrat...@linaro.org
wrote:
On 11/24/2014 10:11 PM, Mike Holmes wrote:
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
test/validation/odp_crypto.c | 11 +--
test/validation/odp_init.c | 7 ---
Lets take it up on the 1.0 API call that is in 1/2 hour
On 25 November 2014 at 08:30, Alexandru Badicioiu
alexandru.badici...@linaro.org wrote:
What is a self-contained application? An application which uses only ODP
calls?
Regarding the classification tests and loopbacks, why there's a need
On 11/25/2014 03:30 PM, Alexandru Badicioiu wrote:
What is a self-contained application? An application which uses only ODP
calls?
I mean an application that doesn't need any external equipment.
Regarding the classification tests and loopbacks, why there's a need for
a special kind of ODP
That loopback interface which allows reclassification (i.e. sending
packets to a HW classifier from the core) would be an appropriate pktio,
opened on a special HW device which is designed for this task. If the
packets are returned to the core (this is not mandatory also), it looks
like a loopback
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
Implement mac function according to pktio log:
https://docs.google.com/document/d/1EHU54p3Kaa-hGUG-W7xquDfQb3aSWF3fEtwmcv5Bts8/edit#heading=h.b8vg8t31zjwt
platform/linux-generic/include/api/odp_packet_io.h | 24
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/odp_pktio.c | 50 +
1 file changed, 50 insertions(+)
diff --git a/test/validation/odp_pktio.c b/test/validation/odp_pktio.c
index e26d820..fe22050 100644
---
Reviewed-by: Robert King robk...@cisco.com
From: lng-odp-boun...@lists.linaro.org [lng-odp-boun...@lists.linaro.org] on
behalf of Mike Holmes [mike.hol...@linaro.org]
Sent: Monday, November 24, 2014 12:18 PM
To: lng-odp@lists.linaro.org
Subject: [lng-odp]
UberConference Reminder___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
Merged,
Maxim.
On 11/24/2014 08:18 PM, Mike Holmes wrote:
For the 1.0 release there are no platforms using the async API.
With no way to test these APIs they should be removed until needed.
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
platform/linux-generic/include/api/odp_crypto.h
On 11/24/2014 02:05 PM, Maxim Uvarov wrote:
Do weak symbols work also for dynamic linking?
It does work for dynamic libraries also.
I've found an issue in ODP_UNIMPLEMENTED() macro.
Will post v2.
___
lng-odp mailing list
lng-odp@lists.linaro.org
Move additional functionality out of ODP_LOG. Move abort() call to
odp_override_log(), so application will be able to implement custom
abort handling.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
platform/linux-generic/include/api/odp_debug.h | 37
ODP application may want to override default ODP logging behaviour
and use custom logging function. Add a weak odp_override_log() function
for this purpose instead of default fprintf().
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
platform/linux-generic/Makefile.am
The entire patch set:
Reviewed-by: Petri Savolainen petri.savolai...@linaro.org
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Bill Fischofer
Sent: Tuesday, November 18, 2014 12:59 AM
To: lng-odp@lists.linaro.org
Meeting notes
Short meeting with a focus on getting to 1.0
-
Plan is for cunit test coverage for 100% API calls ASAP then cut 0.4.0
- Priority
-
Fix small ODP 1.0 items and cut 0.5.0 - possible additional point
releases as the short list of remaining big changes go in.
-
Patch set is merged.
From now we have requirement to use gcc-4.7 and up.
For old ubuntu systems you can install new gcc in that way:
http://askubuntu.com/questions/113291/how-do-i-install-gcc-4-7
Thanks,
Maxim.
On 11/25/2014 01:38 AM, Ola Liljedahl wrote:
Patch set restructured (thanks git
Thanks. What's the status on odp_atomic_internal.h? That's what's needed
for lockless data structure manipulation.
Bill
On Tue, Nov 25, 2014 at 9:29 AM, Maxim Uvarov maxim.uva...@linaro.org
wrote:
Patch set is merged.
From now we have requirement to use gcc-4.7 and up.
For old ubuntu
On 11/25/2014 06:36 PM, Bill Fischofer wrote:
Thanks. What's the status on odp_atomic_internal.h? That's what's
needed for lockless data structure manipulation.
Bill
Do you mean odp_spin_internal.h ? It's gone.
Maxim.
On Tue, Nov 25, 2014 at 9:29 AM, Maxim Uvarov
Real soon now. Testing the stuff on ARM. Will then create the patch
set and send out. If nothing unexpected happens, expect it to be
posted tonight CET.
-- Ola
On 25 November 2014 at 16:36, Bill Fischofer bill.fischo...@linaro.org wrote:
Thanks. What's the status on odp_atomic_internal.h?
That chunk also needs to go together with api change.
Maxim.
On 11/25/2014 06:22 PM, Savolainen, Petri (NSN - FI/Espoo) wrote:
The entire patch set:
Reviewed-by: Petri Savolainen petri.savolai...@linaro.org
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
odp_atomic_internal.h is a new internal header file with atomic
operations with different memory models as required by lock-less
programming and when implementing locks.
odp_spin_internal.h is gone? Time for me to rebase!
-- Ola
On 25 November 2014 at 16:41, Maxim Uvarov
OVS usually ditches stderr and stdout after startup, so logging there won't be
effective. Use instead the proper OVS logging facilities.
Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org
---
lib/netdev-odp.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/odp_packet_io.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/platform/linux-generic/odp_packet_io.c
b/platform/linux-generic/odp_packet_io.c
index c523350..501b2e9 100644
---
Define special name for loop back interface. That interface
can be used mostly for testing. Each implementation can interpret
that loop0 to any other device.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/include/api/odp_packet_io.h | 3 ++-
1 file changed, 2
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/odp_packet_io.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/platform/linux-generic/odp_packet_io.c
b/platform/linux-generic/odp_packet_io.c
index c523350..5c8146a 100644
---
Taras is submitting a patch that allows you to replace the output stream
for ODP_ERR etc with the applications prefered stream - see
https://mail.google.com/mail/u/1/#inbox/149e780e4e57d70c
On 25 November 2014 at 11:00, Zoltan Kiss zoltan.k...@linaro.org wrote:
OVS usually ditches stderr and
That link might not work this thread [lng-odp] [PATCHv2 1/2] platform:
debug: replace fprintf() with odp_override_log()
On 25 November 2014 at 11:54, Mike Holmes mike.hol...@linaro.org wrote:
Taras is submitting a patch that allows you to replace the output stream
for ODP_ERR etc with the
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
On ARM big.LITTLE systems with cluster switching, return the actual number of
currently usable CPU's (e.g. 4, not 8). Trying to bind threads to cores 4..7
will just hang those threads.
platform/linux-generic/odp_system_info.c | 2 +-
1
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/include/api/odp_debug.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/platform/linux-generic/include/api/odp_debug.h
b/platform/linux-generic/include/api/odp_debug.h
index 5c3adde..e853be4
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
.gitignore | 23 ++-
example/generator/.gitignore | 1 +
example/ipsec/.gitignore | 1 +
example/l2fwd/.gitignore | 1 +
example/odp_example/.gitignore | 1 +
example/packet/.gitignore
This makes it easier to deploy OVS with ODP support.
Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org
---
INSTALL.ODP | 28
1 file changed, 28 insertions(+)
diff --git a/INSTALL.ODP b/INSTALL.ODP
index 9c36dd1..86cec1f 100644
--- a/INSTALL.ODP
+++ b/INSTALL.ODP
@@
On 25 November 2014 at 12:10, Maxim Uvarov maxim.uva...@linaro.org wrote:
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
Reviewed-and-tested-by: Mike Holmes mike.hol...@linaro.org
---
platform/linux-generic/include/api/odp_debug.h | 3 +--
1 file changed, 1 insertion(+), 2
Per-worker 'thread_tbl[i]' instance should be initialized
by 'odph_linux_pthread_create()'.
However, 'thread_tbl' (the array itself) was accidentally passed to
'odph_linux_pthread_create', re-initializing 'thread_tbl[0]' on each
iteration.
Furthermore, the iteration is not needed as all threads
On 25 November 2014 at 12:03, Ola Liljedahl ola.liljed...@linaro.org
wrote:
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
Works on x86 - reported the correct number of cores available
http://www.gnu.org/software/libc/manual/html_node/Processor-Resources.html
So I assume it fixes the
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
platform/linux-generic/include/api/odp_atomic.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/platform/linux-generic/include/api/odp_atomic.h
b/platform/linux-generic/include/api/odp_atomic.h
index de9d91c..9eebb86
On 25 November 2014 at 15:38, Ola Liljedahl ola.liljed...@linaro.org
wrote:
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
Reviewed-and-tested-by: Mike Holmes mike.hol...@linaro.org
---
platform/linux-generic/include/api/odp_atomic.h | 2 +-
1 file changed, 1 insertion(+), 1
On 25 November 2014 at 21:07, Mike Holmes mike.hol...@linaro.org wrote:
On 25 November 2014 at 12:03, Ola Liljedahl ola.liljed...@linaro.org
wrote:
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
Works on x86 - reported the correct number of cores available
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
DEPENDENCIES | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/DEPENDENCIES b/DEPENDENCIES
index f70a1d4..11452ff 100644
--- a/DEPENDENCIES
+++ b/DEPENDENCIES
@@ -78,23 +78,33 @@ Prerequisites for building
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
Add t to ar.bz2
DEPENDENCIES | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/DEPENDENCIES b/DEPENDENCIES
index f70a1d4..bc39889 100644
--- a/DEPENDENCIES
+++ b/DEPENDENCIES
@@ -78,23 +78,33 @@
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
Operations (including exchange and compare-and-exchange) with specified
C11-based memory models on odp_atomic_u32_t and odp_atomic_u64_t.
odp_atomic_ptr_t definition and operations (init, load, store, exchange).
odp_atomic_flag_t
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
Use definitions from odp_atomic_internal.h.
platform/linux-generic/odp_barrier.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/platform/linux-generic/odp_barrier.c
b/platform/linux-generic/odp_barrier.c
index
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
Use definitions from odp_atomic_internal.h.
platform/linux-generic/include/api/odp_spinlock.h | 2 +-
platform/linux-generic/odp_spinlock.c | 17 +++--
2 files changed, 12 insertions(+), 7 deletions(-)
diff --git
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
Use definitions from odp_atomic_internal.h.
platform/linux-generic/include/api/odp_rwlock.h | 4 ++-
platform/linux-generic/odp_rwlock.c | 35 -
2 files changed, 20 insertions(+), 19 deletions(-)
diff
Add odp_cunit_common.c for common cunit function and add the cunit
test for the api in odp_share_memory.h which include the new api implement
odp_shm_free.
Signed-off-by: Yan Songming yan.songm...@linaro.org
---
v3 change common file to test/common and fix the problem Jerin found.
v2 fix some
Hi Mike,
As you know these classification patches was submitted as being
interdependent on each other.
But sure I can redo this specific patch to be independently compilable unit.
Also it would be great if I could get review comments on classification
implementation patches so that I can fix any
Hi,
Pls let me know if there are any additional comments for this patch.
If otherwise please provide reviewed-by
Regards,
Bala
On 25 November 2014 03:24, Anders Roxell anders.rox...@linaro.org wrote:
On 24 November 2014 at 22:45, Bill Fischofer bill.fischo...@linaro.org
wrote:
Again, this
67 matches
Mail list logo
