I have only a few minor comments for this patch.
One major query is that Currently this patch does not integrate
headroom/tailroom at segment level
is the feature available in 1.0?
if it is needed to be supported then we need some modifications in segment
handling.
Regards,
Bala
On Tue, Dec 02,
On 12/02/2014 08:35 PM, Mike Holmes wrote:
- * ODP default LOG macro.
+ * ODP log function
+ *
+ * Instead of direct prints to stdout/stderr all logging in ODP
implementation
+ * should be done via this function or its wrappers.
+ * ODP platform MUST provide a
On 12/02/2014 07:50 PM, Zoltan Kiss wrote:
On 02/12/14 17:07, Taras Kondratiuk wrote:
On 12/02/2014 06:42 PM, Zoltan Kiss wrote:
Hi,
At the moment, the careless developer look at enum odp_log_level and
starts using ODP_LOG(ODP_LOG_DBG, ...) instead of ODP_DBG.
I think it would be good to
On 12/02/2014 09:08 PM, Mike Holmes wrote:
On 1 December 2014 at 12:05, Taras Kondratiuk
taras.kondrat...@linaro.org mailto:taras.kondrat...@linaro.org wrote:
+CU_SuiteInfo odp_testsuites[] = {
+ {Queue, init_suite, NULL, NULL, NULL, test_odp_queue},
No need to have init_suite
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
Reviewed-by: Mike Holmes mike.hol...@linaro.org
---
test/validation/Makefile.am |2 +-
test/validation/odp_crypto.c | 43 ++
2 files changed, 7 insertions(+), 38 deletions(-)
diff --git
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
test/validation/Makefile.am |2 +-
test/validation/odp_queue.c | 64 +++
2 files changed, 11 insertions(+), 55 deletions(-)
diff --git a/test/validation/Makefile.am
Hi,
This is the proposed way to break up your patch:
1. break circular dependencies
2. move inline functions to a new odp_buffer_inlines.h file.
3. restructuring ODP buffer pool
4. odp_buffer_pool_create
5. odp_buffer_pool_destroy
6. odp_buffer_pool_info
see more comments inline.
On 2 December
On 12/03/2014 01:07 PM, Anders Roxell wrote:
Hi,
This is the proposed way to break up your patch:
1. break circular dependencies
2. move inline functions to a new odp_buffer_inlines.h file.
3. restructuring ODP buffer pool
4. odp_buffer_pool_create
5. odp_buffer_pool_destroy
6.
On Tue, 2 Dec 2014 13:17:01 -0600 Bill Fischofer bill.fischo...@linaro.org
wrote:
+#define ODP_SEGBITS(x) \
+ ((x) 2 ? 1 : \
+ ((x) 4 ? 2 : \
+ ((x) 8 ? 3 : \
+((x)16 ? 4 : \
+ ((x)32 ? 5 : \
+ ((x)64 ? 6 : \
+
On Wed, Dec 3, 2014 at 5:07 AM, Anders Roxell anders.rox...@linaro.org
wrote:
Hi,
This is the proposed way to break up your patch:
1. break circular dependencies
2. move inline functions to a new odp_buffer_inlines.h file.
3. restructuring ODP buffer pool
4. odp_buffer_pool_create
5.
It simplified debugging because the LOG output is the same independent of
whether I'm testing on big or little endian systems. My mind isn't wired
to read byte-reversed output fields.
On Wed, Dec 3, 2014 at 7:18 AM, Taras Kondratiuk
taras.kondrat...@linaro.org wrote:
On 12/02/2014 09:17 PM,
This patch contains classification implementation for ODP v1.0.
The salient features of this classification version are as follows:
* Attaches PMR, PMR_SET to a Pktio entry
* Attaches CoS values for L2 and L3 QoS to a Pktio entry
* Selects ClassOfService for a packet based on PMR, L2 QoS and L3
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
Update doxygen comments, renaming of function params.
platform/linux-generic/include/api/odp_barrier.h | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
Update doxygen comments, renaming of function params.
platform/linux-generic/include/api/odp_spinlock.h | 42 ---
1 file changed, 22 insertions(+), 20 deletions(-)
diff --git
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
Update doxygen comments, renaming of function params.
platform/linux-generic/include/api/odp_rwlock.h | 46 ++---
1 file changed, 25 insertions(+), 21 deletions(-)
diff --git
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
Update doxygen comments, renaming of function params.
Made _odp_atomic_flag_load() use acquire instead of relaxed memory order.
.../linux-generic/include/odp_atomic_internal.h| 378 +++--
1 file changed, 191
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
Update doxygen comments, renaming of function params.
.../linux-generic/include/api/odp_ticketlock.h | 43 ++
1 file changed, 19 insertions(+), 24 deletions(-)
diff --git
Ping!
On 1 December 2014 at 14:34, Ola Liljedahl ola.liljed...@linaro.org wrote:
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
Replaced an atomic RMW add with separate load, add and store operations.
This avoids generating a locked instruction on x86 which implies unnecessary
On 12/03/2014 04:15 PM, Zoltan Kiss wrote:
On 03/12/14 08:41, Taras Kondratiuk wrote:
On 12/02/2014 07:50 PM, Zoltan Kiss wrote:
And this problem applies to ODP_LOG_ABORT as well: ODP_ABORT
will call abort(), while ODP_LOG(ODP_LOG_ABORT, ...) doesn't.
I think you can just drop the wholw
Add cunit tests for new pktio api:
- MAC address get;
- Promisc mode set / test;
- MTU value set / get;
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/Makefile.am | 4 +-
test/validation/odp_pktio.c | 155
2 files changed,
In case of stdin is not attached socket() can return 0 for valid
socket fd. Not initialized socket has to be -1.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/odp_packet_io.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
ODP application may want to override default ODP logging behaviour
and use custom logging function. Add a weak odp_override_log() function
for this purpose instead of default fprintf().
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
platform/linux-generic/Makefile.am
Move additional functionality out of ODP_LOG. Keep only logging.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
platform/linux-generic/include/api/odp_debug.h | 43 +---
.../linux-generic/include/odp_debug_internal.h |6 ++-
2 files changed, 15
This series adds a default weak odp_override_log() function which can
be replaced by application.
v5: Updated doxygen comment
v4: Move abort() back into ODP_ABORT() to prevent uninitialized
variables warnings.
v3: Rebased and fixed conflicts with merged patches.
v2: Fixed missed comma in
On Wed, Dec 3, 2014 at 10:53 AM, Maxim Uvarov maxim.uva...@linaro.org
wrote:
Patch is based on Bills:
This patch implements the specified odp_packet_flags.h API name changes
for ODP v1.0.
Plus it includes renames for packet function.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
On Wed, Dec 3, 2014 at 9:19 AM, Taras Kondratiuk
taras.kondrat...@linaro.org wrote:
ODP application may want to override default ODP logging behaviour
and use custom logging function. Add a weak odp_override_log() function
for this purpose instead of default fprintf().
Signed-off-by: Taras
On Wed, Dec 3, 2014 at 9:19 AM, Taras Kondratiuk
taras.kondrat...@linaro.org wrote:
Move additional functionality out of ODP_LOG. Keep only logging.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
Reviewed-by: Bill Fischofer bill.fischo...@linaro.org
---
On Wed, Dec 3, 2014 at 3:45 PM, Stuart Haslam stuart.has...@arm.com wrote:
On Wed, Dec 03, 2014 at 09:22:17AM +, Taras Kondratiuk wrote:
Most of test application will have the same main function.
Move main() from odp_shm to a common place where it can be reused by
other test applications.
Apart from the other stuff pointed out by the other guys, this patch
set looks good to me. We should get it merged, I based my work on it
too.
I suppose a new series must be sent for Stuart's comments? Otherwise I
can sign it off.
On Wed, Dec 3, 2014 at 11:22 AM, Taras Kondratiuk
On 12/03/2014 05:20 PM, Ola Liljedahl wrote:
Ping!
Needed more review for this.
On 1 December 2014 at 14:34, Ola Liljedahl ola.liljed...@linaro.org wrote:
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
Replaced an atomic RMW add with separate load, add and store operations.
This
I don¹t think cur_ticket will be read/written by more than one thread
simultaneously, only the one which owns the lock will attempt to update it.
Mario.
On 03/12/2014 17:16, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 12/03/2014 05:20 PM, Ola Liljedahl wrote:
Ping!
Needed more review for
On 3 December 2014 at 12:13, Ciprian Barbu ciprian.ba...@linaro.org wrote:
On Wed, Dec 3, 2014 at 3:45 PM, Stuart Haslam stuart.has...@arm.com
wrote:
On Wed, Dec 03, 2014 at 09:22:17AM +, Taras Kondratiuk wrote:
Most of test application will have the same main function.
Move main()
On Wed, Dec 03, 2014 at 03:05:55PM +, Maxim Uvarov wrote:
Implement pktio device loop device suitable for testing.
Note: lo0 can not be used. Instead of it first upped device
is used.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/odp_packet_io.c | 64
When generating coverage info gcov creates .gcda and .gcno files
alongside each object file.
Signed-off-by: Stuart Haslam stuart.has...@arm.com
---
(This code contribution is provided under the terms of agreement LES-LTM-21309)
.gitignore | 2 ++
1 file changed, 2 insertions(+)
diff --git
On 3 December 2014 at 11:59, Bill Fischofer bill.fischo...@linaro.org
wrote:
On Wed, Dec 3, 2014 at 9:19 AM, Taras Kondratiuk
taras.kondrat...@linaro.org wrote:
ODP application may want to override default ODP logging behaviour
and use custom logging function. Add a weak
On 3 December 2014 at 11:57, Bill Fischofer bill.fischo...@linaro.org
wrote:
On Wed, Dec 3, 2014 at 9:19 AM, Taras Kondratiuk
taras.kondrat...@linaro.org wrote:
Move additional functionality out of ODP_LOG. Keep only logging.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
I also can add reviewed by with the exception of the 77 issue in main.
Maxim for expediency could you alter main to test for non zero and return
-1 as you pull the series in ?
Taras are you ok with that ?
On 3 December 2014 at 12:14, Ciprian Barbu ciprian.ba...@linaro.org wrote:
Apart from the
On 3 December 2014 at 18:29, Mario Torrecillas Rodriguez
mario.torrecillasrodrig...@arm.com wrote:
I don¹t think cur_ticket will be read/written by more than one thread
simultaneously, only the one which owns the lock will attempt to update it.
Exactly.
Do I take that as a review Mario?
Agreed, that correct programming would only have the owner attempt to
unlock, but what about other threads simultaneously attempting to lock
while the owner is unlocking? Maybe I don't fully appreciate the memmodel
semantics, but there can be arbitrary delays between any two instructions
executed
On Wed, Dec 3, 2014 at 7:50 AM, Balasubramanian Manoharan
bala.manoha...@linaro.org wrote:
This patch adds TCP header description structure odph_tcp.h
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
Reviewed-by: Bill Fischofer bill.fischo...@linaro.org
---
On 2014-12-03 07:05, Bill Fischofer wrote:
On Wed, Dec 3, 2014 at 5:07 AM, Anders Roxell anders.rox...@linaro.org
wrote:
Hi,
This is the proposed way to break up your patch:
1. break circular dependencies
2. move inline functions to a new odp_buffer_inlines.h file.
3. restructuring
On 3 December 2014 at 09:17, Ola Liljedahl ola.liljed...@linaro.org wrote:
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
Update doxygen comments, renaming of function params.
.../linux-generic/include/api/odp_ticketlock.h | 43
++
1 file changed, 19
On 3 December 2014 at 09:17, Ola Liljedahl ola.liljed...@linaro.org wrote:
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
Update doxygen comments, renaming of function params.
platform/linux-generic/include/api/odp_spinlock.h | 42
---
1 file changed, 22
On 3 December 2014 at 09:17, Ola Liljedahl ola.liljed...@linaro.org wrote:
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
Update doxygen comments, renaming of function params.
platform/linux-generic/include/api/odp_rwlock.h | 46
++---
1 file changed, 25
Thanks Mario,
I actually intend to post an updated patch because Maxim's questions
are an indication that it is not possible to immediately understand
the code and why it works. The comments could be better (they were
pretty non-existent to start with).
-- Ola
On 3 December 2014 at 21:42, Mario
On 3 December 2014 at 07:05, Maxim Uvarov maxim.uva...@linaro.org wrote:
Define API and implement promisc functions for linux-generic.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/include/api/odp_packet_io.h | 24 +++
On 3 December 2014 at 22:35, Mike Holmes mike.hol...@linaro.org wrote:
On 3 December 2014 at 09:17, Ola Liljedahl ola.liljed...@linaro.org wrote:
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
Update doxygen comments, renaming of function params.
On 3 December 2014 at 22:28, Mike Holmes mike.hol...@linaro.org wrote:
On 3 December 2014 at 09:17, Ola Liljedahl ola.liljed...@linaro.org wrote:
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
Update doxygen comments, renaming of function params.
On 3 December 2014 at 23:19, Mike Holmes mike.hol...@linaro.org wrote:
On 3 December 2014 at 09:17, Ola Liljedahl ola.liljed...@linaro.org wrote:
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
Update doxygen comments, renaming of function params.
On 3 December 2014 at 07:05, Maxim Uvarov maxim.uva...@linaro.org wrote:
Define API for mac address change and implement linux-generic version.
In above comment 'change' is used. I don't see code that
changes mac address in below diff. Change 'change' to 'read'.
Signed-off-by: Maxim Uvarov
On 3 December 2014 at 07:05, Maxim Uvarov maxim.uva...@linaro.org wrote:
Socket can be 0 and it's accounted in previews patch. Correct that function
too.
This patch does more than above.
It also makes some solidifying changes in odp_pktio_set_mtu and
odp_pktio_mtu functions. BTW both these
On 3 December 2014 at 22:53, Victor Kamensky victor.kamen...@linaro.org wrote:
On 3 December 2014 at 13:28, Mike Holmes mike.hol...@linaro.org wrote:
On 3 December 2014 at 09:17, Ola Liljedahl ola.liljed...@linaro.org wrote:
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
What problem do you see with odp_example.c with part 1 of the patch applied
that disappears when you apply the remaining two parts? The code compiles
and runs the same for me.
I had previously mentioned that odp_example.c has a race condition (bug)
that is exacerbated by the fact that the
I think the the patch needs to clearly say it alters the public API and not
just the documentation.
Strictly it is a separate patch as it is possible that unknown
implementations are using 0.3.0 and would want to to see this clearly in
the git log.
On 3 December 2014 at 17:57, Ola Liljedahl
On 3 December 2014 at 17:53, Ola Liljedahl ola.liljed...@linaro.org wrote:
On 3 December 2014 at 22:35, Mike Holmes mike.hol...@linaro.org wrote:
On 3 December 2014 at 09:17, Ola Liljedahl ola.liljed...@linaro.org
wrote:
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
On 3 December 2014 at 17:59, Ola Liljedahl ola.liljed...@linaro.org wrote:
On 3 December 2014 at 23:19, Mike Holmes mike.hol...@linaro.org wrote:
On 3 December 2014 at 09:17, Ola Liljedahl ola.liljed...@linaro.org
wrote:
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
On 3 December 2014 at 05:02, Ola Liljedahl ola.liljed...@linaro.org wrote:
diff --git a/example/timer/odp_timer_test.c
b/example/timer/odp_timer_test.c
We need to rename this, having a test in example makes no sense at
all.
This patch series should rename this as an example -
Actually, I think the example sketches make excellent comments as they show
the intended use of the code.
On Wed, Dec 3, 2014 at 7:47 PM, Mike Holmes mike.hol...@linaro.org wrote:
On 3 December 2014 at 05:02, Ola Liljedahl ola.liljed...@linaro.org
wrote:
diff --git
58 matches
Mail list logo
