[lng-odp] Regarding odp_packet_t and buffer chaining

2015-01-19 Thread Prashant Upadhyaya
Hi, Suppose I have pkt1 and pk2 which are instances of odp_packet_t. Now I have two questions - 1. what is the way to chain the buffers of pkt1 and pkt2 into pkt1 so that from now on I can just use pkt1 for transmission via, say, odp_pktio_send API 2. if I create a new

[lng-odp] [PATCH] helper: ip: add IP protocol value for sctp

2015-01-19 Thread Jerin Jacob
Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com --- helper/include/odph_ip.h | 1 + 1 file changed, 1 insertion(+) diff --git a/helper/include/odph_ip.h b/helper/include/odph_ip.h index 272fd96..f2638ba 100644 --- a/helper/include/odph_ip.h +++ b/helper/include/odph_ip.h @@ -167,6

Re: [lng-odp] [PATCHv8] linux-generic: fix odp_pktio_inq_remdef

2015-01-19 Thread Maxim Uvarov
On 01/16/2015 03:58 PM, Maxim Uvarov wrote: Correctly remove queue from packet i/o and remove it from scheduler. Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org --- v8: fixed Stuart comments and added test. Implementation of odp_pktio_inq_remdef also fixes segfault in existance

Re: [lng-odp] [PATCH] helper: ip: add IP protocol value for sctp

2015-01-19 Thread Jerin Jacob
On Mon, Jan 19, 2015 at 06:13:42AM -0600, Bill Fischofer wrote: Two questions: 1. We previously said we didn't need SCTP support for ODP v1.0, so why is this needed? Then there is a disconnect, exiting API has reference to SCTP /** * Check for SCTP * * @param pkt Packet handle *

Re: [lng-odp] [PATCHv2 7/8] debian: add debian packaging framework

2015-01-19 Thread Steve McIntyre
Bah, almost... On Thu, Jan 15, 2015 at 02:14:50PM +0100, Anders Roxell wrote: Signed-off-by: Anders Roxell anders.rox...@linaro.org debian/libodp0-dev.dirs| 2 ++ debian/libodp0-dev.install | 4 debian/libodp0.dirs| 1 + debian/libodp0.install | 1 +

Re: [lng-odp] odp_packet API queries

2015-01-19 Thread Jerin Jacob
On Mon, Jan 19, 2015 at 06:09:34AM -0600, Bill Fischofer wrote: I think Petri should weigh in on these questions. For the first one, what problems do you anticipate some platforms having with that equation? I have two issues around the unit test case, 1) packet_len =

Re: [lng-odp] odp_packet API queries

2015-01-19 Thread Bill Fischofer
On Mon, Jan 19, 2015 at 10:00 AM, Jerin Jacob jerin.ja...@caviumnetworks.com wrote: On Mon, Jan 19, 2015 at 09:26:08AM -0600, Bill Fischofer wrote: On Mon, Jan 19, 2015 at 7:22 AM, Jerin Jacob jerin.ja...@caviumnetworks.com wrote: On Mon, Jan 19, 2015 at 06:09:34AM -0600, Bill

[lng-odp] 0.9.0 staging patches

2015-01-19 Thread Maxim Uvarov
For next 0.9.0 release I created tempory branch with current patches. Main reason is that events show go to repo first, then all other things. Branch is here: https://git.linaro.org/people/maxim.uvarov/odp.git/shortlog/refs/heads/odp_0.9.0 Maxim.

Re: [lng-odp] odp_packet API queries

2015-01-19 Thread Jerin Jacob
On Mon, Jan 19, 2015 at 09:26:08AM -0600, Bill Fischofer wrote: On Mon, Jan 19, 2015 at 7:22 AM, Jerin Jacob jerin.ja...@caviumnetworks.com wrote: On Mon, Jan 19, 2015 at 06:09:34AM -0600, Bill Fischofer wrote: I think Petri should weigh in on these questions. For the first one, what

Re: [lng-odp] [PATCH] helper: ip: add IP protocol value for sctp

2015-01-19 Thread Maxim Uvarov
On 01/19/2015 02:44 PM, Jerin Jacob wrote: Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com --- helper/include/odph_ip.h | 1 + 1 file changed, 1 insertion(+) diff --git a/helper/include/odph_ip.h b/helper/include/odph_ip.h index 272fd96..f2638ba 100644 ---

Re: [lng-odp] odp_packet API queries

2015-01-19 Thread Bill Fischofer
On Mon, Jan 19, 2015 at 7:22 AM, Jerin Jacob jerin.ja...@caviumnetworks.com wrote: On Mon, Jan 19, 2015 at 06:09:34AM -0600, Bill Fischofer wrote: I think Petri should weigh in on these questions. For the first one, what problems do you anticipate some platforms having with that equation?

Re: [lng-odp] [PATCH 3/3] validation: buffer: enable packet validation test to run on SW emulated odp packet pool on HW

2015-01-19 Thread Bill Fischofer
Are you suggesting that the issue here that some platforms may not be able to allow applications precise control over the number of buffers in a pool? For example, they might have a minimum number of buffers or a minimum buffer count granularity? Do we need additional ODP_CONFIG values to

Re: [lng-odp] odp_packet API queries

2015-01-19 Thread Bill Fischofer
I think Petri should weigh in on these questions. For the first one, what problems do you anticipate some platforms having with that equation? I think the cleanest solution would be to have the platform segment size for a given pool accessible as pool metadata, e.g., odp_pool_seg_size(pool), but

Re: [lng-odp] odp_packet API queries

2015-01-19 Thread Jerin Jacob
On Sat, Jan 17, 2015 at 09:45:12AM -0600, Bill Fischofer wrote: Application-visible sizes refer to application-visible data. Metadata is always implementation-specific and not included in such counts. Metadata is off books data that is associated with the packet but is not part of any

Re: [lng-odp] [PATCH 00/15] Event introduction

2015-01-19 Thread Ola Liljedahl
On 17 January 2015 at 16:28, Bill Fischofer bill.fischo...@linaro.org wrote: In the new model no buffers are queueable. Only events are queueable. But you can convert a buffer handle to the corresponding event handle and enqueue the event. Thus buffers must have the metadata that allows them to

Re: [lng-odp] [PATCH 00/15] Event introduction

2015-01-19 Thread Jerin Jacob
On Mon, Jan 19, 2015 at 11:26:04AM +0100, Ola Liljedahl wrote: On 17 January 2015 at 16:28, Bill Fischofer bill.fischo...@linaro.org wrote: In the new model no buffers are queueable. Only events are queueable. But you can convert a buffer handle to the corresponding event handle and enqueue

[lng-odp] [PATCH] linux-generic: implement of odp_term_global.

2015-01-19 Thread Yan Songming
From: Yan Sonming yan.songm...@linaro.org Free all resource of odp which include share memory, queue and buffer pool. Fix the bug of odp_shm_free. Signed-off-by: Yan Songming yan.songm...@linaro.org --- platform/linux-generic/include/odp_internal.h | 10 +++

[lng-odp] [PATCHv2] linux-generic: Add odp_errno and adapt packet_io and timer implementations to use it

2015-01-19 Thread Mario Torrecillas Rodriguez
Added odp_errno.c and odp_errno.h Changed odp_packet_io and odp_timer to use it. Signed-off-by: Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com --- (This code contribution is provided under the terms of agreement LES-LTM-21309) Changes from previous version: * Moved __odp_errno

Re: [lng-odp] [PATCH 00/15] Event introduction

2015-01-19 Thread Savolainen, Petri (NSN - FI/Espoo)
No, I was considering the abstraction for the fixed size buffer pool only. The new type can used to allocate a buffer pool from hardware fixed size buffer manager without any metadata for queueable. something like, pool = odp_buffer_pool_create(); odp_buffer_t x = odp_buffer_alloc(pool);

Re: [lng-odp] [PATCH 2/3] validation: buffer: fix for the use of cached return value of odp_packet_last_seg

2015-01-19 Thread Ola Liljedahl
On 17 January 2015 at 23:22, Taras Kondratiuk taras.kondrat...@linaro.org wrote: On 01/17/2015 01:29 PM, Jerin Jacob wrote: odp_packet_seg_t is an opaque type, based on the implementation, the return value of odp_packet_last_seg can be changed after headroom/tailroom push/pull operation. No.

Re: [lng-odp] [PATCH] helper: ip: add IP protocol value for sctp

2015-01-19 Thread Bill Fischofer
Two questions: 1. We previously said we didn't need SCTP support for ODP v1.0, so why is this needed? 2. This is a helper, so it's not necessarily constrained by what may be covered by ODP v1.0, but in that case why limit this to SCTP? There are lots of other IP protocols that

Re: [lng-odp] dpdk-pktgen CPU load balancing (Is thread affinity a lie?)

2015-01-19 Thread Wiles, Keith
On 1/19/15, 10:44 AM, Zoltan Kiss zoltan.k...@linaro.org wrote: Hi, I've found this in the README: A new feature for pktgen and DPDK is to run multiple instances of pktgen. This allows the developer to share ports on the same machine. But nothing more about running it in multiple instances.

Re: [lng-odp] dpdk-pktgen CPU load balancing (Is thread affinity a lie?)

2015-01-19 Thread Zoltan Kiss
Hi, I've found this in the README: A new feature for pktgen and DPDK is to run multiple instances of pktgen. This allows the developer to share ports on the same machine. But nothing more about running it in multiple instances. I've tried to run the latest version with 1.8 DPDK, but it

Re: [lng-odp] [PATCH] linux-generic: implement of odp_term_global.

2015-01-19 Thread Mike Holmes
There appear to be a lot of whitespace changes, I assume they are checkpatch cleanups in a number of cases. Can we move all the non functional whitespace changes to their own patch so that the logic of the change is more apparent in a single patch. On 19 January 2015 at 06:34, Yan Songming

Re: [lng-odp] [PATCHv4 0/2] configure.ac check for atomic operations support

2015-01-19 Thread Maxim Uvarov
Ping! Maxim. On 12/29/2014 05:58 PM, Maxim Uvarov wrote: v4: check issues after v3 discusstions: (spell, remote uint32_t, remove Octeon code). Maxim Uvarov (2): linux-generic: remove octeon specific code from odp_atomic_fetch_inc_u32 configure.ac check for atomic operations