-Original Message-
From: ext Ola Liljedahl [mailto:ola.liljed...@linaro.org]
Sent: Wednesday, January 28, 2015 1:29 PM
To: Savolainen, Petri (NSN - FI/Espoo)
Cc: LNG ODP Mailman List
Subject: Re: [lng-odp] odp_cpumask.h
On 28 January 2015 at 12:21, Savolainen, Petri (NSN -
short subject says that you fixed compilation error, what is compilation
error was there?
Please change description to something more clear and put reference to
bug to long log.
Maxim.
On 01/27/2015 03:31 PM, Ciprian Barbu wrote:
Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org
---
Packet offset set routines now verify that offset is not
beyond packet length. IPSec example was attempting to set
offsets before setting length to total packet length, causing
a seg fault when code later tries to use L3 offset.
Signed-off-by: Robbie King robk...@cisco.com
---
Add internal API to allow implementation to copy packet metatdata
when replicating a packet. Add the call to crypto to fix test
failure.
Signed-off-by: Robbie King robk...@cisco.com
---
platform/linux-generic/include/odp_packet_internal.h | 2 ++
platform/linux-generic/odp_crypto.c
On 2015-01-27 21:41, Bill Fischofer wrote:
On Tue, Jan 27, 2015 at 4:44 PM, Geoffrey Blake geoffrey.bl...@arm.com
wrote:
From: Geoffrey Blake geoffrey.bl...@arm.com
Signed-off-by: Geoffrey Blake geoffrey.bl...@arm.com
Reviewed-and-tested-by: Bill Fischofer bill.fischo...@linaro.org
v1 - Move completion event allocation into implementation,
allow synchronous implementation to return status
immediately (i.e. no completion event involved).
Fix two crypto related issues found during debug.
v2 - Merged with odp_event_t changes.
v3 - Changed bool to odp_bool_t
Signed-off-by: Robbie King robk...@cisco.com
---
example/ipsec/odp_ipsec.c| 12 ++--
example/ipsec/odp_ipsec_cache.c | 2 +-
example/ipsec/odp_ipsec_cache.h | 4 ++--
example/ipsec/odp_ipsec_misc.h
Reviewed-by: Petri Savolainen petri.savolai...@linaro.org
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Bill Fischofer
Sent: Wednesday, January 28, 2015 12:37 AM
To: lng-odp@lists.linaro.org
Subject: [lng-odp]
On 2015-01-27 16:44, Geoffrey Blake wrote:
From: Geoffrey Blake geoffrey.bl...@arm.com
Create an opaque tagged pointer type for 32 and 64bit
architectures with large tags to avoid the ABA problem with the lockless stack
used in the buffer allocation code. Compiles cleanly under
x86_64 and
On 2015-01-27 21:42, Bill Fischofer wrote:
On Tue, Jan 27, 2015 at 4:44 PM, Geoffrey Blake geoffrey.bl...@arm.com
wrote:
From: Geoffrey Blake geoffrey.bl...@arm.com
Signed-off-by: Geoffrey Blake geoffrey.bl...@arm.com
Reviewed-and-tested-by: Bill Fischofer bill.fischo...@linaro.org
On 28 January 2015 at 11:48, Ola Liljedahl ola.liljed...@linaro.org wrote:
* @param strOutput buffer
* @param lenSize of string length (incl. ending zero)
*/
void odp_cpumask_to_str(const odp_cpumask_t *mask, char *str, int len);
Why don't we use size_t for thelen parameter?
And
On 01/28/2015 01:44 AM, Geoffrey Blake wrote:
From: Geoffrey Blake geoffrey.bl...@arm.com
Create an opaque tagged pointer type for 32 and 64bit
architectures with large tags to avoid the ABA problem with the lockless stack
used in the buffer allocation code. Compiles cleanly under
x86_64 and
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Ola Liljedahl
Sent: Wednesday, January 28, 2015 12:48 PM
To: LNG ODP Mailman List
Subject: [lng-odp] odp_cpumask.h
* @param strOutput buffer
* @param len
On 2015-01-27 16:36, Bill Fischofer wrote:
Change odp_packet_error() to odp_packet_has_error() and delete
odp_packet_errflag_frame_len() per v1.0 delta doc.
I miss the rational for this... add it in here instead of pointing to a
delta doc... that isn't linked here...
Cheers,
Anders
On 2015-01-28 14:12, Maxim Uvarov wrote:
Directory:
platform/linux-generic/include/api/odp
and:
include/odp/api
have the same files. Did you do copy instead of move?
I did a git move... but git didn't figure out that when I added new
files at the old location... =(
Cheers,
Anders
-Original Message-
From: ext Ola Liljedahl [mailto:ola.liljed...@linaro.org]
Sent: Wednesday, January 28, 2015 2:03 PM
To: Savolainen, Petri (NSN - FI/Espoo)
Cc: LNG ODP Mailman List
Subject: Re: [lng-odp] odp_cpumask.h
On 28 January 2015 at 12:55, Savolainen, Petri (NSN -
On 28 January 2015 at 12:55, Savolainen, Petri (NSN - FI/Espoo)
petri.savolai...@nsn.com wrote:
-Original Message-
From: ext Ola Liljedahl [mailto:ola.liljed...@linaro.org]
Sent: Wednesday, January 28, 2015 1:29 PM
To: Savolainen, Petri (NSN - FI/Espoo)
Cc: LNG ODP Mailman List
The delta doc is the rationale. We're executing to that plan.
On Wed, Jan 28, 2015 at 6:11 AM, Anders Roxell anders.rox...@linaro.org
wrote:
On 2015-01-27 16:36, Bill Fischofer wrote:
Change odp_packet_error() to odp_packet_has_error() and delete
odp_packet_errflag_frame_len() per v1.0
Merged!
Maxim.
On 01/23/2015 11:30 PM, Anders Roxell wrote:
cleanup and update doxygen comments
Anders Roxell (4):
api: cpumask: doxygen: cpumask_first: use app language
api: cpumask: doxygen: add param to odp_cpumask_first
api: cpumask: doxygen: cpumask_last: use app language
On 28 January 2015 at 12:21, Savolainen, Petri (NSN - FI/Espoo)
petri.savolai...@nsn.com wrote:
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Ola Liljedahl
Sent: Wednesday, January 28, 2015 12:48 PM
To: LNG ODP
The following code compiles without warnings or errors:
#include assert.h
#include stddef.h
#include stdio.h
#include stdlib.h
#include sys/types.h
#include odp_cpumask.h
void test(odp_cpumask_t mask)
{
/* Start with a small value so that a retry will be forced */
size_t len = 1;
Done anybody else work on testing/reviewing this?
Maxim.
On 01/28/2015 02:55 AM, Anders Roxell wrote:
The following changes since commit 30b60c59ccf88fc04401c772862ca4770cd6d900:
test: makefile: remove check_PROGRAMS (2015-01-27 20:17:29 +0300)
are available in the git repository at:
* @param strOutput buffer
* @param lenSize of string length (incl. ending zero)
*/
void odp_cpumask_to_str(const odp_cpumask_t *mask, char *str, int len);
Why don't we use size_t for thelen parameter?
-- Ola
___
lng-odp mailing list
On 28 January 2015 at 13:28, Savolainen, Petri (NSN - FI/Espoo)
petri.savolai...@nsn.com wrote:
-Original Message-
From: ext Ola Liljedahl [mailto:ola.liljed...@linaro.org]
Sent: Wednesday, January 28, 2015 2:03 PM
To: Savolainen, Petri (NSN - FI/Espoo)
Cc: LNG ODP Mailman List
(maybe your audio was breaking on call yesterday on that part).
I have tested mixing size_t and ssize_t and neither gcc nor clang
complained. I was using -Wall -ansi -pedantic.
Missing -W from there ? -Wall is not enough...
___
lng-odp mailing list
Directory:
platform/linux-generic/include/api/odp
and:
include/odp/api
have the same files. Did you do copy instead of move?
Maxim.
On 01/28/2015 01:50 PM, Maxim Uvarov wrote:
Done anybody else work on testing/reviewing this?
Maxim.
On 01/28/2015 02:55 AM, Anders Roxell wrote:
The following
I only ran it so far, there is a lot to look at :)
I think Taras is actually basing his work on these changes as they make
managing a platform easier, his comment will be valuable.
On 28 January 2015 at 06:52, Anders Roxell anders.rox...@linaro.org wrote:
On 2015-01-28 14:12, Maxim Uvarov
On 28 January 2015 at 12:55, Savolainen, Petri (NSN - FI/Espoo)
petri.savolai...@nsn.com wrote:
-Original Message-
From: ext Ola Liljedahl [mailto:ola.liljed...@linaro.org]
Sent: Wednesday, January 28, 2015 1:29 PM
To: Savolainen, Petri (NSN - FI/Espoo)
Cc: LNG ODP Mailman List
On Wed, Jan 28, 2015 at 12:02:45PM -0500, Mike Holmes wrote:
Any resolution, I know there have been discussions on going but I need to
know if this is in 0.10.0
According to Petri, Application expects to reuse the seg handle after push/pull
operations.
so, No need to change the existing
Signed-off-by: Robbie King robk...@cisco.com
---
example/ipsec/odp_ipsec.c| 15 +--
platform/linux-generic/include/odp_buffer_internal.h | 8
platform/linux-generic/odp_buffer.c | 7 +++
platform/linux-generic/odp_crypto.c
Add internal API to allow implementation to copy packet metatdata
when replicating a packet. Add the call to crypto to fix test
failure.
Signed-off-by: Robbie King robk...@cisco.com
---
platform/linux-generic/include/odp_packet_internal.h | 2 ++
platform/linux-generic/odp_crypto.c
v1 - Move completion event allocation into implementation,
allow synchronous implementation to return status
immediately (i.e. no completion event involved).
Fix two crypto related issues found during debug.
v2 - Merged with odp_event_t changes.
v3 - Changed bool to odp_bool_t
Any resolution to this for 0.10.0 ?
On 22 January 2015 at 09:56, Taras Kondratiuk taras.kondrat...@linaro.org
wrote:
Sorry if formatting is wrong. Replying from a phone.
On Jan 21, 2015 6:14 PM, Mario Torrecillas Rodriguez
mario.torrecillasrodrig...@arm.com wrote:
Added odp_errno.c and
Any resolution, I know there have been discussions on going but I need to
know if this is in 0.10.0
On 27 January 2015 at 09:12, Mike Holmes mike.hol...@linaro.org wrote:
Can we resolve this for 0.10.0
On 25 January 2015 at 22:40, Jerin Jacob jerin.ja...@caviumnetworks.com
wrote:
On Sun,
On 28 January 2015 at 17:23, Maxim Uvarov maxim.uva...@linaro.org wrote:
If you want to add returns you need to do it in all other examples also.
Someone should do it. We are not stopping Ciprian's patch because it
did not fix the whole universe?
Like example/packet
Maxim.
On 01/28/2015
https://bugs.linaro.org/show_bug.cgi?id=1168
Bug ID: 1168
Summary: odp_schedule test can create more threads than
ODP_CONFIG_MAX_THREADS
Product: OpenDataPlane
Version: 0.9
Hardware: All
OS: Linux
Rename odp_packet_error() to odp_packet_has_error() and delete
odp_packet_errflag_frame_len() for consistency with related
packet APIs.
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
example/generator/odp_generator.c | 2 +-
example/ipsec/odp_ipsec.c
I rebooted and made a new sandbox
I get the same result as Anders if I run the test/performance tests, or the
ones I mentioned with test/validation, I attached a log from both dirs and
there are some core dumps below.
I then did the reverse and took the patches out again
git reset origin/master
Rename odp_packet_error() to odp_packet_has_error() and delete
odp_packet_errflag_frame_len() for consistency with related
packet APIs as requested and approved by Petri.
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
example/generator/odp_generator.c | 2 +-
Hi,
Updated after Taras suggestions.
The following changes since commit 1641fe42647802a9191a50ab73035ada8f5d3349:
api: cpumask: doxygen: add param to odp_cpumask_last (2015-01-28 15:49:23
+0300)
are available in the git repository at:
git://git.linaro.org/people/anders.roxell/odp.git
On 28 January 2015 at 16:23, Taras Kondratiuk
taras.kondrat...@linaro.org wrote:
On 01/28/2015 02:02 PM, Mike Holmes wrote:
I only ran it so far, there is a lot to look at :)
I think Taras is actually basing his work on these changes as they make
managing a platform easier, his comment will
Hmmm, I cannot compile the validation tests as CUnit (using libcunit1 from
apt-get) is trying to incorrectly cast a const char* string literal to a char*
in its datastructures. This is usually a warning but ODP sets -Werror. Looking
at the svn repo for CUnit, it appears this hasn't been
https://bugs.linaro.org/show_bug.cgi?id=1161
Bug ID: 1161
Summary: l2fwd pktio_queue_thread missing return statement
Product: OpenDataPlane
Version: 0.9
Hardware: Other
OS: Linux
Status: UNCONFIRMED
Ignore this patch, I will create a new bug for the missing return
statements and send 2 patches instead.
On Wed, Jan 28, 2015 at 3:11 PM, Maxim Uvarov maxim.uva...@linaro.org wrote:
short subject says that you fixed compilation error, what is compilation
error was there?
Please change
https://bugs.linaro.org/show_bug.cgi?id=1161
--- Comment #1 from Ciprian Barbu ciprian.ba...@linaro.org ---
The behavior is quite peculiar, it almost looks like gcc figures out that the
function never exists the for loop so it doesn't complain about the missing
return statement, but replacing
Fix for https://bugs.linaro.org/show_bug.cgi?id=1161
Signe-off-by: Ciprian Barbu ciprian.ba...@linaro.org
---
example/l2fwd/odp_l2fwd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/example/l2fwd/odp_l2fwd.c b/example/l2fwd/odp_l2fwd.c
index 150de18..7c4e8bd 100644
---
Really simple fixes as described by the bugzilla tickets
Ciprian Barbu (2):
example: l2fwd: fix incorrect cpumask used when spawning threads
example: l2fwd: add return statements in thread functions
example/l2fwd/odp_l2fwd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--
On 01/28/2015 10:53 PM, Bill Fischofer wrote:
Wouldn't a cleaner fix be to change the routine signature from void *
to void? It doesn't return so why should if have a return type in its
signature in the first place?
Because it's thread created with pthread:
int
Thanks to Petri's suggestion about using typed pointers, I have a set of
updates that re-introduce strong typing but still allow the normal C == and
!= operators to work. I'll post it after Anders' API restructure patch is
merged since that's higher priority and it will need to be rebased after
If you want to add returns you need to do it in all other examples also.
Like example/packet
Maxim.
On 01/28/2015 07:01 PM, Ciprian Barbu wrote:
Fix for https://bugs.linaro.org/show_bug.cgi?id=1161
Signe-off-by: Ciprian Barbu ciprian.ba...@linaro.org
---
example/l2fwd/odp_l2fwd.c | 2 ++
https://bugs.linaro.org/show_bug.cgi?id=1165
Bug ID: 1165
Summary: The additional checking maco POOL_ERROR_CHECK is
broken
Product: OpenDataPlane
Version: 0.9
Hardware: Other
OS: Linux
Status:
Talking about API's that take some type of element count or buffer
size as input and return a value related to that. There seems to be a
number of different models.
/**
* Generate random byte string
*
* @param buf Pointer to store result
* @param len Pointer to input length
I cannot seem to reproduce the segmentation faults on the 4 machines I tested
on.
4-core ARM A15 development board: All pass except for odp_pktio_run (no veth
support) and odp_system(no huge pages support)
8-core X86_64 Avoton microserver: All pass
8c/16t X86_64 Xeon: All pass
4c/8t X86_64 Xeon:
On 28 January 2015 at 14:03, Geoffrey Blake geoffrey.bl...@arm.com wrote:
I cannot seem to reproduce the segmentation faults on the 4 machines I
tested on.
4-core ARM A15 development board: All pass except for odp_pktio_run (no
veth support) and odp_system(no huge pages support)
8-core
Wouldn't a cleaner fix be to change the routine signature from void * to
void? It doesn't return so why should if have a return type in its
signature in the first place?
On Wed, Jan 28, 2015 at 11:08 AM, Ola Liljedahl ola.liljed...@linaro.org
wrote:
On 28 January 2015 at 17:23, Maxim Uvarov
https://bugs.linaro.org/show_bug.cgi?id=1165
Bill Fischofer bill.fischo...@linaro.org changed:
What|Removed |Added
Severity|normal |minor
56 matches
Mail list logo
