[lng-odp] [PATCHv3] example: l2fwd print packets per second

2015-03-17 Thread Maxim Uvarov
Current print in l2fwd is not useful with slow links and also it's hard to say how fast does it work. Print pps and packets drops. Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org --- v3: alloc memory for counter in worker threads to avoid cache misses. This patch is independent of 'make

[lng-odp] [RFC 1/4] spinlock: allow platform to override odp_spinlock_t

2015-03-17 Thread Jerin Jacob
Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com --- include/odp/api/spinlock.h | 10 -- .../include/odp/plat/spinlock_types.h | 42 ++ platform/linux-generic/include/odp/spinlock.h | 2 ++ 3 files changed, 44

[lng-odp] [RFC 3/4] ticketlock: allow platform to override odp_ticketlock_t

2015-03-17 Thread Jerin Jacob
Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com --- include/odp/api/ticketlock.h | 12 -- .../include/odp/plat/ticketlock_types.h| 43 ++ platform/linux-generic/include/odp/ticketlock.h| 2 + 3 files changed, 45

[lng-odp] [RFC 4/4] barrier: allow platform to override odp_barrier_t

2015-03-17 Thread Jerin Jacob
Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com --- include/odp/api/barrier.h | 9 - platform/linux-generic/include/odp/barrier.h | 1 + .../linux-generic/include/odp/plat/barrier_types.h | 44 ++ 3 files changed, 45

[lng-odp] [RFC 0/4] Move the definition of odp syncronizers abstract types to platform

2015-03-17 Thread Jerin Jacob
Move the definition of odp syncronizers abstract types to platform from public headerfile. This will allow platform define odp syncronizers abstract type. Useful when native SDK has definition of the odp syncronizers and ODP implementation decides to reuses them. Jerin Jacob (4): spinlock:

[lng-odp] [RFC 2/4] rwlock: allow platform to override odp_rwlock_t

2015-03-17 Thread Jerin Jacob
Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com --- include/odp/api/rwlock.h | 12 -- .../linux-generic/include/odp/plat/rwlock_types.h | 45 ++ platform/linux-generic/include/odp/rwlock.h| 2 + 3 files changed, 47

Re: [lng-odp] [RFC 1/4] spinlock: allow platform to override odp_spinlock_t

2015-03-17 Thread Savolainen, Petri (Nokia - FI/Espoo)
All these changes are needed. Just copy the mechanism from other abstract typedefs we have already. See comments under. -Original Message- From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp- boun...@lists.linaro.org] On Behalf Of ext Jerin Jacob Sent: Tuesday, March 17, 2015 9:26

[lng-odp] [PATCH] performance: odp_atomic: move atomic test from api_test to performance

2015-03-17 Thread Mike Holmes
Signed-off-by: Mike Holmes mike.hol...@linaro.org --- test/api_test/.gitignore | 1 - test/api_test/Makefile.am | 6 +- test/api_test/odp_atomic_test.h| 51 test/api_test/odp_common.c |

[lng-odp] [PATCH] move odp_atomic from api_test to performance directory

2015-03-17 Thread Mike Holmes
The odp_atomic test can form the basis for testing the scalability of the atomic api. Move it so that the api_test dir may be deleted and the odp_atomic test can be run as part of test/performance Mike Holmes (1): performance: odp_atomic: move atomic test from api_test to performance

[lng-odp] [PATCHv2 0/3] Fixes for https://bugs.linaro.org/show_bug.cgi?id=1284

2015-03-17 Thread Ciprian Barbu
v2: - fixed patch 3 Like in the previous RFC, the first patch is the fix. The second and third patch represent a proposed fix for freeing the ODP_QUEUE_TYPE_SCHED queues that were not removed from the internal priority queues because the scheduler did not know they were empty. Ciprian Barbu (3):

[lng-odp] [PATCHv2 2/3] linux-generic: queue: add queue_is_destroyed internal call

2015-03-17 Thread Ciprian Barbu
Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org --- platform/linux-generic/include/odp_queue_internal.h | 9 + 1 file changed, 9 insertions(+) diff --git a/platform/linux-generic/include/odp_queue_internal.h b/platform/linux-generic/include/odp_queue_internal.h index

Re: [lng-odp] [PATCH] linux-generic: queue: fix potential queue leak

2015-03-17 Thread Maxim Uvarov
Merged, Maxim. On 03/17/15 04:40, Bill Fischofer wrote: On Mon, Mar 16, 2015 at 8:58 AM, Stuart Haslam stuart.has...@linaro.org mailto:stuart.has...@linaro.org wrote: If schedule buffer allocation fails during odp_queue_create(), a scheduled or pktin queue may be incorrectly left

[lng-odp] [PATCHv2 1/3] validation: pktio: add support for VPATH builds

2015-03-17 Thread Stuart Haslam
Running make check in a VPATH build fails as the odp_pktio_run script incorrectly assumes that the odp_pktio binary is in the same directory. Resolve this by passing the path to the test binary to the script via the TESTS_ENVIRONMENT variable. Signed-off-by: Stuart Haslam stuart.has...@linaro.org

[lng-odp] [PATCHv2 3/3] performance: scheduling: add support for VPATH builds

2015-03-17 Thread Stuart Haslam
Pass the test executable path to the test script to avoid the assumption that they're both in the same directory. Signed-off-by: Stuart Haslam stuart.has...@linaro.org --- Change in v2; correct name of executable test/performance/Makefile.am| 2 ++ test/performance/odp_scheduling_run |

Re: [lng-odp] [PATCH] linux-generic: strongtypes: add dummy struct var to keep c++ happy

2015-03-17 Thread Maxim Uvarov
Merged, Maxim. On 03/13/15 22:29, Mike Holmes wrote: On 12 March 2015 at 17:36, Bill Fischofer bill.fischo...@linaro.org mailto:bill.fischo...@linaro.org wrote: C++ doesn't like null structs so add a dummy variable to make it happy. Note that we only use these types as

Re: [lng-odp] [PATCHv2 2/2] tests: performance add l2fwd to run script

2015-03-17 Thread Stuart Haslam
On Mon, Mar 16, 2015 at 06:56:19PM +0300, Maxim Uvarov wrote: On 03/16/15 14:09, Stuart Haslam wrote: On Fri, Mar 13, 2015 at 06:03:47PM +0300, Maxim Uvarov wrote: Move common pktio linux-generic functions to setup virtual net to linux-generic folder and add running l2fwd test for make check.

Re: [lng-odp] [PATCH 3/3] linux-generic: schedule: make sure SCHED queues get freed by the scheduler

2015-03-17 Thread Ciprian Barbu
On Tue, Mar 17, 2015 at 3:43 AM, Bill Fischofer bill.fischo...@linaro.org wrote: Code should not have #if 0 or #if 1 in them. Leftover from debugging? Yup, sorry about that. On Mon, Mar 16, 2015 at 10:16 AM, Maxim Uvarov maxim.uva...@linaro.org wrote: On 03/16/15 17:51, Ciprian Barbu

Re: [lng-odp] [PATCH 2/3] performance: scheduling: catch exit codes

2015-03-17 Thread Stuart Haslam
On Tue, Mar 17, 2015 at 11:44:10AM +0200, Ciprian Barbu wrote: On Mon, Mar 16, 2015 at 1:48 PM, Stuart Haslam stuart.has...@linaro.org wrote: odp_scheduling_run always exits with code 0 so make check will never report failures. Signed-off-by: Stuart Haslam stuart.has...@linaro.org ---

Re: [lng-odp] [PATCH 2/3] performance: scheduling: catch exit codes

2015-03-17 Thread Ciprian Barbu
On Mon, Mar 16, 2015 at 1:48 PM, Stuart Haslam stuart.has...@linaro.org wrote: odp_scheduling_run always exits with code 0 so make check will never report failures. Signed-off-by: Stuart Haslam stuart.has...@linaro.org --- test/performance/odp_scheduling_run | 6 +- 1 file changed, 5

[lng-odp] [PATCHv2 3/3] linux-generic: schedule: make sure SCHED queues get freed by the scheduler

2015-03-17 Thread Ciprian Barbu
ODP_QUEUE_TYPE_SCHED queues only get marked as destroyed, they need to be removed from the pri_queues of the linux-generic scheduler Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org --- v2: - removed #if 1 and trailing whitespaces platform/linux-generic/odp_schedule.c | 22

[lng-odp] [PATCHv2 1/3] validation: schedule: free queues and pool

2015-03-17 Thread Ciprian Barbu
With the implementation of termination APIs it is now necessarry to cleanup all allocated resources, queues and pool in this case. Fixes https://bugs.linaro.org/show_bug.cgi?id=1284 Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org --- test/validation/odp_schedule.c | 56

[lng-odp] [RFC v2 2/4] rwlock: allow platform to override odp_rwlock_t

2015-03-17 Thread Jerin Jacob
Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com --- include/odp/api/rwlock.h | 11 + .../linux-generic/include/odp/plat/rwlock_types.h | 48 ++ platform/linux-generic/include/odp/rwlock.h| 2 + 3 files changed, 52

[lng-odp] [RFC v2 3/4] ticketlock: allow platform to override odp_ticketlock_t

2015-03-17 Thread Jerin Jacob
Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com --- include/odp/api/ticketlock.h | 12 +- .../include/odp/plat/ticketlock_types.h| 46 ++ platform/linux-generic/include/odp/ticketlock.h| 2 + 3 files changed, 50

[lng-odp] [RFC v2 0/4] Move the definition of odp syncronizers abstract types to platform

2015-03-17 Thread Jerin Jacob
Move the definition of odp syncronizers abstract types to platform from public headerfile. This will allow platform define odp syncronizers abstract type. Useful when native SDK has definition of the odp syncronizers and ODP implementation decides to reuses them. v1..v2 Corrected Doxygen

[lng-odp] [RFC v2 1/4] spinlock: allow platform to override odp_spinlock_t

2015-03-17 Thread Jerin Jacob
Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com --- include/odp/api/spinlock.h | 10 + .../include/odp/plat/spinlock_types.h | 46 ++ platform/linux-generic/include/odp/spinlock.h | 2 + 3 files changed, 50

Re: [lng-odp] [PATCHv2] validation: pktio: prevent race when using veth pair

2015-03-17 Thread Maxim Uvarov
Merged, Maxim. On 03/16/15 15:27, Stuart Haslam wrote: There's a potential race condition whereby the test case could start running before the virtual ethernet interfaces are fully brought up. So replace the the arbitrary delay with a check for the interface's operational state before kicking

[lng-odp] [RFC v2 4/4] barrier: allow platform to override odp_barrier_t

2015-03-17 Thread Jerin Jacob
Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com --- include/odp/api/barrier.h | 7 +--- platform/linux-generic/include/odp/barrier.h | 1 + .../linux-generic/include/odp/plat/barrier_types.h | 47 ++ 3 files changed, 49 insertions(+),

Re: [lng-odp] [PATCHv2] validation: timer: added cancel test

2015-03-17 Thread Maxim Uvarov
Merged, Maxim. On 03/17/15 04:38, Bill Fischofer wrote: For the additions: Reviewed-by: Bill Fischofer bill.fischo...@linaro.org mailto:bill.fischo...@linaro.org On Mon, Mar 16, 2015 at 8:55 AM, Ola Liljedahl ola.liljed...@linaro.org mailto:ola.liljed...@linaro.org wrote: On 12 March

[lng-odp] [PATCHv2 2/3] performance: scheduling: catch exit codes

2015-03-17 Thread Stuart Haslam
odp_scheduling_run always exits with code 0 so make check will never report failures. Signed-off-by: Stuart Haslam stuart.has...@linaro.org --- Change in v2; correct name of executable test/performance/odp_scheduling_run | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[lng-odp] [PATCH] doc: doxygen: add declaring variables

2015-03-17 Thread Mike Holmes
Signed-off-by: Mike Holmes mike.hol...@linaro.org --- doc/api_guide_lines.dox | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/api_guide_lines.dox b/doc/api_guide_lines.dox index 4cfe088..2bc63a1 100644 --- a/doc/api_guide_lines.dox +++ b/doc/api_guide_lines.dox @@ -149,6

Re: [lng-odp] [RFC v2 3/4] ticketlock: allow platform to override odp_ticketlock_t

2015-03-17 Thread Bill Fischofer
This part also fails make distcheck with error: CC odp_buffer.lo In file included from ../../../platform/linux-generic/include/odp_pool_internal.h:65:0, from ../../../platform/linux-generic/odp_buffer.c:8: ../../../platform/linux-generic/include/odp/ticketlock.h:20:39:

Re: [lng-odp] [RFC v2 4/4] barrier: allow platform to override odp_barrier_t

2015-03-17 Thread Bill Fischofer
This part fails make distcheck with error: CC odp_barrier.lo In file included from ../../../platform/linux-generic/odp_barrier.c:7:0: ../../../platform/linux-generic/include/odp/barrier.h:22:36: fatal error: odp/plat/barrier_types.h: No such file or directory #include

Re: [lng-odp] [RFC v2 1/4] spinlock: allow platform to override odp_spinlock_t

2015-03-17 Thread Bill Fischofer
This part fails make distcheck with error: In file included from ../../../platform/linux-generic/include/odp_packet_io_internal.h:21:0, from ../../../platform/linux-generic/odp_classification.c:15: ../../../platform/linux-generic/include/odp/spinlock.h:20:37: fatal error:

Re: [lng-odp] [RFC v2 2/4] rwlock: allow platform to override odp_rwlock_t

2015-03-17 Thread Bill Fischofer
This part also fails make distcheck with error: CC odp_classification.lo In file included from ../../../platform/linux-generic/include/odp_packet_io_internal.h:21:0, from ../../../platform/linux-generic/odp_classification.c:15:

Re: [lng-odp] [RFC v2 0/4] Move the definition of odp syncronizers abstract types to platform

2015-03-17 Thread Bill Fischofer
On further analysis the make distcheck errors I reported for the parts of this seem to be artifacts of check-odp. I can't make them happen manually so I'm not sure what the issue might be. Anders: Can you take a look at this and advise? In any event, the patches apply cleanly and all tests

Re: [lng-odp] [PATCHv2 0/3] Fixes for https://bugs.linaro.org/show_bug.cgi?id=1284

2015-03-17 Thread Bill Fischofer
For this series: Reviewed-and-tested-by: Bill Fischofer bill.fischo...@linaro.org On Tue, Mar 17, 2015 at 4:53 AM, Ciprian Barbu ciprian.ba...@linaro.org wrote: v2: - fixed patch 3 Like in the previous RFC, the first patch is the fix. The second and third patch represent a proposed fix for

Re: [lng-odp] [PATCH] doc: doxygen: add declaring variables

2015-03-17 Thread Bill Fischofer
On Tue, Mar 17, 2015 at 1:57 PM, Mike Holmes mike.hol...@linaro.org wrote: Signed-off-by: Mike Holmes mike.hol...@linaro.org Reviewed-by: Bill Fischofer bill.fischo...@linaro.org --- doc/api_guide_lines.dox | 15 +++ 1 file changed, 15 insertions(+) diff --git

Re: [lng-odp] ipc for odp

2015-03-17 Thread Ciprian Barbu
On Fri, Mar 13, 2015 at 5:30 PM, Ola Liljedahl ola.liljed...@linaro.org wrote: On 13 March 2015 at 13:35, Maxim Uvarov maxim.uva...@linaro.org wrote: On 03/13/15 13:43, Ciprian Barbu wrote: On Fri, Mar 13, 2015 at 11:34 AM, Ola Liljedahl ola.liljed...@linaro.org wrote: When I think about

Re: [lng-odp] [PATCH 1/2] validation: timer: use ODP_SHM_NULL

2015-03-17 Thread Maxim Uvarov
Merged, Maxim. On 03/06/15 20:30, Mike Holmes wrote: On 6 March 2015 at 09:30, Petri Savolainen petri.savolai...@nokia.com mailto:petri.savolai...@nokia.com wrote: Use ODP_SHM_NULL to select default shm memory in odp_pool_create(), instead of ODP_SHM_INVALID. Signed-off-by:

Re: [lng-odp] [PATCH] doc: move api guidelines to API doc

2015-03-17 Thread Mike Holmes
ping On 11 March 2015 at 14:43, Bill Fischofer bill.fischo...@linaro.org wrote: On Wed, Mar 11, 2015 at 1:24 PM, Mike Holmes mike.hol...@linaro.org wrote: This documentation was moved from the architecture doc to this API doc. Signed-off-by: Mike Holmes mike.hol...@linaro.org

Re: [lng-odp] ipc for odp

2015-03-17 Thread Maxim Uvarov
On 03/17/15 14:30, Ciprian Barbu wrote: On Fri, Mar 13, 2015 at 5:30 PM, Ola Liljedahl ola.liljed...@linaro.org wrote: On 13 March 2015 at 13:35, Maxim Uvarov maxim.uva...@linaro.org wrote: On 03/13/15 13:43, Ciprian Barbu wrote: On Fri, Mar 13, 2015 at 11:34 AM, Ola Liljedahl

Re: [lng-odp] [PATCH] doc: move api guidelines to API doc

2015-03-17 Thread Mike Holmes
ping On 11 March 2015 at 14:43, Bill Fischofer bill.fischo...@linaro.org wrote: On Wed, Mar 11, 2015 at 1:24 PM, Mike Holmes mike.hol...@linaro.org wrote: This documentation was moved from the architecture doc to this API doc. Signed-off-by: Mike Holmes mike.hol...@linaro.org

Re: [lng-odp] ipc for odp

2015-03-17 Thread Ciprian Barbu
On Tue, Mar 17, 2015 at 1:44 PM, Maxim Uvarov maxim.uva...@linaro.org wrote: On 03/17/15 14:30, Ciprian Barbu wrote: On Fri, Mar 13, 2015 at 5:30 PM, Ola Liljedahl ola.liljed...@linaro.org wrote: On 13 March 2015 at 13:35, Maxim Uvarov maxim.uva...@linaro.org wrote: On 03/13/15 13:43,

[lng-odp] [Bug 1365] New: Lock-up following sendmmsg failure

2015-03-17 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1365 Bug ID: 1365 Summary: Lock-up following sendmmsg failure Product: OpenDataPlane Version: 1.0 Hardware: Other OS: Linux Status: UNCONFIRMED Severity:

[lng-odp] UberConference Reminder

2015-03-17 Thread UberConference
UberConference Reminder___ lng-odp mailing list lng-odp@lists.linaro.org http://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [PATCH] doc: move api guidelines to API doc

2015-03-17 Thread Maxim Uvarov
Merged, Maxim. On 03/17/15 15:51, Mike Holmes wrote: ping On 11 March 2015 at 14:43, Bill Fischofer bill.fischo...@linaro.org mailto:bill.fischo...@linaro.org wrote: On Wed, Mar 11, 2015 at 1:24 PM, Mike Holmes mike.hol...@linaro.org mailto:mike.hol...@linaro.org wrote: