[lng-odp] [Bug 1542] Untested API verify_pmr_ip_proto

https://bugs.linaro.org/show_bug.cgi?id=1542 Bala Manoharan changed: What|Removed |Added Resolution|--- |FIXED

[lng-odp] [Bug 1828] Untested internal API verify_pmr_ip_proto

https://bugs.linaro.org/show_bug.cgi?id=1828 Bala Manoharan changed: What|Removed |Added Resolution|--- |DUPLICATE

Re: [lng-odp] [API-NEXT PATCH 3/5] example: use odp_pktio_param_init() API

I can certainly combine them, but I thought our policy was to separate examples from validation, etc. On Thu, Oct 15, 2015 at 6:05 AM, Maxim Uvarov wrote: > I think it's better to have single patch from patches 3,4 and 5, since > they do the same thing. > > Maxim. > >

[lng-odp] [Bug 1546] Untested API verify_pmr_udp_dport

https://bugs.linaro.org/show_bug.cgi?id=1546 Bala Manoharan changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED

Re: [lng-odp] pktio statistic counters

If we're going to follow RFC MIB specifications we should use the field names as specified in the RFCs. We already need to update the checkpatch rules to allow camel case since CUnit uses that anyway. We can simply have a recommendation that ODP doesn't use camel case except in cases like these.

Re: [lng-odp] [PATCHv3 0/5] add ability to mark tests as inactive

Merged, Maxim. On 10/14/2015 15:11, Christophe Milard wrote: That is my point:I think such a macro would make the overloading clearer (more visible). And I agree it can be done later. hence my reviews :-) Christophe. On 14 October 2015 at 14:03, Stuart Haslam

[lng-odp] [Bug 1545] Untested API verify_pmr_tcp_dport

https://bugs.linaro.org/show_bug.cgi?id=1545 Bala Manoharan changed: What|Removed |Added Resolution|--- |FIXED

[lng-odp] [Bug 1544] Untested API verify_pmr_tcp_sport

https://bugs.linaro.org/show_bug.cgi?id=1544 Bala Manoharan changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED

Re: [lng-odp] [API-NEXT/PATCH 1/1] validation: classification: add odp_pktio_param_init() API

On Thu, Oct 15, 2015 at 1:15 AM, Balasubramanian Manoharan < bala.manoha...@linaro.org> wrote: > odp_pktio_param_init() API is used to initialize odp_pktio_param_t params > > Signed-off-by: Balasubramanian Manoharan > Reviewed-by: Bill Fischofer

[lng-odp] [API-NEXT PATCH v4 2/5] example: generator: compare ticks instead of ns in loop

It's more accurate to compare ticks instead of ns in each iteration, so calculate wait range before entering the loop. Signed-off-by: Ivan Khoronzhuk --- example/generator/odp_generator.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git

[lng-odp] [API-NEXT PATCH v4 0/5] api: time: unbind CPU cycles from time API

This seres is intended to unbind time API names from CPU "cycles". Also remove usage of word "cycle" from appropriate places as it's no more valid. This patch series only change API names and adds calls required for that and doesn't add new API functionality. API to get rate of time and delay call

[lng-odp] [API-NEXT PATCH v4 3/5] api: time: unbind CPU cycles from time API

Current time API supposes that frequency of counter is equal to CPU frequency. But that's not always true, for instance, in case if no access to CPU cycle counter, another hi-resolution timer can be used, and it`s rate can be different from CPU rate. There is no big difference in which cycles to

Re: [lng-odp] [API-NEXT PATCH 3/5] example: use odp_pktio_param_init() API

I think it's better to have single patch from patches 3,4 and 5, since they do the same thing. Maxim. On 10/14/2015 14:51, Bill Fischofer wrote: Signed-off-by: Bill Fischofer --- example/classifier/odp_classifier.c | 2 +- example/generator/odp_generator.c | 2

Re: [lng-odp] [PATCH] linux-generic: pktio: fill in L2 parse results by default

Hard to say from looking at this whether this improves OVS performance, which was the main reason lazy parsing was added. Presumably the idea here is that you can use the l2 APIs without triggering a full parse for many applications, so that should be a plus. On Mon, Oct 12, 2015 at 3:15 AM,

Re: [lng-odp] pktio statistic counters

On 15 October 2015 at 13:01, Bill Fischofer wrote: > If we're going to follow RFC MIB specifications we should use the field > names as specified in the RFCs. We already need to update the checkpatch > rules to allow camel case since CUnit uses that anyway. We can

Re: [lng-odp] pktio statistic counters

Camel case should not be used in the API. We can refer to RFC number and terms in documentation, but field names should use ODP style (no camel case). For example, typedef struct { /** The number of octets in valid MAC frames * received on this interface, including * the MAC header

[lng-odp] [API-NEXT PATCH v4 1/5] performance: odp_pktio_perf: fix potential overflow in wait loop

There cannot be used direct comparison of timestamps of counter that can overflow, better to compare ranges. Signed-off-by: Ivan Khoronzhuk --- test/performance/odp_pktio_perf.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git

Re: [lng-odp] [PATCH] linux-generic: packet: use packet metadata copy function on packet realloc

Ping On 09/14/2015 11:14 AM, Nicolas Morey-Chaisemartin wrote: > Remove duplicated code and use preexisting metadata copy function > > Signed-off-by: Nicolas Morey-Chaisemartin > --- > platform/linux-generic/odp_packet.c | 34 ++ > 1 file

[lng-odp] [Bug 1542] Untested API verify_pmr_ip_proto

https://bugs.linaro.org/show_bug.cgi?id=1542 --- Comment #5 from Bala Manoharan --- *** Bug 1828 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug.___

Re: [lng-odp] [API-NEXT/PATCHv5] validation: classification: added additional suite to test individual PMRs

Hi, Bala Just compared this version with requirements for v2 and saw some mistmaches. I didn't analize it deeply, seemply checked what was needed to be changed. See comments below. Sorry, I haven't found v4, and haven't revewed v3. On 14.10.15 08:03, Balasubramanian Manoharan wrote:

Re: [lng-odp] [API-NEXT PATCH 1/5] api: pktio: add odp_pktio_param_init() API

Merged, Maxim. On 10/14/2015 14:51, Bill Fischofer wrote: Signed-off-by: Bill Fischofer --- include/odp/api/packet_io.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/odp/api/packet_io.h b/include/odp/api/packet_io.h index d8e69ed..3479af1

Re: [lng-odp] pktio statistic counters

Please, no Camel casemaybe we can duplicate the struct with names and use convenient one. On 15.10.15 15:12, Mike Holmes wrote: On 15 October 2015 at 13:01, Bill Fischofer > wrote: If we're going to follow RFC MIB

[lng-odp] [API-NEXT PATCH v4 5/5] test/example: avoid "cycle" word usage

The word "cycle" is left from old API time names. The "cycle" is ambiguous word, especially when it can be used for other purposes. So better to use "tick" or "time" word or just "t" symbol. Signed-off-by: Ivan Khoronzhuk --- test/performance/odp_pktio_perf.c |

Re: [lng-odp] [API-NEXT/PATCHv5] validation: classification: added additional suite to test individual PMRs

Merged, Maxim. On 10/15/2015 08:54, Bala Manoharan wrote: Hi Bill, Agreed. Maybe we can merge this patch and then I will send a separate patch to resolve the conflict so that both your patch and the conflict patch could be merged together. IMO, if this patch is acceptable we can merge this as

[lng-odp] [API-NEXT/PATCH 1/1] validation: classification: add odp_pktio_param_init() API

odp_pktio_param_init() API is used to initialize odp_pktio_param_t params Signed-off-by: Balasubramanian Manoharan --- test/validation/classification/odp_classification_test_pmr.c | 2 +- test/validation/classification/odp_classification_tests.c| 2 +- 2 files

Re: [lng-odp] [PATCH] [API-NEXT PATCH v3] api: hash: Added crc32 and crc32c hash functions

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Peng > Sent: Thursday, October 15, 2015 5:31 AM > To: lng-odp@lists.linaro.org > Cc: Peng > Subject: [lng-odp] [PATCH] [API-NEXT PATCH v3] api: hash: Added crc32 and > crc32c hash functions

Re: [lng-odp] [ODP-DPDK] SpanningTree and block a port ?

Hi! Thank you very much for the answer! Regards Nicolas De : Brian Brooks Envoyé : mercredi 7 octobre 2015 15:49 À : Kury Nicolas; lng-odp@lists.linaro.org Objet : RE: [ODP-DPDK] SpanningTree and block a port ? Hi Nicolas, In

Re: [lng-odp] [API-NEXT PATCHv3 1/2] api: config: replace defines with apis

Both patches: Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Bill Fischofer > Sent: Thursday, October 15, 2015 2:02 AM > To: lng-odp@lists.linaro.org > Subject: [lng-odp]

[lng-odp] [PATCH] [API-NEXT PATCH v4] api: hash: Added crc32 and crc32c hash functions

From: Peng v2: Add copyright license. v3: APIs: crc32c, crc32 and generic CRC hash impl linux-generic: add impl for crc32c. v4: linux-generic: change odp_crc32c_1word to crc32c_u32, change odp_crc32c_2words to crc32c_u64, drop inline decorator for

Re: [lng-odp] [PATCH] linux-generic: pktio: remove hyphens from veth interface names

Merged, Maxim. On 10/14/2015 12:39, Stuart Haslam wrote: Recent netmap versions support veth devices so can be tested using the environment setup by the pktio_env script, the only problem is it doesn't like hyphens in interface names: nm_open [839] unexpected character: 'p' pktio-p0-p1

Re: [lng-odp] [PATCH] performance: l2fwd: obey -t in queue mode

Merged, changed short description to test/performance to be clear that it's for tests. Maxim. On 09/10/2015 14:55, Stuart Haslam wrote: The -t command line argument specifies the length of time the application should run before exiting, but this doesn't always work in queue mode as the

Re: [lng-odp] [PATCH] linux-generic: pktio: fill in L2 parse results by default

Ping. > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Petri Savolainen > Sent: Monday, October 12, 2015 11:15 AM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH] linux-generic: pktio: fill in L2 parse results > by default > >

Re: [lng-odp] [API-NEXT/PATCH 1/1] validation: classification: add odp_pktio_param_init() API

This patch needs to be merged after https://patches.linaro.org/54903/ Regards, Bala On 15 October 2015 at 11:45, Balasubramanian Manoharan wrote: > odp_pktio_param_init() API is used to initialize odp_pktio_param_t params > > Signed-off-by: Balasubramanian Manoharan

[lng-odp] [PATCH] [API-NEXT PATCH v5] api: hash: Added crc32 and crc32c hash functions

From: Peng v2: Add copyright license. v3: APIs: crc32c, crc32 and generic CRC hash impl linux-generic: add impl for crc32c. v4: linux-generic: change odp_crc32c_1word to crc32c_u32, change odp_crc32c_2words to crc32c_u64, drop inline decorator for

Re: [lng-odp] [PATCH] [API-NEXT PATCH v5] api: hash: Added crc32 and crc32c hash functions

Reviewed-by: Petri Savolainen > -Original Message- > From: EXT Peng [mailto:xnhp0...@icloud.com] > Sent: Thursday, October 15, 2015 10:51 AM > To: lng-odp@lists.linaro.org > Cc: Savolainen, Petri (Nokia - FI/Espoo); Peng > Subject: [PATCH] [API-NEXT PATCH

Re: [lng-odp] [API-NEXT/PATCHv5] validation: classification: added additional suite to test individual PMRs

On 15.10.15 16:39, Bala Manoharan wrote: Hi Ivan, Thanks for pointing out the issues. Since this patch is merged I will create a bug and add the missing points. Pls provide your inputs on the comments. On 15 October 2015 at 16:53, Ivan Khoronzhuk wrote: Hi, Bala

Re: [lng-odp] [PATCH RFC] Revert "platform: Makefile.inc: use `` instead of != for compatibility with older versions of Make"

It shouldn't depend on catalog the project is built. On 15.10.15 18:10, Ivan Khoronzhuk wrote: This reverts commit a9cc0fc700a4a8b9589404a18136b01974ca4aa3. This revert helps me to revert messages like: "fatal: No names found, cannot describe anything." in case if I build ODP outside of source

Re: [lng-odp] [PATCH RFC] Revert "platform: Makefile.inc: use `` instead of != for compatibility with older versions of Make"

I build it at api-next and see this: ... fatal: No names found, cannot describe anything. CC odp_system_info.lo fatal: No names found, cannot describe anything. CC odp_thread.lo fatal: No names found, cannot describe anything. CC odp_thrmask.lo CC odp_ticketlock.lo

[lng-odp] New ODP Website page created

this story has been completed. A new page was created as requested and added to the navigation structure under Status and the Developer sidebar menu for ease of access. http://www.opendataplane.org/api-documentation/api-differences/ Please test and report any feedback. -- Sincerely, Marshall

[lng-odp] [Bug 1752] timer test: Number of timeouts delivered/received too late: 0

https://bugs.linaro.org/show_bug.cgi?id=1752 Maxim Uvarov changed: What|Removed |Added Resolution|--- |NON REPRODUCIBLE

Re: [lng-odp] [PATCH RFC] Revert "platform: Makefile.inc: use `` instead of != for compatibility with older versions of Make"

Please forget the first two sentences of my previous mail. I started writing an alternate patch and then realized it was fixed in master already. On 10/15/2015 05:20 PM, Nicolas Morey-Chaisemartin wrote: > Maybe changing the directory before running git_hash.sh would fix your issue > and keep

[lng-odp] [PATCH] scripts/git_hash: fix out of tree build

Git hash was modified to handled non git builds but when building out of tree, it detects a .git folder but do not change to this folder to run git command. Signed-off-by: Nicolas Morey-Chaisemartin --- scripts/git_hash.sh | 4 ++-- 1 file changed, 2 insertions(+), 2

[lng-odp] [PATCH RFC] Revert "platform: Makefile.inc: use `` instead of != for compatibility with older versions of Make"

This reverts commit a9cc0fc700a4a8b9589404a18136b01974ca4aa3. This revert helps me to revert messages like: "fatal: No names found, cannot describe anything." in case if I build ODP outside of source catalog by: ../../odp/configure --enable-test-perf --enable-test-vald make Seems it's connected

Re: [lng-odp] [PATCH RFC] Revert "platform: Makefile.inc: use `` instead of != for compatibility with older versions of Make"

Maybe changing the directory before running git_hash.sh would fix your issue and keep the old make working ? Something like This was fixed some time ago: commit 06537738ea438c3e339fc269dedb4ed6c5e48f07 Author: Anders Roxell Date: Fri Aug 14 15:25:05 2015 +0200

Re: [lng-odp] [PATCH RFC] Revert "platform: Makefile.inc: use `` instead of != for compatibility with older versions of Make"

The issue come from git_hash it self. Not the Makefile. I'm sending a patch right now. On 10/15/2015 05:28 PM, Ivan Khoronzhuk wrote: > I build it at api-next and see this: > ... > fatal: No names found, cannot describe anything. > CC odp_system_info.lo > fatal: No names found, cannot

Re: [lng-odp] [PATCH] scripts/git_hash: fix out of tree build

On 15.10.15 18:36, Nicolas Morey-Chaisemartin wrote: Git hash was modified to handled non git builds but when building out of tree, it detects a .git folder but do not change to this folder to run git command. Signed-off-by: Nicolas Morey-Chaisemartin Tested-by: Ivan

[lng-odp] [Bug 1549] Untested API parse_tcp

https://bugs.linaro.org/show_bug.cgi?id=1549 --- Comment #2 from Mike Holmes --- The classification tests generate their own packets and validation tests need to run even on platforms that do not implement pcap pktio as linux-generic does. We have said before that ODP

Re: [lng-odp] New ODP Website page created

How will this page linked through navigation menu? Raj Murali Director - Linaro Networking Group Skype: rajmurali_s │ M: +91 98450 70135 Linaro.org *│ *Open source software for ARM SoCs On 15 October 2015 at 20:59, Marshall Guillory

[lng-odp] [API-NEXT PATCH 2/6] doc: add doxygen layout file to control group page output

Group level documentation can be used for API level general description. Layout file is needed to place detailed group description on the top of a page. By default doxygen shows only the brief description on top (the first sentence). Signed-off-by: Petri Savolainen

[lng-odp] [API-NEXT PATCH 6/6] api: atomic: added 32 bit acquire and release

Added 32 bit acquire load/cas and release store/add/sub calls. These are the minimum set of non-relaxed calls that are needed for building lock-free algorithms. 64 bit versions can be added later. Signed-off-by: Petri Savolainen --- include/odp/api/atomic.h

[lng-odp] [Bug 1365] Lock-up following sendmmsg failure

https://bugs.linaro.org/show_bug.cgi?id=1365 --- Comment #6 from Stuart Haslam --- Updated patches on the list; http://patches.opendataplane.org/patch/3293/ -- You are receiving this mail because: You are on the CC list for the

[lng-odp] [API-NEXT PATCH 1/6] api: doc: remove broken doxygen reference

Reference caused warning when creating doxygen documentation. Signed-off-by: Petri Savolainen --- include/odp/api/packet_io.h| 2 +- platform/linux-generic/include/odp/debug.h | 8 2 files changed, 1 insertion(+), 9 deletions(-) diff --git

[lng-odp] [API-NEXT PATCH 5/6] api: atomic: added cas operations

Added cas operations for 32 and 64 bit atomic variables. These use relaxed memory order (as all other operations). Signed-off-by: Petri Savolainen --- include/odp/api/atomic.h| 37 +

[lng-odp] [API-NEXT PATCH 4/6] api: atomic: clean atomic API documentation

Refined and centralized comment about relaxed memory ordering. Removed in/out doxygen tags since 'atom' pointer to an object that application must not directly access (only through the API). Signed-off-by: Petri Savolainen --- include/odp/api/atomic.h | 112

[lng-odp] [API-NEXT PATCH 3/6] api: doc: re-organize doxygen doc for synchronizer

Removed module synchronizer from doxygen documentation and introduced new modules for locks, atomics and barriers. Removed unnecessary group tagging from internal headers, which are not visible to doxygen anyway. Signed-off-by: Petri Savolainen ---

Re: [lng-odp] [API-NEXT/PATCHv5] validation: classification: added additional suite to test individual PMRs

Hi Ivan, Thanks for pointing out the issues. Since this patch is merged I will create a bug and add the missing points. Pls provide your inputs on the comments. On 15 October 2015 at 16:53, Ivan Khoronzhuk wrote: > Hi, Bala > > Just compared this version with

Re: [lng-odp] [API-NEXT PATCHv4 1/4] api: packet reference count support

On 9 October 2015 at 08:59, Maxim Uvarov wrote: > Add api for packet reference count support. Which is useful in case: > - multicast support > Different packets will probably need different headers prepended to the shared packet. How is this handled? - TCP

Re: [lng-odp] [API-NEXT PATCHv2] api: pktio link

On Tue, Oct 13, 2015 at 03:39:29PM +0300, Maxim Uvarov wrote: > Define API to get pktio link state: seed, autoneg, link up/down, > duplex, started/stopped state. > > Signed-off-by: Maxim Uvarov > --- > v2: - use simple struct to return pktio link state; > - odp will

Re: [lng-odp] [API-NEXT PATCH] api: crypto: add crypto IPSec extension

On 12 October 2015 at 12:33, Agrawal Hemant wrote: > HI Ola, > > I guess you are looking for standard NIC style IPSEC task > offload? > Yes. Even if a SoC-based crypto/IPsec/security engine might be able to do a lot of things, we want the API to be possible

Re: [lng-odp] [PATCH] validation: pktio: don't call APIs with an invalid pktio handle

On Tue, Oct 13, 2015 at 12:05 PM, Stuart Haslam wrote: > If one of the pktio interfaces used by the test unexpectedly fails to > open an invalid pktio handle is passed on to further API calls > resulting in undefined behaviour. > > Reported-by: Anders Roxell

Re: [lng-odp] [API-NEXT PATCH 6/6] api: atomic: added 32 bit acquire and release

On 15 October 2015 at 10:45, Petri Savolainen wrote: > Added 32 bit acquire load/cas and release store/add/sub calls. > You only have cas_acquire. Don't you see a need for cas_release? I use that in one lockless design. I see the beginning of a combinatorial

Re: [lng-odp] [API-NEXT PATCH 5/6] api: atomic: added cas operations

On 15 October 2015 at 10:45, Petri Savolainen wrote: > Added cas operations for 32 and 64 bit atomic variables. These > use relaxed memory order (as all other operations). > Do you have actual use cases for CAS where *only* relaxed memory order is required? Or you

Re: [lng-odp] [PATCH 5/8] add fbk hash table

On 12 October 2015 at 16:30, Maxim Uvarov wrote: > On 10/09/2015 16:27, HePeng wrote: > >> >> 在 2015年10月9日，下午8:20，Maxim Uvarov > maxim.uva...@linaro.org>> 写道： >>> >>> Please specify git commit hash related to original code. >>> >>> I'm thinking

Re: [lng-odp] [API-NEXT PATCHv2] api: pktio link

On 13 October 2015 at 08:39, Maxim Uvarov wrote: > Define API to get pktio link state: seed, autoneg, link up/down, > duplex, started/stopped state. > > Signed-off-by: Maxim Uvarov > --- > v2: - use simple struct to return pktio link state; >

Re: [lng-odp] pktio statistic counters

On 15.10.15 19:51, Ivan Khoronzhuk wrote: On 15.10.15 19:31, Mike Holmes wrote: On 15 October 2015 at 14:04, Ivan Khoronzhuk > wrote: Please, no Camel casemaybe we can duplicate the struct with names and use

Re: [lng-odp] pktio statistic counters

On 15 October 2015 at 14:04, Ivan Khoronzhuk wrote: > Please, no Camel casemaybe we can duplicate the struct with names and > use convenient one. > So we adopt a standard that is bigger than out own and not its naming convention ? Feels presumptuous :) > > >

Re: [lng-odp] pktio statistic counters

On 15.10.15 19:31, Mike Holmes wrote: On 15 October 2015 at 14:04, Ivan Khoronzhuk > wrote: Please, no Camel casemaybe we can duplicate the struct with names and use convenient one. So we adopt a standard that is

Re: [lng-odp] New ODP Website page created

from status On 15 October 2015 at 17:02, Raj Murali wrote: > How will this page linked through navigation menu? > > > > Raj Murali > Director - Linaro Networking Group > Skype: rajmurali_s │ M: +91 98450 70135 > > Linaro.org *│ *Open source

Re: [lng-odp] [PATCH 1/1] helpers: linux: add application defined counters

On 15 October 2015 at 14:53, Maxim Uvarov wrote: > > > On 09/08/2015 16:29, Alexandru Badicioiu wrote: > >> >> On 8 September 2015 at 15:57, Ola Liljedahl > > wrote: >> >> On 1 September 2015 at 13:09,

Re: [lng-odp] pktio statistic counters

I will send update. btw, smnpd does not name variables with same name as counters, we should not do the same. Just correlation between standard and vars name. Maxim. On 10/15/2015 19:53, Ivan Khoronzhuk wrote: On 15.10.15 19:51, Ivan Khoronzhuk wrote: On 15.10.15 19:31, Mike Holmes

Re: [lng-odp] [PATCH 1/1] helpers: linux: add application defined counters

On 09/08/2015 16:29, Alexandru Badicioiu wrote: On 8 September 2015 at 15:57, Ola Liljedahl > wrote: On 1 September 2015 at 13:09, > wrote: