That patches introduce segfault. Pktio is socket_mmap:
8cf523f api: classification: add odp_cls_cos_pool_set() api
8da0ee0 example: classifier: add odp_cls_cos_pool_set() api
4ade6a3 validation: classification: add odp_cls_cos_pool_set() api
e695969 linux-generic: classification: implements
This could help the existing configuration methods to be used if the
application prefers that. The platform_params should always supersede that
though.
Signed-off-by: Zoltan Kiss
---
v2: improve wording about superseding
include/odp/api/init.h | 4
1 file changed,
Ping
On Tue, Dec 1, 2015 at 7:14 AM, Bill Fischofer
wrote:
> This corrects bug https://bugs.linaro.org/show_bug.cgi?id=1921
>
> Signed-off-by: Bill Fischofer
> ---
> platform/linux-generic/odp_schedule.c | 2 ++
> 1 file changed, 2
Bala,
I have opposite result. After you patch master never fails. api-next
fails and my merge master to api-next also fails.
So it looks like we have something in api-next that breaks the work.
queue1 |queue2 |queue3 |DefaultCos |Total Packets
queue pool |queue pool
On 10.12.15 08:42, Maxim Uvarov wrote:
Going to apply this patch to unblock builds in new distros. Any objections?
Maxim.
I worry about change of timespec struct can break linux-generic time API.
I believe it will not happen, but that's why I like Maxim`s approach a little
more.
[lng-odp]
> Signed-off-by: Bill Fischofer
> ---
> .../linux-generic/include/odp/plat/time_types.h| 5 +++-
> platform/linux-generic/odp_time.c | 27 +
> -
> 2 files changed, 20 insertions(+), 12 deletions(-)
>
> diff --git
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Ola
Liljedahl
Sent: Wednesday, December 09, 2015 6:26 PM
To: Bill Fischofer
Cc: LNG ODP Mailman List
Subject: Re: [lng-odp] [API-NEXT PATCH] linux-generic: time: remove posix bleed
through on odp_time_t
On 9 December
> -Original Message-
> From: EXT Maxim Uvarov [mailto:maxim.uva...@linaro.org]
> Sent: Thursday, December 10, 2015 11:15 AM
> To: Savolainen, Petri (Nokia - FI/Espoo); EXT Mike Holmes
> Cc: lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [PATCH 00/10] Pktio checks
>
> On 12/10/2015
From: Grigore Ion
This patch fixes the following problems:
- checksum computation for LE platforms
- checksum is computed in the CPU endianness. The returned result
must be converted to the BE ordering when it is used to update
the UDP checksum in a packet.
- checksum
Hi
I'm trying odp_classification (ODP linux-generic 1.5) and I'm not sure if I'm
doing something wrong or if it's a bug.
uname -a : 3.16.0-30-generic #40~14.04.1-Ubuntu SMP Thu Jan 15 17:43:14 UTC
2015 x86_64 x86_64 x86_64 GNU/Linux
Received packets with this Src IP will be stored in
Timer pool may be freed while another thread executes timer_notify().
This leads to segmentation fault.
Example scenario:
Time main_thread timer_notify_thread
1call
https://bugs.linaro.org/show_bug.cgi?id=1940
Bug ID: 1940
Summary: linux-generic: timer: race for odp_timer_pool
Product: OpenDataPlane - linux- generic reference
Version: unspecified
Hardware: Other
OS: Linux
Thanks for analysis,
Created bug to track it:
https://bugs.linaro.org/show_bug.cgi?id=1940
Maxim.
On 12/10/2015 11:08, Ilya Maximets wrote:
Timer pool may be freed while another thread executes timer_notify().
This leads to segmentation fault.
Example scenario:
Time main_thread
On 12/10/2015 11:21, Savolainen, Petri (Nokia - FI/Espoo) wrote:
Signed-off-by: Bill Fischofer
---
.../linux-generic/include/odp/plat/time_types.h| 5 +++-
platform/linux-generic/odp_time.c | 27 +
-
2 files changed, 20
I’d really need the bug fix applied on api-next ASAP. It’s more urgent than a
guide update. Buggy code slows down actual work. Buggy document is just
annoying but does not prevent working efficiently.
Anyway, this used to be our policy: bug fixes (to master) are merged to
api-next soon after
On 12/10/2015 12:08, Savolainen, Petri (Nokia - FI/Espoo) wrote:
I’d really need the bug fix applied on api-next ASAP. It’s more urgent
than a guide update. Buggy code slows down actual work. Buggy document
is just annoying but does not prevent working efficiently.
Anyway, this used to be
Signed-off-by: Mike Holmes
---
configure.ac | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure.ac b/configure.ac
index 00a1415..e45d90a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -413,4 +413,5 @@ AC_MSG_RESULT([
test_perf: ${test_perf}
linix-generic => linux-generic in subject
Perhaps this can be corrected when merging?
On 10 December 2015 at 15:24, Maxim Uvarov wrote:
> For some pktios like loop and ipc functions like mtu, promisc,
> and mac addr are not applicable. Instead of crash on deference
>
On Thu, Dec 10, 2015 at 3:08 PM, Mike Holmes wrote:
> Signed-off-by: Mike Holmes
>
Reviewed-by: Bill Fischofer
> ---
> configure.ac | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configure.ac
On Thu, Dec 10, 2015 at 12:58 PM, Zoltan Kiss
wrote:
> This could help the existing configuration methods to be used if the
> application prefers that. The platform_params should always supersede that
> though.
>
> Signed-off-by: Zoltan Kiss
>
https://bugs.linaro.org/show_bug.cgi?id=1940
Ilya Maximets changed:
What|Removed |Added
CC||i.maxim...@samsung.com
From: EXT Ola Liljedahl [mailto:ola.liljed...@linaro.org]
Sent: Thursday, December 10, 2015 12:40 PM
To: Savolainen, Petri (Nokia - FI/Espoo)
Cc: Bill Fischofer; LNG ODP Mailman List
Subject: Re: [lng-odp] [API-NEXT PATCH] linux-generic: time: remove posix bleed
through on odp_time_t
On 10
Signed-off-by: Maxim Uvarov
---
include/odp/api/packet_io.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/include/odp/api/packet_io.h b/include/odp/api/packet_io.h
index 443841e..f970ad7 100644
--- a/include/odp/api/packet_io.h
+++
Hi,
I sent a new patch(V6) making the code more understandable.
Thanks,
Grig
-Original Message-
From: Ilya Maximets [mailto:i.maxim...@samsung.com]
Sent: Wednesday, December 09, 2015 2:52 PM
To: Grigore Ion-B17953 ; lng-odp@lists.linaro.org
Subject: Re:
On 10 December 2015 at 09:40, Maxim Uvarov wrote:
> On 12/10/2015 11:21, Savolainen, Petri (Nokia - FI/Espoo) wrote:
>
>> Signed-off-by: Bill Fischofer
>>> ---
>>> .../linux-generic/include/odp/plat/time_types.h| 5 +++-
>>>
Hello,
I did merge of current master branch to api-next. There are bunch of
reject, most of them due to new time api.
It might be not easy to review. Bit it will be good to do some review to
check that I did not lost significant patches.
Merged branch here:
On Thu, Dec 10, 2015 at 02:29:30PM +0300, Maxim Uvarov wrote:
> All tests should be installed under testdir variable and not in the bin
> directory.
>
> Signed-off-by: Maxim Uvarov
Reviewed-by: Stuart Haslam
> ---
>
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT
> Maxim Uvarov
> Sent: Thursday, December 10, 2015 1:45 PM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [API-NEXT PATCH] api: pktio link state
>
> Signed-off-by: Maxim Uvarov
On Thu, Dec 10, 2015 at 08:48:53AM +, Kury Nicolas wrote:
> Hi
>
>
> I'm trying odp_classification (ODP linux-generic 1.5) and I'm not sure if I'm
> doing something wrong or if it's a bug.
>
> uname -a : 3.16.0-30-generic #40~14.04.1-Ubuntu SMP Thu Jan 15 17:43:14 UTC
> 2015 x86_64 x86_64
https://bugs.linaro.org/show_bug.cgi?id=1940
Stuart Haslam changed:
What|Removed |Added
CC|
On 10 December 2015 at 09:30, Savolainen, Petri (Nokia - FI/Espoo) <
petri.savolai...@nokia.com> wrote:
>
>
>
>
> *From:* lng-odp [mailto:lng-odp-boun...@lists.linaro.org] *On Behalf Of *EXT
> Ola Liljedahl
> *Sent:* Wednesday, December 09, 2015 6:26 PM
> *To:* Bill Fischofer
> *Cc:* LNG ODP
All tests should be installed under testdir variable and not in the bin
directory.
Signed-off-by: Maxim Uvarov
---
test/validation/hash/Makefile.am | 2 +-
test/validation/std_clib/Makefile.am | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
On 26 November 2015 at 09:56, Savolainen, Petri (Nokia - FI/Espoo) <
petri.savolai...@nokia.com> wrote:
> ping.
>
> > -Original Message-
> > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT
> > Petri Savolainen
> > Sent: Thursday, November 12, 2015 10:30 AM
> > To:
Bala, can you tested it on merged master to api-next?
https://git.linaro.org/people/maxim.uvarov/odp.git api-next
We need to check if that changes did not went to merge. And I did not
pull error back to api-next.
Maxim.
On 12/10/2015 18:12, Bala Manoharan wrote:
odp_classifier runs on
Please open a bug for this. Thanks.
On Thu, Dec 10, 2015 at 6:27 AM, Stuart Haslam
wrote:
> On Thu, Dec 10, 2015 at 08:48:53AM +, Kury Nicolas wrote:
> > Hi
> >
> >
> > I'm trying odp_classification (ODP linux-generic 1.5) and I'm not sure
> if I'm doing something
On Thu, Dec 10, 2015 at 2:05 AM, Ivan Khoronzhuk wrote:
>
>
> On 10.12.15 08:42, Maxim Uvarov wrote:
>
>> Going to apply this patch to unblock builds in new distros. Any
>> objections?
>>
>> Maxim.
>>
>
> I worry about change of timespec struct can break
On 12/10/2015 16:18, Bala Manoharan wrote:
Looks like a previous commit has changed the Ip address format
As a work around pls provide IP address format in hexadecimal.
For eg "10.10.10.1" ==> "A.A.A.1".
Pls assign the bug to me.
Regards,
Bala
Can we also add that to make check test? It
>Looks like a previous commit has changed the Ip address format
>As a work around pls provide IP address format in hexadecimal.
>For eg "10.10.10.1" ==> "A.A.A.1".
Thank you it works! But I still have no match with ODP_PMR_UDP_DPORT=1234 even
if I use the hexadecimal notation 4D2 or 04D2.
I think with ODP_PMR_UDP_DPORT match there was an issue and I had
fixed it in my latest patch in api-next.
Can you pls try if the api-next branch works for ODP_PMR_UDP_DPORT match.
Hexadecimal is required only for ip address and not for UDP port number.
Anyhow pls report the same in the bug.
I
Looks like a previous commit has changed the Ip address format
As a work around pls provide IP address format in hexadecimal.
For eg "10.10.10.1" ==> "A.A.A.1".
Pls assign the bug to me.
Regards,
Bala
On 10 December 2015 at 18:28, Bill Fischofer wrote:
> Please open
ping
odp_generator appears to be broken on master, this would've caught it.
Stuart.
On 11 November 2015 at 15:01, Stuart Haslam wrote:
> Report a failure if the maximum achieved packet rate is less than a
> predefined threshold (currently set at 5000pps).
>
>
Fixes ipv4 address input format issue.
Signed-off-by: Balasubramanian Manoharan
---
example/classifier/odp_classifier.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/example/classifier/odp_classifier.c
b/example/classifier/odp_classifier.c
Merged.
Maxim.
On 12/10/2015 17:07, Stuart Haslam wrote:
ping
odp_generator appears to be broken on master, this would've caught it.
Stuart.
On 11 November 2015 at 15:01, Stuart Haslam wrote:
Report a failure if the maximum achieved packet rate is less than a
Merged,
Maxim.
On 12/10/2015 18:49, Bill Fischofer wrote:
On Thu, Dec 10, 2015 at 8:13 AM, Balasubramanian Manoharan
> wrote:
Fixes ipv4 address input format issue.
Signed-off-by: Balasubramanian Manoharan
Merged,
Maxim.
On 12/10/2015 22:58, Bill Fischofer wrote:
Ping
On Tue, Dec 1, 2015 at 7:14 AM, Bill Fischofer
> wrote:
This corrects bug https://bugs.linaro.org/show_bug.cgi?id=1921
Signed-off-by: Bill Fischofer
Reviewed-by: Petri Savolainen
> -Original Message-
> From: EXT Zoltan Kiss [mailto:zoltan.k...@linaro.org]
> Sent: Thursday, December 10, 2015 8:59 PM
> To: lng-odp@lists.linaro.org
> Cc: Savolainen, Petri (Nokia - FI/Espoo)
> Subject: [API-NEXT PATCH v2]
Comments inlined.
On 10.12.2015 12:59, ion.grig...@freescale.com wrote:
> From: Grigore Ion
>
> This patch fixes the following problems:
> - checksum computation for LE platforms
> - checksum is computed in the CPU endianness. The returned result
> must be converted
On Thu, Dec 10, 2015 at 8:13 AM, Balasubramanian Manoharan <
bala.manoha...@linaro.org> wrote:
> Fixes ipv4 address input format issue.
>
> Signed-off-by: Balasubramanian Manoharan
>
Reviewed-by: Bill Fischofer
> ---
>
Hi Maxim,
I just tested it again and I am seeing the same behaviour I explained
in the mail above.
In Master branch odp_classifier and odp_generator fails and both are
working on api-next branch.
This behaviour was seen by Stuart as well.
Regards,
Bala
On 11 December 2015 at 01:41, Maxim Uvarov
Move ring and it's test from helper to linux-generic/pktio and kill
not needed api_test directory. Unfortunately odp_ring_test.c had some old
dirty code so I had to clean up it to to use cunit and
latest helper apis.
Signed-off-by: Maxim Uvarov
---
configure.ac
If the examples are broken, this is a strong reason that we need to add the
examples to the "make check" with maybe --enable-test-examples.
We touched on this in the JIra scrub for doc and examples this morning
https://projects.linaro.org/browse/ODP-203
On 10 December 2015 at 09:19, Bala
Not sure which was the commit.
Maybe Bill can confirm the commit.
Regards,
Bala
On 10 December 2015 at 19:55, Maxim Uvarov wrote:
> On 12/10/2015 17:19, Bala Manoharan wrote:
>>
>> Hi,
>>
>> odp_classifier and odp_generator is failing in the master branch but
>> both
Hi,
odp_classifier and odp_generator is failing in the master branch but
both are working in api-next branch.
Looks like the issue in classifier is a bug is in the queue module
which was fixed in api-next branch and this fix needs to be merged
into master branch.
Regards,
Bala
Add flag ODPH_RING_NO_LIST to ring to not link it to linked list.
Signed-off-by: Maxim Uvarov
---
helper/include/odp/helper/ring.h | 21 +
helper/ring.c| 3 ++-
2 files changed, 15 insertions(+), 9 deletions(-)
diff --git
Prefixed were removed for validation test suite and to
be consistent we need to do the same for helpers.
Signed-off-by: Maxim Uvarov
---
helper/test/.gitignore | 10 +-
helper/test/Makefile.am | 25 -
ipc pktio depends on ring which depends on pause. Move
pause to installed helpers to support out of tree builds.
Signed-off-by: Maxim Uvarov
---
helper/Makefile.am | 4 ++--
helper/{odph_pause.h => include/odp/helper/pause.h} | 0
On 12/10/2015 17:07, Stuart Haslam wrote:
ping
odp_generator appears to be broken on master, this would've caught it.
Stuart.
Thank we need to fix it and then apply that patch.
Maxim.
On 11 November 2015 at 15:01, Stuart Haslam wrote:
Report a failure if the
How to reproduce that it is broken?
Maxim.
On 12/10/2015 17:48, Bala Manoharan wrote:
Not sure which was the commit.
Maybe Bill can confirm the commit.
Regards,
Bala
On 10 December 2015 at 19:55, Maxim Uvarov wrote:
On 12/10/2015 17:19, Bala Manoharan wrote:
Hi,
Signed-off-by: Maxim Uvarov
---
helper/include/odp/helper/ring.h | 2 ++
helper/ring.c| 9 -
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/helper/include/odp/helper/ring.h b/helper/include/odp/helper/ring.h
index
v17: - move ring from helper to linux-generic
- do small makefile fixes to make make distcheck pass
v16: - do not use ODPH_DBG if ring is used for implementation,
also set up right errno as described in doxygen description.
v15: - rebase on the latest master
- fix checkpatch
On init odp creates odp_sched_pool. We can not modify API to add new
parameter to odp_pool_param_t and this pool should not be shared
between different processes. To do that implemented internal linux-generic
function with parameters to created shm.
Note: create shm before and then provide it to
Accodring to doxygen comment if ring creation fails __odp_errno
should be set.
Signed-off-by: Maxim Uvarov
---
platform/linux-generic/pktio/ring.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/platform/linux-generic/pktio/ring.c
For some pktios like loop and ipc functions like mtu, promisc,
and mac addr are not applicable. Instead of crash on deference
null pointer just return error if functions are not defined.
Signed-off-by: Maxim Uvarov
---
platform/linux-generic/odp_packet_io.c | 24
Signed-off-by: Maxim Uvarov
---
platform/linux-generic/Makefile.am | 3 +
.../linux-generic/include/odp_buffer_internal.h| 3 +
.../linux-generic/include/odp_packet_io_internal.h | 38 ++
.../include/odp_packet_io_ipc_internal.h | 47
2 example ipc pktio applications create ipc pktio to each other and do
packet transfer, validation magic numbers and packets sequence counters
inside it.
Signed-off-by: Maxim Uvarov
---
platform/linux-generic/m4/configure.m4 | 1 +
Is anyone following the OFP project, they are also discussing this struct
from a user of ODPs perspctive on a couple of threads like
http://www.openfastpath.org/pipermail/openfastpath/2015-December/48.html
On 10 December 2015 at 08:07, Bill Fischofer
wrote:
>
>
>
odp_classifier runs on api-next branch but if we run on master it
currently crashes during queue_enq function.
I remember the crash was similar to the one we had during queue
reorder implementation.
Regards,
Bala
On 10 December 2015 at 20:38, Stuart Haslam wrote:
> On
For the purpose of testing of real-world interfaces the packet's
content should be valid or kernel will throw them away.
Signed-off-by: Ilya Maximets
---
test/validation/pktio/pktio.c | 46 ---
1 file changed, 39 insertions(+), 7
Creates a new pktio type that allows for creating and
sending/receiving packets through TAP interface.
It is intended for use as a simple conventional communication
method between applications that use kernel network stack
(ping, ssh, iperf, etc.) and ODP applications for the purpose
of functional
Creates a new pktio type that allows for creating and
sending/receiving packets through TAP interface.
Detailed description in commit-message of patch
"[PATCHv5 3/4] linux-generic: pktio: add tap pktio type".
Changelog:
Version 5:
* nothing changed. New patch added to add ability
On Thu, Dec 10, 2015 at 06:01:05PM +0300, Maxim Uvarov wrote:
> How to reproduce that it is broken?
>
I was looking at:
sudo ODP_PLATFORM=linux-generic ./test/performance/odp_l2fwd_run
This shows a few packets going through initially then 0. Turns out this
is related to the netmap pktio, this
Thanks. I'll pop over to that thread to take a look. However odp_time_t
should be opaque from a user perspective--that's the purpose of having
abstract types in the first place.
On Thu, Dec 10, 2015 at 9:00 AM, Mike Holmes wrote:
> Is anyone following the OFP project,
'ODP_WAIT_FOR_NETWORK' environment variable may be used
to wait some time right after pktio_open().
Signed-off-by: Ilya Maximets
---
'ODP_WAIT_FOR_NETWORK' also may be used to remove sleep(1)
from netmap pktio in the future, beacause IMO waiting
for external network is a
https://bugs.linaro.org/show_bug.cgi?id=1940
Mike Holmes changed:
What|Removed |Added
Assignee|ola.liljed...@linaro.org
https://bugs.linaro.org/show_bug.cgi?id=1941
Mike Holmes changed:
What|Removed |Added
CC||mike.hol...@linaro.org
https://bugs.linaro.org/show_bug.cgi?id=1873
Mike Holmes changed:
What|Removed |Added
Assignee|lng-odp@lists.linaro.org|maxim.uva...@linaro.org
76 matches
Mail list logo