Re: [lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

2015-12-10 Thread Maxim Uvarov
That patches introduce segfault. Pktio is socket_mmap: 8cf523f api: classification: add odp_cls_cos_pool_set() api 8da0ee0 example: classifier: add odp_cls_cos_pool_set() api 4ade6a3 validation: classification: add odp_cls_cos_pool_set() api e695969 linux-generic: classification: implements

[lng-odp] [API-NEXT PATCH v2] api: init: allow implementation to use private ways for its own configuration

2015-12-10 Thread Zoltan Kiss
This could help the existing configuration methods to be used if the application prefers that. The platform_params should always supersede that though. Signed-off-by: Zoltan Kiss --- v2: improve wording about superseding include/odp/api/init.h | 4 1 file changed,

Re: [lng-odp] [PATCH] linux-generic: schedule: set sched_local.pool correctly

2015-12-10 Thread Bill Fischofer
Ping On Tue, Dec 1, 2015 at 7:14 AM, Bill Fischofer wrote: > This corrects bug https://bugs.linaro.org/show_bug.cgi?id=1921 > > Signed-off-by: Bill Fischofer > --- > platform/linux-generic/odp_schedule.c | 2 ++ > 1 file changed, 2

Re: [lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

2015-12-10 Thread Maxim Uvarov
Bala, I have opposite result. After you patch master never fails. api-next fails and my merge master to api-next also fails. So it looks like we have something in api-next that breaks the work. queue1 |queue2 |queue3 |DefaultCos |Total Packets queue pool |queue pool

Re: [lng-odp] [API-NEXT PATCH] linux-generic: time: remove posix bleed through on odp_time_t

2015-12-10 Thread Ivan Khoronzhuk
On 10.12.15 08:42, Maxim Uvarov wrote: Going to apply this patch to unblock builds in new distros. Any objections? Maxim. I worry about change of timespec struct can break linux-generic time API. I believe it will not happen, but that's why I like Maxim`s approach a little more. [lng-odp]

Re: [lng-odp] [API-NEXT PATCH] linux-generic: time: remove posix bleed through on odp_time_t

2015-12-10 Thread Savolainen, Petri (Nokia - FI/Espoo)
> Signed-off-by: Bill Fischofer > --- > .../linux-generic/include/odp/plat/time_types.h| 5 +++- > platform/linux-generic/odp_time.c | 27 + > - > 2 files changed, 20 insertions(+), 12 deletions(-) > > diff --git

Re: [lng-odp] [API-NEXT PATCH] linux-generic: time: remove posix bleed through on odp_time_t

2015-12-10 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Ola Liljedahl Sent: Wednesday, December 09, 2015 6:26 PM To: Bill Fischofer Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [API-NEXT PATCH] linux-generic: time: remove posix bleed through on odp_time_t On 9 December

Re: [lng-odp] [PATCH 00/10] Pktio checks

2015-12-10 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: EXT Maxim Uvarov [mailto:maxim.uva...@linaro.org] > Sent: Thursday, December 10, 2015 11:15 AM > To: Savolainen, Petri (Nokia - FI/Espoo); EXT Mike Holmes > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [PATCH 00/10] Pktio checks > > On 12/10/2015

[lng-odp] [PATCHv6] helper : Fix UDP checksum computation

2015-12-10 Thread ion.grigore
From: Grigore Ion This patch fixes the following problems: - checksum computation for LE platforms - checksum is computed in the CPU endianness. The returned result must be converted to the BE ordering when it is used to update the UDP checksum in a packet. - checksum

[lng-odp] [HELP] odp_classification no match ?

2015-12-10 Thread Kury Nicolas
Hi I'm trying odp_classification (ODP linux-generic 1.5) and I'm not sure if I'm doing something wrong or if it's a bug. uname -a : 3.16.0-30-generic #40~14.04.1-Ubuntu SMP Thu Jan 15 17:43:14 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux Received packets with this Src IP will be stored in

[lng-odp] [BUG] linux-generic: timer: race for odp_timer_pool

2015-12-10 Thread Ilya Maximets
Timer pool may be freed while another thread executes timer_notify(). This leads to segmentation fault. Example scenario: Time main_thread timer_notify_thread 1call

[lng-odp] [Bug 1940] New: linux-generic: timer: race for odp_timer_pool

2015-12-10 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1940 Bug ID: 1940 Summary: linux-generic: timer: race for odp_timer_pool Product: OpenDataPlane - linux- generic reference Version: unspecified Hardware: Other OS: Linux

Re: [lng-odp] [BUG] linux-generic: timer: race for odp_timer_pool

2015-12-10 Thread Maxim Uvarov
Thanks for analysis, Created bug to track it: https://bugs.linaro.org/show_bug.cgi?id=1940 Maxim. On 12/10/2015 11:08, Ilya Maximets wrote: Timer pool may be freed while another thread executes timer_notify(). This leads to segmentation fault. Example scenario: Time main_thread

Re: [lng-odp] [API-NEXT PATCH] linux-generic: time: remove posix bleed through on odp_time_t

2015-12-10 Thread Maxim Uvarov
On 12/10/2015 11:21, Savolainen, Petri (Nokia - FI/Espoo) wrote: Signed-off-by: Bill Fischofer --- .../linux-generic/include/odp/plat/time_types.h| 5 +++- platform/linux-generic/odp_time.c | 27 + - 2 files changed, 20

Re: [lng-odp] [PATCH 00/10] Pktio checks

2015-12-10 Thread Savolainen, Petri (Nokia - FI/Espoo)
I’d really need the bug fix applied on api-next ASAP. It’s more urgent than a guide update. Buggy code slows down actual work. Buggy document is just annoying but does not prevent working efficiently. Anyway, this used to be our policy: bug fixes (to master) are merged to api-next soon after

Re: [lng-odp] [PATCH 00/10] Pktio checks

2015-12-10 Thread Maxim Uvarov
On 12/10/2015 12:08, Savolainen, Petri (Nokia - FI/Espoo) wrote: I’d really need the bug fix applied on api-next ASAP. It’s more urgent than a guide update. Buggy code slows down actual work. Buggy document is just annoying but does not prevent working efficiently. Anyway, this used to be

[lng-odp] [PATCH] configure.ac: add user_guides config status

2015-12-10 Thread Mike Holmes
Signed-off-by: Mike Holmes --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index 00a1415..e45d90a 100644 --- a/configure.ac +++ b/configure.ac @@ -413,4 +413,5 @@ AC_MSG_RESULT([ test_perf: ${test_perf}

Re: [lng-odp] [PATCHv17 08/10] linix-generic: return error for unsupported pktio calls

2015-12-10 Thread Ola Liljedahl
linix-generic => linux-generic in subject Perhaps this can be corrected when merging? On 10 December 2015 at 15:24, Maxim Uvarov wrote: > For some pktios like loop and ipc functions like mtu, promisc, > and mac addr are not applicable. Instead of crash on deference >

Re: [lng-odp] [PATCH] configure.ac: add user_guides config status

2015-12-10 Thread Bill Fischofer
On Thu, Dec 10, 2015 at 3:08 PM, Mike Holmes wrote: > Signed-off-by: Mike Holmes > Reviewed-by: Bill Fischofer > --- > configure.ac | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configure.ac

Re: [lng-odp] [API-NEXT PATCH v2] api: init: allow implementation to use private ways for its own configuration

2015-12-10 Thread Bill Fischofer
On Thu, Dec 10, 2015 at 12:58 PM, Zoltan Kiss wrote: > This could help the existing configuration methods to be used if the > application prefers that. The platform_params should always supersede that > though. > > Signed-off-by: Zoltan Kiss >

[lng-odp] [Bug 1940] linux-generic: timer: race for odp_timer_pool

2015-12-10 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1940 Ilya Maximets changed: What|Removed |Added CC||i.maxim...@samsung.com

Re: [lng-odp] [API-NEXT PATCH] linux-generic: time: remove posix bleed through on odp_time_t

2015-12-10 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: EXT Ola Liljedahl [mailto:ola.liljed...@linaro.org] Sent: Thursday, December 10, 2015 12:40 PM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: Bill Fischofer; LNG ODP Mailman List Subject: Re: [lng-odp] [API-NEXT PATCH] linux-generic: time: remove posix bleed through on odp_time_t On 10

[lng-odp] [API-NEXT PATCH] api: pktio link state

2015-12-10 Thread Maxim Uvarov
Signed-off-by: Maxim Uvarov --- include/odp/api/packet_io.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/include/odp/api/packet_io.h b/include/odp/api/packet_io.h index 443841e..f970ad7 100644 --- a/include/odp/api/packet_io.h +++

Re: [lng-odp] [PATCHv5] helper : Fix UDP checksum computation

2015-12-10 Thread Ion Grigore
Hi, I sent a new patch(V6) making the code more understandable. Thanks, Grig -Original Message- From: Ilya Maximets [mailto:i.maxim...@samsung.com] Sent: Wednesday, December 09, 2015 2:52 PM To: Grigore Ion-B17953 ; lng-odp@lists.linaro.org Subject: Re:

Re: [lng-odp] [API-NEXT PATCH] linux-generic: time: remove posix bleed through on odp_time_t

2015-12-10 Thread Ola Liljedahl
On 10 December 2015 at 09:40, Maxim Uvarov wrote: > On 12/10/2015 11:21, Savolainen, Petri (Nokia - FI/Espoo) wrote: > >> Signed-off-by: Bill Fischofer >>> --- >>> .../linux-generic/include/odp/plat/time_types.h| 5 +++- >>>

[lng-odp] merge master -> api-next

2015-12-10 Thread Maxim Uvarov
Hello, I did merge of current master branch to api-next. There are bunch of reject, most of them due to new time api. It might be not easy to review. Bit it will be good to do some review to check that I did not lost significant patches. Merged branch here:

Re: [lng-odp] [API-NEXT PATCH] validation: Makefiles: change install location

2015-12-10 Thread Stuart Haslam
On Thu, Dec 10, 2015 at 02:29:30PM +0300, Maxim Uvarov wrote: > All tests should be installed under testdir variable and not in the bin > directory. > > Signed-off-by: Maxim Uvarov Reviewed-by: Stuart Haslam > --- >

Re: [lng-odp] [API-NEXT PATCH] api: pktio link state

2015-12-10 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Maxim Uvarov > Sent: Thursday, December 10, 2015 1:45 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXT PATCH] api: pktio link state > > Signed-off-by: Maxim Uvarov

Re: [lng-odp] [HELP] odp_classification no match ?

2015-12-10 Thread Stuart Haslam
On Thu, Dec 10, 2015 at 08:48:53AM +, Kury Nicolas wrote: > Hi > > > I'm trying odp_classification (ODP linux-generic 1.5) and I'm not sure if I'm > doing something wrong or if it's a bug. > > uname -a : 3.16.0-30-generic #40~14.04.1-Ubuntu SMP Thu Jan 15 17:43:14 UTC > 2015 x86_64 x86_64

[lng-odp] [Bug 1940] linux-generic: timer: race for odp_timer_pool

2015-12-10 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1940 Stuart Haslam changed: What|Removed |Added CC|

Re: [lng-odp] [API-NEXT PATCH] linux-generic: time: remove posix bleed through on odp_time_t

2015-12-10 Thread Ola Liljedahl
On 10 December 2015 at 09:30, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > > *From:* lng-odp [mailto:lng-odp-boun...@lists.linaro.org] *On Behalf Of *EXT > Ola Liljedahl > *Sent:* Wednesday, December 09, 2015 6:26 PM > *To:* Bill Fischofer > *Cc:* LNG ODP

[lng-odp] [API-NEXT PATCH] validation: Makefiles: change install location

2015-12-10 Thread Maxim Uvarov
All tests should be installed under testdir variable and not in the bin directory. Signed-off-by: Maxim Uvarov --- test/validation/hash/Makefile.am | 2 +- test/validation/std_clib/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [lng-odp] [API-NEXT PATCH v3] api: atomic: added atomic_lock_free_u64

2015-12-10 Thread Ola Liljedahl
On 26 November 2015 at 09:56, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > ping. > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > > Petri Savolainen > > Sent: Thursday, November 12, 2015 10:30 AM > > To:

Re: [lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

2015-12-10 Thread Maxim Uvarov
Bala, can you tested it on merged master to api-next? https://git.linaro.org/people/maxim.uvarov/odp.git api-next We need to check if that changes did not went to merge. And I did not pull error back to api-next. Maxim. On 12/10/2015 18:12, Bala Manoharan wrote: odp_classifier runs on

Re: [lng-odp] [HELP] odp_classification no match ?

2015-12-10 Thread Bill Fischofer
Please open a bug for this. Thanks. On Thu, Dec 10, 2015 at 6:27 AM, Stuart Haslam wrote: > On Thu, Dec 10, 2015 at 08:48:53AM +, Kury Nicolas wrote: > > Hi > > > > > > I'm trying odp_classification (ODP linux-generic 1.5) and I'm not sure > if I'm doing something

Re: [lng-odp] [API-NEXT PATCH] linux-generic: time: remove posix bleed through on odp_time_t

2015-12-10 Thread Bill Fischofer
On Thu, Dec 10, 2015 at 2:05 AM, Ivan Khoronzhuk wrote: > > > On 10.12.15 08:42, Maxim Uvarov wrote: > >> Going to apply this patch to unblock builds in new distros. Any >> objections? >> >> Maxim. >> > > I worry about change of timespec struct can break

Re: [lng-odp] [HELP] odp_classification no match ?

2015-12-10 Thread Maxim Uvarov
On 12/10/2015 16:18, Bala Manoharan wrote: Looks like a previous commit has changed the Ip address format As a work around pls provide IP address format in hexadecimal. For eg "10.10.10.1" ==> "A.A.A.1". Pls assign the bug to me. Regards, Bala Can we also add that to make check test? It

Re: [lng-odp] [HELP] odp_classification no match ?

2015-12-10 Thread Kury Nicolas
>Looks like a previous commit has changed the Ip address format >As a work around pls provide IP address format in hexadecimal. >For eg "10.10.10.1" ==> "A.A.A.1". Thank you it works! But I still have no match with ODP_PMR_UDP_DPORT=1234 even if I use the hexadecimal notation 4D2 or 04D2.

Re: [lng-odp] [HELP] odp_classification no match ?

2015-12-10 Thread Bala Manoharan
I think with ODP_PMR_UDP_DPORT match there was an issue and I had fixed it in my latest patch in api-next. Can you pls try if the api-next branch works for ODP_PMR_UDP_DPORT match. Hexadecimal is required only for ip address and not for UDP port number. Anyhow pls report the same in the bug. I

Re: [lng-odp] [HELP] odp_classification no match ?

2015-12-10 Thread Bala Manoharan
Looks like a previous commit has changed the Ip address format As a work around pls provide IP address format in hexadecimal. For eg "10.10.10.1" ==> "A.A.A.1". Pls assign the bug to me. Regards, Bala On 10 December 2015 at 18:28, Bill Fischofer wrote: > Please open

Re: [lng-odp] [PATCH] test: performance: set a packet rate pass threshold for l2fwd

2015-12-10 Thread Stuart Haslam
ping odp_generator appears to be broken on master, this would've caught it. Stuart. On 11 November 2015 at 15:01, Stuart Haslam wrote: > Report a failure if the maximum achieved packet rate is less than a > predefined threshold (currently set at 5000pps). > >

[lng-odp] [PATCH] example: classifier: fix ipv4 address input format

2015-12-10 Thread Balasubramanian Manoharan
Fixes ipv4 address input format issue. Signed-off-by: Balasubramanian Manoharan --- example/classifier/odp_classifier.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/example/classifier/odp_classifier.c b/example/classifier/odp_classifier.c

Re: [lng-odp] [PATCH] test: performance: set a packet rate pass threshold for l2fwd

2015-12-10 Thread Maxim Uvarov
Merged. Maxim. On 12/10/2015 17:07, Stuart Haslam wrote: ping odp_generator appears to be broken on master, this would've caught it. Stuart. On 11 November 2015 at 15:01, Stuart Haslam wrote: Report a failure if the maximum achieved packet rate is less than a

Re: [lng-odp] [PATCH] example: classifier: fix ipv4 address input format

2015-12-10 Thread Maxim Uvarov
Merged, Maxim. On 12/10/2015 18:49, Bill Fischofer wrote: On Thu, Dec 10, 2015 at 8:13 AM, Balasubramanian Manoharan > wrote: Fixes ipv4 address input format issue. Signed-off-by: Balasubramanian Manoharan

Re: [lng-odp] [PATCH] linux-generic: schedule: set sched_local.pool correctly

2015-12-10 Thread Maxim Uvarov
Merged, Maxim. On 12/10/2015 22:58, Bill Fischofer wrote: Ping On Tue, Dec 1, 2015 at 7:14 AM, Bill Fischofer > wrote: This corrects bug https://bugs.linaro.org/show_bug.cgi?id=1921 Signed-off-by: Bill Fischofer

Re: [lng-odp] [API-NEXT PATCH v2] api: init: allow implementation to use private ways for its own configuration

2015-12-10 Thread Savolainen, Petri (Nokia - FI/Espoo)
Reviewed-by: Petri Savolainen > -Original Message- > From: EXT Zoltan Kiss [mailto:zoltan.k...@linaro.org] > Sent: Thursday, December 10, 2015 8:59 PM > To: lng-odp@lists.linaro.org > Cc: Savolainen, Petri (Nokia - FI/Espoo) > Subject: [API-NEXT PATCH v2]

Re: [lng-odp] [PATCHv6] helper : Fix UDP checksum computation

2015-12-10 Thread Ilya Maximets
Comments inlined. On 10.12.2015 12:59, ion.grig...@freescale.com wrote: > From: Grigore Ion > > This patch fixes the following problems: > - checksum computation for LE platforms > - checksum is computed in the CPU endianness. The returned result > must be converted

Re: [lng-odp] [PATCH] example: classifier: fix ipv4 address input format

2015-12-10 Thread Bill Fischofer
On Thu, Dec 10, 2015 at 8:13 AM, Balasubramanian Manoharan < bala.manoha...@linaro.org> wrote: > Fixes ipv4 address input format issue. > > Signed-off-by: Balasubramanian Manoharan > Reviewed-by: Bill Fischofer > --- >

Re: [lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

2015-12-10 Thread Bala Manoharan
Hi Maxim, I just tested it again and I am seeing the same behaviour I explained in the mail above. In Master branch odp_classifier and odp_generator fails and both are working on api-next branch. This behaviour was seen by Stuart as well. Regards, Bala On 11 December 2015 at 01:41, Maxim Uvarov

[lng-odp] [PATCHv17 06/10] linux-generic/helper: move ring from helper to linux-generic

2015-12-10 Thread Maxim Uvarov
Move ring and it's test from helper to linux-generic/pktio and kill not needed api_test directory. Unfortunately odp_ring_test.c had some old dirty code so I had to clean up it to to use cunit and latest helper apis. Signed-off-by: Maxim Uvarov --- configure.ac

Re: [lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

2015-12-10 Thread Mike Holmes
If the examples are broken, this is a strong reason that we need to add the examples to the "make check" with maybe --enable-test-examples. We touched on this in the JIra scrub for doc and examples this morning https://projects.linaro.org/browse/ODP-203 On 10 December 2015 at 09:19, Bala

Re: [lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

2015-12-10 Thread Bala Manoharan
Not sure which was the commit. Maybe Bill can confirm the commit. Regards, Bala On 10 December 2015 at 19:55, Maxim Uvarov wrote: > On 12/10/2015 17:19, Bala Manoharan wrote: >> >> Hi, >> >> odp_classifier and odp_generator is failing in the master branch but >> both

[lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

2015-12-10 Thread Bala Manoharan
Hi, odp_classifier and odp_generator is failing in the master branch but both are working in api-next branch. Looks like the issue in classifier is a bug is in the queue module which was fixed in api-next branch and this fix needs to be merged into master branch. Regards, Bala

[lng-odp] [PATCHv17 03/10] helper: flag to not link ring to linked list

2015-12-10 Thread Maxim Uvarov
Add flag ODPH_RING_NO_LIST to ring to not link it to linked list. Signed-off-by: Maxim Uvarov --- helper/include/odp/helper/ring.h | 21 + helper/ring.c| 3 ++- 2 files changed, 15 insertions(+), 9 deletions(-) diff --git

[lng-odp] [PATCHv17 04/10] helpers: remove odp_ prefix for tests source files

2015-12-10 Thread Maxim Uvarov
Prefixed were removed for validation test suite and to be consistent we need to do the same for helpers. Signed-off-by: Maxim Uvarov --- helper/test/.gitignore | 10 +- helper/test/Makefile.am | 25 -

[lng-odp] [PATCHv17 05/10] helper: move odp pause to installed helper

2015-12-10 Thread Maxim Uvarov
ipc pktio depends on ring which depends on pause. Move pause to installed helpers to support out of tree builds. Signed-off-by: Maxim Uvarov --- helper/Makefile.am | 4 ++-- helper/{odph_pause.h => include/odp/helper/pause.h} | 0

Re: [lng-odp] [PATCH] test: performance: set a packet rate pass threshold for l2fwd

2015-12-10 Thread Maxim Uvarov
On 12/10/2015 17:07, Stuart Haslam wrote: ping odp_generator appears to be broken on master, this would've caught it. Stuart. Thank we need to fix it and then apply that patch. Maxim. On 11 November 2015 at 15:01, Stuart Haslam wrote: Report a failure if the

Re: [lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

2015-12-10 Thread Maxim Uvarov
How to reproduce that it is broken? Maxim. On 12/10/2015 17:48, Bala Manoharan wrote: Not sure which was the commit. Maybe Bill can confirm the commit. Regards, Bala On 10 December 2015 at 19:55, Maxim Uvarov wrote: On 12/10/2015 17:19, Bala Manoharan wrote: Hi,

[lng-odp] [PATCHv17 01/10] helper: ring: update ring with shm proc argument

2015-12-10 Thread Maxim Uvarov
Signed-off-by: Maxim Uvarov --- helper/include/odp/helper/ring.h | 2 ++ helper/ring.c| 9 - 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/helper/include/odp/helper/ring.h b/helper/include/odp/helper/ring.h index

[lng-odp] [PATCHv17 00/10] IPC (pktio)

2015-12-10 Thread Maxim Uvarov
v17: - move ring from helper to linux-generic - do small makefile fixes to make make distcheck pass v16: - do not use ODPH_DBG if ring is used for implementation, also set up right errno as described in doxygen description. v15: - rebase on the latest master - fix checkpatch

[lng-odp] [PATCHv17 02/10] linux-generic: create internal pool create function with shm flags

2015-12-10 Thread Maxim Uvarov
On init odp creates odp_sched_pool. We can not modify API to add new parameter to odp_pool_param_t and this pool should not be shared between different processes. To do that implemented internal linux-generic function with parameters to created shm. Note: create shm before and then provide it to

[lng-odp] [PATCHv17 07/10] linux-generic: ring set up __odp_errno as doxygen says

2015-12-10 Thread Maxim Uvarov
Accodring to doxygen comment if ring creation fails __odp_errno should be set. Signed-off-by: Maxim Uvarov --- platform/linux-generic/pktio/ring.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/platform/linux-generic/pktio/ring.c

[lng-odp] [PATCHv17 08/10] linix-generic: return error for unsupported pktio calls

2015-12-10 Thread Maxim Uvarov
For some pktios like loop and ipc functions like mtu, promisc, and mac addr are not applicable. Instead of crash on deference null pointer just return error if functions are not defined. Signed-off-by: Maxim Uvarov --- platform/linux-generic/odp_packet_io.c | 24

[lng-odp] [PATCHv17 09/10] linux-generic: add ipc pktio support

2015-12-10 Thread Maxim Uvarov
Signed-off-by: Maxim Uvarov --- platform/linux-generic/Makefile.am | 3 + .../linux-generic/include/odp_buffer_internal.h| 3 + .../linux-generic/include/odp_packet_io_internal.h | 38 ++ .../include/odp_packet_io_ipc_internal.h | 47

[lng-odp] [PATCHv17 10/10] linux-generic: internal ipc_pktio test

2015-12-10 Thread Maxim Uvarov
2 example ipc pktio applications create ipc pktio to each other and do packet transfer, validation magic numbers and packets sequence counters inside it. Signed-off-by: Maxim Uvarov --- platform/linux-generic/m4/configure.m4 | 1 +

Re: [lng-odp] [API-NEXT PATCH] linux-generic: time: remove posix bleed through on odp_time_t

2015-12-10 Thread Mike Holmes
Is anyone following the OFP project, they are also discussing this struct from a user of ODPs perspctive on a couple of threads like http://www.openfastpath.org/pipermail/openfastpath/2015-December/48.html On 10 December 2015 at 08:07, Bill Fischofer wrote: > > >

Re: [lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

2015-12-10 Thread Bala Manoharan
odp_classifier runs on api-next branch but if we run on master it currently crashes during queue_enq function. I remember the crash was similar to the one we had during queue reorder implementation. Regards, Bala On 10 December 2015 at 20:38, Stuart Haslam wrote: > On

[lng-odp] [PATCHv5 1/4] validation: pktio: initialize mac addresses for all packets

2015-12-10 Thread Ilya Maximets
For the purpose of testing of real-world interfaces the packet's content should be valid or kernel will throw them away. Signed-off-by: Ilya Maximets --- test/validation/pktio/pktio.c | 46 --- 1 file changed, 39 insertions(+), 7

[lng-odp] [PATCHv5 3/4] linux-generic: pktio: add tap pktio type

2015-12-10 Thread Ilya Maximets
Creates a new pktio type that allows for creating and sending/receiving packets through TAP interface. It is intended for use as a simple conventional communication method between applications that use kernel network stack (ping, ssh, iperf, etc.) and ODP applications for the purpose of functional

[lng-odp] [PATCHv5 0/4] TAP pktio

2015-12-10 Thread Ilya Maximets
Creates a new pktio type that allows for creating and sending/receiving packets through TAP interface. Detailed description in commit-message of patch "[PATCHv5 3/4] linux-generic: pktio: add tap pktio type". Changelog: Version 5: * nothing changed. New patch added to add ability

Re: [lng-odp] ODP_CLASSIFIER and ODP_GENERATOR failing in master branch

2015-12-10 Thread Stuart Haslam
On Thu, Dec 10, 2015 at 06:01:05PM +0300, Maxim Uvarov wrote: > How to reproduce that it is broken? > I was looking at: sudo ODP_PLATFORM=linux-generic ./test/performance/odp_l2fwd_run This shows a few packets going through initially then 0. Turns out this is related to the netmap pktio, this

Re: [lng-odp] [API-NEXT PATCH] linux-generic: time: remove posix bleed through on odp_time_t

2015-12-10 Thread Bill Fischofer
Thanks. I'll pop over to that thread to take a look. However odp_time_t should be opaque from a user perspective--that's the purpose of having abstract types in the first place. On Thu, Dec 10, 2015 at 9:00 AM, Mike Holmes wrote: > Is anyone following the OFP project,

[lng-odp] [PATCHv5 2/4] validation: pktio: ability to wait for external network

2015-12-10 Thread Ilya Maximets
'ODP_WAIT_FOR_NETWORK' environment variable may be used to wait some time right after pktio_open(). Signed-off-by: Ilya Maximets --- 'ODP_WAIT_FOR_NETWORK' also may be used to remove sleep(1) from netmap pktio in the future, beacause IMO waiting for external network is a

[lng-odp] [Bug 1940] linux-generic: timer: race for odp_timer_pool

2015-12-10 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1940 Mike Holmes changed: What|Removed |Added Assignee|ola.liljed...@linaro.org

[lng-odp] [Bug 1941] [odp_classifier] ODP_PMR_SIP_ADDR never matches

2015-12-10 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1941 Mike Holmes changed: What|Removed |Added CC||mike.hol...@linaro.org

[lng-odp] [Bug 1873] odp process-mode is broken

2015-12-10 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1873 Mike Holmes changed: What|Removed |Added Assignee|lng-odp@lists.linaro.org|maxim.uva...@linaro.org