Re: [lng-odp] [API-NEXT PATCH v3 0/6] Multi-queue pktio for poll mode

Stuart, can you please review this? Maxim. On 01/11/2016 14:39, Petri Savolainen wrote: This patch set adds support for multi-queue pktio for poll mode queues. v3: * Rebased v2: * Bug correction in patch 2/6: bad netmap initialization when using the old API. Matias Elo (1):

[lng-odp] [PATCH v6] validation: system: add validation tests for odp_cpu_cycles_* calls

https://bugs.linaro.org/show_bug.cgi?id=1906 Signed-off-by: Ivan Khoronzhuk --- Since v5: - add res instead of "1" while wrap - get cycle stamps a multiple of res instead direct valuues. - move resolution test before diff test Since v3: - modified log "wrap is not

[lng-odp] [API-NEXT PATCH v2 04/13] api: atomic: add non-relaxed 64bit operations

Added 64 bit versions of the same set of non-relaxed atomic operations that are already defined for 32 bit. Signed-off-by: Petri Savolainen --- include/odp/api/atomic.h | 99 1 file changed, 99 insertions(+) diff

[lng-odp] [API-NEXT PATCH v2 11/13] validation: atomic: added non-relaxed test

Added validation test for all operations with non-relaxed memory model. Mainly testing that functions are available. Signed-off-by: Petri Savolainen --- test/validation/synchronizers/synchronizers.c | 82 +++

Re: [lng-odp] [PATCH v5] validation: system: add validation tests for odp_cpu_cycles_* calls

> -Original Message- > From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] > Sent: Monday, January 18, 2016 2:24 PM > To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [PATCH v5] validation: system: add validation tests > for

[lng-odp] [API-NEXT PATCH v2 00/13] atomi api completion

Completed additions to atomic API. Added exchange operation in relaxed memory model. Added CAS operations in rel and acq_rel memory order. Added 64 bit versions of all non-relaxed operations defined so far. Added all missing validation tests. Replaced internal atomics usage in lock, etc code

[lng-odp] [API-NEXT PATCH v2 07/13] linux-generic: atomic: implemented exchange

Implemented 32 and 64 bit atomic exchange operations. Signed-off-by: Petri Savolainen --- platform/linux-generic/include/odp/atomic.h | 16 1 file changed, 16 insertions(+) diff --git a/platform/linux-generic/include/odp/atomic.h

[lng-odp] [API-NEXT PATCH v2 05/13] linux-generic: atomic: non-relaxed 64bit operations

Implemented 64 bit non-relaxed atomic operations. Additional ordering is not needed in case of using ATOMIC_OP since it includes both acquire and release ordering. Signed-off-by: Petri Savolainen --- platform/linux-generic/include/odp/atomic.h | 83

[lng-odp] [API-NEXT PATCH v2 12/13] linux-generic: locks: replace internal atomics

Replace internal non-relaxed atomics with API calls. Timer and spinlock were not converted since those use flags and 128 variables. Signed-off-by: Petri Savolainen --- platform/linux-generic/include/odp_pool_internal.h | 1 - platform/linux-generic/odp_pool.c

[lng-odp] [API-NEXT PATCH v2 13/13] linux-generic: barrier: use API memory barrier

Use full memory barrier from API instead of the internal function. Signed-off-by: Petri Savolainen --- platform/linux-generic/include/odp_atomic_internal.h | 6 -- platform/linux-generic/odp_barrier.c | 8 2 files changed, 4

Re: [lng-odp] [PATCH v5] validation: system: add validation tests for odp_cpu_cycles_* calls

v6 is sent. On 18.01.16 14:58, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Monday, January 18, 2016 2:24 PM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp]

[lng-odp] [API-NEXT PATCH v2 02/13] api: atomic: added 32bit cas_rel and cas_acq_rel

Added RELEASE and ACQUIRE-and-RELEASE versions of 32 bit CAS. These are commonly needed operations in lock-free algorithms. Signed-off-by: Petri Savolainen --- include/odp/api/atomic.h | 86 +--- 1 file changed, 67

[lng-odp] [API-NEXT PATCH v2 03/13] linux-generic: atomic: 32bit cas_rel and cas_acq_rel

Implemented 32bit cas_rel and cas_acq_rel calls. Signed-off-by: Petri Savolainen --- platform/linux-generic/include/odp/atomic.h | 37 ++--- 1 file changed, 28 insertions(+), 9 deletions(-) diff --git

[lng-odp] [API-NEXT PATCH v2 01/13] api: atomic: rename release ordering

Rename release ordering from _rls_ to _rel_ since it matches better with _acq_rel_, which is going to be used for C11 memory_order_acq_rel order. Signed-off-by: Petri Savolainen --- include/odp/api/atomic.h| 8

[lng-odp] [API-NEXT PATCH v2 06/13] api: atomic: added relaxed exchange operation

Added 32 and 64 bit atomic exchange operations in relaxed memory ordering. These can be used e.g. to initialize a counter while counting. Signed-off-by: Petri Savolainen --- include/odp/api/atomic.h | 27 +++ 1 file changed, 27 insertions(+)

[lng-odp] [API-NEXT PATCH v2 08/13] validation: atomic: added max and min tests

Added validation tests for atomic max and min operations. Results validation is a simple compare, since absolute min/max values depend on the number of threads. Signed-off-by: Petri Savolainen --- test/validation/synchronizers/synchronizers.c | 111

[lng-odp] [API-NEXT PATCH v2 09/13] validation: atomic: added cas test

Added validation test for CAS operations. Maintained the structure of other atomic tests: one function increments and another decrements a variable. Signed-off-by: Petri Savolainen --- test/validation/synchronizers/synchronizers.c | 83 +++

Re: [lng-odp] [PATCH v6] validation: system: add validation tests for odp_cpu_cycles_* calls

Not sure if "odp_cpu_cycles_*" will cause problems in git log history. May be Maxim can remove the '*' from the string during merge (e.g. just "... cpu_cycles calls"). Reviewed-by: Petri Savolainen > -Original Message- > From: EXT Ivan Khoronzhuk

Re: [lng-odp] [PATCH] test: change l2fwd pool size

strange that on make check l2fwd test fails due to small packet rate 1405 maximum packets per second. without patch: 6475 maximum packets per second. test consumes that less then 5000 is error. Please check on your machine. Maxim. On 01/15/2016 16:27, Bill Fischofer wrote: On Thu, Jan

Re: [lng-odp] [PATCH API-NEXT] api: pktio: remove unused ODP_PKTIO_ANY

Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Stuart Haslam > Sent: Friday, January 15, 2016 5:18 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH API-NEXT] api:

Re: [lng-odp] [PATCH] linux-generic: init: handle local/global init/term cleanly

Merged, Maxim. On 01/15/2016 19:05, Ivan Khoronzhuk wrote: On 14.01.16 23:21, Bill Fischofer wrote: Restructure odp_init_global() and odp_init_local() so that they recover cleanly if initialization fails. At exit any partial initialization is reversed so that system is in the same state as

Re: [lng-odp] [PATCHv19 9/9] linux-generic: internal ipc_pktio test

On Mon, Jan 18, 2016 at 12:59:44PM +0300, Maxim Uvarov wrote: > On 01/15/2016 15:57, Stuart Haslam wrote: > >On Mon, Dec 21, 2015 at 01:56:11PM +0300, Maxim Uvarov wrote: > >>2 example ipc pktio applications create ipc pktio to each other and do > >>packet transfer, validation magic numbers and

[lng-odp] [PATCH v5 API-NEXT 12/12] linux-generic: sysinfo: rename variable cpu_hz to cpu_hz_max

From: Hongbo Zhang The legacy variable cpu_hz holds the max frequency for odp_cpu_hz_max(), so rename it to cpu_hz_max for better meaning. Signed-off-by: Hongbo Zhang --- platform/linux-generic/arch/mips64/odp_sysinfo_parse.c | 2 +-

[lng-odp] [PATCH v5 API-NEXT 11/12] linux-generic: sysinfo: apply per-CPU implementation to PowerPC

From: Hongbo Zhang When per-CPU framework was introduced, it was only implemented on x86, for other platforms, only the model_str[0] and cpu_hz[0] are set to pass compile, this patch set all values for model_str[] and cpu_hz[] on the PowerPC platform. Signed-off-by:

[lng-odp] [PATCH v5 API-NEXT 03/12] linux-generic: sysinfo: rename odp_cpu_hz_current with odp_ prefix

From: Hongbo Zhang This function will be moved to their own platform specific files too, it is better to be named with a odp_ prefix. Signed-off-by: Hongbo Zhang --- platform/linux-generic/odp_system_info.c | 12 ++-- 1 file changed, 6

[lng-odp] [PATCH v5 API-NEXT 06/12] linux-generic: sysinfo: move ARM system info codes to default arch file

From: Hongbo Zhang This patch moves the ARM system info codes into the general arch file, ARM sysinfo isn't implemented now and there is no need to create specific arch file for it, but this can serve as the default implementaton instead. Signed-off-by: Hongbo Zhang

[lng-odp] [PATCH v5 API-NEXT 05/12] linux-generic: sysinfo: move MIPS system info codes to its plarform file

From: Hongbo Zhang This patch moves the MIPS system info codes into the newly added MIPS specific platform file. Signed-off-by: Hongbo Zhang --- platform/linux-generic/Makefile.am | 1 +

Re: [lng-odp] What to do regarding cahe non coherant systems

On 15 January 2016 at 15:48, Christophe Milard wrote: > On Tuesday's ARCH call, we will be discussing the above topic. > Nicolas (Kalray) will try to join, but he is very uncertain at this stage > (if he can be there)... > Cache coherence is the norm today,

[lng-odp] [PATCH v5 API-NEXT 04/12] linux-generic: sysinfo: move x86 system info codes to its plarform file

From: Hongbo Zhang This patch moves the x86 system info codes into the newly added x86 specific platform file. Signed-off-by: Hongbo Zhang --- platform/linux-generic/Makefile.am | 6 +-

[lng-odp] [PATCH v5 API-NEXT 02/12] linux-generic: sysinfo: use uniform call odp_sysinfo_parser

From: Hongbo Zhang It is common way that the general top layer calls a uniform interface to initialize data structrure for different plarform, this patch introduces odp_sysinfo_parser() instead of using different interfaces for each platform, and also removes using

[lng-odp] [PATCH v5 API-NEXT 07/12] linux-generic: sysinfo: move PowerPC system info codes to its plarform file

From: Hongbo Zhang This patch moves the PowerPC system info codes into the newly added PowerPC specific platform file. This patch also creates syslink to arch/linux/odp_cpu_cycles.c for PowerPC. Signed-off-by: Hongbo Zhang --- configure.ac

Re: [lng-odp] [PATCHv19 8/9] linux-generic: add ipc pktio support

On 01/15/2016 16:01, Stuart Haslam wrote: On Mon, Dec 21, 2015 at 01:56:10PM +0300, Maxim Uvarov wrote: Signed-off-by: Maxim Uvarov --- platform/linux-generic/Makefile.am | 3 + .../linux-generic/include/odp_buffer_internal.h| 3 +

Re: [lng-odp] [PATCHv19 9/9] linux-generic: internal ipc_pktio test

On 01/15/2016 15:57, Stuart Haslam wrote: On Mon, Dec 21, 2015 at 01:56:11PM +0300, Maxim Uvarov wrote: 2 example ipc pktio applications create ipc pktio to each other and do packet transfer, validation magic numbers and packets sequence counters inside it. It looks like there's a race

[lng-odp] [PATCH v5 API-NEXT 00/12] Separate CPU info codes into their platform files

From: Hongbo Zhang v4->v5 changes: - rebase to latest api-next branch v3->v4 changes: - update patch 9 of platform naming - add new patch 12 to rename cpu_hz to cpu_hz_max v2->v3 changes: use "api: cpu:" tag in patch 8/11 title instead of "linux-generic: sysinfo"

[lng-odp] [PATCH v5 API-NEXT 09/12] linux-generic: sysinfo: set values for cpu_arch_str

From: Hongbo Zhang The values of cpu_arch_str were deleted due to codes reorganization, this patch adds values to them again. Signed-off-by: Hongbo Zhang --- platform/linux-generic/arch/mips64/odp_sysinfo_parse.c | 1 +

[lng-odp] [PATCH v5 API-NEXT 08/12] api: cpu: make frequency API return 0 on failure

From: Hongbo Zhang All the CPU frequency API return value type is uint64_t, this patch makes them return 0 on failure instead of -1. Signed-off-by: Hongbo Zhang --- include/odp/api/cpu.h | 4

[lng-odp] [PATCH v5 API-NEXT 10/12] linux-generic: sysinfo: apply per-CPU implementation to MIPS

From: Hongbo Zhang When per-CPU framework was introduced, it was only implemented on x86, for other platforms, only the model_str[0] and cpu_hz[0] are set to pass compile, this patch set all values for model_str[] and cpu_hz[] on the MIPS platform. Signed-off-by: Hongbo

Re: [lng-odp] [PATCH] validation: pktio: fix check of pktio_stop() called twice

ping On 13.01.16 19:38, Ivan Khoronzhuk wrote: The odp_pktio_stop() called is supposed to return error. Signed-off-by: Ivan Khoronzhuk --- test/validation/pktio/pktio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [lng-odp] [PATCH] validation: pktio: use odp_time_ns() instead own function

ping On 13.01.16 19:18, Ivan Khoronzhuk wrote: Now odp_time_wait_ns() can be used. Signed-off-by: Ivan Khoronzhuk --- test/validation/pktio/pktio.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/test/validation/pktio/pktio.c

Re: [lng-odp] [PATCH] validation: pktio: assign MAC address if one loop pktio is used

ping On 14.01.16 12:56, Ivan Khoronzhuk wrote: In case of one loop pktio the MAC address is not set in the packets but should be. Signed-off-by: Ivan Khoronzhuk --- test/validation/pktio/pktio.c | 18 ++ 1 file changed, 14 insertions(+), 4

Re: [lng-odp] [PATCH] validation: pktio: don't continue if packet with > MTU is sent

ping On 15.01.16 17:55, Stuart Haslam wrote: On Fri, Jan 15, 2016 at 05:53:20PM +0200, Ivan Khoronzhuk wrote: On 15.01.16 17:51, Stuart Haslam wrote: On Wed, Jan 13, 2016 at 06:46:57PM +0200, Ivan Khoronzhuk wrote: If packet with size > MTU is sent the test can crash farther, so better to

Re: [lng-odp] [API-NEXT PATCH v3 0/6] Multi-queue pktio for poll mode

On Mon, Jan 18, 2016 at 05:58:37PM +0300, Maxim Uvarov wrote: > Stuart, can you please review this? > > Maxim. I've just run it through the validation tests and all seems well, I've have a closer look at the changes tomorrow. -- Stuart. ___ lng-odp

Re: [lng-odp] [PATCH] validation: pktio: don't continue if packet with > MTU is sent

merged. Maxim. On 01/18/2016 20:54, Ivan Khoronzhuk wrote: ping On 15.01.16 17:55, Stuart Haslam wrote: On Fri, Jan 15, 2016 at 05:53:20PM +0200, Ivan Khoronzhuk wrote: On 15.01.16 17:51, Stuart Haslam wrote: On Wed, Jan 13, 2016 at 06:46:57PM +0200, Ivan Khoronzhuk wrote: If packet with

Re: [lng-odp] [PATCHv19 9/9] linux-generic: internal ipc_pktio test

On 01/18/2016 19:10, Ivan Khoronzhuk wrote: +int ipc_odp_packet_sendall(odp_pktio_t pktio, + odp_packet_t pkt_tbl[], int num) +{ +int ret; +int sent = 0; +uint64_t start_cycle; +uint64_t diff; +uint64_t wait; + +wait = odp_time_local_from_ns(1 *

Re: [lng-odp] [PATCH v5 API-NEXT 00/12] Separate CPU info codes into their platform files

please run ./scripts/checkpatch.pl on patches, some of them have errors. Maxim. On 01/18/2016 13:09, hongbo.zh...@linaro.org wrote: From: Hongbo Zhang v4->v5 changes: - rebase to latest api-next branch v3->v4 changes: - update patch 9 of platform naming - add

Re: [lng-odp] [PATCH v5] validation: system: add validation tests for odp_cpu_cycles_* calls

> -Original Message- > From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] > Sent: Friday, January 15, 2016 5:07 PM > To: lng-odp@lists.linaro.org > Cc: Savolainen, Petri (Nokia - FI/Espoo); Ivan Khoronzhuk > Subject: [lng-odp] [PATCH v5] validation: system: add validation

Re: [lng-odp] [PATCH API-NEXT] api: pktio: remove unused ODP_PKTIO_ANY

Merged. Maxim. On 01/18/2016 12:04, Savolainen, Petri (Nokia - FI/Espoo) wrote: Reviewed-by: Petri Savolainen -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Stuart Haslam Sent: Friday, January 15, 2016 5:18 PM

Re: [lng-odp] [API-NEXT PATCH v2 0/3] validation: cls: correct tests a little

For the series: Reviewed-by: Balasubramanian Manoharan Regards, Bala On 15 January 2016 at 22:58, Ivan Khoronzhuk wrote: > This patch series corrects classification tests to be a little bit > adoptive. > > Since v1: > - removed patch for

Re: [lng-odp] [PATCH v5] validation: system: add validation tests for odp_cpu_cycles_* calls

On 18.01.16 13:37, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org] Sent: Friday, January 15, 2016 5:07 PM To: lng-odp@lists.linaro.org Cc: Savolainen, Petri (Nokia - FI/Espoo); Ivan Khoronzhuk Subject:

Re: [lng-odp] [API-NEXT PATCH 00/13] atomi api completion

On 8 January 2016 at 14:41, Petri Savolainen wrote: > Completed additions to atomic API. Added exchange operation in relaxed > memory > model. Added CAS operations in rel and acq_rel memory order. Added 64 bit > versions of all non-relaxed operations defined so far.

Re: [lng-odp] [PATCH v5 API-NEXT 04/12] linux-generic: sysinfo: move x86 system info codes to its plarform file

WARNING: line over 80 characters #73: FILE: platform/linux-generic/arch/x86/odp_sysinfo_parse.c:27: +sysinfo->cpu_hz[id] = (uint64_t)(ghz * 10.0); On 01/18/2016 13:10, hongbo.zh...@linaro.org wrote: From: Hongbo Zhang This patch moves the x86

Re: [lng-odp] [PATCHv19 9/9] linux-generic: internal ipc_pktio test

On 18.01.16 11:59, Maxim Uvarov wrote: On 01/15/2016 15:57, Stuart Haslam wrote: On Mon, Dec 21, 2015 at 01:56:11PM +0300, Maxim Uvarov wrote: 2 example ipc pktio applications create ipc pktio to each other and do packet transfer, validation magic numbers and packets sequence counters inside

[lng-odp] [PATCH] linux-generic: crypto: fix AES-GCM compatibility with old version of OpenSSL

Old version of OpenSSL require SET_TAG to be called before decrypting the data. New versions are compatible either way Signed-off-by: Nicolas Morey-Chaisemartin --- Repost due to previous mail tagged as SPAM platform/linux-generic/odp_crypto.c | 3 +-- 1 file changed, 1

Re: [lng-odp] [PATCH v6] validation: system: add validation tests for odp_cpu_cycles_* calls

Merged. On 01/18/2016 16:40, Savolainen, Petri (Nokia - FI/Espoo) wrote: Not sure if "odp_cpu_cycles_*" will cause problems in git log history. May be Maxim can remove the '*' from the string during merge (e.g. just "... cpu_cycles calls"). done. Reviewed-by: Petri Savolainen

Re: [lng-odp] [API-NEXT PATCH v2 10/13] validation: atomic: added xchg test

On 18 January 2016 at 16:25, Ola Liljedahl wrote: > On 18 January 2016 at 14:25, Petri Savolainen > wrote: > >> Added validation test for exchange operations. >> >> Signed-off-by: Petri Savolainen >> --- >>

Re: [lng-odp] [API-NEXT PATCHv1 2/2] linux-generic/validation: wait for timer handler completiion after timer deletion

On 15.01.16 11:14, Maxim Uvarov wrote: Add test case based on previous seg fault code that pool destroy does not fail if there are some timers in fight. Signed-off-by: Maxim Uvarov --- platform/linux-generic/odp_timer.c | 15 ++-

Re: [lng-odp] What to do regarding cahe non coherant systems

We can discuss your proposal during the call, today. I have a question, though. If the ODP_SHM_NONCOHERENT flag is implemeneted, then I guess we are back to the need for a refresh() or similar function to update the cache. Or you could implement this flag in your implementation only, allocating

Re: [lng-odp] What to do regarding cahe non coherant systems

Hi all, Our problem is about shmem usage so far. After some discussions we believe we have an acceptable solution: add a new flag to odp_shm_reserve(). So far we have ODP_SHM_SW_ONLY and ODP_SHM_PROC, we would like to add something like ODP_SHM_NONCOHERENT or similar. It would allow to keep

Re: [lng-odp] [API-NEXT PATCHv1 1/2] validation: increase timer expiration wait time

Maxim, in general, I had no look in this test, it was working for me and I was happy. At fast glance I have some comments. Hope you will find time to correct it. On 15.01.16 11:14, Maxim Uvarov wrote: Following current test logic validation test should correctly wait for all scheduled timer