Re: [lng-odp] 32b support in ODP-Cloud

On Tue, Mar 28, 2017 at 10:47 PM Honnappa Nagarahalli < honnappa.nagaraha...@linaro.org> wrote: > On 28 March 2017 at 22:27, Bill Fischofer > wrote: > > > > > > On Mon, Mar 27, 2017 at 10:11 PM, Honnappa Nagarahalli > > wrote: > >> >

Re: [lng-odp] 32b support in ODP-Cloud

On 28 March 2017 at 22:27, Bill Fischofer wrote: > > > On Mon, Mar 27, 2017 at 10:11 PM, Honnappa Nagarahalli > wrote: >> >> On 27 March 2017 at 08:36, Ola Liljedahl wrote: >> > On 27 March 2017 at 07:58,

Re: [lng-odp] [API-NEXT 4/4] A scalable software scheduler

On Tue, Mar 28, 2017 at 10:28 PM, Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote: > I had run the checkpatch.pl, but I did not see these issues. May be it > was to do with the way I generated the patch. I will address the ones that > make sense. > I did a git am for your patches and

Re: [lng-odp] [API-NEXT 4/4] A scalable software scheduler

I had run the checkpatch.pl, but I did not see these issues. May be it was to do with the way I generated the patch. I will address the ones that make sense. Do we have to compile for 32b with gcc? From: Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Tuesday, March 28, 2017 10:01 PM

Re: [lng-odp] 32b support in ODP-Cloud

On Mon, Mar 27, 2017 at 10:11 PM, Honnappa Nagarahalli < honnappa.nagaraha...@linaro.org> wrote: > On 27 March 2017 at 08:36, Ola Liljedahl wrote: > > On 27 March 2017 at 07:58, Honnappa Nagarahalli > > wrote: > >> My answers inline. I

Re: [lng-odp] [PATCH 2/2] linux-gen: remove pktio ipc option from configure

On Mon, Feb 27, 2017 at 9:21 AM, Maxim Uvarov wrote: > Options becomes stable and not need any entry in main > configure for platform specific pktio. > > Signed-off-by: Maxim Uvarov > Reviewed-by: Bill Fischofer >

Re: [lng-odp] [PATCH] test: perf: fix bash syntax in odp_pktio_ordered_run.sh

On Tue, Mar 21, 2017 at 11:50 AM, Maxim Uvarov wrote: > bash -lt syntax expects 2 integer values, not strings. > Also return code of piped command needs to be get in > a little bit different way. > https://bugs.linaro.org/show_bug.cgi?id=2872 > > Signed-off-by: Maxim

Re: [lng-odp] [PATCH] linux-gen: pktio: socket mmap: check unmap return code

On Tue, Mar 21, 2017 at 12:08 PM, Maxim Uvarov wrote: > Check unmap return code > https://bugs.linaro.org/show_bug.cgi?id=2831 > > Signed-off-by: Maxim Uvarov > Reviewed-by: Bill Fischofer > --- >

Re: [lng-odp] [API-NEXT 4/4] A scalable software scheduler

First off, I'm not sure why you're seeing HTML since Gmail is set to plain text mode for me. On Tue, Mar 28, 2017 at 9:18 PM, Brian Brooks wrote: > On 03/28 18:50:32, Bill Fischofer wrote: > > > > > > > > > > On Tue, > Mar 28,

Re: [lng-odp] [API-NEXT 3/4] api: queue: Add ring_size

On Tue, Mar 28, 2017 at 2:23 PM, Brian Brooks wrote: > Signed-off-by: Brian Brooks > --- > include/odp/api/spec/queue.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/include/odp/api/spec/queue.h b/include/odp/api/spec/queue.h > index

Re: [lng-odp] odp_queue_enq semantics

On 28 March 2017 at 20:32, Bill Fischofer wrote: > On Tue, Mar 28, 2017 at 11:18 AM, Honnappa Nagarahalli > wrote: >> On 28 March 2017 at 07:21, Bill Fischofer wrote: >>> On Tue, Mar 28, 2017 at 7:19 AM,

[lng-odp] [API-NEXT 3/4] api: queue: Add ring_size

Signed-off-by: Brian Brooks --- include/odp/api/spec/queue.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/odp/api/spec/queue.h b/include/odp/api/spec/queue.h index 7972feac..1cec4773 100644 --- a/include/odp/api/spec/queue.h +++

[lng-odp] [API-NEXT 2/4] linux-generic: ring.c: use required memory orderings

From: Ola Liljedahl Signed-off-by: Ola Liljedahl Reviewed-by: Brian Brooks --- platform/linux-generic/pktio/ring.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) mode change 100644 =>

[lng-odp] [API-NEXT 1/4] helper: cuckootable: Specify queue ring_size

From: Ola Liljedahl Signed-off-by: Ola Liljedahl Reviewed-by: Brian Brooks Reviewed-by: Honnappa Nagarahalli --- helper/cuckootable.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [lng-odp] odp_queue_enq semantics

On Tue, Mar 28, 2017 at 11:18 AM, Honnappa Nagarahalli wrote: > On 28 March 2017 at 07:21, Bill Fischofer wrote: >> On Tue, Mar 28, 2017 at 7:19 AM, Verma, Shally >> wrote: >>> >>> >>> -Original

Re: [lng-odp] odp_queue_enq semantics

On 28 March 2017 at 07:21, Bill Fischofer wrote: > On Tue, Mar 28, 2017 at 7:19 AM, Verma, Shally > wrote: >> >> >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill >> Fischofer >> Sent:

Re: [lng-odp] [PATCH] test: perf: fix bash syntax in odp_pktio_ordered_run.sh

ping On 03/21/17 19:50, Maxim Uvarov wrote: > bash -lt syntax expects 2 integer values, not strings. > Also return code of piped command needs to be get in > a little bit different way. > https://bugs.linaro.org/show_bug.cgi?id=2872 > > Signed-off-by: Maxim Uvarov > ---

Re: [lng-odp] [PATCH] linux-gen: pktio: socket mmap: check unmap return code

ping On 03/21/17 20:08, Maxim Uvarov wrote: > Check unmap return code > https://bugs.linaro.org/show_bug.cgi?id=2831 > > Signed-off-by: Maxim Uvarov > --- > platform/linux-generic/pktio/socket_mmap.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-)

Re: [lng-odp] [API-NEXT PATCH v2 1/2] validation: packet: increase test pool size

On 27 February 2017 at 13:18, Matias Elo wrote: > Previously packet_test_concatsplit() could fail on some pool > implementations as the pool ran out of buffers. Increase default pools size > and use capability to make sure the value is valid. > > Signed-off-by: Matias Elo

Re: [lng-odp] [API-NEXT PATCH v3 1/4] api: ipsec: extend lookaside API

On Tue, Mar 28, 2017 at 7:21 AM, Bogdan Pricope wrote: > There are two aspects to consider: > 1. How to process odp_ipsec_in(), odp_ipsec_out(),etc. with explicit > SA reference after an odp_ipsec_sa_disable() (or after > odp_ipsec_sa_destroy())? > 2. When is safe to

Re: [lng-odp] odp_queue_enq semantics

On Tue, Mar 28, 2017 at 7:19 AM, Verma, Shally wrote: > > > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill > Fischofer > Sent: 28 March 2017 16:44 > To: Ola Liljedahl > Cc: nd

Re: [lng-odp] odp_queue_enq semantics

On 28/03/17 12:13, Bill Fischofer wrote: > On Tue, Mar 28, 2017 at 4:10 AM, Ola Liljedahl > wrote: >> On 28 March 2017 at 10:41, Joe Savage wrote: >>> Hey, >>> >>> I just wanted to clarify something about the expected behaviour of >>> odp_queue_enq.

Re: [lng-odp] [API-NEXT PATCH] api: packet: add per packet checksum control

On Tue, Mar 28, 2017 at 6:39 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > It's a mandatory feature when forwarding: "Forwarded packets need to maintain > original, end-to-end checksum value.". A box in the middle must not > re-compute e.g. L4 checksum.

Re: [lng-odp] [API-NEXT PATCH v3 1/4] api: ipsec: extend lookaside API

On Tue, Mar 28, 2017 at 4:58 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: Bill Fischofer [mailto:bill.fischo...@linaro.org] >> Sent: Tuesday, March 28, 2017 4:32 AM >> To: Savolainen, Petri (Nokia - FI/Espoo)

Re: [lng-odp] [API-NEXT PATCH] api: packet: add per packet checksum control

It's a mandatory feature when forwarding: "Forwarded packets need to maintain original, end-to-end checksum value.". A box in the middle must not re-compute e.g. L4 checksum. If it would do that, it could introduce an error in payload data and update the checksum accordingly. The receiving end

Re: [lng-odp] [API-NEXT PATCH] api: packet: add per packet checksum control

These look good, but shouldn't these be documented as advisory? When dealing with well-formed packets, it should not matter if HW always recomputes checksums on transmit. The only time you'd need to suppress checksum generation would be in diagnostic packet generators that are intentionally

Re: [lng-odp] odp_queue_enq semantics

On Tue, Mar 28, 2017 at 4:10 AM, Ola Liljedahl wrote: > On 28 March 2017 at 10:41, Joe Savage wrote: >> Hey, >> >> I just wanted to clarify something about the expected behaviour of >> odp_queue_enq. In the following code snippet, is it acceptable

[lng-odp] [API-NEXT PATCH] api: packet: add per packet checksum control

Checksum insertion has pktio interface level configuration options. Per packet override is needed for example when L4 checksumming is enabled and application forwards packets. Forwarded packets need to maintain original, end-to-end checksum value. Signed-off-by: Petri Savolainen

[lng-odp] [PATCHv5 5/5] test: generator: use multiple TX queues in send UDP mode

Signed-off-by: Bogdan Pricope --- example/generator/odp_generator.c | 136 +++--- 1 file changed, 84 insertions(+), 52 deletions(-) diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c index

[lng-odp] [PATCHv5 4/5] test: generator: use multiple RX queue in receiving mode

Signed-off-by: Bogdan Pricope --- example/generator/odp_generator.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c index 452fa8b..9305aa9 100644 ---

[lng-odp] [PATCHv5 3/5] test: generator: receive packets in bursts

Signed-off-by: Bogdan Pricope --- example/generator/odp_generator.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c index a9b07e5..452fa8b 100644

[lng-odp] [PATCHv5 1/5] test: generator: compose sending packets from reference packet plus differences

Signed-off-by: Bogdan Pricope --- example/generator/odp_generator.c | 130 +- 1 file changed, 113 insertions(+), 17 deletions(-) diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c index

[lng-odp] [PATCHv5 2/5] test: generator: send UDP packets in bursts

Signed-off-by: Bogdan Pricope --- example/generator/odp_generator.c | 74 --- 1 file changed, 53 insertions(+), 21 deletions(-) diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c index

[lng-odp] [PATCHv5 0/5] test: generator: improve performance

Improve performance of "odp_generator" example application. Bogdan Pricope (5): test: generator: compose sending packets from reference packet plus differences test: generator: send UDP packets in bursts test: generator: receive packets in bursts test: generator: use multiple RX queue

Re: [lng-odp] [API-NEXT PATCH v3 1/4] api: ipsec: extend lookaside API

> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Tuesday, March 28, 2017 4:32 AM > To: Savolainen, Petri (Nokia - FI/Espoo) labs.com> > Cc: lng-odp-forward > Subject: Re: [lng-odp] [API-NEXT

Re: [lng-odp] odp_queue_enq semantics

On 28 March 2017 at 10:41, Joe Savage wrote: > Hey, > > I just wanted to clarify something about the expected behaviour of > odp_queue_enq. In the following code snippet, is it acceptable for the assert > to fire? (i.e. for a dequeue after a successful enqueue to fail, with

[lng-odp] odp_queue_enq semantics

Hey, I just wanted to clarify something about the expected behaviour of odp_queue_enq. In the following code snippet, is it acceptable for the assert to fire? (i.e. for a dequeue after a successful enqueue to fail, with only a single thread of execution) odp_queue_t queue;

Re: [lng-odp] [API-NEXT PATCH v2 1/2] validation: packet: increase test pool size

Ping. > On 27 Feb 2017, at 14:18, Matias Elo wrote: > > Previously packet_test_concatsplit() could fail on some pool > implementations as the pool ran out of buffers. Increase default pools size > and use capability to make sure the value is valid. > > Signed-off-by:

Re: [lng-odp] [PATCH v2 1/3] linux-gen: add internal helper for reading system thread id

Ping. > On 17 Mar 2017, at 14:16, Matias Elo wrote: > > Signed-off-by: Matias Elo > --- > platform/linux-generic/Makefile.am | 1 + > platform/linux-generic/include/odp_thread_internal.h | 20 >

Re: [lng-odp] [API-NEXT PATCH 1/4] linux-gen: packet: recognize ICMPv6 packets

Ping. > On 22 Mar 2017, at 17:29, Matias Elo wrote: > > Signed-off-by: Matias Elo > --- > example/generator/odp_generator.c | 4 ++-- > example/ipsec/odp_ipsec_stream.c | 6 +++--- > helper/include/odp/helper/ip.h