Re: [lng-odp] [API-NEXT PATCH v2 09/16] Avoid shm namespace collisions and allow shm block per queue

I think this can be an independent patch that can go into master/api-next. On 4 April 2017 at 17:44, Bill Fischofer wrote: > On Tue, Apr 4, 2017 at 1:48 PM, Brian Brooks wrote: >> Signed-off-by: Kevin Wang >> Reviewed-by: Ola

Re: [lng-odp] [API-NEXT PATCH v2 07/16] test: odp_scheduling: Handle dequeueing from a concurrent queue

This can go into master/api-next as an independent patch. Agree? On 4 April 2017 at 21:22, Brian Brooks wrote: > On 04/04 17:26:12, Bill Fischofer wrote: >> On Tue, Apr 4, 2017 at 3:37 PM, Brian Brooks wrote: >> > On 04/04 21:59:15, Maxim Uvarov

Re: [lng-odp] [API-NEXT PATCH v2 00/16] A scalable software scheduler

On 4 April 2017 at 16:12, Bill Fischofer wrote: > When I compile configure this without --enable-schedule-scalable the > scheduler validation test runs normally, however if I enable the new > scheduler I get this output: > > > ... > CUnit - A unit testing framework

Re: [lng-odp] [API-NEXT PATCH v2 06/16] Fix a locking bug

On 04/04 17:23:10, Bill Fischofer wrote: > On Tue, Apr 4, 2017 at 5:20 PM, Bill Fischofer > wrote: > > This is clearly orthogonal to this patch series. Ideally you should > > (a) Create a Bug to represent this, (b) Post the fix patch noting the > > Bug URL in the commit

Re: [lng-odp] [API-NEXT PATCH v2 07/16] test: odp_scheduling: Handle dequeueing from a concurrent queue

On 04/04 17:26:12, Bill Fischofer wrote: > On Tue, Apr 4, 2017 at 3:37 PM, Brian Brooks wrote: > > On 04/04 21:59:15, Maxim Uvarov wrote: > >> On 04/04/17 21:47, Brian Brooks wrote: > >> > Signed-off-by: Ola Liljedahl > >> > Reviewed-by: Brian Brooks

Re: [lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

On 04/05 02:21:36, Dmitry Eremin-Solenikov wrote: > On 05.04.2017 00:25, Brian Brooks wrote: > > On 04/04 23:23:33, Dmitry Eremin-Solenikov wrote: > >> On 04.04.2017 22:25, Maxim Uvarov wrote: > >>> it's better to have 2 separate files for that. One for ODP_CONFIG_LLDSCD > >>> defined and one for

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

On 04/04 23:12:07, Maxim Uvarov wrote: > On 04/04/17 23:08, Brian Brooks wrote: > > On 04/04 22:17:48, Maxim Uvarov wrote: > >> On 04/04/17 21:48, Brian Brooks wrote: [snip] > >>> +/* Load-exclusive with memory ordering */ > >>> +static inline bitset_t bitset_ldex(bitset_t *bs, int mo) > >>> +{

Re: [lng-odp] [API-NEXT PATCH v2 12/16] Add LL/SC and signaling primitives

On 04/05 03:10:25, Dmitry Eremin-Solenikov wrote: > On 05.04.2017 02:34, Ola Liljedahl wrote: > > > > > > > > > > On 05/04/2017, 01:29, "Dmitry Eremin-Solenikov" > > wrote: > > > >> On 05.04.2017 01:00, Brian Brooks wrote: > >>> On Tue, Apr 4, 2017 at 3:38

Re: [lng-odp] [API-NEXT PATCH v2 12/16] Add LL/SC and signaling primitives

On 05.04.2017 02:34, Ola Liljedahl wrote: > > > > > On 05/04/2017, 01:29, "Dmitry Eremin-Solenikov" > wrote: > >> On 05.04.2017 01:00, Brian Brooks wrote: >>> On Tue, Apr 4, 2017 at 3:38 PM, Ola Liljedahl >>> wrote: On

Re: [lng-odp] [API-NEXT PATCH v2 12/16] Add LL/SC and signaling primitives

On 05/04/2017, 01:29, "Dmitry Eremin-Solenikov" wrote: >On 05.04.2017 01:00, Brian Brooks wrote: >> On Tue, Apr 4, 2017 at 3:38 PM, Ola Liljedahl >>wrote: >>> On 04/04/2017, 22:14, "Dmitry Eremin-Solenikov" >>>

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

Trying a different way to avoid the ARM disclaimer. But just to make sure, this email does NOT contain any confidential information. On 05/04/2017, 01:25, "Dmitry Eremin-Solenikov" wrote: >On 04.04.2017 23:52, Ola Liljedahl wrote: >> Sending from my ARM

Re: [lng-odp] [API-NEXT PATCH v2 12/16] Add LL/SC and signaling primitives

On 05.04.2017 01:00, Brian Brooks wrote: > On Tue, Apr 4, 2017 at 3:38 PM, Ola Liljedahl wrote: >> On 04/04/2017, 22:14, "Dmitry Eremin-Solenikov" >> wrote: >>> On 04.04.2017 21:48, Brian Brooks wrote: +#endif + +#if

Re: [lng-odp] [API-NEXT PATCH v2 12/16] Add LL/SC and signaling primitives

On 05.04.2017 00:00, Ola Liljedahl wrote: > I think I missed one comment. > > > On 04/04/2017, 22:14, "Dmitry Eremin-Solenikov" > wrote: > >> On 04.04.2017 21:48, Brian Brooks wrote: >>> Signed-off-by: Ola Liljedahl >>> Reviewed-by:

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

On 04.04.2017 23:52, Ola Liljedahl wrote: > Sending from my ARM email account, I hope Outlook does not mess up the > format. > > > > On 04/04/2017, 22:21, "Dmitry Eremin-Solenikov" > wrote: > >> On 04.04.2017 21:48, Brian Brooks wrote: >>> Signed-off-by: Ola

Re: [lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

On 05.04.2017 00:25, Brian Brooks wrote: > On 04/04 23:23:33, Dmitry Eremin-Solenikov wrote: >> On 04.04.2017 22:25, Maxim Uvarov wrote: >>> it's better to have 2 separate files for that. One for ODP_CONFIG_LLDSCD >>> defined and one for not. >> >> Seconding that. At least LLDSCD and non-LLDSCD

Re: [lng-odp] [API-NEXT PATCH v2 07/16] test: odp_scheduling: Handle dequeueing from a concurrent queue

On 4 April 2017 at 20:59, Maxim Uvarov wrote: > On 04/04/17 21:47, Brian Brooks wrote: >> Signed-off-by: Ola Liljedahl >> Reviewed-by: Brian Brooks >> Reviewed-by: Honnappa Nagarahalli >>

Re: [lng-odp] [API-NEXT PATCH v2 07/16] test: odp_scheduling: Handle dequeueing from a concurrent queue

On 5 April 2017 at 00:26, Bill Fischofer wrote: > On Tue, Apr 4, 2017 at 3:37 PM, Brian Brooks wrote: >> On 04/04 21:59:15, Maxim Uvarov wrote: >>> On 04/04/17 21:47, Brian Brooks wrote: >>> > Signed-off-by: Ola Liljedahl

Re: [lng-odp] [API-NEXT PATCH v2 06/16] Fix a locking bug

On 5 April 2017 at 00:23, Bill Fischofer wrote: > On Tue, Apr 4, 2017 at 5:20 PM, Bill Fischofer > wrote: >> This is clearly orthogonal to this patch series. Ideally you should >> (a) Create a Bug to represent this, (b) Post the fix patch

Re: [lng-odp] [API-NEXT PATCH v2 10/16] Add _odp_packet_to_buf_hdr_ptr()

On Tue, Apr 4, 2017 at 1:48 PM, Brian Brooks wrote: > Signed-off-by: Kevin Wang > Reviewed-by: Brian Brooks > --- > platform/linux-generic/include/odp_packet_internal.h | 3 +++ > platform/linux-generic/odp_packet.c

Re: [lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

On 4 April 2017 at 21:25, Maxim Uvarov wrote: > it's better to have 2 separate files for that. One for ODP_CONFIG_LLDSCD "better"? In what way? > defined and one for not. Also ODP_ prefix should not be used for > internal things (not api). OK this was not clear, some of

Re: [lng-odp] [API-NEXT PATCH v2 09/16] Avoid shm namespace collisions and allow shm block per queue

On Tue, Apr 4, 2017 at 1:48 PM, Brian Brooks wrote: > Signed-off-by: Kevin Wang > Reviewed-by: Ola Liljedahl > Reviewed-by: Brian Brooks > Reviewed-by: Honnappa Nagarahalli >

Re: [lng-odp] [API-NEXT PATCH v2 08/16] test: scheduler: Fixup calling release operations

On Tue, Apr 4, 2017 at 3:48 PM, Brian Brooks wrote: > On 04/04 23:07:32, Maxim Uvarov wrote: >> On 04/04/17 22:51, Brian Brooks wrote: >> > On 04/04 22:01:23, Maxim Uvarov wrote: >> >> On 04/04/17 21:48, Brian Brooks wrote: >> >>> Remove erroneous assertion that is handled

Re: [lng-odp] [API-NEXT PATCH v2 07/16] test: odp_scheduling: Handle dequeueing from a concurrent queue

On Tue, Apr 4, 2017 at 3:37 PM, Brian Brooks wrote: > On 04/04 21:59:15, Maxim Uvarov wrote: >> On 04/04/17 21:47, Brian Brooks wrote: >> > Signed-off-by: Ola Liljedahl >> > Reviewed-by: Brian Brooks >> > Reviewed-by: Honnappa

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

On 04.04.2017 23:34, Brian Brooks wrote: > On 04/04 23:27:51, Dmitry Eremin-Solenikov wrote: >> On 04.04.2017 23:26, Brian Brooks wrote: >>> On 04/04 23:04:10, Dmitry Eremin-Solenikov wrote: On 04.04.2017 21:47, Brian Brooks wrote: > Signed-off-by: Brian Brooks

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

On 05.04.2017 00:31, Brian Brooks wrote: > On 04/04 14:53:23, Bill Fischofer wrote: >> On Tue, Apr 4, 2017 at 2:45 PM, Brian Brooks wrote: >>> On 04/04 21:55:06, Maxim Uvarov wrote: this patch should be not part of this serries and can go to master as standalone

Re: [lng-odp] [API-NEXT PATCH v2 06/16] Fix a locking bug

On Tue, Apr 4, 2017 at 5:20 PM, Bill Fischofer wrote: > This is clearly orthogonal to this patch series. Ideally you should > (a) Create a Bug to represent this, (b) Post the fix patch noting the > Bug URL in the commit log, and (c) update the Bug entry with the URL >

Re: [lng-odp] [API-NEXT PATCH v2 06/16] Fix a locking bug

This is clearly orthogonal to this patch series. Ideally you should (a) Create a Bug to represent this, (b) Post the fix patch noting the Bug URL in the commit log, and (c) update the Bug entry with the URL of the patch that fixes this bug. On Tue, Apr 4, 2017 at 1:47 PM, Brian Brooks

Re: [lng-odp] [API-NEXT PATCH v2 05/16] Add ODP_CONFIG_QUEUE_SIZE

On Tue, Apr 4, 2017 at 3:40 PM, Brian Brooks wrote: > On 04/04 23:02:15, Maxim Uvarov wrote: >> On 04/04/17 22:48, Brian Brooks wrote: >> > On 04/04 21:57:29, Maxim Uvarov wrote: >> >> On 04/04/17 21:47, Brian Brooks wrote: >> >>> Signed-off-by: Ola Liljedahl

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

On Tue, Apr 4, 2017 at 4:31 PM, Brian Brooks wrote: > On 04/04 14:53:23, Bill Fischofer wrote: >> On Tue, Apr 4, 2017 at 2:45 PM, Brian Brooks wrote: >> > On 04/04 21:55:06, Maxim Uvarov wrote: >> >> this patch should be not part of this serries and

Re: [lng-odp] [API-NEXT PATCH v2 12/16] Add LL/SC and signaling primitives

Sorry to say but I see the ARM disclaimer at the bottom even though I requested the disclaimer not to be added to this specific email (there is a trick for that). I need to figure out what went wrong. -- Ola On 4 April 2017 at 22:38, Ola Liljedahl wrote: > > > > > On

Re: [lng-odp] [API-NEXT PATCH v2 12/16] Add LL/SC and signaling primitives

On Tue, Apr 4, 2017 at 3:38 PM, Ola Liljedahl wrote: > > > > > > On 04/04/2017, 22:14, "Dmitry Eremin-Solenikov" > wrote: > > >On 04.04.2017 21:48, Brian Brooks wrote: > >> Signed-off-by: Ola Liljedahl > >>

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

On 04/04 14:53:23, Bill Fischofer wrote: > On Tue, Apr 4, 2017 at 2:45 PM, Brian Brooks wrote: > > On 04/04 21:55:06, Maxim Uvarov wrote: > >> this patch should be not part of this serries and can go to master as > >> standalone patch. > > > > Can you help to cherry pick

Re: [lng-odp] [API-NEXT PATCH v2 03/16] api: queue: Add ring_size

On Tue, Apr 4, 2017 at 4:23 PM, Brian Brooks wrote: > On 04/04 15:20:06, Bill Fischofer wrote: >> On Tue, Apr 4, 2017 at 3:11 PM, Brian Brooks wrote: >> > On 04/04 14:22:25, Bill Fischofer wrote: >> >> On Tue, Apr 4, 2017 at 1:53 PM, Maxim Uvarov

Re: [lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

On 04/04 23:23:33, Dmitry Eremin-Solenikov wrote: > On 04.04.2017 22:25, Maxim Uvarov wrote: > > it's better to have 2 separate files for that. One for ODP_CONFIG_LLDSCD > > defined and one for not. > > Seconding that. At least LLDSCD and non-LLDSCD code should not be > interleaved. Can you

Re: [lng-odp] [API-NEXT PATCH v2 03/16] api: queue: Add ring_size

On 04/04 15:20:06, Bill Fischofer wrote: > On Tue, Apr 4, 2017 at 3:11 PM, Brian Brooks wrote: > > On 04/04 14:22:25, Bill Fischofer wrote: > >> On Tue, Apr 4, 2017 at 1:53 PM, Maxim Uvarov > >> wrote: > >> > On 04/04/17 21:47, Brian Brooks wrote:

Re: [lng-odp] [API-NEXT PATCH v2 00/16] A scalable software scheduler

When I compile configure this without --enable-schedule-scalable the scheduler validation test runs normally, however if I enable the new scheduler I get this output: ... CUnit - A unit testing framework for C - Version 2.1-3 http://cunit.sourceforge.net/

Re: [lng-odp] [API-NEXT PATCH v2 12/16] Add LL/SC and signaling primitives

I think I missed one comment. On 04/04/2017, 22:14, "Dmitry Eremin-Solenikov" wrote: >On 04.04.2017 21:48, Brian Brooks wrote: >> Signed-off-by: Ola Liljedahl >> Reviewed-by: Brian Brooks >> Reviewed-by: Honnappa

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

Sending from my ARM email account, I hope Outlook does not mess up the format. On 04/04/2017, 22:21, "Dmitry Eremin-Solenikov" wrote: >On 04.04.2017 21:48, Brian Brooks wrote: >> Signed-off-by: Ola Liljedahl >> Reviewed-by: Brian

Re: [lng-odp] [API-NEXT PATCH v2 08/16] test: scheduler: Fixup calling release operations

On 04/04 23:07:32, Maxim Uvarov wrote: > On 04/04/17 22:51, Brian Brooks wrote: > > On 04/04 22:01:23, Maxim Uvarov wrote: > >> On 04/04/17 21:48, Brian Brooks wrote: > >>> Remove erroneous assertion that is handled in later code > >>> > >> > >> Patch logically incorrect. This patch adds

Re: [lng-odp] [API-NEXT PATCH v2 12/16] Add LL/SC and signaling primitives

On 04/04/2017, 22:14, "Dmitry Eremin-Solenikov" wrote: >On 04.04.2017 21:48, Brian Brooks wrote: >> Signed-off-by: Ola Liljedahl >> Reviewed-by: Brian Brooks >> Reviewed-by: Honnappa Nagarahalli

Re: [lng-odp] [API-NEXT PATCH v2 05/16] Add ODP_CONFIG_QUEUE_SIZE

On 04/04 23:02:15, Maxim Uvarov wrote: > On 04/04/17 22:48, Brian Brooks wrote: > > On 04/04 21:57:29, Maxim Uvarov wrote: > >> On 04/04/17 21:47, Brian Brooks wrote: > >>> Signed-off-by: Ola Liljedahl > >>> Reviewed-by: Honnappa Nagarahalli >

Re: [lng-odp] [API-NEXT PATCH v2 07/16] test: odp_scheduling: Handle dequeueing from a concurrent queue

On 04/04 21:59:15, Maxim Uvarov wrote: > On 04/04/17 21:47, Brian Brooks wrote: > > Signed-off-by: Ola Liljedahl > > Reviewed-by: Brian Brooks > > Reviewed-by: Honnappa Nagarahalli > > Reviewed-by: Kevin Wang

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

On Tue, Apr 4, 2017 at 3:35 PM, Bill Fischofer wrote: > On Tue, Apr 4, 2017 at 3:08 PM, Brian Brooks wrote: >> On 04/04 22:17:48, Maxim Uvarov wrote: >>> On 04/04/17 21:48, Brian Brooks wrote: >>> > Signed-off-by: Ola Liljedahl

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

On Tue, Apr 4, 2017 at 3:08 PM, Brian Brooks wrote: > On 04/04 22:17:48, Maxim Uvarov wrote: >> On 04/04/17 21:48, Brian Brooks wrote: >> > Signed-off-by: Ola Liljedahl >> > Reviewed-by: Brian Brooks >> > Reviewed-by: Honnappa

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

On 04/04 23:27:51, Dmitry Eremin-Solenikov wrote: > On 04.04.2017 23:26, Brian Brooks wrote: > > On 04/04 23:04:10, Dmitry Eremin-Solenikov wrote: > >> On 04.04.2017 21:47, Brian Brooks wrote: > >>> Signed-off-by: Brian Brooks > >> > >> Brian, > >> > >> how does this fail

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

On 04.04.2017 23:26, Brian Brooks wrote: > On 04/04 23:04:10, Dmitry Eremin-Solenikov wrote: >> On 04.04.2017 21:47, Brian Brooks wrote: >>> Signed-off-by: Brian Brooks >> >> Brian, >> >> how does this fail with clang on ARMv8? Could you please include error >> message in

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

On 04/04 23:04:10, Dmitry Eremin-Solenikov wrote: > On 04.04.2017 21:47, Brian Brooks wrote: > > Signed-off-by: Brian Brooks > > Brian, > > how does this fail with clang on ARMv8? Could you please include error > message in the commit message? Well, you can't pass -mcx16

Re: [lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

On 04.04.2017 22:25, Maxim Uvarov wrote: > it's better to have 2 separate files for that. One for ODP_CONFIG_LLDSCD > defined and one for not. Seconding that. At least LLDSCD and non-LLDSCD code should not be interleaved. -- With best wishes Dmitry

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

On 04.04.2017 21:48, Brian Brooks wrote: > Signed-off-by: Ola Liljedahl > Reviewed-by: Brian Brooks > Reviewed-by: Honnappa Nagarahalli > +/**

Re: [lng-odp] [API-NEXT PATCH v2 03/16] api: queue: Add ring_size

On Tue, Apr 4, 2017 at 3:11 PM, Brian Brooks wrote: > On 04/04 14:22:25, Bill Fischofer wrote: >> On Tue, Apr 4, 2017 at 1:53 PM, Maxim Uvarov wrote: >> > On 04/04/17 21:47, Brian Brooks wrote: >> >> Signed-off-by: Brian Brooks

Re: [lng-odp] [API-NEXT PATCH v2 02/16] linux-generic: ring.c: use required memory orderings

On Tue, Apr 4, 2017 at 2:53 PM, Brian Brooks wrote: > On 04/04 14:11:45, Bill Fischofer wrote: >> This part has already been merged into the repo and should be removed >> from this series as it cannot be applied since it's already part of >> api-next. > > Right, but it can

Re: [lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

On 04/04 22:25:29, Maxim Uvarov wrote: > it's better to have 2 separate files for that. I actually think it's really helpful to see both variants (lock and lock-free) next to each other with spatial locality. But, it did take me quite a while to work with such code. > One for ODP_CONFIG_LLDSCD >

Re: [lng-odp] [API-NEXT PATCH v2 12/16] Add LL/SC and signaling primitives

On 04.04.2017 21:48, Brian Brooks wrote: > Signed-off-by: Ola Liljedahl > Reviewed-by: Brian Brooks > Reviewed-by: Honnappa Nagarahalli > --- > platform/linux-generic/include/odp_llsc.h | 332 >

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

On 04/04/17 23:08, Brian Brooks wrote: > On 04/04 22:17:48, Maxim Uvarov wrote: >> On 04/04/17 21:48, Brian Brooks wrote: >>> Signed-off-by: Ola Liljedahl >>> Reviewed-by: Brian Brooks >>> Reviewed-by: Honnappa Nagarahalli

Re: [lng-odp] [API-NEXT PATCH v2 03/16] api: queue: Add ring_size

On 04/04 14:22:25, Bill Fischofer wrote: > On Tue, Apr 4, 2017 at 1:53 PM, Maxim Uvarov wrote: > > On 04/04/17 21:47, Brian Brooks wrote: > >> Signed-off-by: Brian Brooks > >> Signed-off-by: Honnappa Nagarahalli > >>

Re: [lng-odp] [API-NEXT PATCH v2 02/16] linux-generic: ring.c: use required memory orderings

On 04/04/17 22:53, Brian Brooks wrote: > On 04/04 14:11:45, Bill Fischofer wrote: >> This part has already been merged into the repo and should be removed >> from this series as it cannot be applied since it's already part of >> api-next. > > Right, but it can only be dropped once that patch has

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

On 04/04 22:17:48, Maxim Uvarov wrote: > On 04/04/17 21:48, Brian Brooks wrote: > > Signed-off-by: Ola Liljedahl > > Reviewed-by: Brian Brooks > > Reviewed-by: Honnappa Nagarahalli > > --- > >

Re: [lng-odp] [API-NEXT PATCH v2 08/16] test: scheduler: Fixup calling release operations

On 04/04/17 22:51, Brian Brooks wrote: > On 04/04 22:01:23, Maxim Uvarov wrote: >> On 04/04/17 21:48, Brian Brooks wrote: >>> Remove erroneous assertion that is handled in later code >>> >> >> Patch logically incorrect. This patch adds odp_schedule_release_x(). >> Chunk of removing ASSERT has to

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

On 04.04.2017 21:47, Brian Brooks wrote: > Signed-off-by: Brian Brooks Brian, how does this fail with clang on ARMv8? Could you please include error message in the commit message? -- With best wishes Dmitry

Re: [lng-odp] [API-NEXT PATCH v2 05/16] Add ODP_CONFIG_QUEUE_SIZE

On 04/04/17 22:48, Brian Brooks wrote: > On 04/04 21:57:29, Maxim Uvarov wrote: >> On 04/04/17 21:47, Brian Brooks wrote: >>> Signed-off-by: Ola Liljedahl >>> Reviewed-by: Honnappa Nagarahalli >>> Reviewed-by: Brian Brooks

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

On 04/04/17 22:45, Brian Brooks wrote: > On 04/04 21:55:06, Maxim Uvarov wrote: >> this patch should be not part of this serries and can go to master as >> standalone patch. > > Can you help to cherry pick such patches to master? They need to remain > in this patch series until they are cherry

Re: [lng-odp] [API-NEXT PATCH v2 02/16] linux-generic: ring.c: use required memory orderings

On 04/04 14:11:45, Bill Fischofer wrote: > This part has already been merged into the repo and should be removed > from this series as it cannot be applied since it's already part of > api-next. Right, but it can only be dropped once that patch has made its way into api-next. Until then I have to

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

On Tue, Apr 4, 2017 at 2:45 PM, Brian Brooks wrote: > On 04/04 21:55:06, Maxim Uvarov wrote: >> this patch should be not part of this serries and can go to master as >> standalone patch. > > Can you help to cherry pick such patches to master? They need to remain > in this

Re: [lng-odp] [API-NEXT PATCH v2 08/16] test: scheduler: Fixup calling release operations

On 04/04 22:01:23, Maxim Uvarov wrote: > On 04/04/17 21:48, Brian Brooks wrote: > > Remove erroneous assertion that is handled in later code > > > > Patch logically incorrect. This patch adds odp_schedule_release_x(). > Chunk of removing ASSERT has to go to "later code" patch. I'm not sure I

Re: [lng-odp] [API-NEXT PATCH v2 05/16] Add ODP_CONFIG_QUEUE_SIZE

On 04/04 21:57:29, Maxim Uvarov wrote: > On 04/04/17 21:47, Brian Brooks wrote: > > Signed-off-by: Ola Liljedahl > > Reviewed-by: Honnappa Nagarahalli > > Reviewed-by: Brian Brooks > > --- > >

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

On 04/04 21:55:06, Maxim Uvarov wrote: > this patch should be not part of this serries and can go to master as > standalone patch. Can you help to cherry pick such patches to master? They need to remain in this patch series until they are cherry picked to master and master is sync'd into

Re: [lng-odp] [API-NEXT PATCH v2 16/16] Add scalable scheduler

On 04/04/17 21:48, Brian Brooks wrote: > Add queue getters and setters to provide an abstraction over more than one > internal queue data structure. > > Use buffer handles instead of pointer to internal object in pktio and tm code. > > Increase the running time of odp_sched_latency to get more

Re: [lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

it's better to have 2 separate files for that. One for ODP_CONFIG_LLDSCD defined and one for not. Also ODP_ prefix should not be used for internal things (not api). Maxim. On 04/04/17 21:48, Brian Brooks wrote: > Signed-off-by: Ola Liljedahl > Reviewed-by: Brian Brooks

Re: [lng-odp] [API-NEXT PATCH v2 03/16] api: queue: Add ring_size

On Tue, Apr 4, 2017 at 1:53 PM, Maxim Uvarov wrote: > On 04/04/17 21:47, Brian Brooks wrote: >> Signed-off-by: Brian Brooks >> Signed-off-by: Honnappa Nagarahalli >> --- >> include/odp/api/spec/queue.h | 5 + >> 1

Re: [lng-odp] [API-NEXT PATCH v2 12/16] Add LL/SC and signaling primitives

On 04/04/17 21:48, Brian Brooks wrote: > Signed-off-by: Ola Liljedahl > Reviewed-by: Brian Brooks > Reviewed-by: Honnappa Nagarahalli > --- > platform/linux-generic/include/odp_llsc.h | 332 >

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

On 04/04/17 21:48, Brian Brooks wrote: > Signed-off-by: Ola Liljedahl > Reviewed-by: Brian Brooks > Reviewed-by: Honnappa Nagarahalli > --- > platform/linux-generic/include/odp_bitset.h | 155 >

Re: [lng-odp] [API-NEXT PATCH v2 02/16] linux-generic: ring.c: use required memory orderings

This part has already been merged into the repo and should be removed from this series as it cannot be applied since it's already part of api-next. On Tue, Apr 4, 2017 at 1:47 PM, Brian Brooks wrote: > From: Ola Liljedahl > > Signed-off-by: Ola

Re: [lng-odp] [API-NEXT PATCH v2 08/16] test: scheduler: Fixup calling release operations

On 04/04/17 21:48, Brian Brooks wrote: > Remove erroneous assertion that is handled in later code > Patch logically incorrect. This patch adds odp_schedule_release_x(). Chunk of removing ASSERT has to go to "later code" patch. Maxim. > Signed-off-by: Kevin Wang >

Re: [lng-odp] [API-NEXT PATCH v2 07/16] test: odp_scheduling: Handle dequeueing from a concurrent queue

On 04/04/17 21:47, Brian Brooks wrote: > Signed-off-by: Ola Liljedahl > Reviewed-by: Brian Brooks > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Kevin Wang > --- >

Re: [lng-odp] [API-NEXT PATCH v2 05/16] Add ODP_CONFIG_QUEUE_SIZE

On 04/04/17 21:47, Brian Brooks wrote: > Signed-off-by: Ola Liljedahl > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Brian Brooks > --- > platform/linux-generic/include/odp_config_internal.h | 7 +++ > 1 file

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

this patch should be not part of this serries and can go to master as standalone patch. No need of camel case is shor description. Long description in git comment is required. Maxim. On 04/04/17 21:47, Brian Brooks wrote: > Signed-off-by: Brian Brooks > --- >

Re: [lng-odp] [API-NEXT PATCH v2 03/16] api: queue: Add ring_size

On 04/04/17 21:47, Brian Brooks wrote: > Signed-off-by: Brian Brooks > Signed-off-by: Honnappa Nagarahalli > --- > include/odp/api/spec/queue.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/include/odp/api/spec/queue.h

[lng-odp] [API-NEXT PATCH v2 16/16] Add scalable scheduler

Add queue getters and setters to provide an abstraction over more than one internal queue data structure. Use buffer handles instead of pointer to internal object in pktio and tm code. Increase the running time of odp_sched_latency to get more stable numbers across multiple runs. This is not

[lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

Signed-off-by: Ola Liljedahl Reviewed-by: Brian Brooks --- platform/linux-generic/include/odp_llqueue.h | 285 +++ 1 file changed, 285 insertions(+) create mode 100644 platform/linux-generic/include/odp_llqueue.h diff --git

[lng-odp] [API-NEXT PATCH v2 14/16] Add atomic ops for 128-bit scalars

Signed-off-by: Ola Liljedahl Reviewed-by: Brian Brooks --- platform/linux-generic/include/odp_atomic16.h | 214 ++ 1 file changed, 214 insertions(+) create mode 100644 platform/linux-generic/include/odp_atomic16.h diff --git

[lng-odp] [API-NEXT PATCH v2 12/16] Add LL/SC and signaling primitives

Signed-off-by: Ola Liljedahl Reviewed-by: Brian Brooks Reviewed-by: Honnappa Nagarahalli --- platform/linux-generic/include/odp_llsc.h | 332 ++ 1 file changed, 332 insertions(+) create mode

[lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

Signed-off-by: Ola Liljedahl Reviewed-by: Brian Brooks Reviewed-by: Honnappa Nagarahalli --- platform/linux-generic/include/odp_bitset.h | 155 1 file changed, 155 insertions(+) create mode

[lng-odp] [API-NEXT PATCH v2 11/16] Add scalable scheduler build config

Signed-off-by: Brian Brooks --- .../linux-generic/include/odp_config_internal.h| 80 ++ 1 file changed, 80 insertions(+) diff --git a/platform/linux-generic/include/odp_config_internal.h b/platform/linux-generic/include/odp_config_internal.h index

[lng-odp] [API-NEXT PATCH v2 09/16] Avoid shm namespace collisions and allow shm block per queue

Signed-off-by: Kevin Wang Reviewed-by: Ola Liljedahl Reviewed-by: Brian Brooks Reviewed-by: Honnappa Nagarahalli --- .../linux-generic/include/odp_config_internal.h| 4 +--

[lng-odp] [API-NEXT PATCH v2 10/16] Add _odp_packet_to_buf_hdr_ptr()

Signed-off-by: Kevin Wang Reviewed-by: Brian Brooks --- platform/linux-generic/include/odp_packet_internal.h | 3 +++ platform/linux-generic/odp_packet.c | 5 + 2 files changed, 8 insertions(+) diff --git

[lng-odp] [API-NEXT PATCH v2 08/16] test: scheduler: Fixup calling release operations

Remove erroneous assertion that is handled in later code Signed-off-by: Kevin Wang Reviewed-by: Ola Liljedahl --- test/common_plat/validation/api/scheduler/scheduler.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git

[lng-odp] [API-NEXT PATCH v2 07/16] test: odp_scheduling: Handle dequeueing from a concurrent queue

Signed-off-by: Ola Liljedahl Reviewed-by: Brian Brooks Reviewed-by: Honnappa Nagarahalli Reviewed-by: Kevin Wang --- test/common_plat/performance/odp_scheduling.c | 12 ++-- 1 file changed,

[lng-odp] [API-NEXT PATCH v2 06/16] Fix a locking bug

Signed-off-by: Kevin Wang Reviewed-by: Ola Liljedahl Reviewed-by: Brian Brooks --- platform/linux-generic/pktio/loop.c | 1 + 1 file changed, 1 insertion(+) diff --git a/platform/linux-generic/pktio/loop.c

[lng-odp] [API-NEXT PATCH v2 00/16] A scalable software scheduler

This work derives from Ola Liljedahl's prototype [1] which introduced a scalable scheduler design based on primarily lock-free algorithms and data structures designed to decrease contention. A thread searches through a data structure containing only queues that are both non-empty and allowed to be

[lng-odp] [API-NEXT PATCH v2 02/16] linux-generic: ring.c: use required memory orderings

From: Ola Liljedahl Signed-off-by: Ola Liljedahl Reviewed-by: Brian Brooks --- platform/linux-generic/pktio/ring.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git

[lng-odp] [API-NEXT PATCH v2 04/16] helper: cuckootable: Specify queue ring_size

From: Ola Liljedahl The cuckoo code may enqueue a million events onto a queue. When queues are implemented as bounded buffers, a default queue size can be used during queue create, otherwise this information needs to be passed down from the application. The reverse

[lng-odp] [API-NEXT PATCH v2 05/16] Add ODP_CONFIG_QUEUE_SIZE

Signed-off-by: Ola Liljedahl Reviewed-by: Honnappa Nagarahalli Reviewed-by: Brian Brooks --- platform/linux-generic/include/odp_config_internal.h | 7 +++ 1 file changed, 7 insertions(+) diff --git

[lng-odp] [API-NEXT PATCH v2 03/16] api: queue: Add ring_size

Signed-off-by: Brian Brooks Signed-off-by: Honnappa Nagarahalli --- include/odp/api/spec/queue.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/odp/api/spec/queue.h b/include/odp/api/spec/queue.h index 7972feac..1cec4773

[lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

Signed-off-by: Brian Brooks --- configure.ac | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/configure.ac b/configure.ac index 419c136f..da091ab1 100644 --- a/configure.ac +++ b/configure.ac @@ -304,20 +304,22 @@

Re: [lng-odp] [API-NEXT PATCH v2 1/4] linux-gen: packet: recognize ICMPv6 packets

Merged. Please ignore first comment due to initially I tried to apply it to master. Not to api-next. Maxim. On 04.04.2017 09:28, Matias Elo wrote: > Signed-off-by: Matias Elo > Reviewed-and-tested-by: Bill Fischofer > --- > V2: > - Rebase > >

[lng-odp] [Linaro/odp] cd0d6f: linux-gen: packet: recognize ICMPv6 packets

Branch: refs/heads/api-next Home: https://github.com/Linaro/odp Commit: cd0d6fc0adfbc7442c36053f61dc75b1ea15ef78 https://github.com/Linaro/odp/commit/cd0d6fc0adfbc7442c36053f61dc75b1ea15ef78 Author: Matias Elo Date: 2017-04-04 (Tue, 04 Apr 2017)

Re: [lng-odp] [API-NEXT PATCH v2 2/4] linux-gen: packet: remove lazy parsing

breaks build: https://travis-ci.org/muvarov/odp/jobs/218496566 On 4 April 2017 at 09:28, Matias Elo wrote: > Replace old lazy parsing code with a new packet parsing implementation > which follows the latest API (parsing level is selected using > odp_pktio_config()). > >

Re: [lng-odp] odp_ipsec_result behaviour

Hi, > - odp_ipsec_result() would change buffer type from IPSEC_RESULT to > PACKET, extract ipsec_op_result, etc. After this operation original > event is unsuitable for further operations. An added complication with ODP IPsec is fragmentation offload that can cause multiple result packets for

Re: [lng-odp] [PATCH] linux-generic: decouple odp_errno define from odp-linux

ping On 30 March 2017 at 15:31, Balakrishna Garapati < balakrishna.garap...@linaro.org> wrote: > makes it easy to define odp_errno to dpdk rteerrno and fixes > linking issues. > > Signed-off-by: Balakrishna Garapati > --- > platform/linux-generic/Makefile.am

Re: [lng-odp] odp_ipsec_result behaviour

On 04.04.2017 10:15, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of >> Dmitry Eremin-Solenikov >> Sent: Monday, April 03, 2017 10:48 PM >> To: lng-odp-forward >>

  1   2   >