[lng-odp] [Bug 2779] CID 173342: Error handling issues (CHECKED_RETURN)

2017-04-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2779 --- Comment #4 from Bill Fischofer --- Patch http://patches.opendataplane.org/patch/8459/ posted to resolve this issue, following Maxim's comments about the first patch. -- You are receiving this mail because: You are on

Re: [lng-odp] [API-NEXT PATCH v2 07/16] test: odp_scheduling: Handle dequeueing from a concurrent queue

2017-04-05 Thread Maxim Uvarov
On 04/05/17 17:30, Ola Liljedahl wrote: > On 5 April 2017 at 14:50, Maxim Uvarov wrote: >> On 04/05/17 06:57, Honnappa Nagarahalli wrote: >>> This can go into master/api-next as an independent patch. Agree? >> >> agree. If we accept implementation where events can be

[lng-odp] [PATCH] example: l3fwd: check rc from odph_eth_addr_parse()

2017-04-05 Thread Bill Fischofer
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2779 by checking the return code from odph_eth_addr_parse() and failing the call if dst_mac is unparseable. Signed-off-by: Bill Fischofer --- example/l3fwd/odp_l3fwd_db.c | 3 ++- 1 file changed, 2 insertions(+), 1

[lng-odp] [Bug 2852] ODP_STATIC_ASSERT() fails when used by C++

2017-04-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2852 --- Comment #4 from Bill Fischofer --- Patch v5 submitted via pull request from bill-fischofer-linaro/odp. Need status update but it seems this has not yet been merged. -- You are receiving this mail because: You are on

[lng-odp] [Bug 2911] unchecked return value may result in out of bounds access

2017-04-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2911 Bill Fischofer changed: What|Removed |Added Severity|critical|minor -- You are

[lng-odp] [Bug 2911] unchecked return value may result in out of bounds access

2017-04-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2911 --- Comment #2 from Bill Fischofer --- Actually, while the odp_packet_alloc_multi() may return -1 on errors, this code calls the internal packet_alloc_multi() which returns the number of packets allocated in the range

Re: [lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

2017-04-05 Thread Maxim Uvarov
On 04/05/17 21:36, Ola Liljedahl wrote: > On 5 April 2017 at 17:33, Dmitry Eremin-Solenikov > wrote: >> On 05.04.2017 17:40, Ola Liljedahl wrote: >>> On 5 April 2017 at 14:20, Maxim Uvarov wrote: On 04/05/17 01:46, Ola Liljedahl

Re: [lng-odp] [RFC/API-NEXT 1/1] api: classification: packet hashing per class of service

2017-04-05 Thread Brian Brooks
On Fri, Dec 9, 2016 at 5:54 AM, Balasubramanian Manoharan wrote: > Adds support to spread packet from a single CoS to multiple queues by > configuring hashing at CoS level. > > Signed-off-by: Balasubramanian Manoharan > --- >

Re: [lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

2017-04-05 Thread Ola Liljedahl
On 5 April 2017 at 17:33, Dmitry Eremin-Solenikov wrote: > On 05.04.2017 17:40, Ola Liljedahl wrote: >> On 5 April 2017 at 14:20, Maxim Uvarov wrote: >>> On 04/05/17 01:46, Ola Liljedahl wrote: On 4 April 2017 at 21:25, Maxim

Re: [lng-odp] CRC/Adler requirement in comp interface

2017-04-05 Thread Bill Fischofer
Adding Barry to the to list since I'm not sure if he follows the ODP mailing list and this was something he raised. On Wed, Apr 5, 2017 at 7:31 AM, Verma, Shally wrote: > from yesterday meeting minutes , I see a note on this feedback on compression: > Consider adding

Re: [lng-odp] [API-NEXT PATCH v2 00/16] A scalable software scheduler

2017-04-05 Thread Brian Brooks
On 04/05 21:27:37, Jerin Jacob wrote: > -Original Message- > > Date: Tue, 4 Apr 2017 13:47:52 -0500 > > From: Brian Brooks > > To: lng-odp@lists.linaro.org > > Subject: [lng-odp] [API-NEXT PATCH v2 00/16] A scalable software scheduler > > X-Mailer: git-send-email

Re: [lng-odp] [PATCH] linux-generic: decouple odp_errno define from odp-linux

2017-04-05 Thread Bill Fischofer
This patch has an extra blank line that checkpatch flags: le-odp_errno-define-from-odp-lin.patch CHECK: Please don't use multiple blank lines #48: FILE: platform/linux-generic/include/odp_errno_define.h:13: + + But other than that, this is good. On Thu, Mar 30, 2017 at 8:31 AM, Balakrishna

Re: [lng-odp] [API-NEXT PATCH v2 00/16] A scalable software scheduler

2017-04-05 Thread Jerin Jacob
-Original Message- > Date: Tue, 4 Apr 2017 13:47:52 -0500 > From: Brian Brooks > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXT PATCH v2 00/16] A scalable software scheduler > X-Mailer: git-send-email 2.12.2 > > This work derives from Ola Liljedahl's

Re: [lng-odp] [API-NEXT PATCH v2 16/16] Add scalable scheduler

2017-04-05 Thread Brian Brooks
On 04/04 22:27:54, Maxim Uvarov wrote: > On 04/04/17 21:48, Brian Brooks wrote: > > Add queue getters and setters to provide an abstraction over more than one > > internal queue data structure. > > > > Use buffer handles instead of pointer to internal object in pktio and tm > > code. > > > >

Re: [lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

2017-04-05 Thread Dmitry Eremin-Solenikov
On 05.04.2017 17:40, Ola Liljedahl wrote: > On 5 April 2017 at 14:20, Maxim Uvarov wrote: >> On 04/05/17 01:46, Ola Liljedahl wrote: >>> On 4 April 2017 at 21:25, Maxim Uvarov wrote: it's better to have 2 separate files for that. One for

Re: [lng-odp] [API-NEXT PATCH v2 00/16] A scalable software scheduler

2017-04-05 Thread Ola Liljedahl
_fdserver.c: #define FDSERVER_MAX_ENTRIES 256 /* store the file descriptor in table: */ if (fd_table_nb_entries < FDSERVER_MAX_ENTRIES) { } else { ODP_ERR("FD table full\n"); Weird that you get this but not we. It is

Re: [lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

2017-04-05 Thread Ola Liljedahl
On 5 April 2017 at 01:21, Dmitry Eremin-Solenikov wrote: > On 05.04.2017 00:25, Brian Brooks wrote: >> On 04/04 23:23:33, Dmitry Eremin-Solenikov wrote: >>> On 04.04.2017 22:25, Maxim Uvarov wrote: it's better to have 2 separate files for that. One for

Re: [lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

2017-04-05 Thread Ola Liljedahl
On 5 April 2017 at 14:20, Maxim Uvarov wrote: > On 04/05/17 01:46, Ola Liljedahl wrote: >> On 4 April 2017 at 21:25, Maxim Uvarov wrote: >>> it's better to have 2 separate files for that. One for ODP_CONFIG_LLDSCD >> "better"? In what way? Please

Re: [lng-odp] [API-NEXT PATCH v2 07/16] test: odp_scheduling: Handle dequeueing from a concurrent queue

2017-04-05 Thread Ola Liljedahl
On 5 April 2017 at 14:50, Maxim Uvarov wrote: > On 04/05/17 06:57, Honnappa Nagarahalli wrote: >> This can go into master/api-next as an independent patch. Agree? > > agree. If we accept implementation where events can be 'delayed' Probably all platforms with HW queues.

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

2017-04-05 Thread Ola Liljedahl
On 05/04/2017, 15:39, "Dmitry Eremin-Solenikov" wrote: >On 05.04.2017 16:33, Ola Liljedahl wrote: >> >> >> >> >> On 05/04/2017, 15:22, "Dmitry Eremin-Solenikov" >> wrote: >> >>> On 05.04.2017 15:16, Ola Liljedahl wrote:

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

2017-04-05 Thread Dmitry Eremin-Solenikov
On 05.04.2017 16:33, Ola Liljedahl wrote: > > > > > On 05/04/2017, 15:22, "Dmitry Eremin-Solenikov" > wrote: > >> On 05.04.2017 15:16, Ola Liljedahl wrote: >>> On 05/04/2017, 12:36, "Dmitry Eremin-Solenikov" >>> wrote:

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

2017-04-05 Thread Ola Liljedahl
On 05/04/2017, 15:22, "Dmitry Eremin-Solenikov" wrote: >On 05.04.2017 15:16, Ola Liljedahl wrote: >> On 05/04/2017, 12:36, "Dmitry Eremin-Solenikov" >> wrote: >> >>> On 05.04.2017 02:31, Ola Liljedahl wrote: On

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

2017-04-05 Thread Dmitry Eremin-Solenikov
On 05.04.2017 15:16, Ola Liljedahl wrote: > On 05/04/2017, 12:36, "Dmitry Eremin-Solenikov" > wrote: > >> On 05.04.2017 02:31, Ola Liljedahl wrote: >>> On 05/04/2017, 01:25, "Dmitry Eremin-Solenikov" >>> wrote: On

Re: [lng-odp] [API-NEXT PATCH v2 07/16] test: odp_scheduling: Handle dequeueing from a concurrent queue

2017-04-05 Thread Maxim Uvarov
On 04/05/17 06:57, Honnappa Nagarahalli wrote: > This can go into master/api-next as an independent patch. Agree? agree. If we accept implementation where events can be 'delayed' than it looks like we missed some api to sync queues. But I do not see why we need this patch. On the same cpu test

[lng-odp] CRC/Adler requirement in comp interface

2017-04-05 Thread Verma, Shally
from yesterday meeting minutes , I see a note on this feedback on compression: Consider adding additional "hashes" (e.g., CRC, Adler) As we mentioned that comp interface does not provide CRC. Also adler comes as output of zlib format and CRC can be available through helper functions. So is

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

2017-04-05 Thread Maxim Uvarov
On 04/05/17 15:16, Ola Liljedahl wrote: > On 05/04/2017, 12:36, "Dmitry Eremin-Solenikov" > wrote: > >> On 05.04.2017 02:31, Ola Liljedahl wrote: >>> On 05/04/2017, 01:25, "Dmitry Eremin-Solenikov" >>> wrote: On

Re: [lng-odp] [API-NEXT PATCH v2 15/16] Add llqueue, an unbounded concurrent queue

2017-04-05 Thread Maxim Uvarov
On 04/05/17 01:46, Ola Liljedahl wrote: > On 4 April 2017 at 21:25, Maxim Uvarov wrote: >> it's better to have 2 separate files for that. One for ODP_CONFIG_LLDSCD > "better"? In what way? > >> defined and one for not. Also ODP_ prefix should not be used for >> internal

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

2017-04-05 Thread Ola Liljedahl
On 05/04/2017, 12:36, "Dmitry Eremin-Solenikov" wrote: >On 05.04.2017 02:31, Ola Liljedahl wrote: >> On 05/04/2017, 01:25, "Dmitry Eremin-Solenikov" >> wrote: >>> On 04.04.2017 23:52, Ola Liljedahl wrote: Sending from my

Re: [lng-odp] [API-NEXT PATCH v2 00/16] A scalable software scheduler

2017-04-05 Thread Bill Fischofer
Environment is Ubuntu 16.10. On Wed, Apr 5, 2017 at 7:03 AM, Bill Fischofer wrote: > This is running on my desktop x86: > > ./bootstrap > ./configure --enable-schedule-scalable --enable-cunit-support > make > cd test/common_plat/validation/api/scheduler >

Re: [lng-odp] [API-NEXT PATCH v2 00/16] A scalable software scheduler

2017-04-05 Thread Bill Fischofer
This is running on my desktop x86: ./bootstrap ./configure --enable-schedule-scalable --enable-cunit-support make cd test/common_plat/validation/api/scheduler ./scheduler_main On Tue, Apr 4, 2017 at 10:24 PM, Honnappa Nagarahalli wrote: > On 4 April 2017 at

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

2017-04-05 Thread Dmitry Eremin-Solenikov
On 05.04.2017 02:31, Ola Liljedahl wrote: > On 05/04/2017, 01:25, "Dmitry Eremin-Solenikov" > wrote: >> On 04.04.2017 23:52, Ola Liljedahl wrote: >>> Sending from my ARM email account, I hope Outlook does not mess up the >>> format. >>> >>> >>> >>> On

Re: [lng-odp] v1.14.0.0 was tagged!

2017-04-05 Thread Savolainen, Petri (Nokia - FI/Espoo)
Hi, A month has passed. I'd suggest that we tag 1.15 and include parser configuration API changes from api-next. Other things in api-next seems to lack implementation still. Crypto sha1/sha512 is the next candidate to get into 1.15. -Petri > -Original Message- > From: lng-odp

[lng-odp] [RFC][PATCH] added asymmetric crypto algorithm support.

2017-04-05 Thread Umesh Kartha
Asymmetric crypto algorithms are essential in protocols such as SSL/TLS. As the current ODP crypto library lacks support for asymmetric crypto algorithms, this RFC is an attempt to address it and add support for the same. The asymmetric algorithms featured in this version are 1 RSA - RSA Sign

Re: [lng-odp] [API-NEXT PATCH v2 2/4] linux-gen: packet: remove lazy parsing

2017-04-05 Thread Elo, Matias (Nokia - FI/Espoo)
> On 4 Apr 2017, at 18:30, Maxim Uvarov wrote: > > breaks build: > https://travis-ci.org/muvarov/odp/jobs/218496566 > > Hi Maxim, I'm unable to repeat this problem. Were the patches perhaps merged to the wrong branch? -Matias