Re: [lng-odp] [PATCH 3/4] linux-generic: odp_rwlock[ch]: use odp_atomic_internal.h

On 2014-11-25 23:37, Ola Liljedahl wrote: > Signed-off-by: Ola Liljedahl > --- > Use definitions from odp_atomic_internal.h. > > platform/linux-generic/include/api/odp_rwlock.h | 4 ++- > platform/linux-generic/odp_rwlock.c | 35 > - > 2 files changed, 20 in

Re: [lng-odp] [PATCH 2/4] linux-generic: odp_barrier.h: use odp_atomic_internal.h

Nit: I think you menat odp_barrier.c and not .h in the message right On 2014-11-25 23:37, Ola Liljedahl wrote: > Signed-off-by: Ola Liljedahl > --- > Use definitions from odp_atomic_internal.h. > > platform/linux-generic/odp_barrier.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-)

Re: [lng-odp] [PATCH] .gitignore: add CUnit-Memory-Dump.xml

On 2014-11-25 14:54, Taras Kondratiuk wrote: > On 11/25/2014 02:43 PM, Mike Holmes wrote: > > > > > >On 25 November 2014 at 07:15, Maxim Uvarov >> wrote: > > > >On 11/25/2014 01:18 AM, Mike Holmes wrote: > > > >Does no one else see this ? > > > > > >

Re: [lng-odp] [PATCH v1 3/5] Linux-generic: Pktio changes for Classification

On 24 November 2014 at 22:45, Bill Fischofer wrote: > Again, this points out that we need to start merging patches. Otherwise > we're going to be spending all our time reworking and rebasing them rather > than moving onto the next patch. There's just no clean way to avoid this > with API changes

Re: [lng-odp] [PATCH] exception_handling.dox: remove redundant text

On 2014-11-03 17:00, Mike Holmes wrote: > Signed-off-by: Mike Holmes Applied! Cheers, Anders > --- > exception_handling.dox | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/exception_handling.dox b/exception_handling.dox > index fe693bc..03a9bbd 100644 > --- a/exceptio

[lng-odp] [PATCH 2/4] configure: cleanup OpenSSL configuration

Always check OpenSSL dependency Signed-off-by: Anders Roxell --- configure.ac | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/configure.ac b/configure.ac index 3752f3d..acd0060 100644 --- a/configure.ac +++ b/configure.ac @@ -126,21

[lng-odp] [PATCH 1/4] configure: show libs and rename output

Signed-off-by: Anders Roxell --- configure.ac | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index c30d9cb..3752f3d 100644 --- a/configure.ac +++ b/configure.ac @@ -198,9 +198,10 @@ AC_MSG_RESULT([ libdir: ${libdir

[lng-odp] [PATCH 0/4] configure cleanups

This patchset cleans up the configure script and will check OpenSSL and CUnit, whether it is built in or via a path. Cheers, Anders Anders Roxell (4): configure: show libs and rename output configure: cleanup OpenSSL configuration configure: always check for cunit (lib and headers

[lng-odp] [PATCH 4/4] configure: display cunit flag

Signed-off-by: Anders Roxell --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index 9df4754..5110cd9 100644 --- a/configure.ac +++ b/configure.ac @@ -151,6 +151,8 @@ then [AC_MSG_ERROR([CUnit libraries required])]) AC_CHECK_HEADERS

[lng-odp] [PATCH 3/4] configure: always check for cunit (lib and headers)

Signed-off-by: Anders Roxell --- configure.ac| 29 - test/validation/Makefile.am | 3 +-- 2 files changed, 21 insertions(+), 11 deletions(-) diff --git a/configure.ac b/configure.ac index acd0060..9df4754 100644 --- a/configure.ac +++ b/configure.ac

Re: [lng-odp] splitting patches which can not be split

Hi, I still think its better to say no way to all big patches. =) Othervice if we do like this, we create a backdoor for people that doesn't want's to split up their patches or lack the knowledge how to do it. Cheers, Anders On 23 November 2014 at 23:58, Maxim Uvarov wrote: > On 11/23/2014 05

Re: [lng-odp] [PATCHv2 1/3] test/example changes for v1.0 buffer pool APIs

On 22 November 2014 at 14:51, Anders Roxell wrote: > > On 22 Nov 2014 14:31, "Bill Fischofer" wrote: >> >> How do I do that? Following the recommendations in the DEPENDENCIES file: >> >> sudo apt-get install libcunit1-dev >> Reading package lists.

Re: [lng-odp] [PATCHv2 1/3] test/example changes for v1.0 buffer pool APIs

vironment: >>> >>> ./bootstrap >>> ./configure --with-platform=linux-generic --enable-cunit >>> >>> Thanks. >>> >>> Bill >>> >>> On Fri, Nov 21, 2014 at 3:29 PM, Mike Holmes wrote: >>>> >>>> If you build and

Re: [lng-odp] [PATCHv2] cunit: add odp_init sunnyday unit test

On 21 November 2014 17:02, Mike Holmes wrote: > > > On 21 November 2014 06:46, Maxim Uvarov wrote: >> >> On 11/21/2014 02:40 PM, Taras Kondratiuk wrote: >>> >>> On 11/20/2014 08:18 PM, Madhusudan Venugopal wrote: int main(void) { -CU_pSuite ptr_suite = NULL; -

Re: [lng-odp] [PATCHv2 1/3] test/example changes for v1.0 buffer pool APIs

On 21 November 2014 14:15, Taras Kondratiuk wrote: > On 11/21/2014 02:48 PM, Bill Fischofer wrote: >> >> How do I do that? I'm just doing >> >> ./bootstrap >> ./configure >> make >> >> Is there another step missing? > > > ./configure --with-platform=linux-generic --enable-cunit and you have to i

Re: [lng-odp] [PATCHv5 3/3] promisc mode manipulation functions

fd; > + > + strncpy(ifr.ifr_name, entry->s.name, IFNAMSIZ); > + > + ret = ioctl(sockfd, SIOCGIFFLAGS, &ifr); > + if (ret < 0) { > + ODP_DBG("ioctl SIOCGIFFLAGS error\n"); > + return -1; > + } > + > + if (ifr.ifr_flags & IFF_PROMISC) > + return 1; > + else > + return 0; > +} > -- > 1.8.5.1.163.gd7aced9 > > > ___ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp -- Anders Roxell anders.rox...@linaro.org M: +46 709 71 42 85 | IRC: roxell ___ lng-odp mailing list lng-odp@lists.linaro.org http://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [PATCHv5 2/3] enhance odp_pktio to set/get mtu

On 2014-11-20 11:44, Maxim Uvarov wrote: > Add new option -t or --mtu to set up new mtu value. > > Signed-off-by: Maxim Uvarov > Reviewed-by Mike Holmes Same here fix Mikes Reviewed-by... then I'm fine with this patch. Reviewed-by: Anders Roxell > --- > example/

Re: [lng-odp] [PATCHv5 1/3] pktio: add MTU manipulation functions

d be "Reviewed-by: Mike..." Reviewed-by: Anders Roxell > --- > platform/linux-generic/include/api/odp_packet_io.h | 23 > .../linux-generic/include/odp_packet_io_internal.h | 4 ++ > platform/linux-generic/odp_packet_io.c | 66 > +

Re: [lng-odp] [PATCHv2 1/3] test/example changes for v1.0 buffer pool APIs

On 21 Nov 2014 01:23, "Bill Fischofer" wrote: > > The three parts are for review convenience. They are a single patch. Then please add RFC to the subject! > > > On Thursday, November 20, 2014, Anders Roxell wrote: >> >> On 21 November 2014 01:13, B

Re: [lng-odp] [PATCHv2 1/3] test/example changes for v1.0 buffer pool APIs

On 21 November 2014 01:13, Bill Fischofer wrote: > Not sure I understand. They build just fine for me. What problem are you > seeing? Can you apply patch 1/3 and then do "make" what happens then? > > Bill > > > On Thursday, November 20, 2014, Anders Roxell >

Re: [lng-odp] [PATCHv2 1/3] test/example changes for v1.0 buffer pool APIs

Again Bill, I complained about this in your last patch set [1] as well! You shall be able to build every patch. [1] http://lists.linaro.org/pipermail/lng-odp/2014-November/004999.html On 21 November 2014 00:27, Bill Fischofer wrote: > Signed-off-by: Bill Fischofer > --- > example/generator/od

Re: [lng-odp] [PATCH v1] crypto : use override_iv_ptr when session IV is NULL

On 2014-11-19 12:27, alexandru.badici...@linaro.org wrote: > From: Alexandru Badicioiu > > NULL session IV prevents using per operation IV (override_iv_ptr). > This fixes *_OVR_IV cunit tests segfaults. > > Signed-off-by: Alexandru Badicioiu Reviewed-and-Tested

Re: [lng-odp] [PATCH v2] test: rename cunit dir to validation

On 2014-11-19 16:44, Mike Holmes wrote: > Signed-off-by: Mike Holmes Reviewed-and-Tested-by: Anders Roxell > --- > > Convert spaces to tabs in configure.ac > > .gitignore | 4 ++-- > configure.ac | 2 +

Re: [lng-odp] [PATCH v3] add implement for odp_shm_free

ke it together is better , because the change of the reval for > odp_shm_free > is need to according to the implement of the func odp_shm_free. > Make one patch can make sure this change will take effect together. ok > > > yan.songm...@linaro.org >

Re: [lng-odp] [PATCH v3] add implement for odp_shm_free

On 2014-11-19 16:23, Mike Holmes wrote: > On 19 November 2014 16:13, Maxim Uvarov wrote: > > > On 11/19/2014 11:21 PM, Mike Holmes wrote: > > > >> > >> > >> On 19 November 2014 10:36, Yan Songming >> yan.songm...@linaro.org>> wrote: > >> > >> New API implementing odp_shm_free to match the od

Re: [lng-odp] [PATCH v3] add implement for odp_shm_free

Change subject to something like this: platform: odp_shared_memory.c: implement odp_shm_free Nit: This should really go as two patches with the commit messages below. 1. api: doxygen: fix retval for odp_shm_free 2. platform: odp_shared_memory.c: implement func odp_shm_free On 2014-11-19 23:36, Ya

Re: [lng-odp] [PATCH ARCH] testing.dox: Fix section overview tag

On 2014-11-19 12:06, Mike Holmes wrote: > The overview section had a badly formatted doxygen section tag. > > Signed-off-by: Mike Holmes Applied, Thanks, Anders > --- > testing.dox | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/testing.dox b/testing.dox > index 8b21

Re: [lng-odp] [PATCHv4 1/3] pktio: add MTU manipulation functions

On 19 November 2014 16:56, Maxim Uvarov wrote: > Anders, check for -1 is not correct. It does not matter what is in man page. > Don't read documentation :) I'm sorry for not doing my homework! =) > Look the kernel code: > > ./net/core/dev_ioctl.c: > case SIOCSIFMTU:/* Set the MTU of a de

[lng-odp] [PATCH 2/2] test: api_test: move include path

Signed-off-by: Anders Roxell --- test/Makefile.inc | 1 + test/api_test/Makefile.am | 8 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/test/Makefile.inc b/test/Makefile.inc index b096a9c..e28919c 100644 --- a/test/Makefile.inc +++ b/test/Makefile.inc @@ -4,6

[lng-odp] [PATCH 0/2] Makefile: test cleanup and fix example build issue

Syncronizing the Makefile.inc to work the same way for both the test and example directory. And fixing a build bug when configuring a new builddir. Cheers, Anders Anders Roxell (2): example: Makefile.inc: fix include path test: api_test: move include path example/Makefile.inc | 1

[lng-odp] [PATCH 1/2] example: Makefile.inc: fix include path

Break when configuring building in a separate build directory Signed-off-by: Anders Roxell --- example/Makefile.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/example/Makefile.inc b/example/Makefile.inc index b096a9c..9a3167b 100644 --- a/example/Makefile.inc +++ b/example/Makefile.inc

Re: [lng-odp] [PATCH v4 ARCH] Add testing.dox

ay require network interfaces and external equipment. > + > +@section benchmarking Benchmarks > + > +Benchmarks are currently also stored with the functional tests, this may be > re assessed depending on the test volume. > +@verbatim > +test > +. > +|-- functional > + |-- > + |-- / > +@endverbatim > + - These tests are generally more elaborate with a goal of quantifying the > capacity of a complex functionality. > + - There is no framework for these benchmarks and they generally take > command line arguments to modify their behaviour. > + - They do not provide a pass fail indication. > + > +@section test_versioning Test versioning relationship to ODP and versioning > + > +For ODP to declare for example the v1.0 tag in its git repository it must > have passed the corresponding test suit. > +When ODP API v3.0 is released it will be validated against the test suite > version tagged ODP v3.0 > +It is possible that a version of the ODP API is released and that the test > suite used has a flaw, in this case the test suite will be re released as > v3.0-1 > +*/ > -- > 2.1.0 > > > ___ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp -- Anders Roxell anders.rox...@linaro.org M: +46 709 71 42 85 | IRC: roxell ___ lng-odp mailing list lng-odp@lists.linaro.org http://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [PATCHv4 1/3] pktio: add MTU manipulation functions

On 2014-11-19 14:39, Maxim Uvarov wrote: > On 11/19/2014 12:32 PM, Anders Roxell wrote: > >On 2014-11-15 12:25, Maxim Uvarov wrote: > >>On 11/14/2014 10:50 PM, Mike Holmes wrote: > >>>>+ ret = ioctl(sockfd, SIOCSIFMTU, (caddr_t)&ifr); > >>>&

Re: [lng-odp] [PATCH 1/2] test/example changes for v1.0 buffer pool APIs

7704181..1566f4f 100644 > --- a/test/api_test/odp_timer_ping.c > +++ b/test/api_test/odp_timer_ping.c > @@ -319,9 +319,8 @@ int main(int argc ODP_UNUSED, char *argv[] ODP_UNUSED) > ping_arg_t pingarg; > odp_queue_t queue; > odp_buffer_pool_t pool; > - void *pool

Re: [lng-odp] [PATCHv4 3/3] promisc mode manipulation functions

On 2014-11-14 12:30, Maxim Uvarov wrote: > Define API and implement promisc functions: > odp_pktio_set_promisc() > odp_pktio_promisc() > > Signed-off-by: Maxim Uvarov > --- > platform/linux-generic/include/api/odp_packet_io.h | 25 +++ > platform/linux-generic/odp_packet_io.c |

Re: [lng-odp] [PATCHv4 1/3] pktio: add MTU manipulation functions

On 2014-11-15 12:25, Maxim Uvarov wrote: > On 11/14/2014 10:50 PM, Mike Holmes wrote: > >>+ ret = ioctl(sockfd, SIOCSIFMTU, (caddr_t)&ifr); > >>>+ if (ret) { > > From the ioctl man page > >Usually, on success zero is returned. A few ioctl() requests use the > >return value as a

Re: [lng-odp] [PATCHv3] Factor ODP types into a common include file

On 17 November 2014 12:17, Taras Kondratiuk wrote: > On 11/17/2014 12:00 PM, Maxim Uvarov wrote: >> >> On 11/17/2014 12:01 PM, Taras Kondratiuk wrote: >>> >>> On 11/15/2014 12:01 PM, Maxim Uvarov wrote: Merged! >>> >>> >>> Guys, what about commit message? How one should understand what w

Re: [lng-odp] [PATCH v5] cunit : add tests for crypto APIs

On 2014-11-14 16:13, alexandru.badici...@linaro.org wrote: > From: Alexandru Badicioiu > > This patch adds a suite for sync and async inplace mode of crypto APIs. > Correctness of crypto operation output is verified with known test > vectors. Various options and functionalities like use session I

Re: [lng-odp] [PATCH] gitignore: add the unit test odp_queue

On 2014-11-12 19:30, Mike Holmes wrote: > Signed-off-by: Mike Holmes Reviewed-by: Anders Roxell > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore > index a8038d3..90db906 100644 > --- a/.gitignore > +++ b/

Re: [lng-odp] [PATCHv3] Factor ODP types into a common include file

On 2014-11-14 12:40, Bill Fischofer wrote: > Signed-off-by: Bill Fischofer Reviewed-by: Anders Roxell > --- > platform/linux-generic/Makefile.am | 1 + > platform/linux-generic/include/api/odp_buffer.h| 9 +-- > .../linux-generic/include/api/odp_buffer

Re: [lng-odp] [PATCH v4] cunit : add tests for crypto APIs

On 2014-11-13 16:14, alexandru.badici...@linaro.org wrote: > From: Alexandru Badicioiu > > This patch adds a suite for sync and async inplace mode of crypto APIs. > Correctness of crypto operation output is verified with known test > vectors. Various options and functionalities like use session I

Re: [lng-odp] [PATCH v4] cunit : add tests for crypto APIs

t;> > > Mine is ubuntu Version: 2.1-0.dfsg-9. > > > > So we need to add to ./configure check that 2.1.-3 is required. > > > > Or you can malloc that names. I think it's better to switch to new version > > if code is fixed in cunit. > > > >

Re: [lng-odp] [PATCHv2] Factor ODP types into a common include file

On 2014-11-13 20:18, Bill Fischofer wrote: > Signed-off-by: Bill Fischofer > --- > platform/linux-generic/Makefile.am | 1 + > platform/linux-generic/include/api/odp_buffer.h| 9 +-- > .../linux-generic/include/api/odp_buffer_pool.h| 5 +- > .../linux-generic/include/ap

Re: [lng-odp] [PATCH v4] cunit : add tests for crypto APIs

> + if (compl_new == ODP_BUFFER_INVALID) { > [...] > + } else { > [...] > If we remove the braces the test will not compile, it seems the CUnit > macros are the problem. > I'll shorten the lines over 80 characters. > > Alex > > > On 14 November 2014 10:23, A

Re: [lng-odp] [PATCH v4] cunit : add tests for crypto APIs

On 2014-11-13 16:14, alexandru.badici...@linaro.org wrote: > From: Alexandru Badicioiu > > This patch adds a suite for sync and async inplace mode of crypto APIs. > Correctness of crypto operation output is verified with known test > vectors. Various options and functionalities like use session I

Re: [lng-odp] [PATCH NETMAP 1/4] Update to netmap_v11.1

On 2014-11-11 19:35, Ciprian Barbu wrote: > Signed-off-by: Ciprian Barbu > --- > platform/linux-netmap/README | 23 ++--- > platform/linux-netmap/include/odp_packet_netmap.h | 20 +++ > platform/linux-netmap/odp_packet_netmap.c | 30 >

Re: [lng-odp] [PATCHv2 1/2] pktio: add MTU manipulation functions

On 2014-11-13 02:04, Maxim Uvarov wrote: > Implement pktio mtu functions: > odp_pktio_mtu() to get mtu value; > odp_pktio_set_mtu() to set mtu value. > > Signed-off-by: Maxim Uvarov > --- > platform/linux-generic/include/api/odp_packet_io.h | 23 > .../linux-generic/include/odp_packet_i

Re: [lng-odp] [PATCH] Factor ODP typedefs into a common include file

Maybe write the commit message something like this: types: factor platform definitions into a common file Elaborate more why we want this in the commit message itself On 2014-11-12 11:32, Bill Fischofer wrote: > Signed-off-by: Bill Fischofer > --- > platform/linux-generic/Makefile.am

Re: [lng-odp] [PATCHv3 ODP v1.0 Buffer/Packet APIs 0/3] *** v3 Fix Level ***

On 2014-11-13 11:12, Taras Kondratiuk wrote: > On 11/13/2014 01:21 AM, Bill Fischofer wrote: > > *** Buffer/Packet API Patch v3 *** > > > > v3 corrects some errors in the packaging of v2 and also changes > > odp_buffer_alloc() and odp_packet_alloc() to by default allocate > > buffers/packets of th

Re: [lng-odp] [PATCH 1/2] linux-generic: implement pktio mtu finctions

t; + > + if (pktio_entry->s.pkt_sock_mmap.sockfd) > + sockfd = pktio_entry->s.pkt_sock_mmap.sockfd; > + else > + sockfd = pktio_entry->s.pkt_sock.sockfd; > + > + strncpy(ifr.ifr_name, pktio_entry->s.name, IFNAMSIZ); > +

Re: [lng-odp] [PATCH ODP v1.0 Buffer/Packet APIs 0/9] Official For Review/Merge

On 11 November 2014 17:12, Taras Kondratiuk wrote: > On 11/11/2014 04:50 PM, Anders Roxell wrote: >> >> On 2014-11-11 08:24, Bill Fischofer wrote: >>> >>> So what you're saying is that patches aren't always the practical >>> solution? >>&

Re: [lng-odp] [PATCH v7] cunit: add queue test

an that the name of suit should be the same as file name . >> I just see the change you made at odp_init.c today. >> I will fix it and send to Maxim >> Thanks. >> >> >> >> -------- >> ya

Re: [lng-odp] [PATCH v2] CONTRIBUTING: Improve the guidelines

On 2014-11-10 13:02, Mike Holmes wrote: > Clarify the ODP contribution process and add a common errors section. > > Signed-off-by: Mike Holmes Reviewed-by: Anders Roxell > --- > CONTRIBUTING | 188 > ++- >

Re: [lng-odp] [PATCH ODP v1.0 Buffer/Packet APIs 0/9] Official For Review/Merge

es/hrtr.eps > >> create mode 100644 doc/images/hrtr.png > >> create mode 100644 doc/images/packet.eps > >> create mode 100644 doc/images/packet.png > >> create mode 100644 doc/images/segments.eps > >> create mode 100644 doc/images/segments.png > >> create mode 100644 doc/images/splitafter.eps

Re: [lng-odp] [PATCH v7] cunit: add queue test

On 2014-11-11 21:06, Yan Songming wrote: > Add the cunit test for none syne queue. Test the base queue function > > Signed-off-by: yan.songming Reviewed-and-Tested-by: Anders Roxell Minor nit that maybe Maxim can fixup before applying the patch? See inline > --- > Fix spell

Re: [lng-odp] [PATCH v2 ARCH] Add API guide lines

time, as network speeds increase, more and higher level networking > > functions are expected to migrate directly into hardware and ODP APIs MUST > > be mindful of this evolution in their design. > > + > > +@subsection essential_functions Essential functions vs. Extensio

Re: [lng-odp] [PATCH] cunit: remove postfix _test from odp_init

On 10 November 2014 23:07, Maxim Uvarov wrote: > On 11/11/2014 12:07 AM, Anders Roxell wrote: > >> Synchronise the file name with the test suite name. >> > > why is that needed? the file is located in the test directory so that is more than enough I think. Chee

Re: [lng-odp] [PATCH] example: remove odp_generator

. I assume pktgen will need a loopback >> interface if no real interface is involved - is that an issue ? >> >> >> On 10 November 2014 16:07, Anders Roxell > <mailto:anders.rox...@linaro.org>> wrote: >> >> The generator is deprecated and it will be r

[lng-odp] [PATCH] example: remove odp_generator

The generator is deprecated and it will be replaced with pktgen and it has become a maintenance burden now when the API is changing so rapidly. Signed-off-by: Anders Roxell --- .gitignore| 1 - configure.ac | 1 - doc/doxygen.cfg

[lng-odp] [PATCH] cunit: remove postfix _test from odp_init

Synchronise the file name with the test suite name. Signed-off-by: Anders Roxell --- test/cunit/Makefile.am | 2 +- test/cunit/{odp_init_test.c => odp_init.c} | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) rename test/cunit/{odp_init_test.c => odp_init.

[lng-odp] [PATCH] configure: remove duplicated cunit lib paths

Signed-off-by: Anders Roxell --- configure.ac | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 1c061e9..fcd7279 100644 --- a/configure.ac +++ b/configure.ac @@ -73,11 +73,7 @@ AC_ARG_ENABLE([cunit], AC_ARG_WITH([cunit-path

[lng-odp] [PATCH] gitignore: hide log and tsr files in cunit dir

Signed-off-by: Anders Roxell --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 57b47ea..a8038d3 100644 --- a/.gitignore +++ b/.gitignore @@ -46,3 +46,5 @@ odp_ipsec odp_init doxygen-doc test-driver +test/cunit/*.log +test/cunit/*.trs -- 2.1.0

Re: [lng-odp] [PATCH v5] add queue test

On 2014-11-06 23:08, Yan Songming wrote: > From: "yan.songming" > > Add the cunit test for none syne queue. Test the base queue function > > Signed-off-by: yan.songming > --- > Fix spelling problem and commend problem. Add term_local and term_global. > Move cunit queue test to test_odp_queue_ba

Re: [lng-odp] [PATCH v3] add tests for queue

On 2014-11-04 00:31, Yan Songming wrote: > From: "yan.songming" > Say in subject something like this: cunit/odp_queue: add queue test Run checkpatch and fix the problems I will point out some of them and other review comments. In the C file change 4 space to 1 tab. Be consistent either line va

[lng-odp] [PATCH] gitignore: ignore test-driver

Signed-off-by: Anders Roxell --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index a721904..57b47ea 100644 --- a/.gitignore +++ b/.gitignore @@ -45,3 +45,4 @@ odp_l2fwd odp_ipsec odp_init doxygen-doc +test-driver -- 2.1.0

Re: [lng-odp] [PATCH OVS v2 4/4] netdev, ofpbuf: Adjust OVS implementation to the latest ODP

On 2014-10-29 13:24, Zoltan Kiss wrote: > --- > lib/netdev-odp.c | 32 +--- > 1 file changed, 17 insertions(+), 15 deletions(-) > > diff --git a/lib/netdev-odp.c b/lib/netdev-odp.c > index 74fbac9..59de46d 100644 > --- a/lib/netdev-odp.c > +++ b/lib/netdev-odp.c > @@ -

Re: [lng-odp] [PATCH OVS v2 3/4] Config option to enable ODP debug

On 2014-10-29 13:24, Zoltan Kiss wrote: > Signed-off-by: Zoltan Kiss > --- > acinclude.m4 | 31 ++- > configure.ac | 1 + > 2 files changed, 31 insertions(+), 1 deletion(-) > > diff --git a/acinclude.m4 b/acinclude.m4 > index 1579286..5e9f3ee 100644 > --- a/acinclude

[lng-odp] [PATCH 3/4] odp_debug.h: ensure the macro is always compiled

To ensure there is no stale code that can be broken over time. Signed-off-by: Anders Roxell --- platform/linux-generic/include/api/odp_debug.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/platform/linux-generic/include/api/odp_debug.h b/platform/linux-generic

[lng-odp] [PATCH 4/4] configure.ac: add configure option to enable ODP_DEBUG

Signed-off-by: Anders Roxell --- configure.ac | 11 +++ 1 file changed, 11 insertions(+) diff --git a/configure.ac b/configure.ac index 42a3fed..1c061e9 100644 --- a/configure.ac +++ b/configure.ac @@ -99,6 +99,17 @@ AC_ARG_ENABLE([debug-print], ODP_CFLAGS="$ODP_C

[lng-odp] [PATCH 1/4] odp_debug_internal.h: move to include dir from API dir

Signed-off-by: Anders Roxell --- platform/linux-generic/include/{api => }/odp_debug_internal.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename platform/linux-generic/include/{api => }/odp_debug_internal.h (100%) diff --git a/platform/linux-generic/include/api/odp_debug_inte

[lng-odp] [PATCH 2/4] configure.ac: accurately name compile option

Signed-off-by: Anders Roxell --- configure.ac | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index fd69e85..42a3fed 100644 --- a/configure.ac +++ b/configure.ac @@ -90,13 +90,13 @@ AM_CONDITIONAL([ODP_CUNIT_ENABLED], [test x

[lng-odp] [PATCH 0/4] cleanup debug

Hi, This patch set cleans up debug and lets us turn them on via configure. Cheers, Anders Anders Roxell (4): odp_debug_internal.h: move to include dir from API dir configure.ac: accurately name compile option odp_debug.h: ensure the macro is always compiled configure.ac: add configure

Re: [lng-odp] [PATCH ARCH] Add testing.dox

On 2014-10-24 09:17, Mike Holmes wrote: > Detail how ODP API testing will be performed. > > Signed-off-by: Mike Holmes > --- > > This patch is best reviewed by setting API_DOC_PATH in the environment before > building this document because it makes several links to the API doc > > testing.dox

[lng-odp] [PATCH] test/cunit/Makefile.am: add checks

Make it possible to do make check Signed-off-by: Anders Roxell --- test/cunit/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/cunit/Makefile.am b/test/cunit/Makefile.am index 6bd82f6..927a5a5 100644 --- a/test/cunit/Makefile.am +++ b/test/cunit/Makefile.am @@ -4,6 +4,8

[lng-odp] [PATCH] configure.ac: remove unnecessary additional -lcunit

This flag is already added to the appropriate Makefile.am Signed-off-by: Anders Roxell --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index aa94034..a4e0174 100644 --- a/configure.ac +++ b/configure.ac @@ -75,7 +75,7

Re: [lng-odp] [PATCH ARCH] classification_design.dox: bad reference

On 2014-10-23 17:52, Mike Holmes wrote: > odp-architecture/classification_design.dox:9: > Warning: unable to resolve reference to `odp_classify.h' for \ref command > > Signed-off-by: Mike Holmes > --- > classification_design.dox | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -

Re: [lng-odp] [PATCH 1/2] linux-generic: remove odp_packet_netmap.h

ping On 23 October 2014 13:24, Ciprian Barbu wrote: > On Wed, Oct 22, 2014 at 3:40 PM, Anders Roxell > wrote: > > Signed-off-by: Anders Roxell > > Reviewed-by: Ciprian Barbu > > > --- > > platform/linux-generic/include/odp_packet_netmap.h | 67 > --

Re: [lng-odp] [ODP PATCHv2] odp_classification.h:Doxygen error correction

merged! On 23 October 2014 16:02, Mike Holmes wrote: > ping > > On 21 October 2014 11:07, Mike Holmes wrote: > >> >> >> On 21 October 2014 08:32, Bill Fischofer >> wrote: >> >>> >>> >>> On Tue, Oct 21, 2014 at 3:15 AM, Balasubramanian Manoharan < >>> bala.manoha...@linaro.org> wrote: >>>

Re: [lng-odp] linux-d01's rebase progress

On 2014-10-22 16:58, Weilong Chen wrote: > Hi Anders > > I push linux-d01 to git.linaro.org/people/weilong.chen/linux-d01.git > There's still some bugs to workout. > If you want to have a quit look at it, you can get it. > > Thanks, > Weilong And I guess you have to change the copyright year as

Re: [lng-odp] [PATCH] force latex to generate docs

nstopmode refman.tex; \ > >countdown=`expr $$countdown - 1`; \ > >done; \ > >$(DX_DVIPS) -o ../@PACKAGE@.ps refman.dvi > >-- > >1.8.5.1.163.gd7aced9 > > > > > >___ > >lng-odp mailing list > >lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > >http://lists.linaro.org/mailman/listinfo/lng-odp > > > > > > > > > >-- > >*Mike Holmes* > >Linaro Sr Technical Manager > >LNG - ODP > > > ___ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp -- Anders Roxell anders.rox...@linaro.org M: +46 709 71 42 85 | IRC: roxell ___ lng-odp mailing list lng-odp@lists.linaro.org http://lists.linaro.org/mailman/listinfo/lng-odp

[lng-odp] [PATCH 0/2] linux-generic remove netmap

Hi, This patch set removes netmap from linux-generic. Cheers, Anders Anders Roxell (2): linux-generic: remove odp_packet_netmap.h gitignore: remove odp_packet_netmap .gitignore | 1 - platform/linux-generic/include/odp_packet_netmap.h | 67

[lng-odp] [PATCH 2/2] gitignore: remove odp_packet_netmap

Signed-off-by: Anders Roxell --- .gitignore | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitignore b/.gitignore index 6342e34..a721904 100644 --- a/.gitignore +++ b/.gitignore @@ -34,7 +34,6 @@ obj/ build/ odp_example odp_packet -odp_packet_netmap odp_atomic odp_shm odp_ring

[lng-odp] [PATCH 1/2] linux-generic: remove odp_packet_netmap.h

Signed-off-by: Anders Roxell --- platform/linux-generic/include/odp_packet_netmap.h | 67 -- 1 file changed, 67 deletions(-) delete mode 100644 platform/linux-generic/include/odp_packet_netmap.h diff --git a/platform/linux-generic/include/odp_packet_netmap.h b/platform

Re: [lng-odp] [PATCH] Rename ODPH_PACKED macro

On 2014-10-20 17:19, Jerin Jacob wrote: > - Definition of ODPH_PACKED is in include/api/odp_align.h so changing to > ODP_PACKED > > Signed-off-by: Jerin Jacob Reviewed-and-Tested-by: Anders Roxell > --- > example/ipsec/odp_ipsec_stream.c | 2 +- > help

[lng-odp] [PATCHv2 2/2] doxygen: remove api.dox

Signed-off-by: Anders Roxell Reviewed-by: Mike Holmes --- doc/api/api.dox | 11 --- doc/doxygen.cfg | 2 +- 2 files changed, 1 insertion(+), 12 deletions(-) delete mode 100644 doc/api/api.dox diff --git a/doc/api/api.dox b/doc/api/api.dox deleted file mode 100644 index 7522270

[lng-odp] [PATCHv2 0/2] add grouping

Added the grouping that got ratified on [1]. And the second patch remove unused doxygen file. Cheers, Anders [1] https://docs.google.com/a/linaro.org/document/d/1DUnb8hggeDsH6ML95P9x9hjW9Cf8xFYM_IAsBDDcAVs/edit#heading=h.jnjyndeqwpd5 Anders Roxell (2): doxygen: add grouping doxygen: remove

[lng-odp] [PATCHv2 1/2] doxygen: add grouping

add submodules to gather the API docs. Signed-off-by: Anders Roxell --- platform/linux-generic/include/api/odp_align.h | 8 platform/linux-generic/include/api/odp_atomic.h | 8 platform/linux-generic/include/api/odp_barrier.h| 7 +++ platform/linux

Re: [lng-odp] [ODP ARCH] Classification API Minor Format changes

On 2014-10-21 10:57, Balasubramanian Manoharan wrote: > Signed-off-by: Balasubramanian Manoharan > --- > Removes struct definition from platform specific opaque handles > Corrects variable definition in odp_pktio_pmr_match_set_cos and > odp_pmr_match_set_create function > classification_design.d

Re: [lng-odp] [PATCHv2 NETMAP] linux-netmap: Include README in User's Guide

On 2014-10-17 16:19, Ciprian Barbu wrote: > Signed-off-by: Ciprian Barbu > --- > doc/doxygen.cfg | 2 +- > doc/users-guide/guide.dox | 8 ++-- > 2 files changed, 3 insertions(+), 7 deletions(-) > > diff --git a/doc/doxygen.cfg b/doc/doxygen.cfg > index a77ae1e..fc56317 100644 > ---

Re: [lng-odp] [ODP/PATCH v1] ODP Buffer Segment Support API

On 17 October 2014 15:03, Ola Liljedahl wrote: > But segmentation is already needed in a current and known subclass (i.e. > packets). We are not talking about some other feature which we don't know > if it will be needed. So this is not a case of "just in case". > I agree with Petri, that it sho

Re: [lng-odp] [PATCH] Add crypto and rwlock into odp.h

On 2014-10-15 14:43, Petri Savolainen wrote: > Signed-off-by: Petri Savolainen Reviewed-by: Anders Roxell > --- > example/generator/odp_generator.c| 2 +- > example/ipsec/odp_ipsec.c| 3 +-- > example/ipsec/odp_ipsec_cache.c | 3 +-- &

Re: [lng-odp] [PATCH ARCH] Remove "ODP Design" prefix from page titles

On 2014-10-08 12:25, Mike Holmes wrote: > When the document is generated the prefix becomes repetitious. > > Signed-off-by: Mike Holmes > --- > classification_design.dox | 2 +- > crypto_design.dox | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/classificatio

Re: [lng-odp] [ODP/PATCH v3] ODP Classification API

On 15 October 2014 17:05, Bala Manoharan wrote: > > Hi, > > On 15 October 2014 19:37, Anders Roxell wrote: > >> Question: should we add "#include " into odp.h in >> this patch as well or in a separate patch? > > > I would prefer to add this

[lng-odp] [PATCH] linux-generic/Makefile.am: migrate helper to install

During install migrate the helper dir to the regular install dir Signed-off-by: Anders Roxell --- platform/linux-generic/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/linux-generic/Makefile.am b/platform/linux-generic/Makefile.am index d076d50

Re: [lng-odp] [ODP/PATCH v3] ODP Classification API

id; > + (void)req_data_set; > + ODP_UNIMPLEMENTED(); > + return 0; > +} > +odp_cos_flow_set_t > +odp_cos_port_flow_signature(odp_pktio_t pktio_in, > + odp_cos_flow_set_t req_data_set) > +{ > + (void)pktio_in; > + (void)req_data_

Re: [lng-odp] [PATCH] Makefile misses icmp and ipsec helper files

On 2014-10-15 10:32, Petri Savolainen wrote: > Signed-off-by: Petri Savolainen Reviewed-by: Anders Roxell > --- > platform/linux-generic/Makefile.am | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/platform/linux-generic/Makefile.am > b/platform/linux-generi

Re: [lng-odp] [ODP/PATCH 1/2 v2] ODP Classification API

Couple of nits see comments inline. On 2014-10-07 21:45, Balasubramanian Manoharan wrote: > v2: This patch incorporates mike's review comments This shouldn't be here should be after the "---" > > Signed-off-by: Balasubramanian Manoharan > --- > platform/linux-generic/Makefile.am

Re: [lng-odp] [PATCH ARCH] Factor out requirement terminology

On 8 October 2014 19:31, Mike Holmes wrote: > We only need one copy of the requirements terminology > > Signed-off-by: Mike Holmes > --- > boilerplate.dox | 15 +++ > classification_design.dox | 3 +-- > crypto_design.dox | 3 +-- > 3 files changed, 17 insertions

Re: [lng-odp] Documentation ways of working

On 9 October 2014 16:17, Savolainen, Petri (NSN - FI/Espoo) < petri.savolai...@nsn.com> wrote: > > > > -Original Message- > > From: ext Taras Kondratiuk [mailto:taras.kondrat...@linaro.org] > > Sent: Thursday, October 09, 2014 4:26 PM > > To: Savola

[lng-odp] [DO NOT REVIEW 7/7] packet_io: add Verification

Signed-off-by: Anders Roxell --- packet_io.dox | 9 + 1 file changed, 9 insertions(+) diff --git a/packet_io.dox b/packet_io.dox index 9cc55af..0c96ab0 100644 --- a/packet_io.dox +++ b/packet_io.dox @@ -545,4 +545,13 @@ associated with the defined functions, as well as suggested SW

<    1   2   3   4   5   6   7   8   >