> - checksum computation in the test and the example applications
>
> Signed-off-by: Grigore Ion <ion.grig...@freescale.com>
> ---
> v8:
> - Checksum in BE endianness (Ilya Maximets)
> v7:
> - Make code simpler and more understandable as it was
> sugessted by Ilya M
modify only checksum value in helper/test/odp_chksum.c.
Best regards, Ilya Maximets.
On 30.12.2015 18:15, Maxim Uvarov wrote:
> Ilya is that version good for you? Do you want to add your Review-by?
>
> Maxim.
>
> On 12/17/2015 19:36, Ion Grigore wrote:
>> Ping
>>
>
Thanks.
Reviewed-by: Ilya Maximets <i.maxim...@samsung.com>
On 14.12.2015 18:26, Maxim Uvarov wrote:
> pktio/tap.c:267:21: error: comparison between signed and
> unsigned integer expressions [-Werror=sign-compare]
>} else if (retval != pkt_len) {
>
> Cc: I
On 11.12.2015 19:51, Stuart Haslam wrote:
> On Thu, Dec 10, 2015 at 06:32:00PM +0300, Ilya Maximets wrote:
>> Creates a new pktio type that allows for creating and
>> sending/receiving packets through TAP interface.
>> Detailed description in commit-message of patch
>> &
On 11.12.2015 12:19, Maxim Uvarov wrote:
> On 12/11/2015 10:39, Ilya Maximets wrote:
>> Comments inlined.
>>
>> On 10.12.2015 12:59, ion.grig...@freescale.com wrote:
>>> From: Grigore Ion <ion.grig...@freescale.com>
>>>
>>> This patch fixes the
On 11.12.2015 18:28, Ion Grigore wrote:
>
> Comments inlined
>
> -Original Message-----
> From: Ilya Maximets [mailto:i.maxim...@samsung.com]
> Sent: Friday, December 11, 2015 5:24 PM
> To: Grigore Ion-B17953 <ion.grig...@freescale.com>; Maxim Uvarov
> <
On 11.12.2015 18:47, Ion Grigore wrote:
> A more precise question. Did you check on a LE platform ?
Yes. On my LE i7.
> - /* Fold sum to 16 bits: add carrier to result */
> - while (sum >> 16)
> - sum = (sum & 0x) + (sum >> 16);
> -
> +
On 11.12.2015 17:07, Ion Grigore wrote:
> Comments inlined
>
> -Original Message-
> From: Maxim Uvarov [mailto:maxim.uva...@linaro.org]
> Sent: Friday, December 11, 2015 11:20 AM
> To: Ilya Maximets <i.maxim...@samsung.com>; Grigore Ion-B17953
> <ion.g
at memory.
I have no time to fix that. Tag below may be added to patch that fixes that.
Reported-by: Ilya Maximets <i.maxim...@samsung.com>
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
..@freescale.com>
> ---
> v6:
> - Make code more understandable (Ilya Maximets)
> v5:
> - Checksum in CPU endianness fix added (Ilya Maximets)
> v4:
> - Verify checksum in CPU endianness in the associated test
> (Ilya Maximets)
> v3:
> - fix the UDP checksum
For the purpose of testing of real-world interfaces the packet's
content should be valid or kernel will throw them away.
Signed-off-by: Ilya Maximets <i.maxim...@samsung.com>
---
test/validation/pktio/pktio.c | 46 ---
1 file changed, 39 insertions
ded to use this pktio.
There should be no device named 'iface' in the system.
The total length of the 'iface' is limited by IF_NAMESIZE.
Signed-off-by: Ilya Maximets <i.maxim...@samsung.com>
---
platform/linux-generic/Makefile.am | 2 +
.../linux-generic/include/odp_packet_io_
t a kernel interface's MAC
* Interfaces are UP after pktio_open()
* Fixed getting mtu, getting/setting promisc mode
* Misclenious fixes
Ilya Maximets (4):
validation: pktio: initialize mac addresses for all packets
validation: pktio: ability to wait for external network
lin
'ODP_WAIT_FOR_NETWORK' environment variable may be used
to wait some time right after pktio_open().
Signed-off-by: Ilya Maximets <i.maxim...@samsung.com>
---
'ODP_WAIT_FOR_NETWORK' also may be used to remove sleep(1)
from netmap pktio in the future, beacause IMO waiting
for external n
ig...@freescale.com>
> ---
> v5:
> - Checksum in CPU endianness fix added (Ilya Maximets)
> v4:
> - Verify checksum in CPU endianness in the associated test
> (Ilya Maximets)
> v3:
> - fix the UDP checksum computation in the associated test
> (Maxim Uvarov)
> v2
On 09.12.2015 15:26, Ion Grigore wrote:
> See inline comments.
>
> -Original Message-
> From: Ilya Maximets [mailto:i.maxim...@samsung.com]
> Sent: Wednesday, December 09, 2015 12:04 PM
> To: Grigore Ion-B17953 <ion.grig...@freescale.com>; lng-odp@lists.
On 08.12.2015 14:24, Stuart Haslam wrote:
> On Mon, Dec 07, 2015 at 01:55:31PM +0300, Ilya Maximets wrote:
>> Creates a new pktio type that allows for creating and
>> sending/receiving packets through TAP interface.
>> It is intended for use as a simple conventional communicat
Matias,
I think, better to make separate patch for that.
It will not intersect with mine in case of only 2 deletions.
Would you prepare it?
Best regards, Ilya Maximets.
On 08.12.2015 15:21, Elo, Matias (Nokia - FI/Espoo) wrote:
> Hi Ilya,
>
> I had completely missed your previous p
Matias,
please check out my patch (
https://lists.linaro.org/pipermail/lng-odp/2015-December/018057.html )
from my 'TAP pktio' patch set.
Best regards, Ilya Maximets.
On 08.12.2015 13:36, Elo, Matias (Nokia - FI/Espoo) wrote:
> In both tests set MAC addresses to test packets to enable
> t
On 08.12.2015 15:16, Stuart Haslam wrote:
> On Tue, Dec 08, 2015 at 02:51:40PM +0300, Ilya Maximets wrote:
>> On 08.12.2015 14:24, Stuart Haslam wrote:
>>> On Mon, Dec 07, 2015 at 01:55:31PM +0300, Ilya Maximets wrote:
>>>> Creates a new pktio type that allows
Signed-off-by: Ilya Maximets <i.maxim...@samsung.com>
---
platform/linux-generic/test/Makefile.am | 1 +
platform/linux-generic/test/pktio/Makefile.am | 3 +-
platform/linux-generic/test/pktio/pktio_run_tap | 114
3 files changed, 117 insertions
For the purpose of testing of real-world interfaces the packet's
content should be valid or kernel will throw them away.
Signed-off-by: Ilya Maximets <i.maxim...@samsung.com>
---
test/validation/pktio/pktio.c | 46 ---
1 file changed, 39 insertions
ded to use this pktio.
There should be no device named 'iface' in the system.
The total length of the 'iface' is limited by IF_NAMESIZE.
Signed-off-by: Ilya Maximets <i.maxim...@samsung.com>
---
platform/linux-generic/Makefile.am | 2 +
.../linux-generic/include/odp_packet_io_
On 08.12.2015 15:35, Stuart Haslam wrote:
> On Tue, Dec 08, 2015 at 03:25:01PM +0300, Ilya Maximets wrote:
>>
>>
>> On 08.12.2015 15:16, Stuart Haslam wrote:
>>> On Tue, Dec 08, 2015 at 02:51:40PM +0300, Ilya Maximets wrote:
>>>> On 08.12.2015 14:24, Stuar
ng to
documentation, sets up errno.
My opinion is that almost all functions should set it on errors, otherwise it
useless.
Best regards, Ilya Maximets.
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
ces are UP after pktio_open()
* Fixed getting mtu, getting/setting promisc mode
* Misclenious fixes
Ilya Maximets (3):
validation: pktio: initialize mac addresses for all packets
linux-generic: pktio: add tap pktio type
linux-generic: pktio: add test for tap pktio
platform/lin
_chksum(test_packet);
> + udp->chksum = odp_cpu_to_be_16(odph_ipv4_udp_chksum(test_packet));
>
> if (udp->chksum == 0)
> return -1;
>
> printf("chksum = 0x%x\n", udp->chksum);
>
> - if (ud
Also debug output enhanced.
Signed-off-by: Ilya Maximets <i.maxim...@samsung.com>
---
platform/linux-generic/pktio/socket.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/platform/linux-generic/pktio/socket.c
b/platform/linux-generic/pktio/socket.c
, udp->chksum);
>
> - if (udp->chksum != 0xab2d)
> + if (udp->chksum != odp_be_to_cpu_16(0x7e5a))
Isn't it illogical, that you're trying to compare BE integer with integer in
CPU endianness?
I mean odp_cpu_to_be_16() != odp_be_to_cpu_16() .
Best regards, Ilya Maximets
omisc mode
* Misclenious fixes
Ilya Maximets (3):
validation: pktio: initialize mac addresses for all packets
linux-generic: pktio: add tap pktio type
linux-generic: pktio: add test for tap pktio
platform/linux-generic/Makefile.am | 2 +
.../linux-gener
ded to use this pktio.
There should be no device named 'iface' in the system.
The total length of the 'iface' is limited by IF_NAMESIZE.
Signed-off-by: Ilya Maximets <i.maxim...@samsung.com>
---
platform/linux-generic/Makefile.am | 2 +
.../linux-generic/include/odp_packet_io_
On 07.12.2015 13:01, Stuart Haslam wrote:
> On Wed, Dec 02, 2015 at 04:13:25PM +0300, Ilya Maximets wrote:
>> Signed-off-by: Ilya Maximets <i.maxim...@samsung.com>
>> ---
>> platform/linux-generic/test/Makefile.am | 1 +
>> platform/linux-gener
For the purpose of testing of real-world interfaces the packet's
content should be valid or kernel will throw them away.
Signed-off-by: Ilya Maximets <i.maxim...@samsung.com>
---
test/validation/pktio/pktio.c | 46 ---
1 file changed, 39 insertions
For the purpose of testing of real-world interfaces the packet's
content should be valid or kernel will throw them away.
Signed-off-by: Ilya Maximets <i.maxim...@samsung.com>
---
test/validation/pktio/pktio.c | 46 ---
1 file changed, 39 insertions
ests fixed to work with real-world
interfaces.
* MAC of pktio now is not a kernel interface's MAC
* Interfaces are UP after pktio_open()
* Fixed getting mtu, getting/setting promisc mode
* Misclenious fixes
Ilya Maximets (3):
validation: pktio: initialize mac
ded to use this pktio.
There should be no device named 'iface' in the system.
The total length of the 'iface' is limited by IF_NAMESIZE.
Signed-off-by: Ilya Maximets <i.maxim...@samsung.com>
---
platform/linux-generic/Makefile.am | 2 +
.../linux-generic/include/odp_packet_io_
Signed-off-by: Ilya Maximets <i.maxim...@samsung.com>
---
platform/linux-generic/test/Makefile.am | 1 +
platform/linux-generic/test/pktio/Makefile.am | 3 +-
platform/linux-generic/test/pktio/pktio_run_tap | 111
3 files changed, 114 insertions
OK. I try to prepare them.
Best regards, Ilya Maximets.
On 27.11.2015 13:19, Maxim Uvarov wrote:
> Hello Ilya,
>
> Thanks for sending that patch. Tap pktio should be interesting.
> To accept it we also need coverage validation tests.
>
> Best regards,
> Maxim.
>
>
ded to use this pktio.
There should be no device named 'iface' in the system.
The total length of the 'iface' is limited by IF_NAMESIZE.
Signed-off-by: Ilya Maximets <i.maxim...@samsung.com>
---
platform/linux-generic/Makefile.am | 2 +
.../linux-generic/include/odp_packet_io_
39 matches
Mail list logo
