Brian, can you please resend all patches as new version of patch set.
Not embed them into current email thread. I think it will be more easy
for second review.
Maxim.
On 04.04.2017 21:48, Brian Brooks wrote:
> Remove erroneous assertion that is handled in later code
>
> Signed-off-by: Kevin Wang
On 04/11/17 17:06, Yi He wrote:
> Hi, team
>
> Today in odp cloud meeting we talked about the DDF status, before the new
> LNG colleague joining to take over the DDF works, I'll take the ownership
> of the DDF and continue to move this patch series forward and related bugs,
> comments.
>
> This T
Petri, whom review is needed for that?
Maxim.
On 11 April 2017 at 09:29, Savolainen, Petri (Nokia - FI/Espoo) <
petri.savolai...@nokia-bell-labs.com> wrote:
> Ping. Spec for queue size and capability.
>
>
> > -Original Message-
> > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org]
Merged,
Maxim.
On 04/10/17 15:34, Savolainen, Petri (Nokia - FI/Espoo) wrote:
>
>
>> -Original Message-
>> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill
>> Fischofer
>> Sent: Friday, April 07, 2017 3:53 PM
>> To: Peltonen, Janne (Nokia - FI/Espoo)
>> Cc: lng-
---Original Message-
> > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of
> Maxim
> > Uvarov
> > Sent: Monday, April 10, 2017 3:43 PM
> > To: lng-odp@lists.linaro.org
> > Subject: [lng-odp] [PATCH 1/3] api: ipsec: make num_pkt/out/sa/opt
>
From: Dmitry Eremin-Solenikov
It does not make sense to specify negative amount inside num_*. Make
respective fields unsigned instead.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email created from pull request 13 (lumag:ipsec-api)
** https://github.com/Linaro/odp/pull/13
** Patch: https:/
From: Nikhil Agarwal
Signed-off-by: Nikhil Agarwal
---
/** Email created from pull request 12 (NikhilA-Linaro:api-next)
** https://github.com/Linaro/odp/pull/12
** Patch: https://github.com/Linaro/odp/pull/12.patch
** Base sha: 38485719c028918b019c6a5fc67cf05053421c83
** Merge commit sha: 1d
Yes, also patch should pass code coverage. That is set on github and it
should warn that there are function which are not used marked with red
color. We are trying to remove all not used functions from the code. So
that should go with code where it's used.
Maxim.
On 10 April 2017 at 13:20, Savola
I forget to note that it will be great to update .travis file for
testing new option.
Maxim.
On 04/04/17 21:47, Brian Brooks wrote:
> This work derives from Ola Liljedahl's prototype [1] which introduced a
> scalable scheduler design based on primarily lock-free algorithms and
> data structures d
Merged this patch.
Maxim.
On 04/07/17 15:47, Bill Fischofer wrote:
> On Fri, Apr 7, 2017 at 7:35 AM, Petri Savolainen
> wrote:
>> Lookup modes are per SA and thus may be used in a mix. Spi_overlap
>> parameter is global. So, removed comment about ignoring it in
>> LOOKUP_SPI mode.
>>
>> Signed-o
I'm ok with this patch. That can go to master, not need for api-next.
Maxim.
On 04/06/17 20:09, Brian Brooks wrote:
> On 04/05 01:24:44, Dmitry Eremin-Solenikov wrote:
>> On 04.04.2017 23:34, Brian Brooks wrote:
>>> On 04/04 23:27:51, Dmitry Eremin-Solenikov wrote:
On 04.04.2017 23:26, Brian
On 04/06/17 13:35, Ola Liljedahl wrote:
> On 5 April 2017 at 23:39, Maxim Uvarov wrote:
>> On 04/05/17 17:30, Ola Liljedahl wrote:
>>> On 5 April 2017 at 14:50, Maxim Uvarov wrote:
>>>> On 04/05/17 06:57, Honnappa Nagarahalli wrote:
>>>>> This can go
Please review this patch. TM very often fails in Travis CI. This patch has
to fix it.
Maxim.
On 31 March 2017 at 23:39, Maxim Uvarov wrote:
> tm test fails time to time in Travis environment. Because
> of we can not control that machine we can not do things like
> taskset and core
I merged v2 for that to api-next. Initially I applied to master not to api
next. Please check that patches are merged.
Maxim.
On 5 April 2017 at 09:03, Elo, Matias (Nokia - FI/Espoo) <
matias@nokia-bell-labs.com> wrote:
>
>
>
> > On 4 Apr 2017, at 18:30, Maxim Uvarov
From: Nikhil Agarwal
Signed-off-by: Nikhil Agarwal
---
/** Email created from pull request 8 (NikhilA-Linaro:master)
** https://github.com/Linaro/odp/pull/8
** Patch: https://github.com/Linaro/odp/pull/8.patch
** Base sha: ff6c083358f97f7b5b261d8e75ca7a2eaaab5dea
** Merge commit sha: b6d92e4
From: Dmitry Eremin-Solenikov
Currently ODP testsuite only verifies generation of digests. Let's also
verify that checking the digest actually works. Test that check function
will accept valid digest and that it will reject wrong digests.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email cre
From: Bill Fischofer
The ODP_STATIC_ASSERT() macro expands to _Static_assert(), however when
used in C++ programs this needs to expand to static_assert().
This resolves Bug https://bugs.linaro.org/show_bug.cgi?id=2852
Reported-by: Moshe Tubul
Signed-off-by: Bill Fischofer
---
/** Email create
From: Dmitry Eremin-Solenikov
Currently ODP testsuite only verifies generation of digests. Let's also
verify that checking the digest actually works. Test that check function
will accept valid digest and that it will reject wrong digests.
Signed-off-by: Dmitry Eremin-Solenikov
---
/** Email cre
On 04/05/17 17:30, Ola Liljedahl wrote:
> On 5 April 2017 at 14:50, Maxim Uvarov wrote:
>> On 04/05/17 06:57, Honnappa Nagarahalli wrote:
>>> This can go into master/api-next as an independent patch. Agree?
>>
>> agree. If we accept implementation where events c
On 04/05/17 21:36, Ola Liljedahl wrote:
> On 5 April 2017 at 17:33, Dmitry Eremin-Solenikov
> wrote:
>> On 05.04.2017 17:40, Ola Liljedahl wrote:
>>> On 5 April 2017 at 14:20, Maxim Uvarov wrote:
>>>> On 04/05/17 01:46, Ola Liljedahl wrote:
>>>>&g
cpu is has to always
work. Isn't it?
Maxim.
>
> On 4 April 2017 at 21:22, Brian Brooks wrote:
>> On 04/04 17:26:12, Bill Fischofer wrote:
>>> On Tue, Apr 4, 2017 at 3:37 PM, Brian Brooks wrote:
>>>> On 04/04 21:59:15, Maxim Uvarov wrote:
>>>>> On
On 04/05/17 15:16, Ola Liljedahl wrote:
> On 05/04/2017, 12:36, "Dmitry Eremin-Solenikov"
> wrote:
>
>> On 05.04.2017 02:31, Ola Liljedahl wrote:
>>> On 05/04/2017, 01:25, "Dmitry Eremin-Solenikov"
>>> wrote:
On 04.04.2017 23:52, Ola Liljedahl wrote:
> Sending from my ARM email account,
On 04/05/17 01:46, Ola Liljedahl wrote:
> On 4 April 2017 at 21:25, Maxim Uvarov wrote:
>> it's better to have 2 separate files for that. One for ODP_CONFIG_LLDSCD
> "better"? In what way?
>
>> defined and one for not. Also ODP_ prefix should not be used fo
On 04/04/17 23:08, Brian Brooks wrote:
> On 04/04 22:17:48, Maxim Uvarov wrote:
>> On 04/04/17 21:48, Brian Brooks wrote:
>>> Signed-off-by: Ola Liljedahl
>>> Reviewed-by: Brian Brooks
>>> Reviewed-by: Honnappa Nagarahalli
>>> ---
>>&
On 04/04/17 22:53, Brian Brooks wrote:
> On 04/04 14:11:45, Bill Fischofer wrote:
>> This part has already been merged into the repo and should be removed
>> from this series as it cannot be applied since it's already part of
>> api-next.
>
> Right, but it can only be dropped once that patch has m
On 04/04/17 22:51, Brian Brooks wrote:
> On 04/04 22:01:23, Maxim Uvarov wrote:
>> On 04/04/17 21:48, Brian Brooks wrote:
>>> Remove erroneous assertion that is handled in later code
>>>
>>
>> Patch logically incorrect. This patch adds odp_schedule_release_
On 04/04/17 22:48, Brian Brooks wrote:
> On 04/04 21:57:29, Maxim Uvarov wrote:
>> On 04/04/17 21:47, Brian Brooks wrote:
>>> Signed-off-by: Ola Liljedahl
>>> Reviewed-by: Honnappa Nagarahalli
>>> Reviewed-by: Brian Brooks
>>> ---
>>> pl
On 04/04/17 22:45, Brian Brooks wrote:
> On 04/04 21:55:06, Maxim Uvarov wrote:
>> this patch should be not part of this serries and can go to master as
>> standalone patch.
>
> Can you help to cherry pick such patches to master? They need to remain
> in this patch seri
On 04/04/17 21:48, Brian Brooks wrote:
> Add queue getters and setters to provide an abstraction over more than one
> internal queue data structure.
>
> Use buffer handles instead of pointer to internal object in pktio and tm code.
>
> Increase the running time of odp_sched_latency to get more st
it's better to have 2 separate files for that. One for ODP_CONFIG_LLDSCD
defined and one for not. Also ODP_ prefix should not be used for
internal things (not api).
Maxim.
On 04/04/17 21:48, Brian Brooks wrote:
> Signed-off-by: Ola Liljedahl
> Reviewed-by: Brian Brooks
> ---
> platform/linux-g
On 04/04/17 21:48, Brian Brooks wrote:
> Signed-off-by: Ola Liljedahl
> Reviewed-by: Brian Brooks
> Reviewed-by: Honnappa Nagarahalli
> ---
> platform/linux-generic/include/odp_llsc.h | 332
> ++
> 1 file changed, 332 insertions(+)
> create mode 100644 platform/lin
On 04/04/17 21:48, Brian Brooks wrote:
> Signed-off-by: Ola Liljedahl
> Reviewed-by: Brian Brooks
> Reviewed-by: Honnappa Nagarahalli
> ---
> platform/linux-generic/include/odp_bitset.h | 155
>
> 1 file changed, 155 insertions(+)
> create mode 100644 platform/lin
On 04/04/17 21:48, Brian Brooks wrote:
> Remove erroneous assertion that is handled in later code
>
Patch logically incorrect. This patch adds odp_schedule_release_x().
Chunk of removing ASSERT has to go to "later code" patch.
Maxim.
> Signed-off-by: Kevin Wang
> Reviewed-by: Ola Liljedahl
>
On 04/04/17 21:47, Brian Brooks wrote:
> Signed-off-by: Ola Liljedahl
> Reviewed-by: Brian Brooks
> Reviewed-by: Honnappa Nagarahalli
> Reviewed-by: Kevin Wang
> ---
> test/common_plat/performance/odp_scheduling.c | 12 ++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff
On 04/04/17 21:47, Brian Brooks wrote:
> Signed-off-by: Ola Liljedahl
> Reviewed-by: Honnappa Nagarahalli
> Reviewed-by: Brian Brooks
> ---
> platform/linux-generic/include/odp_config_internal.h | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/platform/linux-generic/include/odp_
this patch should be not part of this serries and can go to master as
standalone patch. No need of camel case is shor description. Long
description in git comment is required.
Maxim.
On 04/04/17 21:47, Brian Brooks wrote:
> Signed-off-by: Brian Brooks
> ---
> configure.ac | 30
On 04/04/17 21:47, Brian Brooks wrote:
> Signed-off-by: Brian Brooks
> Signed-off-by: Honnappa Nagarahalli
> ---
> include/odp/api/spec/queue.h | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/odp/api/spec/queue.h b/include/odp/api/spec/queue.h
> index 7972feac..1cec4773 10
Merged. Please ignore first comment due to initially I tried to apply it
to master. Not to api-next.
Maxim.
On 04.04.2017 09:28, Matias Elo wrote:
> Signed-off-by: Matias Elo
> Reviewed-and-tested-by: Bill Fischofer
> ---
> V2:
> - Rebase
>
> example/generator/odp_generator.c | 4
breaks build:
https://travis-ci.org/muvarov/odp/jobs/218496566
On 4 April 2017 at 09:28, Matias Elo wrote:
> Replace old lazy parsing code with a new packet parsing implementation
> which follows the latest API (parsing level is selected using
> odp_pktio_config()).
>
> Signed-off-by: Matias Elo
Matias can you please update patches and check them?
Maxim.
On 04/03/17 02:36, Bill Fischofer wrote:
> For this series:
>
> Reviewed-and-tested-by: Bill Fischofer
>
> On Wed, Mar 22, 2017 at 10:29 AM, Matias Elo wrote:
>> Signed-off-by: Matias Elo
>> ---
>> example/generator/odp_generator.c
o.org/show_bug.cgi?id=2881
Signed-off-by: Maxim Uvarov
---
.../validation/api/traffic_mngr/Makefile.am| 12 +--
.../validation/api/traffic_mngr/traffic_mngr.sh| 25 ++
2 files changed, 35 insertions(+), 2 deletions(-)
create mode 100755 test/common_plat/valid
arning: ignoring unsupported tag `HTML_EXTRA_STYLESHEET =' at line
>>>> 31, file ./doc/helper-guide/Doxyfile
>>>> error: Unexpected start tag `services' found in scope='class/memberdecl/'!
>>>> error: Unexpected start tag `interfaces' found
On 03/31/17 10:43, Matias Elo wrote:
> Fixes https://bugs.linaro.org/show_bug.cgi?id=2910
>
Matias please add some description here. Link to problem is good
but people like to read only git logs.
Maxim.
> Signed-off-by: Matias Elo
> ---
> helper/iplookuptable.c | 8
> 1 file changed,
Merged to master branch.
Maxim.
On 03/31/17 16:45, Ola Liljedahl wrote:
> On 31 March 2017 at 15:21, Maxim Uvarov wrote:
>> On 03/28/17 22:23, Brian Brooks wrote:
>>> From: Ola Liljedahl
>>>
>>> Signed-off-by: Ola Liljedahl
>>> Reviewed-by: Bria
On 03/28/17 22:23, Brian Brooks wrote:
> From: Ola Liljedahl
>
> Signed-off-by: Ola Liljedahl
> Reviewed-by: Brian Brooks
> ---
> platform/linux-generic/pktio/ring.c | 30 ++
> 1 file changed, 14 insertions(+), 16 deletions(-)
> mode change 100644 => 100755 platfor
Thanks Christophe for all that work which you did! It's really good impact
to the project. And all the best wishes in future.
Maxim.
On 31 March 2017 at 11:32, Yi He wrote:
> Hi, Christophe,
>
> Wish you all the best and joy in your new endeavors.
>
> Best Regards, Yi
>
> On 31 March 2017 at 16
bash -lt syntax expects 2 integer values, not strings.
Also return code of piped command needs to be get in
a little bit different way.
https://bugs.linaro.org/show_bug.cgi?id=2872
Signed-off-by: Maxim Uvarov
---
v2: after repairing test logic make distcheck failed due to
missing targets
I think for now we do not have build for arm v8 & clang. At least it did
not capture build error.
Maxim.
On 30 March 2017 at 17:45, Bill Fischofer wrote:
> On Thu, Mar 30, 2017 at 8:56 AM, Brian Brooks
> wrote:
> > On 03/28 18:50:32, Bill Fischofer wrote:
> >>
> >>
> >>
> >>