[lng-odp] [PATCH 2/5] linux-generic: classification: Remove typedef forward declarations

2015-02-04 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/include/odp_classification_datamodel.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/platform/linux-generic/include/odp_classification_datamodel.h b/platform/linux-generic

[lng-odp] [PATCH 1/5] api: debug: fix static assert macro

2015-02-04 Thread Taras Kondratiuk
Clang doesn't like parentheses around _Static_assert() macro. Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- include/odp/api/debug.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/odp/api/debug.h b/include/odp/api/debug.h index 05f4e9e..6cf4e05

[lng-odp] [PATCH 4/5] api: hints: add printf format attribute

2015-02-04 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- include/odp/api/hints.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/odp/api/hints.h b/include/odp/api/hints.h index a7aa90e..d6bf723 100644 --- a/include/odp/api/hints.h +++ b/include/odp/api/hints.h @@ -46,6

Re: [lng-odp] [PATCH v2 1/4] api: cpu: Added cpu.h

2015-02-03 Thread Taras Kondratiuk
On 02/03/2015 01:07 PM, Ola Liljedahl wrote: On 3 February 2015 at 11:59, Petri Savolainen petri.savolai...@linaro.org wrote: This file contains cpu related API calls. The calls are renames from odp_thread_cpu() and odp_sys_cpu_count(). Signed-off-by: Petri Savolainen

Re: [lng-odp] [PATCHv5 11/19] linux-generic: buffers: add strong typing support

2015-02-03 Thread Taras Kondratiuk
On 02/03/2015 11:50 PM, Bill Fischofer wrote: The changes here are to platform/linux-generic/include/odp/plat/type_types.h. This is where the strong typing is actually implemented for each ODP type in linux-generic. The converter functions are part of that implementation, and are also

Re: [lng-odp] [PATCHv5 11/19] linux-generic: buffers: add strong typing support

2015-02-03 Thread Taras Kondratiuk
On 02/03/2015 11:57 PM, Ola Liljedahl wrote: The re-org has make it easier for the implementors of ODP. However, its a bit harder to follow the structure now maybe. static inline functions should go into: platform/linux-generic/include/odp/*.h and typedefs, defines, enums, and structs that

Re: [lng-odp] [PATCH v2] validation: init: split cases into executables

2015-02-03 Thread Taras Kondratiuk
On 02/03/2015 03:12 PM, Maxim Uvarov wrote: Patch applied with small correction. You deleted odp_classification from the list which is obvious error, no need to do that. Hmm. Where is it removed? ___ lng-odp mailing list lng-odp@lists.linaro.org

Re: [lng-odp] [PATCH v2 0/5] Add replaceable odp abort mechanism

2015-02-03 Thread Taras Kondratiuk
abort function api: init_global: allow abort fn to be overidden validation: init: add test for replace abort For a whole series: Reviewed-by: Taras Kondratiuk taras.kondrat...@linaro.org ___ lng-odp mailing list lng-odp@lists.linaro.org http

Re: [lng-odp] [PATCHv5 11/19] linux-generic: buffers: add strong typing support

2015-02-03 Thread Taras Kondratiuk
On 02/04/2015 12:42 AM, Mike Holmes wrote: On 3 February 2015 at 17:16, Taras Kondratiuk taras.kondrat...@linaro.org mailto:taras.kondrat...@linaro.org wrote: On 02/03/2015 11:50 PM, Bill Fischofer wrote: The changes here are to platform/linux-generic/include/odp/plat

Re: [lng-odp] [PATCH v2] validation: init: split cases into executables

2015-02-03 Thread Taras Kondratiuk
On 02/03/2015 12:02 AM, Mike Holmes wrote: init_global can only be called once per executable, split the init_global testing into multiple executables. Signed-off-by: Mike Holmes mike.hol...@linaro.org --- v2 fix copyright year remove uneeded defines test/validation/Makefile.am| 4 +--

Re: [lng-odp] [PATCHv4] linux-generic: Add odp_errno and adapt packet_io and timer implementations to use it

2015-02-02 Thread Taras Kondratiuk
On 02/02/2015 11:57 AM, Maxim Uvarov wrote: Taras, looks like Mario fixed comment you requested in v3. Is this version ok for you? Reviewed-by: Taras Kondratiuk taras.kondrat...@linaro.org One comment below not directly related to this patch. diff --git a/platform/linux-generic

Re: [lng-odp] Regarding ODP Buffers

2015-02-02 Thread Taras Kondratiuk
On 01/31/2015 06:19 PM, Prashant Upadhyaya wrote: Hi, Suppose I create a buffer pool with odp_buffer_pool_create. Now I can allocate buffers from this pool with odp_packet_alloc. I can get hold of the packet data pointer with odp_packet_data. So far so good. Now, the buffer address which I

Re: [lng-odp] [PATCHv2 1/9] api: add base macros for strong typing support

2015-01-31 Thread Taras Kondratiuk
)) + +#define _odp_cast_scalar(type, val) ((type)(size_t)(val)) + +#endif -- Taras Kondratiuk ___ lng-odp mailing list lng-odp@lists.linaro.org http://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] Handling xxx_INVALID handles

2015-01-30 Thread Taras Kondratiuk
On 01/30/2015 04:40 PM, Savolainen, Petri (NSN - FI/Espoo) wrote: -Original Message- From: ext Taras Kondratiuk [mailto:taras.kondrat...@linaro.org] Sent: Friday, January 30, 2015 3:17 PM To: Savolainen, Petri (NSN - FI/Espoo) Cc: ext Ola Liljedahl; lng-odp@lists.linaro.org Subject

Re: [lng-odp] Handling xxx_INVALID handles

2015-01-30 Thread Taras Kondratiuk
On 01/30/2015 02:06 PM, Savolainen, Petri (NSN - FI/Espoo) wrote: -Original Message- From: ext Taras Kondratiuk [mailto:taras.kondrat...@linaro.org] Sent: Friday, January 30, 2015 1:50 PM To: Savolainen, Petri (NSN - FI/Espoo); ext Ola Liljedahl Cc: lng-odp@lists.linaro.org Subject

Re: [lng-odp] Handling xxx_INVALID handles

2015-01-30 Thread Taras Kondratiuk
On 01/30/2015 02:41 PM, Savolainen, Petri (NSN - FI/Espoo) wrote: -Original Message- From: ext Taras Kondratiuk [mailto:taras.kondrat...@linaro.org] Sent: Friday, January 30, 2015 2:28 PM To: Savolainen, Petri (NSN - FI/Espoo); ext Ola Liljedahl Cc: lng-odp@lists.linaro.org Subject

Re: [lng-odp] Handling xxx_INVALID handles

2015-01-30 Thread Taras Kondratiuk
On 01/30/2015 01:15 PM, Savolainen, Petri (NSN - FI/Espoo) wrote: As explained below, XXX_NULL != XXX_INVALID enables to distinguish this error ... x = odp_xxx_create(...); // error! = Returns XXX_INVALID y = odp_yyy_create(x, ); // x == XXX_INVALID = error! Deferring error

[lng-odp] Handling xxx_INVALID handles

2015-01-29 Thread Taras Kondratiuk
Hi We had a discussion recently about wrong ODP handles passed to API functions. As far as I remember we agreed that in this case behavior is undefined. What about passing xxx_INVALID values to API? Currently packet IO verification tests pass ODP_PKTIO_INVALID explicitly to some API

Re: [lng-odp] [PULL REQUESTv2] reorganisation of API header files

2015-01-29 Thread Taras Kondratiuk
: schedule: move defines api: event: move types and defines api: version: move defines Taras Kondratiuk (5): api: move ODP headers to a directory doc: cfg: disable TYPEDEF_HIDES_STRUCT doc: cfg: fix structure attributes parsing api: atomic: move types

Re: [lng-odp] Handling xxx_INVALID handles

2015-01-29 Thread Taras Kondratiuk
On 01/29/2015 07:01 PM, Ola Liljedahl wrote: On 29 January 2015 at 17:46, Taras Kondratiuk taras.kondrat...@linaro.org wrote: Hi We had a discussion recently about wrong ODP handles passed to API functions. As far as I remember we agreed that in this case behavior is undefined. What about

Re: [lng-odp] Handling xxx_INVALID handles

2015-01-29 Thread Taras Kondratiuk
On 01/30/2015 12:05 AM, Ola Liljedahl wrote: On 29 January 2015 at 22:55, Taras Kondratiuk taras.kondrat...@linaro.org wrote: There are cases when access to a shared ODP resource is done indirectly (not via handle). For example, accessing shared memory block after obtaining its address via

Re: [lng-odp] [PATCH] linux-generic: pktio: abort on enq to pktin or deq from pktout

2015-01-27 Thread Taras Kondratiuk
On 01/27/2015 04:25 PM, Maxim Uvarov wrote: We need to take some decision here. If KS2 does not support enq to a pktin queue or deq from a pktout queue lets apply this patch. As I've noted in this thread there are no limitations in HW to support it. I just don't see a real use-case for this

Re: [lng-odp] [PATCH] linux-generic: pktio: abort on enq to pktin or deq from pktout

2015-01-27 Thread Taras Kondratiuk
action */ - return queue_enq(qentry, buf_hdr); + (void)qentry; + (void)buf_hdr; We used to use ODP_UNUSED attribute. Otherwise Reviewed-by: Taras Kondratiuk taras.kondrat...@linaro.org ___ lng-odp mailing list lng-odp@lists.linaro.org http

Re: [lng-odp] [PATCH 2/3] validation: buffer: fix for the use of cached return value of odp_packet_last_seg

2015-01-25 Thread Taras Kondratiuk
On 01/24/2015 08:06 PM, Bill Fischofer wrote: The issue is not whether the number of segments is changed but whether the pkt handle is changed. APIs that potentially substitute a new handle must return a handle. If a handle is not returned then the input handle is unchanged, however behavior

Re: [lng-odp] [PATCHv1 1/3] api: crypto: new completion event scheme

2015-01-25 Thread Taras Kondratiuk
auth_status; /** Authentication status */ } odp_crypto_op_errors_t; odp_crypto_compl_errors(odp_crypto_compl_event_t completion_event, odp_crypto_op_errors_t *errors); +} odp_crypto_op_result_t; /** * Crypto session creation (synchronous) -- Taras Kondratiuk

Re: [lng-odp] [PATCH 2/3] validation: buffer: fix for the use of cached return value of odp_packet_last_seg

2015-01-24 Thread Taras Kondratiuk
On 01/19/2015 12:18 PM, Ola Liljedahl wrote: On 17 January 2015 at 23:22, Taras Kondratiuk taras.kondrat...@linaro.org wrote: On 01/17/2015 01:29 PM, Jerin Jacob wrote: odp_packet_seg_t is an opaque type, based on the implementation, the return value of odp_packet_last_seg can be changed

Re: [lng-odp] [PATCHv3] linux-generic: Add odp_errno and adapt packet_io and timer implementations to use it

2015-01-22 Thread Taras Kondratiuk
Sorry if formatting is wrong. Replying from a phone. On Jan 21, 2015 6:14 PM, Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com wrote: Added odp_errno.c and odp_errno.h Changed odp_packet_io and odp_timer to use it. Signed-off-by: Mario Torrecillas Rodriguez

Re: [lng-odp] Regarding reserve memory where both SW + HW can access.

2015-01-18 Thread Taras Kondratiuk
accordingly. -- Taras Kondratiuk ___ lng-odp mailing list lng-odp@lists.linaro.org http://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] Regarding reserve memory where both SW + HW can access.

2015-01-18 Thread Taras Kondratiuk
From: Taras Kondratiuk taras.kondrat...@linaro.org Sent: Sunday, January 18, 2015 4:40 PM To: Mrityunjay Kumar; supp...@linaro.org; lng-odp@lists.linaro.org Subject: Re: [lng-odp] Regarding reserve memory where both SW + HW can access. On 01/18/2015 11:08 AM, Mrityunjay Kumar wrote

Re: [lng-odp] Regarding reserve memory where both SW + HW can access.

2015-01-18 Thread Taras Kondratiuk
On 01/18/2015 04:43 PM, Taras Kondratiuk wrote: On 01/18/2015 03:07 PM, Mrityunjay Kumar wrote: I want to allocate memory by the ODP API, which will also seen by the hardware. As per my understanding address actually seen by the memory hardware is a physical address. Is there any way

Re: [lng-odp] [PATCH 00/15] Event introduction

2015-01-17 Thread Taras Kondratiuk
On 01/16/2015 05:39 PM, Ola Dahl wrote: I am wondering why odp_buffer_t is still around, when it is supposed to be replaced by odp_event_t? It is for ODP_EVENT_BUFFER (previously ODP_BUFFER_TYPE_RAW) type of odp_event_t. -- Taras Kondratiuk ___ lng

Re: [lng-odp] [PATCH 1/3] validation: buffer: check the return value of odp_packet_l?_offset_set

2015-01-17 Thread Taras Kondratiuk
On 01/17/2015 01:29 PM, Jerin Jacob wrote: Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com --- test/validation/buffer/odp_packet_test.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) Reviewed-by: Taras Kondratiuk taras.kondrat...@linaro.org -- Taras Kondratiuk

Re: [lng-odp] [PATCH 2/3] validation: buffer: fix for the use of cached return value of odp_packet_last_seg

2015-01-17 Thread Taras Kondratiuk
); + CU_ASSERT(seg != ODP_SEGMENT_INVALID); + CU_ASSERT(tail != NULL); CU_ASSERT(odp_packet_seg_data_len(pkt, seg) == seg_data_len + shift); CU_ASSERT(odp_packet_len(pkt) == pkt_data_len + shift); -- Taras Kondratiuk

Re: [lng-odp] [PATCH] linux-generic: queue: fix PKTIN queue destroy

2015-01-14 Thread Taras Kondratiuk
On 01/14/2015 09:07 PM, Stuart Haslam wrote: On Thu, Dec 18, 2014 at 10:27:43AM +, Taras Kondratiuk wrote: PKTIN queue was not handled correctly. Check queue status instead of queue type. I just had cause to want to destroy a PKTIN queue and remembered this patch. I applied

Re: [lng-odp] [PATCHv2 1/3] linux-generic: buffers: expand ODP_BITSIZE macro for u64 use

2015-01-13 Thread Taras Kondratiuk
ODP_BITSIZE(x) (8 * sizeof(long long) - __builtin_clzll(x - 1)) -- Taras Kondratiuk ___ lng-odp mailing list lng-odp@lists.linaro.org http://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [PATCHv2 2/3] linux-generic: buffers: improve lockless allocator

2015-01-13 Thread Taras Kondratiuk
On 01/13/2015 11:43 PM, Bill Fischofer wrote: I can include that in a v3 if needed. Would that go above or below the -- ? I think it should be in a git history, so above. ___ lng-odp mailing list lng-odp@lists.linaro.org

Re: [lng-odp] [PATCHv2 1/3] linux-generic: buffers: expand ODP_BITSIZE macro for u64 use

2015-01-13 Thread Taras Kondratiuk
, but most probably clang have something similar. -- Taras Kondratiuk ___ lng-odp mailing list lng-odp@lists.linaro.org http://lists.linaro.org/mailman/listinfo/lng-odp

[lng-odp] [PATCH] linux-generic: timer: add missing queue header

2014-12-29 Thread Taras Kondratiuk
Timer code uses queue API but doesn't include header. The header is included indirectly from another header just by chance. Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/odp_timer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/platform/linux

Re: [lng-odp] [PATCHv3] configure.ac check for atomic operations support

2014-12-25 Thread Taras Kondratiuk
: On 23 December 2014 at 11:15, Taras Kondratiuk taras.kondrat...@linaro.org mailto:taras.kondrat...@linaro.org mailto:taras.kondratiuk@__linaro.org

Re: [lng-odp] [PATCHv3] configure.ac check for atomic operations support

2014-12-25 Thread Taras Kondratiuk
On 12/25/2014 11:53 AM, Maxim Uvarov wrote: On 12/25/2014 12:34 PM, Taras Kondratiuk wrote: On 12/24/2014 12:21 PM, Maxim Uvarov wrote: On 12/23/2014 07:15 PM, Taras Kondratiuk wrote: Linux-generic shouldn't have arch specific parts, because it is *generic*. Instead it can fall back to strong

Re: [lng-odp] [PATCHv3] configure.ac check for atomic operations support

2014-12-25 Thread Taras Kondratiuk
On 12/25/2014 12:23 PM, Maxim Uvarov wrote: On 12/25/2014 12:15 PM, Taras Kondratiuk wrote: There is no need to make it so complex. At least until 'static' before 'not static' functions is forbidden by some post-C11 standard). Me and Anders are making another try to separate clean API

Re: [lng-odp] [PATCH] example: move odp_example to test/performance

2014-12-25 Thread Taras Kondratiuk
On 12/25/2014 12:36 AM, Mike Holmes wrote: odp_example is too complex to be an example, and is not a unit test, instead it is a performance oriented test application. Signed-off-by: Mike Holmes mike.hol...@linaro.org Reviewed-by: Taras Kondratiuk taras.kondrat...@linaro.org -- Taras

[lng-odp] [PATCH] test/example: Remove ODP component headers

2014-12-23 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- example/ipsec/odp_ipsec_sp_db.c | 2 -- test/api_test/odp_timer_ping.c| 1 - test/validation/buffer/odp_buffer_tests.h | 1 - test/validation/odp_pktio.c | 1 - 4 files changed, 5 deletions

[lng-odp] [RFC] api: move ODP headers to a directory

2014-12-23 Thread Taras Kondratiuk
/..', 'odp/private/..', etc. https://git.linaro.org/people/taras.kondratiuk/odp.git/commitdiff/d6e6fdd3ef40814ee6f426d939f4f61388318669 This one step into direction to separate API form platform details. Me and Anders will try to prepare (yet another :)) split during holidays. -- Taras Kondratiuk

Re: [lng-odp] [PATCHv3] configure.ac check for atomic operations support

2014-12-23 Thread Taras Kondratiuk
, because it is *generic*. Instead it can fall back to strong __sync functions if __atomic are not available. -- Taras Kondratiuk ___ lng-odp mailing list lng-odp@lists.linaro.org http://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [PATCH] linux-generic: buffer: add buffer pool termination

2014-12-19 Thread Taras Kondratiuk
On 12/19/2014 01:20 AM, Bill Fischofer wrote: Good catch. The issue here is that odp_init_global() specifies a sequence of component initializers, and odp_term_global() must do the same in reverse but the others aren't ready yet. So odp_buffer_pool_term_global() must not be called prior to a

Re: [lng-odp] [PATCHv2 3/3] validation: buffer: add initial packet tests

2014-12-19 Thread Taras Kondratiuk
On 12/18/2014 07:04 PM, Bill Fischofer wrote: See detailed comments inline. I verified that this passes all tests when the packet segmentation patch is applied. Bill On Thu, Dec 18, 2014 at 6:11 AM, Taras Kondratiuk taras.kondrat...@linaro.org mailto:taras.kondrat...@linaro.org wrote

Re: [lng-odp] [PATCHv2 0/3] validation: buffer: add initial tests

2014-12-19 Thread Taras Kondratiuk
On 12/18/2014 02:11 PM, Taras Kondratiuk wrote: Taras Kondratiuk (3): validation: buffer: add initial buffer pool tests validation: buffer: add initial buffer tests validation: buffer: add initial packet tests Hi Maxim, I'm going to update 3rd patch, but first two are ready

Re: [lng-odp] [PATCHv2 2/2] linux-generic: packets enable segmented packet support

2014-12-19 Thread Taras Kondratiuk
On 12/18/2014 11:21 PM, Bill Fischofer wrote: Signed-off-by: Bill Fischofer bill.fischo...@linaro.org --- v2 makes requests for packet pools of buf_size ODP_CONFIG_PACKET_BUF_LEN_MAX unsegmented Reviewed-and-tested-by: Taras Kondratiuk taras.kondrat...@linaro.org Patches in this series

Re: [lng-odp] [PATCHv2 0/3] validation: buffer: add initial tests

2014-12-19 Thread Taras Kondratiuk
On 12/19/2014 06:10 PM, Maxim Uvarov wrote: On 12/19/2014 06:33 PM, Taras Kondratiuk wrote: On 12/18/2014 02:11 PM, Taras Kondratiuk wrote: Taras Kondratiuk (3): validation: buffer: add initial buffer pool tests validation: buffer: add initial buffer tests validation: buffer: add

Re: [lng-odp] [PATCHv2 3/3] validation: buffer: add initial packet tests

2014-12-19 Thread Taras Kondratiuk
On 12/19/2014 05:38 PM, Bill Fischofer wrote: On Fri, Dec 19, 2014 at 8:46 AM, Taras Kondratiuk taras.kondrat...@linaro.org mailto:taras.kondrat...@linaro.org wrote: + + if (shift 0) + data = odp_packet_push_head(packet, shift

Re: [lng-odp] [PATCHv2 3/3] validation: buffer: add initial packet tests

2014-12-19 Thread Taras Kondratiuk
On 12/19/2014 06:54 PM, Bill Fischofer wrote: On Fri, Dec 19, 2014 at 10:34 AM, Taras Kondratiuk taras.kondrat...@linaro.org mailto:taras.kondrat...@linaro.org wrote: On 12/19/2014 05:38 PM, Bill Fischofer wrote: On Fri, Dec 19, 2014 at 8:46 AM, Taras Kondratiuk

[lng-odp] [PATCHv3 1/3] validation: buffer: add initial buffer pool tests

2014-12-19 Thread Taras Kondratiuk
Reviewed-and-tested-by: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- test/validation/.gitignore| 1 + test/validation/Makefile.am | 5 +- test/validation/buffer/odp_buffer_pool_test.c | 212

[lng-odp] [PATCHv3 0/3] validation: buffer: add initial tests

2014-12-19 Thread Taras Kondratiuk
Initial version of sunny day buffer pool, buffer and packet API tests. linux-generic doesn't support segmented buffers for now, so two tests are failing. If segmentation is enabled for packets, then all tests pass. v3: Addressed most of Bill's comments for patch #3. Rebased patches. Taras

[lng-odp] [PATCHv3 3/3] validation: buffer: add initial packet tests

2014-12-19 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- test/validation/Makefile.am | 1 + test/validation/buffer/odp_buffer_tests.h | 4 + test/validation/buffer/odp_packet_test.c | 668 ++ test/validation/odp_buffer.c | 5

Re: [lng-odp] [PATCHv2 0/3] validation: buffer: add initial tests

2014-12-19 Thread Taras Kondratiuk
On 12/19/2014 06:26 PM, Maxim Uvarov wrote: On 12/19/2014 07:23 PM, Taras Kondratiuk wrote: On 12/19/2014 06:10 PM, Maxim Uvarov wrote: On 12/19/2014 06:33 PM, Taras Kondratiuk wrote: On 12/18/2014 02:11 PM, Taras Kondratiuk wrote: Taras Kondratiuk (3): validation: buffer: add initial

Re: [lng-odp] [PATCHv2 2/2] linux-generic: packets enable segmented packet support

2014-12-19 Thread Taras Kondratiuk
wouldn't insist much to keep them separate. -- Taras Kondratiuk ___ lng-odp mailing list lng-odp@lists.linaro.org http://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [PATCHv3 3/3] validation: buffer: add initial packet tests

2014-12-19 Thread Taras Kondratiuk
On 12/20/2014 01:07 AM, Bill Fischofer wrote: On Fri, Dec 19, 2014 at 2:56 PM, Taras Kondratiuk taras.kondrat...@linaro.org mailto:taras.kondrat...@linaro.org wrote: +static void _verify_tailroom_shift(odp_packet_t pkt, + int shift

Re: [lng-odp] [PATCHv3 3/3] validation: buffer: add initial packet tests

2014-12-19 Thread Taras Kondratiuk
doesn't make sense. Old values are not valid anymore anyway. I looks like some misunderstanding. Petri, could you please clarify which exactly behavior do you expect? -- Taras Kondratiuk ___ lng-odp mailing list lng-odp@lists.linaro.org http

Re: [lng-odp] [PATCHv3 3/3] validation: buffer: add initial packet tests

2014-12-19 Thread Taras Kondratiuk
On 12/20/2014 01:58 AM, Taras Kondratiuk wrote: On 12/20/2014 01:30 AM, Bill Fischofer wrote: https://patches.linaro.org/42375/ posted by Petri and scheduled to be part of 0.6.0 makes it very clear that this is a spec change to the operation of push/pull head operations, not tail operations

Re: [lng-odp] [RFC PATCH] linux-generic: add buffer pool termination

2014-12-18 Thread Taras Kondratiuk
On 12/18/2014 04:43 AM, Bill Fischofer wrote: This patch doesn't apply to the current tip. Yes. As noted in the commit message it is based on another patch in ML. Bill On Wed, Dec 17, 2014 at 9:00 AM, Taras Kondratiuk taras.kondrat...@linaro.org mailto:taras.kondrat...@linaro.org wrote

[lng-odp] [PATCH] linux-generic: queue: fix PKTIN queue destroy

2014-12-18 Thread Taras Kondratiuk
PKTIN queue was not handled correctly. Check queue status instead of queue type. Reported-by: Stuart Haslam stuart.has...@arm.com Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/odp_queue.c | 39 -- 1 file changed, 21

[lng-odp] [PATCH 1/2] api: init: add a way to determine a last ODP thread termination

2014-12-18 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/include/api/odp_init.h | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/platform/linux-generic/include/api/odp_init.h b/platform/linux-generic/include/api/odp_init.h index

[lng-odp] [PATCH 2/2] linux-generic: init: implement basic odp_term_local()

2014-12-18 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/include/odp_internal.h | 1 + platform/linux-generic/odp_init.c | 3 +-- platform/linux-generic/odp_linux.c| 10 -- platform/linux-generic/odp_thread.c | 14

Re: [lng-odp] [RFC PATCH] linux-generic: add buffer pool termination

2014-12-18 Thread Taras Kondratiuk
On 12/18/2014 01:31 PM, Bill Fischofer wrote: Ok, I hadn't noticed that. As an aside, is there a standard for specifying pre-reqs / co-reqs for patches? With so many patches in flight it can be confusing to know what all the dependency chains are. Usually dependency or other important notes

Re: [lng-odp] [RFC PATCH] linux-generic: add buffer pool termination

2014-12-18 Thread Taras Kondratiuk
On 12/18/2014 01:52 PM, Bill Fischofer wrote: I was thinking of something that git itself (or one of its support tools) might understand, but thanks. Gerrit handles dependencies nicely, but we are not using it. ___ lng-odp mailing list

Re: [lng-odp] [PATCHv2 0/4] linux-generic: crypto: fix validation tests failures

2014-12-18 Thread Taras Kondratiuk
Hi Robbie. I've addressed your comments. Are you ok with a current series? On 12/18/2014 02:05 PM, Maxim Uvarov wrote: is that ready for merge? Maxim. On 12/16/2014 05:19 PM, Taras Kondratiuk wrote: This series fixes all crypto tests failures. Suite: odp_crypto_sync_inp Test

[lng-odp] [PATCHv2 0/3] validation: buffer: add initial tests

2014-12-18 Thread Taras Kondratiuk
Passed Failed Inactive suites 3 3n/a 00 tests 31 31 31 00 asserts242242242 0 n/a Taras Kondratiuk (3): validation: buffer: add initial buffer pool tests validation: buffer: add

[lng-odp] [PATCHv2 1/3] validation: buffer: add initial buffer pool tests

2014-12-18 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- test/validation/.gitignore | 1 + test/validation/Makefile.am| 5 +- test/validation/buffer/odp_buffer_pool_test.c | 212 + test/validation/buffer

[lng-odp] [PATCHv2 3/3] validation: buffer: add initial packet tests

2014-12-18 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- test/validation/Makefile.am| 1 + test/validation/buffer/odp_buffer_testsuites.h | 4 + test/validation/buffer/odp_packet_test.c | 670 + test/validation/odp_buffer.c

[lng-odp] [PATCHv2 2/3] validation: buffer: add initial buffer tests

2014-12-18 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- test/validation/Makefile.am| 1 + test/validation/buffer/odp_buffer_test.c | 52 ++ test/validation/buffer/odp_buffer_testsuites.h | 4 ++ test/validation/odp_buffer.c

Re: [lng-odp] [PATCH] Documentation: Change odp_buffer_pool_info_t output

2014-12-18 Thread Taras Kondratiuk
Otherwise Reviewed-by: Taras Kondratiuk taras.kondrat...@linaro.org Should ODP_SHM_NULL definition be removed completely now from API? ___ lng-odp mailing list lng-odp@lists.linaro.org http://lists.linaro.org/mailman/listinfo/lng-odp

Re: [lng-odp] [PATCH 1/2] linux-generic: packets: enable segmented packet support

2014-12-18 Thread Taras Kondratiuk
On 12/18/2014 01:16 AM, Bill Fischofer wrote: Add segmented packet I/O support via sockets. RAW sockets limited to single segment. Signed-off-by: Bill Fischofer bill.fischo...@linaro.org --- platform/linux-generic/odp_packet_socket.c | 33 +- 1 file changed, 19

Re: [lng-odp] [PATCH 2/2] linux-generic: packets: enable segmented packet support

2014-12-18 Thread Taras Kondratiuk
On 12/18/2014 04:31 PM, Bill Fischofer wrote: It's one patch broken into two parts [1/2] [2/2]. Is this not correct? I'm trying to break things up since folks don't want to see single patches. Split looks correct. First patch prepares pktio code for segmented buffers, and the second patch

Re: [lng-odp] [PATCH] Documentation: Change odp_buffer_pool_info_t output

2014-12-18 Thread Taras Kondratiuk
On 12/18/2014 05:41 PM, Savolainen, Petri (NSN - FI/Espoo) wrote: -Original Message- From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp- boun...@lists.linaro.org] On Behalf Of ext Taras Kondratiuk Sent: Thursday, December 18, 2014 4:36 PM To: Bill Fischofer; lng-odp

[lng-odp] [PATCH] linux-generic: buffer: add buffer pool termination

2014-12-18 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/include/odp_internal.h | 2 ++ platform/linux-generic/odp_buffer_pool.c | 37 +-- platform/linux-generic/odp_init.c | 10 +++- platform/linux-generic/odp_linux.c

Re: [lng-odp] [PATCH] linux-generic: queue: fix PKTIN queue destroy

2014-12-18 Thread Taras Kondratiuk
On 12/18/2014 01:42 PM, Bill Fischofer wrote: This looks good. As a practice, for patch revisions post-merge I think these should be tracked as bugs that are being fixed, and the patch comments should note what bug it's addressing. Is it our 'official' approach? Should I create bugs on

[lng-odp] [RFC PATCH] api: init: add a way to determine a last ODP thread termination

2014-12-17 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/include/api/odp_init.h | 5 ++--- platform/linux-generic/include/odp_internal.h | 1 + platform/linux-generic/odp_init.c | 4 +++- platform/linux-generic/odp_linux.c| 10

[lng-odp] [RFC PATCH] linux-generic: add buffer pool termination

2014-12-17 Thread Taras Kondratiuk
Buffer pool terminate throws an error in case of any pool still exist at ODP global termination stage. Based on api: init: add a way to determine a last ODP thread termination patch. Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/include/odp_internal.h

Re: [lng-odp] [RFC PATCH] api: init: add a way to determine a last ODP thread termination

2014-12-17 Thread Taras Kondratiuk
On 12/17/2014 06:36 PM, Savolainen, Petri (NSN - FI/Espoo) wrote: -Original Message- From: ext Taras Kondratiuk [mailto:taras.kondrat...@linaro.org] Sent: Wednesday, December 17, 2014 4:49 PM To: lng-odp@lists.linaro.org; Savolainen, Petri (NSN - FI/Espoo) Cc: Taras Kondratiuk

[lng-odp] [PATCHv5 1/9] api: packet: move helper functions to public API

2014-12-16 Thread Taras Kondratiuk
From: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- example/generator/odp_generator.c | 5 +- example/ipsec/odp_ipsec.c | 3 +- example/ipsec

[lng-odp] [PATCHv5 3/9] api: packet: change layer offset/pointer API

2014-12-16 Thread Taras Kondratiuk
From: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- example/generator/odp_generator.c | 10 +- example/ipsec/odp_ipsec.c | 13

[lng-odp] [PATCHv5 2/9] api: packet: change alloc/free

2014-12-16 Thread Taras Kondratiuk
From: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- example/ipsec/odp_ipsec_stream.c | 9 +-- platform/linux-generic/include/api/odp_packet.h| 65

[lng-odp] [PATCHv5 4/9] api: packet: replace packet_addr with packet_data

2014-12-16 Thread Taras Kondratiuk
From: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- example/ipsec/odp_ipsec.c | 8 platform/linux-generic/odp_classification.c | 2 +- platform/linux

[lng-odp] [PATCHv5 6/9] linux-generic: packet: improve packet parsing

2014-12-16 Thread Taras Kondratiuk
From: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- helper/include/odph_ip.h | 28 +- .../linux-generic/include/odp_packet_internal.h| 31

[lng-odp] [PATCHv5 8/9] api: packet: add head/tail room manipulation

2014-12-16 Thread Taras Kondratiuk
From: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- example/ipsec/odp_ipsec.c | 4 +- example/ipsec/odp_ipsec_stream.c | 2

[lng-odp] [PATCHv5 9/9] api: packet: add segmentation and copy API

2014-12-16 Thread Taras Kondratiuk
From: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- helper/include/odph_ip.h | 4 +- platform/linux-generic/include/api/odp_packet.h| 304

[lng-odp] [PATCHv2 0/4] linux-generic: crypto: fix validation tests failures

2014-12-16 Thread Taras Kondratiuk
'make check' workaround. Taras Kondratiuk (4): linux-generic: crypto: always make a copy of IV linux-generic: crypto: implement completion event context linux-generic: crypto: implement odp_crypto_get_operation_compl_packet() Revert validation: XFAIL crypto until API is implemented

[lng-odp] [PATCHv2 1/4] linux-generic: crypto: always make a copy of IV

2014-12-16 Thread Taras Kondratiuk
DES library modifies IV buffer in-place. Current code handles this correctly only in case of encryption operation with session IV. To prevent user buffer modifications always make a copy of a provided IV. Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic

[lng-odp] [PATCHv2 3/4] linux-generic: crypto: implement odp_crypto_get_operation_compl_packet()

2014-12-16 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/include/odp_crypto_internal.h | 1 + platform/linux-generic/odp_crypto.c | 11 --- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/platform/linux-generic/include

[lng-odp] [PATCHv2 2/4] linux-generic: crypto: implement completion event context

2014-12-16 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- .../linux-generic/include/odp_crypto_internal.h| 1 + platform/linux-generic/odp_crypto.c| 24 -- 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/platform/linux-generic/include

Re: [lng-odp] [PATCHv2 0/4] linux-generic: crypto: fix validation tests failures

2014-12-16 Thread Taras Kondratiuk
Forgot to mention: this should go after packet series. It would be nice to have it in v0.5 so all 'make check' tests pass. On 12/16/2014 04:19 PM, Taras Kondratiuk wrote: This series fixes all crypto tests failures. Suite: odp_crypto_sync_inp Test: ENC_ALG_3DES_CBC ...passed Test

Re: [lng-odp] odp_buffer_inlines.h

2014-12-16 Thread Taras Kondratiuk
On 12/16/2014 05:22 PM, Ola Liljedahl wrote: This internal header files does not include header files which it depends on (e.g. odp_buffer_internal.h, odp_buffer_pool_internal.h) and thus becomes dependent on the parent file to include the necessary files. I think this is poor design, all header

[lng-odp] [PATCHv3] linux-generic: implement odp_queue_destroy()

2014-12-16 Thread Taras Kondratiuk
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- v3: Move queue status check under a lock v2: Handle scheduled queues destroy .../linux-generic/include/odp_queue_internal.h | 23 ++-- platform/linux-generic/odp_queue.c | 69 +- platform

Re: [lng-odp] [PATCH] validation: crypto: remove data offset workaround

2014-12-15 Thread Taras Kondratiuk
Hi Alex Could you please take a look on this, so we can merge it together with buffer/packet changes. On 12/13/2014 02:48 PM, Taras Kondratiuk wrote: Current crypto tests calculate range offsets expecting a bug in crypto implementation: data offsets are applied relatively to a start

Re: [lng-odp] [PATCH 0/3] linux-generic: crypto: fix validation tests failures

2014-12-15 Thread Taras Kondratiuk
Hi Robby, Will you be able to review this? On 12/13/2014 12:40 AM, Taras Kondratiuk wrote: This series fixes all crypto tests failures. Suite: odp_crypto_sync_inp Test: ENC_ALG_3DES_CBC ...passed Test: DEC_ALG_3DES_CBC ...passed Test: ENC_ALG_3DES_CBC_OVR_IV ...passed Test

Re: [lng-odp] [PATCH 0/3] Remove odp_schedule_one for 1.0 compliance

2014-12-15 Thread Taras Kondratiuk
. I imagined a following structure: odp |- examples |- tests |- benchmarks |- validation -- Taras Kondratiuk ___ lng-odp mailing list lng-odp@lists.linaro.org http://lists.linaro.org/mailman/listinfo/lng-odp

[lng-odp] [PATCHv6 0/7] Implement v0.5 buffer pool APIs

2014-12-15 Thread Taras Kondratiuk
Update buffer pool API to v0.5 specification level. v6: - Split into smaller patches. - Rebase the series and fix scheduler tests and pktio example failures. v5: Incorporates documentation changes to standardize @return/@retval usage and correct miscellaneous typos. No code changes in this

[lng-odp] [PATCHv6 1/7] api: buffer/shm: prevent circular dependencies

2014-12-15 Thread Taras Kondratiuk
From: Bill Fischofer bill.fischo...@linaro.org Move shared memory and buffer pool handles to odp_platform_types.h to allow ODP types cross-references. Signed-off-by: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic

[lng-odp] [PATCHv6 4/7] api: buffer: change pool create

2014-12-15 Thread Taras Kondratiuk
From: Bill Fischofer bill.fischo...@linaro.org Modify pool create API to be able to specify number of buffers directly. Signed-off-by: Bill Fischofer bill.fischo...@linaro.org Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- example/generator/odp_generator.c

<    1   2   3   4   >