Re: [lng-odp] [PATCH] helper: ip: add IP protocol value for sctp

2015-01-20 Thread Jerin Jacob
On Mon, Jan 19, 2015 at 06:49:35PM +0300, Maxim Uvarov wrote: On 01/19/2015 02:44 PM, Jerin Jacob wrote: Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com --- helper/include/odph_ip.h | 1 + 1 file changed, 1 insertion(+) diff --git a/helper/include/odph_ip.h

Re: [lng-odp] [PATCH] helper: ip: add IP protocol value for sctp

2015-01-20 Thread Bill Fischofer
I'd agree if it's to be added it should be to the odp helper file. On Tue, Jan 20, 2015 at 9:00 AM, Mike Holmes mike.hol...@linaro.org wrote: On 20 January 2015 at 09:52, Jerin Jacob jerin.ja...@caviumnetworks.com wrote: On Mon, Jan 19, 2015 at 06:49:35PM +0300, Maxim Uvarov wrote: On

[lng-odp] [PATCH] helper: ip: add IP protocol value for sctp

2015-01-19 Thread Jerin Jacob
Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com --- helper/include/odph_ip.h | 1 + 1 file changed, 1 insertion(+) diff --git a/helper/include/odph_ip.h b/helper/include/odph_ip.h index 272fd96..f2638ba 100644 --- a/helper/include/odph_ip.h +++ b/helper/include/odph_ip.h @@ -167,6

Re: [lng-odp] [PATCH] helper: ip: add IP protocol value for sctp

2015-01-19 Thread Jerin Jacob
On Mon, Jan 19, 2015 at 06:13:42AM -0600, Bill Fischofer wrote: Two questions: 1. We previously said we didn't need SCTP support for ODP v1.0, so why is this needed? Then there is a disconnect, exiting API has reference to SCTP /** * Check for SCTP * * @param pkt Packet handle *

Re: [lng-odp] [PATCH] helper: ip: add IP protocol value for sctp

2015-01-19 Thread Maxim Uvarov
On 01/19/2015 02:44 PM, Jerin Jacob wrote: Signed-off-by: Jerin Jacob jerin.ja...@caviumnetworks.com --- helper/include/odph_ip.h | 1 + 1 file changed, 1 insertion(+) diff --git a/helper/include/odph_ip.h b/helper/include/odph_ip.h index 272fd96..f2638ba 100644 ---

Re: [lng-odp] [PATCH] helper: ip: add IP protocol value for sctp

2015-01-19 Thread Bill Fischofer
Two questions: 1. We previously said we didn't need SCTP support for ODP v1.0, so why is this needed? 2. This is a helper, so it's not necessarily constrained by what may be covered by ODP v1.0, but in that case why limit this to SCTP? There are lots of other IP protocols that