Re: [lng-odp] [PATCH v2 4/6] helper: use ODP_LIB_FLAVOR to generate libodp name

Thanks, I will post to the list On 12 December 2016 at 04:31, Nicolas Morey-Chaisemartin wrote: > I just had a quick look and it looks good to me. > > Nicolas > > > Le 12/10/2016 à 08:29 PM, Mike Holmes a écrit : > > https://github.com/mike-holmes-linaro/odp/tree/helpers-os >

Re: [lng-odp] [PATCH v2 4/6] helper: use ODP_LIB_FLAVOR to generate libodp name

I just had a quick look and it looks good to me. Nicolas Le 12/10/2016 à 08:29 PM, Mike Holmes a écrit : > https://github.com/mike-holmes-linaro/odp/tree/helpers-os > > > Helper lib now gets the default helper OS from the platfrom in

Re: [lng-odp] [PATCH v2 4/6] helper: use ODP_LIB_FLAVOR to generate libodp name

https://github.com/mike-holmes-linaro/odp/tree/helpers-os Helper lib now gets the default helper OS from the platfrom in use via its configure.m4 On 9 December 2016 at 08:45, Nicolas Morey-Chaisemartin wrote: > > > Le 12/09/2016 à 02:41 PM, Mike Holmes a écrit : > > > > On 9

Re: [lng-odp] [PATCH v2 4/6] helper: use ODP_LIB_FLAVOR to generate libodp name

Le 12/09/2016 à 02:41 PM, Mike Holmes a écrit : > > > On 9 December 2016 at 08:33, Nicolas Morey-Chaisemartin > wrote: > > > > Le 12/09/2016 à 02:18 PM, Mike Holmes a écrit : >> >> >> On 9 December 2016 at 04:41, Nicolas Morey-Chaisemartin

Re: [lng-odp] [PATCH v2 4/6] helper: use ODP_LIB_FLAVOR to generate libodp name

On 9 December 2016 at 08:33, Nicolas Morey-Chaisemartin wrote: > > > Le 12/09/2016 à 02:18 PM, Mike Holmes a écrit : > > > > On 9 December 2016 at 04:41, Nicolas Morey-Chaisemartin > wrote: > >> I'm OK with this. The only issue I have with this is that it

Re: [lng-odp] [PATCH v2 4/6] helper: use ODP_LIB_FLAVOR to generate libodp name

Le 12/09/2016 à 02:18 PM, Mike Holmes a écrit : > > > On 9 December 2016 at 04:41, Nicolas Morey-Chaisemartin > wrote: > > I'm OK with this. The only issue I have with this is that it moves back > platform/OS selection back to configure.ac

Re: [lng-odp] [PATCH v2 4/6] helper: use ODP_LIB_FLAVOR to generate libodp name

On 9 December 2016 at 04:41, Nicolas Morey-Chaisemartin wrote: > I'm OK with this. The only issue I have with this is that it moves back > platform/OS selection back to configure.ac while I've been trying to move > it out

Re: [lng-odp] [PATCH v2 4/6] helper: use ODP_LIB_FLAVOR to generate libodp name

I'm OK with this. The only issue I have with this is that it moves back platform/OS selection back to configure.ac while I've been trying to move it out (https://github.com/nmorey/odp/tree/dev/generic-platforms). Shouldn't each platform select the right OS ? I mean linux-generic will probably

Re: [lng-odp] [PATCH v2 4/6] helper: use ODP_LIB_FLAVOR to generate libodp name

So this https://github.com/mike-holmes-linaro/odp/tree/helpers-os is what I was thinking It moves the Linux specifics to helper/os/linux and selects the helper os to be built in the configure step It renames the linux.h helper include to threads.h which is what it predominately is It also removes

Re: [lng-odp] [PATCH v2 4/6] helper: use ODP_LIB_FLAVOR to generate libodp name

On 7 December 2016 at 01:54, Nicolas Morey-Chaisemartin wrote: > > > Le 12/06/2016 à 09:37 PM, Mike Holmes a écrit : > > On 6 December 2016 at 12:08, Nicolas Morey-Chaisemartin > > wrote: > >> Signed-off-by: Nicolas Morey-Chaisemartin > >>

Re: [lng-odp] [PATCH v2 4/6] helper: use ODP_LIB_FLAVOR to generate libodp name

The test code needs some of those (the no_barrier for examples). I'm pretty sure the hashtable will need some of those because it used a globally shared structure. Le 12/07/2016 à 09:15 AM, Maxim Uvarov a écrit : > it's ok if this places in api. But do we have such places in examples or >

Re: [lng-odp] [PATCH v2 4/6] helper: use ODP_LIB_FLAVOR to generate libodp name

it's ok if this places in api. But do we have such places in examples or helper code? On 7 December 2016 at 10:43, Nicolas Morey-Chaisemartin wrote: > I usually force somme access to be uncached. A whole barrier would work, > but the performance cost is way too big. > > > Just

Re: [lng-odp] [PATCH v2 4/6] helper: use ODP_LIB_FLAVOR to generate libodp name

I usually force somme access to be uncached. A whole barrier would work, but the performance cost is way too big. Just as an example: static inline void odp_atomic_init_u64(odp_atomic_u64_t *atom, uint64_t val) { atom->v = val; #if __GCC_ATOMIC_LLONG_LOCK_FREE < 2 __atomic_clear(>lock,

Re: [lng-odp] [PATCH v2 4/6] helper: use ODP_LIB_FLAVOR to generate libodp name

Nicolas, what do you do to solve coherency problem? I think that maybe we are missing some api in odp, like read/write barriers. Maxim. On 7 December 2016 at 09:54, Nicolas Morey-Chaisemartin wrote: > > > Le 12/06/2016 à 09:37 PM, Mike Holmes a écrit : > > On 6 December 2016

Re: [lng-odp] [PATCH v2 4/6] helper: use ODP_LIB_FLAVOR to generate libodp name

Le 12/06/2016 à 09:37 PM, Mike Holmes a écrit : > On 6 December 2016 at 12:08, Nicolas Morey-Chaisemartin > wrote: >> Signed-off-by: Nicolas Morey-Chaisemartin >> --- >> helper/Makefile.am | 6 +++--- >> helper/test/Makefile.am | 6 +++--- >> 2 files

Re: [lng-odp] [PATCH v2 4/6] helper: use ODP_LIB_FLAVOR to generate libodp name

Le 12/06/2016 à 10:17 PM, Maxim Uvarov a écrit : > On 12/06/16 23:37, Mike Holmes wrote: >> On 6 December 2016 at 12:08, Nicolas Morey-Chaisemartin >> wrote: >>> Signed-off-by: Nicolas Morey-Chaisemartin >>> --- >>> helper/Makefile.am | 6 +++--- >>>

Re: [lng-odp] [PATCH v2 4/6] helper: use ODP_LIB_FLAVOR to generate libodp name

On 12/06/16 23:37, Mike Holmes wrote: > On 6 December 2016 at 12:08, Nicolas Morey-Chaisemartin > wrote: >> Signed-off-by: Nicolas Morey-Chaisemartin >> --- >> helper/Makefile.am | 6 +++--- >> helper/test/Makefile.am | 6 +++--- >> 2 files changed, 6

Re: [lng-odp] [PATCH v2 4/6] helper: use ODP_LIB_FLAVOR to generate libodp name

On 6 December 2016 at 12:08, Nicolas Morey-Chaisemartin wrote: > Signed-off-by: Nicolas Morey-Chaisemartin > --- > helper/Makefile.am | 6 +++--- > helper/test/Makefile.am | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git

[lng-odp] [PATCH v2 4/6] helper: use ODP_LIB_FLAVOR to generate libodp name

Signed-off-by: Nicolas Morey-Chaisemartin --- helper/Makefile.am | 6 +++--- helper/test/Makefile.am | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/helper/Makefile.am b/helper/Makefile.am index d09d900..c75db00 100644 --- a/helper/Makefile.am