Re: [lng-odp] [PATCHv4 2/2] platform: debug: Simplify ODP_LOG() macro

2014-12-03 Thread Taras Kondratiuk
On 12/02/2014 07:50 PM, Zoltan Kiss wrote: On 02/12/14 17:07, Taras Kondratiuk wrote: On 12/02/2014 06:42 PM, Zoltan Kiss wrote: Hi, At the moment, the careless developer look at enum odp_log_level and starts using ODP_LOG(ODP_LOG_DBG, ...) instead of ODP_DBG. I think it would be good to

Re: [lng-odp] [PATCHv4 2/2] platform: debug: Simplify ODP_LOG() macro

2014-12-03 Thread Taras Kondratiuk
On 12/03/2014 04:15 PM, Zoltan Kiss wrote: On 03/12/14 08:41, Taras Kondratiuk wrote: On 12/02/2014 07:50 PM, Zoltan Kiss wrote: And this problem applies to ODP_LOG_ABORT as well: ODP_ABORT will call abort(), while ODP_LOG(ODP_LOG_ABORT, ...) doesn't. I think you can just drop the wholw

[lng-odp] [PATCHv4 2/2] platform: debug: Simplify ODP_LOG() macro

2014-12-02 Thread Taras Kondratiuk
Move additional functionality out of ODP_LOG. Keep only logging. Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org --- platform/linux-generic/include/api/odp_debug.h | 43 +--- .../linux-generic/include/odp_debug_internal.h |6 ++- 2 files changed, 15

Re: [lng-odp] [PATCHv4 2/2] platform: debug: Simplify ODP_LOG() macro

2014-12-02 Thread Zoltan Kiss
Hi, At the moment, the careless developer look at enum odp_log_level and starts using ODP_LOG(ODP_LOG_DBG, ...) instead of ODP_DBG. I think it would be good to provide either ODP_LOG(loglevel, ...) or ODP_[loglevel](...), but not both. Regards, Zoli On 02/12/14 11:27, Taras Kondratiuk

Re: [lng-odp] [PATCHv4 2/2] platform: debug: Simplify ODP_LOG() macro

2014-12-02 Thread Taras Kondratiuk
On 12/02/2014 06:42 PM, Zoltan Kiss wrote: Hi, At the moment, the careless developer look at enum odp_log_level and starts using ODP_LOG(ODP_LOG_DBG, ...) instead of ODP_DBG. I think it would be good to provide either ODP_LOG(loglevel, ...) or ODP_[loglevel](...), but not both. These are